Re: style rules

2022-07-11 Thread Gyori Andras
Hi all! I think this rule is all right. A real constant value (like PI) should be declared as static final, which could be named in an all caps fashion without violating the rule. In my opinion this rule is also a good safety net: if you declare a constant without static, you might end up with a l

[DISCUSS] Race condition in ProtobufRpcEngine2

2022-02-28 Thread Gyori Andras
Hey everyone! We have started seeing test failures in YARN PRs for a while. We have identified the problematic commit, which is HADOOP-18082 , however, this change just revealed the race condition lying in ProtobufRpcEngine2 introduced in HADOOP-