Github user aajisaka commented on the pull request:
https://github.com/apache/hadoop/pull/89#issuecomment-205680037
Thank you for the update! I'm +1 if the above comments are addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user aajisaka commented on a diff in the pull request:
https://github.com/apache/hadoop/pull/89#discussion_r58492524
--- Diff:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java
---
@@ -55,9 +56,11 @@
public class TestFileUtil {
Github user vinayakumarb commented on the pull request:
https://github.com/apache/hadoop/pull/89#issuecomment-205285404
Rebased,
and separated the common changes and hdfs changes.
Pushed only common changes in this PR.
---
If your project is set up for it, you can reply to thi
Github user aajisaka commented on the pull request:
https://github.com/apache/hadoop/pull/89#issuecomment-205168263
Thank you for rebasing! Mostly looks good to me. Two comments:
* Can we separate the patch into common change and hdfs change? That way
the patch becomes smaller and
Github user aajisaka commented on a diff in the pull request:
https://github.com/apache/hadoop/pull/89#discussion_r58334727
--- Diff:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDecommissioningStatus.java
---
@@ -87,7 +87,7 @@ public st
GitHub user vinayakumarb opened a pull request:
https://github.com/apache/hadoop/pull/89
HADOOP-12984. Add GenericTestUtils.getTestDir method and use it for
emporary directory in tests
Rebased.
You can merge this pull request into a Git repository by running:
$ git pull https:
