[RESULT] Re: [VOTE] Merge feature branch HADOOP-12930

Vote passes. 1 = +1 non-binding 4 = +1 binding I’ll squash and commit here in a sec. Thanks everyone! - To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail:

Re: [VOTE] Merge feature branch HADOOP-12930

Understood about the tests. --Chris Nauroth On 5/15/16, 7:30 AM, "Allen Wittenauer" wrote: > >> On May 14, 2016, at 3:11 PM, Chris Nauroth >>wrote: >> >> +1 (binding) >> >> -Tried a dry-run merge of HADOOP-12930 to trunk. >> -Successfully built

Re: [VOTE] Merge feature branch HADOOP-12930

+1. - Checked out HADOOP-12930 - Built by "mvn package -Pdist -DskipTests -Dtar" successfully - Added custom subcommands to ~/.hadooprc and confirmed they worked - Built documentation and it looks good Thanks, Akira On 5/15/16 02:33, Allen Wittenauer wrote: This vote closes in 2 days and the

Re: [VOTE] Merge feature branch HADOOP-12930

> Fix (with unit tests!) committed. Thanks, Allen. +1. - checked out HADOOP-12930 and ran shelltest on my local - ran 'mvn package -Pdist -Pnative -DskipTests' - started pseudo-distributed cluster by start-dfs.sh and start-yarn.sh - ran 'hadoop distcp' and 'mapred streaming' successfully -

Re: [VOTE] Merge feature branch HADOOP-12930

> On May 15, 2016, at 7:27 AM, Allen Wittenauer wrote: > > >> On May 14, 2016, at 9:04 PM, Masatake Iwasaki >> wrote: >> >> + hadoop_debug "Calling dynamically: hadoop_subcommand_${HADOOP_SUBCMD} >> ${HADOOP_SUBCMD_ARGS[$*]}” > > Easy

Re: [VOTE] Merge feature branch HADOOP-12930

> On May 14, 2016, at 3:11 PM, Chris Nauroth wrote: > > +1 (binding) > > -Tried a dry-run merge of HADOOP-12930 to trunk. > -Successfully built distro on Windows. > -Ran "hdfs namenode", "hdfs datanode", and various interactive hdfs > commands through Cygwin. >

Re: [VOTE] Merge feature branch HADOOP-12930

> On May 14, 2016, at 9:04 PM, Masatake Iwasaki > wrote: > > + hadoop_debug "Calling dynamically: hadoop_subcommand_${HADOOP_SUBCMD} > ${HADOOP_SUBCMD_ARGS[$*]}” Easy fix. The $* should just be *. I’ll open an issue and fix it here in a sec.

Re: [VOTE] Merge feature branch HADOOP-12930

Hi Allen, I had a problem when I was testing HADOOP-12930 branch. (built by mvn package -Pdist) Single argument is ok.:: [iwasakims@centos7 HADOOP-12930]$ bin/hadoop hello foo foo Error on multiple arguments. :: [iwasakims@centos7 HADOOP-12930]$ bin/hadoop hello foo bar

Re: [VOTE] Merge feature branch HADOOP-12930

+1 (binding) -Tried a dry-run merge of HADOOP-12930 to trunk. -Successfully built distro on Windows. -Ran "hdfs namenode", "hdfs datanode", and various interactive hdfs commands through Cygwin. -Reviewed documentation. Allen, thank you for the contribution. Would you please attach a full patch

Re: [VOTE] Merge feature branch HADOOP-12930

This vote closes in 2 days and the only response has been from a non-committer and one of the 137 other committers on the project…. it’d be great if some others could take a look. Thanks! > On May 12, 2016, at 6:07 PM, Andrew Wang wrote: > > +1. I looked at the

Re: [VOTE] Merge feature branch HADOOP-12930

+1. I looked at the patches on the branch, wasn't too bad to review. As Allen said, there's some code movement, assorted other nice doc and shell fixups. Found one extra typo, which I added to HADOOP-13129. Best, Andrew On Wed, May 11, 2016 at 1:14 AM, Sean Busbey wrote:

Re: [VOTE] Merge feature branch HADOOP-12930

+1 (non-binding) reviewed everything, filed an additional subtask for a very trivial typo in the docs. should be fine to make a full issue after close and then fix. tried merging locally, tried running through new shell tests (both with and without bats installed), tried making an example custom

[VOTE] Merge feature branch HADOOP-12930

Hey gang! I’d like to call a vote to run for 7 days (ending May 16 at 13:30 PT) to merge the HADOOP-12930 feature branch into trunk. This branch was developed exclusively by me as per the discussion two months ago as a way to make what would be a rather large patch hopefully