Re: InterfaceStability and InterfaceAudience stability

2015-01-16 Thread Abraham Elmahrek
Agreed. Any one interested in reviewing/committing https://issues.apache.org/jira/browse/HADOOP-11476? On Thu, Jan 15, 2015 at 11:27 AM, Chris Nauroth cnaur...@hortonworks.com wrote: Would it really be backwards-incompatible if we added new levels later? That seems counter-intuitive and

Re: InterfaceStability and InterfaceAudience stability

2015-01-16 Thread Allen Wittenauer
It may work fine from a code perspective, but from a semantic and/or human perspective, I think it’d be confusing and could lead to problems down the road. Let’s say we add Contract after making this Stable. If we change any Private’s to Contracts as a result, is that a break? On

Re: InterfaceStability and InterfaceAudience stability

2015-01-15 Thread Chris Nauroth
Would it really be backwards-incompatible if we added new levels later? That seems counter-intuitive and contrary to this piece of documentation: http://docs.oracle.com/javase/specs/jls/se7/html/jls-13.html#jls-13.5.7 Quoting: Annotation types behave exactly like any other interface. Adding or

Re: InterfaceStability and InterfaceAudience stability

2015-01-15 Thread Allen Wittenauer
IIRC, it was marked as evolving because it wasn’t clear at the time whether we would need to add more stability levels. (One of the key inspirations for the stability levels—Sun’s ARC process—had more.) So I think it’s important to remember that if this gets changed to stable,

Re: InterfaceStability and InterfaceAudience stability

2015-01-14 Thread Abraham Elmahrek
Patch attached. I'm not sure what is necessary for changing the stability of class. Please review. On Tue, Jan 13, 2015 at 5:09 PM, Abraham Elmahrek a...@cloudera.com wrote: Thanks for your thoughts guys. I've created https://issues.apache.org/jira/browse/HADOOP-11476 to follow through on

Re: InterfaceStability and InterfaceAudience stability

2015-01-13 Thread Abraham Elmahrek
Thanks for your thoughts guys. I've created https://issues.apache.org/jira/browse/HADOOP-11476 to follow through on this. On Tue, Jan 13, 2015 at 3:55 PM, Karthik Kambatla ka...@cloudera.com wrote: +1 On Wed, Jan 14, 2015 at 4:04 AM, Robert Kanter rkan...@cloudera.com wrote: +1 Though

Re: InterfaceStability and InterfaceAudience stability

2015-01-13 Thread Robert Kanter
+1 Though it is kinda funny that the InterfaceStability annotation was marked as Evolving :) @InterfaceStability.Evolving public class InterfaceStability {...} On Tue, Jan 13, 2015 at 2:21 PM, Ted Yu yuzhih...@gmail.com wrote: +1 On Tue, Jan 13, 2015 at 1:47 PM, Abraham Elmahrek

InterfaceStability and InterfaceAudience stability

2015-01-13 Thread Abraham Elmahrek
Hey guys, I've noticed the InterfaceStability ( https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceStability.java) and InterfaceAudience (

Re: InterfaceStability and InterfaceAudience stability

2015-01-13 Thread Karthik Kambatla
+1 On Wed, Jan 14, 2015 at 4:04 AM, Robert Kanter rkan...@cloudera.com wrote: +1 Though it is kinda funny that the InterfaceStability annotation was marked as Evolving :) @InterfaceStability.Evolving public class InterfaceStability {...} On Tue, Jan 13, 2015 at 2:21 PM, Ted Yu