Re: Thoughts about moving submarine to a separate git repo?

2019-08-21 Thread Wangda Tan
> > One major point from my end is that the commits to new repo ideally should > happen from committers or branch committers. Definitely agree! On Thu, Aug 22, 2019 at 12:32 PM Sunil Govindan wrote: > Thanks Wangda for sharing the thoughts. > > I agree with the idea of new repo for more

Re: Thoughts about moving submarine to a separate git repo?

2019-08-21 Thread Sunil Govindan
Thanks Wangda for sharing the thoughts. I agree with the idea of new repo for more cleaner code base and remove additional dependencies, jenkins etc. One major point from my end is that the commits to new repo ideally should happen from committers or branch committers. As hadoop community, we

Re: Thoughts about moving submarine to a separate git repo?

2019-08-20 Thread Wangda Tan
Hi Xun, Thanks for starting this thread. I'm glad to see the existing momentum made by Submarine community, and I like the proposal to make it be a separate Git repo. Some suggestions: 1) For options mentioned by Sunil: I think it's better to be a separate Git repo instead of a branch. To me,

Re: Thoughts about moving submarine to a separate git repo?

2019-08-20 Thread Wei-Chiu Chuang
> > > > Submarine dev community has a total of 8 developers and submits an average > of 4 to 5 PR per day. > But there are a limited number of Hadoop committer actively help review and > merge patches, which causes development progress delays. > > I just want to point this out that this is

Re: Thoughts about moving submarine to a separate git repo?

2019-08-20 Thread Wanqiang Ji
; Best Regards > > > Xun Liu > > > > > > > > > > On Aug 16, 2019, at 5:25 PM, dashuiguailu...@gmail.com wrote: > > > > > > > > +1 ,Agree that independent development of submarine can better adapt > to > > > the development of

Re: Thoughts about moving submarine to a separate git repo?

2019-08-20 Thread kevin su
, at 5:25 PM, dashuiguailu...@gmail.com wrote: > > > > +1 ,Agree that independent development of submarine can better adapt to > the development of machine learning > > > > > > > > dashuiguailu...@gmail.com > > > > From: Xun Liu > > Date: 2019-08-

Re: Thoughts about moving submarine to a separate git repo?

2019-08-16 Thread dashuiguailu...@gmail.com
+1 ,Agree that independent development of submarine can better adapt to the development of machine learning dashuiguailu...@gmail.com From: Xun Liu Date: 2019-08-16 12:43 To: common-dev; yarn-dev; hdfs-dev; submarine-dev Subject: Thoughts about moving submarine to a separate git repo? Dear

Re: Thoughts about moving submarine to a separate git repo?

2019-08-16 Thread Sunil Govindan
Hi Xun, Thanks for the proposal. Altogether this proposal makes sense to me. IIUC, an external repo is created and developers found more productive in that because of faster reviews and commits. To do more this apache way, 1. I think its better we track all this in apache jira (apparently this

Thoughts about moving submarine to a separate git repo?

2019-08-15 Thread Xun Liu
Dear Submarine developers, My name is Xun Liu, I am a member of the Hadoop submarine development team. I'm one of the major contributor of Submarine since June 2018. I want to hear your thoughts about creating a separate GitHub repo under Apache to do submarine development. This is an