Re: making a hadoop-common test run if a property is set

2012-12-18 Thread Colin McCabe
On Mon, Dec 17, 2012 at 11:03 AM, Steve Loughran ste...@hortonworks.com wrote: On 17 December 2012 16:06, Tom White t...@cloudera.com wrote: There are some tests like the S3 tests that end with Test (e.g. Jets3tNativeS3FileSystemContractTest) - unlike normal tests which start with Test. Only

Re: making a hadoop-common test run if a property is set

2012-12-18 Thread Colin McCabe
On Tue, Dec 18, 2012 at 1:05 AM, Colin McCabe cmcc...@alumni.cmu.edu wrote: On Mon, Dec 17, 2012 at 11:03 AM, Steve Loughran ste...@hortonworks.com wrote: On 17 December 2012 16:06, Tom White t...@cloudera.com wrote: There are some tests like the S3 tests that end with Test (e.g.

Re: making a hadoop-common test run if a property is set

2012-12-18 Thread Steve Loughran
On 18 December 2012 09:11, Colin McCabe cmcc...@alumni.cmu.edu wrote: On Tue, Dec 18, 2012 at 1:05 AM, Colin McCabe cmcc...@alumni.cmu.edu wrote: another tactic could be to have specific test projects: test-s3, test-openstack, test-... which contain nothing but test cases. You'd set

Re: making a hadoop-common test run if a property is set

2012-12-18 Thread Steve Loughran
On 18 December 2012 09:05, Colin McCabe cmcc...@alumni.cmu.edu wrote: I think the way to go is to have one XML file include another. ?xml version=1.0? ?xml-stylesheet type=text/xsl href=configuration.xsl? configuration xmlns:xi=http://www.w3.org/2001/XInclude; property

Re: making a hadoop-common test run if a property is set

2012-12-18 Thread Steve Loughran
On 17 December 2012 16:06, Tom White t...@cloudera.com wrote: There are some tests like the S3 tests that end with Test (e.g. Jets3tNativeS3FileSystemContractTest) - unlike normal tests which start with Test. Only those that start with Test are run automatically (see the surefire

Re: making a hadoop-common test run if a property is set

2012-12-17 Thread Steve Loughran
thanks, I'l; have a look. I've always wanted to add the notion of skipped to test runs -all the way through to the XML and generated reports, but you'd have to do a new junit runner for this and tweak the reporting code. Which, if it involved going near maven source, is not something I am prepared

Re: making a hadoop-common test run if a property is set

2012-12-17 Thread Tom White
There are some tests like the S3 tests that end with Test (e.g. Jets3tNativeS3FileSystemContractTest) - unlike normal tests which start with Test. Only those that start with Test are run automatically (see the surefire configuration in hadoop-project/pom.xml). You have to run the others manually

Re: making a hadoop-common test run if a property is set

2012-12-17 Thread Steve Loughran
On 17 December 2012 16:06, Tom White t...@cloudera.com wrote: There are some tests like the S3 tests that end with Test (e.g. Jets3tNativeS3FileSystemContractTest) - unlike normal tests which start with Test. Only those that start with Test are run automatically (see the surefire

making a hadoop-common test run if a property is set

2012-12-14 Thread Steve Loughran
The swiftfs tests need only to run if there's a target filesystem; copying the s3/s3n tests, something like property nametest.fs.swift.name/name valueswift://your-object-store-herel//value /property How does one actually go about making junit tests optional in mvn-land? Should the

Re: making a hadoop-common test run if a property is set

2012-12-14 Thread Colin McCabe
One approach we've taken in the past is making the junit test skip itself when some precondition is not true. Then, we often create a property which people can use to cause the skipped tests to become a hard error. For example, all the tests that rely on libhadoop start with these lines: @Test