Re: [DISCUSS] About creation of Hadoop Thirdparty repository for shaded artifacts

2020-01-12 Thread Vinayakumar B
PR has been merged. Thanks everyone for discussions. -Vinay On Thu, Jan 9, 2020 at 4:47 PM Ayush Saxena wrote: > Hi All, > FYI : > We will be going ahead with the present approach, will merge by tomorrow > EOD. Considering no one has objections. > Thanx Everyone!!! > > -Ayush > > > On 07-Jan-

Re: [DISCUSS] About creation of Hadoop Thirdparty repository for shaded artifacts

2020-01-09 Thread Ayush Saxena
Hi All, FYI : We will be going ahead with the present approach, will merge by tomorrow EOD. Considering no one has objections. Thanx Everyone!!! -Ayush > On 07-Jan-2020, at 9:22 PM, Brahma Reddy Battula wrote: > > Hi Sree vaddi,Owen,stack,Duo Zhang, > > We can move forward based on your comme

Re: [DISCUSS] About creation of Hadoop Thirdparty repository for shaded artifacts

2020-01-07 Thread Brahma Reddy Battula
Hi Sree vaddi,Owen,stack,Duo Zhang, We can move forward based on your comments, just waiting for your reply.Hope all of your comments answered..(unification we can think parallel thread as Vinay mentioned). On Mon, 6 Jan 2020 at 6:21 PM, Vinayakumar B wrote: > Hi Sree, > > > apache/hadoop-thi

Re: [DISCUSS] About creation of Hadoop Thirdparty repository for shaded artifacts

2020-01-06 Thread Vinayakumar B
Hi Sree, > apache/hadoop-thirdparty, How would it fit into ASF ? As an Incubating Project ? Or as a TLP ? > Or as a new project definition ? As already mentioned by Ayush, this will be a subproject of Hadoop. Releases will be voted by Hadoop PMC as per ASF process. > The effort to streamline and

Re: [DISCUSS] About creation of Hadoop Thirdparty repository for shaded artifacts

2020-01-05 Thread Ayush Saxena
Hey Sree > apache/hadoop-thirdparty, How would it fit into ASF ? As an Incubating > Project ? Or as a TLP ? > Or as a new project definition ? > A sub project of Apache Hadoop, having its own independent release cycles. May be you can put this into the same column as ozone or as submarine(couple o

Re: [DISCUSS] About creation of Hadoop Thirdparty repository for shaded artifacts

2020-01-05 Thread Brahma Reddy Battula
I just gone through previous discussions from jira (HADOOP-13363) and this thread,As stack and Duo Zhang mentioned ,this artifact(instead of thirdparty we can give shaded??) will be voted by PMC like below, won’t it be fair?? https://lists.apache.org/thread.html/f12c589baabbc79c7fb2843422d4590bea

Re: [DISCUSS] About creation of Hadoop Thirdparty repository for shaded artifacts

2020-01-04 Thread Sree Vaddi
apache/hadoop-thirdparty, How would it fit into ASF ? As an Incubating Project ? Or as a TLP ? Or as a new project definition ? The effort to streamline and put in an accepted standard for the dependencies that require shading,seems beyond the siloed efforts of hadoop, hbase, etc I propose,

Re: [DISCUSS] About creation of Hadoop Thirdparty repository for shaded artifacts

2020-01-04 Thread Vinayakumar B
Hi, Sorry for the late reply,. >>> To be exact, how can we better use the thirdparty repo? Looking at HBase as an example, it looks like everything that are known to break a lot after an update get shaded into the hbase-thirdparty artifact: guava, netty, ... etc. Is it the purpose to isolate these

Re: [DISCUSS] About creation of Hadoop Thirdparty repository for shaded artifacts

2019-10-09 Thread Wei-Chiu Chuang
Hi I am late to this but I am keen to understand more. To be exact, how can we better use the thirdparty repo? Looking at HBase as an example, it looks like everything that are known to break a lot after an update get shaded into the hbase-thirdparty artifact: guava, netty, ... etc. Is it the purp

Re: [DISCUSS] About creation of Hadoop Thirdparty repository for shaded artifacts

2019-10-09 Thread Vinayakumar B
Hi All, I have updated the PR as per @Owen O'Malley 's suggestions. i. Renamed the module to 'hadoop-shaded-protobuf37' ii. Kept the shaded package to 'o.a.h.thirdparty.protobuf37' Please review!! Thanks, -Vinay On Sat, Sep 28, 2019 at 10:29 AM 张铎(Duo Zhang) wrote: > For HBase we h

Re: [DISCUSS] About creation of Hadoop Thirdparty repository for shaded artifacts

2019-09-27 Thread Duo Zhang
For HBase we have a separated repo for hbase-thirdparty https://github.com/apache/hbase-thirdparty We will publish the artifacts to nexus so we do not need to include binaries in our git repo, just add a dependency in the pom. https://mvnrepository.com/artifact/org.apache.hbase.thirdparty/hbase-

Re: [DISCUSS] About creation of Hadoop Thirdparty repository for shaded artifacts

2019-09-27 Thread Vinayakumar B
Please find replies inline. -Vinay On Fri, Sep 27, 2019 at 10:21 PM Owen O'Malley wrote: > I'm very unhappy with this direction. In particular, I don't think git is > a good place for distribution of binary artifacts. Furthermore, the PMC > shouldn't be releasing anything without a release vote

Re: [DISCUSS] About creation of Hadoop Thirdparty repository for shaded artifacts

2019-09-27 Thread Owen O'Malley
I'm very unhappy with this direction. In particular, I don't think git is a good place for distribution of binary artifacts. Furthermore, the PMC shouldn't be releasing anything without a release vote. I'd propose that we make a third party module that contains the *source* of the pom files to bui

[DISCUSS] About creation of Hadoop Thirdparty repository for shaded artifacts

2019-09-27 Thread Vinayakumar B
Hi All, I wanted to discuss about the separate repo for thirdparty dependencies which we need to shaded and include in Hadoop component's jars. Apologies for the big text ahead, but this needs clear explanation!! Right now most needed such dependency is protobuf. Protobuf dependency was