Re: Code guidelines and bash

2014-07-30 Thread Steve Loughran
one argument in favour of 80 is that it's easier to side-by-side diff even so, I find it restrictive in Java code; once you go for long env vars in bash-land then you are in trouble. As for python, you have to indent according to your code flow. were we to have a special getout of 120 chars in

Re: Code guidelines and bash

2014-07-29 Thread Andrew Purtell
On Mon, Jul 28, 2014 at 12:05 PM, Doug Cutting cutt...@apache.org wrote: On Sun, Jul 27, 2014 at 9:28 PM, Ted Dunning tdunn...@maprtech.com wrote: I don't know of any dev environments in common use today that can't display 100 characters. I edit in an 80-column Emacs window that just fits

Re: Code guidelines and bash

2014-07-29 Thread 俊平堵
Sun's java code convention (published in year of 97) suggest 80 column per line for old-style terminals. It sounds pretty old, However, I saw some developers (not me :)) like to open multiple terminals in one screen for coding/debugging so 80-colum could be just fit. Google's java convention (

Re: Code guidelines and bash

2014-07-29 Thread Colin McCabe
On Tue, Jul 29, 2014 at 2:45 AM, 俊平堵 junping...@apache.org wrote: Sun's java code convention (published in year of 97) suggest 80 column per line for old-style terminals. It sounds pretty old, However, I saw some developers (not me :)) like to open multiple terminals in one screen for

Re: Code guidelines and bash

2014-07-28 Thread Doug Cutting
On Sun, Jul 27, 2014 at 9:28 PM, Ted Dunning tdunn...@maprtech.com wrote: I don't know of any dev environments in common use today that can't display 100 characters. I edit in an 80-column Emacs window that just fits beside an 80-column shell window on a portrait-rotated 24 monitor. Doug

Re: Code guidelines and bash

2014-07-27 Thread Chris Douglas
[moving to common-dev@] The 80 character limit is for legibility across dev environments. If it's impeding that goal in bash, then nobody will insist on it. Since HADOOP-9902 rewrites most of this code, the particular cases can be worked through in that JIRA. -C On Sat, Jul 26, 2014 at 12:20