[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s…

bharatviswa504 commented on a change in pull request #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s… URL: https://github.com/apache/hadoop/pull/1163#discussion_r307597443 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s…

bharatviswa504 commented on a change in pull request #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s… URL: https://github.com/apache/hadoop/pull/1163#discussion_r307597008 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s…

bharatviswa504 commented on a change in pull request #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s… URL: https://github.com/apache/hadoop/pull/1163#discussion_r307597008 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1147: HDDS-1619. Support volume addACL operations for OM HA. Contributed by…

bharatviswa504 commented on a change in pull request #1147: HDDS-1619. Support volume addACL operations for OM HA. Contributed by… URL: https://github.com/apache/hadoop/pull/1147#discussion_r307592917 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1147: HDDS-1619. Support volume addACL operations for OM HA. Contributed by…

bharatviswa504 commented on a change in pull request #1147: HDDS-1619. Support volume addACL operations for OM HA. Contributed by… URL: https://github.com/apache/hadoop/pull/1147#discussion_r307593872 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on issue #1168: HDDS-1864. Turn on topology aware read in TestFailureHandlingByClient.

hadoop-yetus commented on issue #1168: HDDS-1864. Turn on topology aware read in TestFailureHandlingByClient. URL: https://github.com/apache/hadoop/pull/1168#issuecomment-515315317 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] bharatviswa504 merged pull request #1165: HDDS-1861. Fix TableCacheImpl cleanup logic.

bharatviswa504 merged pull request #1165: HDDS-1861. Fix TableCacheImpl cleanup logic. URL: https://github.com/apache/hadoop/pull/1165 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] bharatviswa504 commented on issue #1165: HDDS-1861. Fix TableCacheImpl cleanup logic.

bharatviswa504 commented on issue #1165: HDDS-1861. Fix TableCacheImpl cleanup logic. URL: https://github.com/apache/hadoop/pull/1165#issuecomment-515314662 Thank you @arp7 for the review. Test failures are not related to this patch. I will commit this to trunk.

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1147: HDDS-1619. Support volume addACL operations for OM HA. Contributed by…

bharatviswa504 commented on a change in pull request #1147: HDDS-1619. Support volume addACL operations for OM HA. Contributed by… URL: https://github.com/apache/hadoop/pull/1147#discussion_r307592917 ## File path:

[GitHub] [hadoop] nandakumar131 commented on issue #1153: HDDS-1855. TestStorageContainerManager#testScmProcessDatanodeHeartbeat is failing.

nandakumar131 commented on issue #1153: HDDS-1855. TestStorageContainerManager#testScmProcessDatanodeHeartbeat is failing. URL: https://github.com/apache/hadoop/pull/1153#issuecomment-515311574 @ChenSammi, the test was failing even in my local. This is because `CachedDNSToSwitchMapping`

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1147: HDDS-1619. Support volume addACL operations for OM HA. Contributed by…

xiaoyuyao commented on a change in pull request #1147: HDDS-1619. Support volume addACL operations for OM HA. Contributed by… URL: https://github.com/apache/hadoop/pull/1147#discussion_r307589215 ## File path:

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1147: HDDS-1619. Support volume addACL operations for OM HA. Contributed by…

xiaoyuyao commented on a change in pull request #1147: HDDS-1619. Support volume addACL operations for OM HA. Contributed by… URL: https://github.com/apache/hadoop/pull/1147#discussion_r307588979 ## File path:

[jira] [Commented] (HADOOP-16447) Upgrade JUnit5 from 5.3.1 to 5.5+ to support global timeout

[ https://issues.apache.org/jira/browse/HADOOP-16447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893325#comment-16893325 ] kevin su commented on HADOOP-16447: --- I just see more people use 5.5.0, so I use it.  of course, I

[GitHub] [hadoop] xiaoyuyao commented on issue #1158: HDDS-1839: Change topology sorting related logs in Pipeline from INFO to DEBUG

xiaoyuyao commented on issue #1158: HDDS-1839: Change topology sorting related logs in Pipeline from INFO to DEBUG URL: https://github.com/apache/hadoop/pull/1158#issuecomment-515299074 +1 pending Jenkins. This is an

[GitHub] [hadoop] xiaoyuyao commented on issue #1158: HDDS-1839: Change topology sorting related logs in Pipeline from INFO to DEBUG

xiaoyuyao commented on issue #1158: HDDS-1839: Change topology sorting related logs in Pipeline from INFO to DEBUG URL: https://github.com/apache/hadoop/pull/1158#issuecomment-515299050 /retest This is an automated message

[GitHub] [hadoop] hadoop-yetus commented on issue #1166: HDDS-1856. Merge HA and Non-HA code in OM.

hadoop-yetus commented on issue #1166: HDDS-1856. Merge HA and Non-HA code in OM. URL: https://github.com/apache/hadoop/pull/1166#issuecomment-515292094 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] ChenSammi opened a new pull request #1168: HDDS-1864. Turn on topology aware read in TestFailureHandlingByClient.

ChenSammi opened a new pull request #1168: HDDS-1864. Turn on topology aware read in TestFailureHandlingByClient. URL: https://github.com/apache/hadoop/pull/1168 https://issues.apache.org/jira/browse/HDDS-1864. This is an

[GitHub] [hadoop] hadoop-yetus commented on issue #1167: HDDS-1863. Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key.

hadoop-yetus commented on issue #1167: HDDS-1863. Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key. URL: https://github.com/apache/hadoop/pull/1167#issuecomment-515293051 :broken_heart: **-1 overall** | Vote | Subsystem |

[GitHub] [hadoop] ChenSammi commented on issue #1143: Ozone Read fails with StatusRunTimeExceptions after 2 datanode fail i…

ChenSammi commented on issue #1143: Ozone Read fails with StatusRunTimeExceptions after 2 datanode fail i… URL: https://github.com/apache/hadoop/pull/1143#issuecomment-515289761 Create a ticket for this code change. This is

[GitHub] [hadoop] ChenSammi commented on issue #1143: Ozone Read fails with StatusRunTimeExceptions after 2 datanode fail i…

ChenSammi commented on issue #1143: Ozone Read fails with StatusRunTimeExceptions after 2 datanode fail i… URL: https://github.com/apache/hadoop/pull/1143#issuecomment-515289547 @bshashikant Agree. I will open a new ticket and close this one.

[GitHub] [hadoop] ChenSammi closed pull request #1143: Ozone Read fails with StatusRunTimeExceptions after 2 datanode fail i…

ChenSammi closed pull request #1143: Ozone Read fails with StatusRunTimeExceptions after 2 datanode fail i… URL: https://github.com/apache/hadoop/pull/1143 This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] ChenSammi merged pull request #1153: HDDS-1855. TestStorageContainerManager#testScmProcessDatanodeHeartbeat is failing.

ChenSammi merged pull request #1153: HDDS-1855. TestStorageContainerManager#testScmProcessDatanodeHeartbeat is failing. URL: https://github.com/apache/hadoop/pull/1153 This is an automated message from the Apache Git

[GitHub] [hadoop] ayushtkn commented on issue #1162: HDFS-14670: RBF: Create secret manager instance using FederationUtil#newInstance

ayushtkn commented on issue #1162: HDFS-14670: RBF: Create secret manager instance using FederationUtil#newInstance URL: https://github.com/apache/hadoop/pull/1162#issuecomment-515284949 Thanx @chittshota, On a quick look, the code looks good. Regarding the yetus I tried to trigger

[jira] [Comment Edited] (HADOOP-16435) RpcMetrics should not be retained forever

[ https://issues.apache.org/jira/browse/HADOOP-16435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893250#comment-16893250 ] Akira Ajisaka edited comment on HADOOP-16435 at 7/26/19 2:13 AM: -

[jira] [Commented] (HADOOP-16453) Remove useless trace log in NetUtils.java

[ https://issues.apache.org/jira/browse/HADOOP-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893265#comment-16893265 ] Lisheng Sun commented on HADOOP-16453: -- hi [~elgoiri]. the exception which is thrown when call

[jira] [Updated] (HADOOP-16453) Remove useless trace log in NetUtils.java

[ https://issues.apache.org/jira/browse/HADOOP-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lisheng Sun updated HADOOP-16453: - Description: When there is no String Constructor for the exception, we Log a Trace Message.

[jira] [Updated] (HADOOP-16453) Remove useless trace log in NetUtils.java

[ https://issues.apache.org/jira/browse/HADOOP-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lisheng Sun updated HADOOP-16453: - Description: When there is no String Constructor for the exception, we Log a Trace Message.

[jira] [Comment Edited] (HADOOP-16435) RpcMetrics should not be retained forever

[ https://issues.apache.org/jira/browse/HADOOP-16435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893250#comment-16893250 ] Akira Ajisaka edited comment on HADOOP-16435 at 7/26/19 1:44 AM: -

[jira] [Commented] (HADOOP-16435) RpcMetrics should not be retained forever

[ https://issues.apache.org/jira/browse/HADOOP-16435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893250#comment-16893250 ] Akira Ajisaka commented on HADOOP-16435: [~kgyrtkirk] thank you for the information. +1, I

[GitHub] [hadoop] chenjunjiedada commented on a change in pull request #1158: HDDS-1839: Change topology sorting related logs in Pipeline from INFO to DEBUG

chenjunjiedada commented on a change in pull request #1158: HDDS-1839: Change topology sorting related logs in Pipeline from INFO to DEBUG URL: https://github.com/apache/hadoop/pull/1158#discussion_r307557943 ## File path:

[GitHub] [hadoop] chenjunjiedada commented on a change in pull request #1158: HDDS-1839: Change topology sorting related logs in Pipeline from INFO to DEBUG

chenjunjiedada commented on a change in pull request #1158: HDDS-1839: Change topology sorting related logs in Pipeline from INFO to DEBUG URL: https://github.com/apache/hadoop/pull/1158#discussion_r307557939 ## File path:

[jira] [Commented] (HADOOP-16447) Upgrade JUnit5 from 5.3.1 to 5.5+ to support global timeout

[ https://issues.apache.org/jira/browse/HADOOP-16447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893248#comment-16893248 ] Akira Ajisaka commented on HADOOP-16447: Thank you for the patch, [~pingsutw]. Some comments:

[GitHub] [hadoop] bharatviswa504 opened a new pull request #1167: HDDS-1863. Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key.

bharatviswa504 opened a new pull request #1167: HDDS-1863. Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key. URL: https://github.com/apache/hadoop/pull/1167 This is an automated

[GitHub] [hadoop] bharatviswa504 commented on issue #1166: HDDS-1856. Merge HA and Non-HA code in OM.

bharatviswa504 commented on issue #1166: HDDS-1856. Merge HA and Non-HA code in OM. URL: https://github.com/apache/hadoop/pull/1166#issuecomment-515263195 /retest This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] hadoop-yetus commented on issue #1166: HDDS-1856. Merge HA and Non-HA code in OM.

hadoop-yetus commented on issue #1166: HDDS-1856. Merge HA and Non-HA code in OM. URL: https://github.com/apache/hadoop/pull/1166#issuecomment-515258588 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated

bharatviswa504 commented on a change in pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated URL: https://github.com/apache/hadoop/pull/1164#discussion_r307543280 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated

bharatviswa504 commented on a change in pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated URL: https://github.com/apache/hadoop/pull/1164#discussion_r307543280 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated

bharatviswa504 commented on a change in pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated URL: https://github.com/apache/hadoop/pull/1164#discussion_r307540522 ## File path:

[GitHub] [hadoop] arp7 commented on a change in pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated

arp7 commented on a change in pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated URL: https://github.com/apache/hadoop/pull/1164#discussion_r307539625 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/RDBTable.java

[GitHub] [hadoop] anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r307539277 ## File path:

[GitHub] [hadoop] anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r307539083 ## File path:

[GitHub] [hadoop] anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r307537762 ## File path:

[GitHub] [hadoop] anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r307538039 ## File path:

[GitHub] [hadoop] anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r307538835 ## File path:

[GitHub] [hadoop] anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r307537516 ## File path:

[GitHub] [hadoop] anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r307538592 ## File path:

[GitHub] [hadoop] anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r307536162 ## File path:

[GitHub] [hadoop] bharatviswa504 opened a new pull request #1166: HDDS-1856. Merge HA and Non-HA code in OM.

bharatviswa504 opened a new pull request #1166: HDDS-1856. Merge HA and Non-HA code in OM. URL: https://github.com/apache/hadoop/pull/1166 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] arp7 commented on issue #1156: HDDS-1830 OzoneManagerDoubleBuffer#stop should wait for daemon thread to die

arp7 commented on issue #1156: HDDS-1830 OzoneManagerDoubleBuffer#stop should wait for daemon thread to die URL: https://github.com/apache/hadoop/pull/1156#issuecomment-515249526 I am not sure how revert will work with the PR. Will leave it alone for now. Let's see if subsequent CI runs

[GitHub] [hadoop] arp7 commented on issue #1156: HDDS-1830 OzoneManagerDoubleBuffer#stop should wait for daemon thread to die

arp7 commented on issue #1156: HDDS-1830 OzoneManagerDoubleBuffer#stop should wait for daemon thread to die URL: https://github.com/apache/hadoop/pull/1156#issuecomment-515248940 I merged this before CI had a chance to complete. Sorry about that. Let me revert and retest.

[GitHub] [hadoop] avijayanhwx commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

avijayanhwx commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#discussion_r307536825 ## File path:

[GitHub] [hadoop] avijayanhwx commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

avijayanhwx commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#discussion_r307536807 ## File path:

[GitHub] [hadoop] arp7 merged pull request #1156: HDDS-1830 OzoneManagerDoubleBuffer#stop should wait for daemon thread to die

arp7 merged pull request #1156: HDDS-1830 OzoneManagerDoubleBuffer#stop should wait for daemon thread to die URL: https://github.com/apache/hadoop/pull/1156 This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] avijayanhwx commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

avijayanhwx commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#discussion_r307536091 ## File path:

[GitHub] [hadoop] anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r307535953 ## File path:

[GitHub] [hadoop] bharatviswa504 opened a new pull request #1165: HDDS-1861. Fix TableCacheImpl cleanup logic.

bharatviswa504 opened a new pull request #1165: HDDS-1861. Fix TableCacheImpl cleanup logic. URL: https://github.com/apache/hadoop/pull/1165 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] avijayanhwx commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

avijayanhwx commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#discussion_r307535001 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java

[GitHub] [hadoop] smengcl commented on a change in pull request #1156: HDDS-1830 OzoneManagerDoubleBuffer#stop should wait for daemon thread to die

smengcl commented on a change in pull request #1156: HDDS-1830 OzoneManagerDoubleBuffer#stop should wait for daemon thread to die URL: https://github.com/apache/hadoop/pull/1156#discussion_r307534380 ## File path:

[GitHub] [hadoop] smengcl commented on a change in pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated

smengcl commented on a change in pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated URL: https://github.com/apache/hadoop/pull/1164#discussion_r307531341 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/TypedTable.java

[GitHub] [hadoop] smengcl commented on a change in pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated

smengcl commented on a change in pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated URL: https://github.com/apache/hadoop/pull/1164#discussion_r307530723 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/RDBTable.java

[GitHub] [hadoop] smengcl opened a new pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated

smengcl opened a new pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated URL: https://github.com/apache/hadoop/pull/1164 This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] avijayanhwx commented on a change in pull request #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s…

avijayanhwx commented on a change in pull request #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s… URL: https://github.com/apache/hadoop/pull/1163#discussion_r307529945 ## File path:

[GitHub] [hadoop] arp7 commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

arp7 commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#discussion_r307529200 ## File path:

[GitHub] [hadoop] arp7 commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

arp7 commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#discussion_r307528281 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/RDBStore.java

[GitHub] [hadoop] arp7 commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

arp7 commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#discussion_r307528628 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java

[GitHub] [hadoop] arp7 commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

arp7 commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#discussion_r307528176 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/RDBStore.java

[GitHub] [hadoop] arp7 commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

arp7 commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#discussion_r307527924 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/RDBStore.java

[GitHub] [hadoop] swagle commented on a change in pull request #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s…

swagle commented on a change in pull request #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s… URL: https://github.com/apache/hadoop/pull/1163#discussion_r307529271 ## File path:

[GitHub] [hadoop] avijayanhwx commented on issue #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s…

avijayanhwx commented on issue #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s… URL: https://github.com/apache/hadoop/pull/1163#issuecomment-515240355 cc @swagle This is an automated message

[GitHub] [hadoop] arp7 commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

arp7 commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#discussion_r307527606 ## File path:

[GitHub] [hadoop] avijayanhwx commented on issue #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

avijayanhwx commented on issue #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#issuecomment-515238282 @arp7 Can you please review/commit this PR?

[GitHub] [hadoop] avijayanhwx commented on issue #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s…

avijayanhwx commented on issue #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s… URL: https://github.com/apache/hadoop/pull/1163#issuecomment-515236913 @mukul1987 / @lokeshj1703 / @bharatviswa504 / @bshashikant Please review when you have a chance.

[GitHub] [hadoop] avijayanhwx commented on issue #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s…

avijayanhwx commented on issue #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s… URL: https://github.com/apache/hadoop/pull/1163#issuecomment-515236951 /label ozone This is an automated message

[GitHub] [hadoop] chittshota commented on issue #1162: HDFS-14670: RBF: Create secret manager instance using FederationUtil#newInstance

chittshota commented on issue #1162: HDFS-14670: RBF: Create secret manager instance using FederationUtil#newInstance URL: https://github.com/apache/hadoop/pull/1162#issuecomment-515234978 @goiri Thanks for the review. @steveloughran Could you help us know how to kick trigger the build

[GitHub] [hadoop] avijayanhwx opened a new pull request #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s…

avijayanhwx opened a new pull request #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s… URL: https://github.com/apache/hadoop/pull/1163 …napshots. Right now, after after taking a new snapshot, the previous snapshot file is left in the raft log directory.

[GitHub] [hadoop] anuengineer closed pull request #1159: HDDS-1850. ReplicationManager should consider inflight replication and deletion while picking datanode for re-replication.

anuengineer closed pull request #1159: HDDS-1850. ReplicationManager should consider inflight replication and deletion while picking datanode for re-replication. URL: https://github.com/apache/hadoop/pull/1159 This is an

[GitHub] [hadoop] anuengineer commented on issue #1159: HDDS-1850. ReplicationManager should consider inflight replication and deletion while picking datanode for re-replication.

anuengineer commented on issue #1159: HDDS-1850. ReplicationManager should consider inflight replication and deletion while picking datanode for re-replication. URL: https://github.com/apache/hadoop/pull/1159#issuecomment-515227006 @nandakumar131 Thanks for your contribution. @mukul1987

[GitHub] [hadoop] goiri commented on issue #1162: HDFS-14670: RBF: Create secret manager instance using FederationUtil#newInstance

goiri commented on issue #1162: HDFS-14670: RBF: Create secret manager instance using FederationUtil#newInstance URL: https://github.com/apache/hadoop/pull/1162#issuecomment-515226872 The code looks good. I think that Yatus used to run by itself but it got disabled? In Spark there is

[GitHub] [hadoop] swagle commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

swagle commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r307494588 ## File path:

[GitHub] [hadoop] chittshota opened a new pull request #1162: HDFS-14670: RBF: Create secret manager instance using FederationUtil#newInstance

chittshota opened a new pull request #1162: HDFS-14670: RBF: Create secret manager instance using FederationUtil#newInstance URL: https://github.com/apache/hadoop/pull/1162 This is an automated message from the Apache Git

[GitHub] [hadoop] hadoop-yetus commented on issue #1028: HDFS-14617 - Improve fsimage load time by writing sub-sections to the fsimage index

hadoop-yetus commented on issue #1028: HDFS-14617 - Improve fsimage load time by writing sub-sections to the fsimage index URL: https://github.com/apache/hadoop/pull/1028#issuecomment-515186531 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1028: HDFS-14617 - Improve fsimage load time by writing sub-sections to the fsimage index

hadoop-yetus commented on a change in pull request #1028: HDFS-14617 - Improve fsimage load time by writing sub-sections to the fsimage index URL: https://github.com/apache/hadoop/pull/1028#discussion_r307469373 ## File path:

[GitHub] [hadoop] swagle commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

swagle commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r307454335 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/HddsConfigKeys.java

[jira] [Commented] (HADOOP-16452) Increase ipc.maximum.data.length default from 64MB to 128MB

[ https://issues.apache.org/jira/browse/HADOOP-16452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893060#comment-16893060 ] Erik Krogen commented on HADOOP-16452: -- {quote} Breaking the BRs into multiple messages is a

[jira] [Commented] (HADOOP-16453) Remove useless trace log in NetUtils.java

[ https://issues.apache.org/jira/browse/HADOOP-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893058#comment-16893058 ] Íñigo Goiri commented on HADOOP-16453: -- How does the exception thrown look like? Is there enough

[jira] [Commented] (HADOOP-16459) Backport [HADOOP-16266] "Add more fine-grained processing time metrics to the RPC layer" to branch-2

[ https://issues.apache.org/jira/browse/HADOOP-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893049#comment-16893049 ] Íñigo Goiri commented on HADOOP-16459: -- [^HADOOP-16266-branch-2.001.patch] LGTM. +1 > Backport

[jira] [Commented] (HADOOP-16459) Backport [HADOOP-16266] "Add more fine-grained processing time metrics to the RPC layer" to branch-2

[ https://issues.apache.org/jira/browse/HADOOP-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893048#comment-16893048 ] Erik Krogen commented on HADOOP-16459: -- The checkstyles are carry-overs from matching the style

[GitHub] [hadoop] xiaoyuyao commented on issue #931: HDDS-1586. Allow Ozone RPC client to read with topology awareness.

xiaoyuyao commented on issue #931: HDDS-1586. Allow Ozone RPC client to read with topology awareness. URL: https://github.com/apache/hadoop/pull/931#issuecomment-515135949 The JIRA has been merged with a different PR. This

[GitHub] [hadoop] xiaoyuyao closed pull request #931: HDDS-1586. Allow Ozone RPC client to read with topology awareness.

xiaoyuyao closed pull request #931: HDDS-1586. Allow Ozone RPC client to read with topology awareness. URL: https://github.com/apache/hadoop/pull/931 This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop] xiaoyuyao commented on issue #1008: HDDS-1713. ReplicationManager fail to find proper node topology based…

xiaoyuyao commented on issue #1008: HDDS-1713. ReplicationManager fail to find proper node topology based… URL: https://github.com/apache/hadoop/pull/1008#issuecomment-515135542 The JIRA has been taken over with a different PR.

[GitHub] [hadoop] xiaoyuyao closed pull request #1008: HDDS-1713. ReplicationManager fail to find proper node topology based…

xiaoyuyao closed pull request #1008: HDDS-1713. ReplicationManager fail to find proper node topology based… URL: https://github.com/apache/hadoop/pull/1008 This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1158: HDDS-1839: Change topology sorting related logs in Pipeline from INFO to DEBUG

xiaoyuyao commented on a change in pull request #1158: HDDS-1839: Change topology sorting related logs in Pipeline from INFO to DEBUG URL: https://github.com/apache/hadoop/pull/1158#discussion_r307396865 ## File path: hadoop-hdds/container-service/src/main/resources/ozone-site.xml

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1158: HDDS-1839: Change topology sorting related logs in Pipeline from INFO to DEBUG

xiaoyuyao commented on a change in pull request #1158: HDDS-1839: Change topology sorting related logs in Pipeline from INFO to DEBUG URL: https://github.com/apache/hadoop/pull/1158#discussion_r307396688 ## File path:

[jira] [Created] (HADOOP-16463) Migrate away from jsr305 jar

Eric Yang created HADOOP-16463: -- Summary: Migrate away from jsr305 jar Key: HADOOP-16463 URL: https://issues.apache.org/jira/browse/HADOOP-16463 Project: Hadoop Common Issue Type: Bug

[GitHub] [hadoop] bharatviswa504 merged pull request #1155: HDDS-1842. Implement S3 Abort MPU request to use Cache and DoubleBuffer.

bharatviswa504 merged pull request #1155: HDDS-1842. Implement S3 Abort MPU request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1155 This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] bharatviswa504 commented on issue #1155: HDDS-1842. Implement S3 Abort MPU request to use Cache and DoubleBuffer.

bharatviswa504 commented on issue #1155: HDDS-1842. Implement S3 Abort MPU request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1155#issuecomment-515099573 Thank You @arp7 for the review. Test failures are not related to this patch. I will commit this to the

[GitHub] [hadoop] hadoop-yetus commented on issue #1160: HADOOP-16458 LocatedFileStatusFetcher.getFileStatuses failing intermittently with s3

hadoop-yetus commented on issue #1160: HADOOP-16458 LocatedFileStatusFetcher.getFileStatuses failing intermittently with s3 URL: https://github.com/apache/hadoop/pull/1160#issuecomment-515099301 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment

[GitHub] [hadoop] hadoop-yetus commented on issue #1161: HADOOP-16461. Regression: FileSystem cache lock parses XML within the lock

hadoop-yetus commented on issue #1161: HADOOP-16461. Regression: FileSystem cache lock parses XML within the lock URL: https://github.com/apache/hadoop/pull/1161#issuecomment-515087924 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus commented on issue #1124: HDDS-1749 : Ozone Client should randomize the list of nodes in pipeline for reads

hadoop-yetus commented on issue #1124: HDDS-1749 : Ozone Client should randomize the list of nodes in pipeline for reads URL: https://github.com/apache/hadoop/pull/1124#issuecomment-515078126 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] bshashikant commented on issue #1124: HDDS-1749 : Ozone Client should randomize the list of nodes in pipeline for reads

bshashikant commented on issue #1124: HDDS-1749 : Ozone Client should randomize the list of nodes in pipeline for reads URL: https://github.com/apache/hadoop/pull/1124#issuecomment-515078010 Thanks @avijayanhwx for working on this and @bharatviswa504 for the review. I have committed the

  1   2   >