[GitHub] [hadoop] adoroszlai edited a comment on issue #1600: HDDS-2239. Fix TestOzoneFsHAUrls

2019-10-04 Thread GitBox
adoroszlai edited a comment on issue #1600: HDDS-2239. Fix TestOzoneFsHAUrls URL: https://github.com/apache/hadoop/pull/1600#issuecomment-538617721 ``` [INFO] Running org.apache.hadoop.fs.ozone.TestOzoneFsHAURLs [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:

[GitHub] [hadoop] adoroszlai commented on issue #1600: HDDS-2239. Fix TestOzoneFsHAUrls

2019-10-04 Thread GitBox
adoroszlai commented on issue #1600: HDDS-2239. Fix TestOzoneFsHAUrls URL: https://github.com/apache/hadoop/pull/1600#issuecomment-538617721 ``` [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 80.155 s - in org.apache.hadoop.fs.ozone.TestOzoneFSInputStream

[GitHub] [hadoop] goiri commented on a change in pull request #1480: HDFS-14857 FS operations fail in HA mode: DataNode fails to connect to NameNode

2019-10-04 Thread GitBox
goiri commented on a change in pull request #1480: HDFS-14857 FS operations fail in HA mode: DataNode fails to connect to NameNode URL: https://github.com/apache/hadoop/pull/1480#discussion_r331732588 ## File path:

[GitHub] [hadoop] goiri commented on a change in pull request #1480: HDFS-14857 FS operations fail in HA mode: DataNode fails to connect to NameNode

2019-10-04 Thread GitBox
goiri commented on a change in pull request #1480: HDFS-14857 FS operations fail in HA mode: DataNode fails to connect to NameNode URL: https://github.com/apache/hadoop/pull/1480#discussion_r331732560 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on issue #1480: HDFS-14857 FS operations fail in HA mode: DataNode fails to connect to NameNode

2019-10-04 Thread GitBox
hadoop-yetus commented on issue #1480: HDFS-14857 FS operations fail in HA mode: DataNode fails to connect to NameNode URL: https://github.com/apache/hadoop/pull/1480#issuecomment-538615750 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HADOOP-16152) Upgrade Eclipse Jetty version to 9.4.x

2019-10-04 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944972#comment-16944972 ] Hadoop QA commented on HADOOP-16152: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hadoop] hadoop-yetus commented on issue #1517: HDDS-2169. Avoid buffer copies while submitting client requests in Ratis

2019-10-04 Thread GitBox
hadoop-yetus commented on issue #1517: HDDS-2169. Avoid buffer copies while submitting client requests in Ratis URL: https://github.com/apache/hadoop/pull/1517#issuecomment-538613430 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1446: YARN-9834. Allow using a pool of local users to run Yarn Secure Conta…

2019-10-04 Thread GitBox
hadoop-yetus commented on a change in pull request #1446: YARN-9834. Allow using a pool of local users to run Yarn Secure Conta… URL: https://github.com/apache/hadoop/pull/1446#discussion_r331730566 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1446: YARN-9834. Allow using a pool of local users to run Yarn Secure Conta…

2019-10-04 Thread GitBox
hadoop-yetus commented on a change in pull request #1446: YARN-9834. Allow using a pool of local users to run Yarn Secure Conta… URL: https://github.com/apache/hadoop/pull/1446#discussion_r331730570 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on issue #1446: YARN-9834. Allow using a pool of local users to run Yarn Secure Conta…

2019-10-04 Thread GitBox
hadoop-yetus commented on issue #1446: YARN-9834. Allow using a pool of local users to run Yarn Secure Conta… URL: https://github.com/apache/hadoop/pull/1446#issuecomment-538611918 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Comment Edited] (HADOOP-14445) Use DelegationTokenIssuer to create KMS delegation tokens that can authenticate to all KMS instances

2019-10-04 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-14445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944110#comment-16944110 ] Siyao Meng edited comment on HADOOP-14445 at 10/5/19 3:20 AM: -- Looks like

[jira] [Updated] (HADOOP-16152) Upgrade Eclipse Jetty version to 9.4.x

2019-10-04 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HADOOP-16152: Attachment: HADOOP-16152.005.patch Target Version/s: 3.3.0 Status: Patch

[jira] [Updated] (HADOOP-16152) Upgrade Eclipse Jetty version to 9.4.x

2019-10-04 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HADOOP-16152: Status: In Progress (was: Patch Available) > Upgrade Eclipse Jetty version to 9.4.x >

[GitHub] [hadoop] hadoop-yetus commented on issue #1517: HDDS-2169. Avoid buffer copies while submitting client requests in Ratis

2019-10-04 Thread GitBox
hadoop-yetus commented on issue #1517: HDDS-2169. Avoid buffer copies while submitting client requests in Ratis URL: https://github.com/apache/hadoop/pull/1517#issuecomment-538606858 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HADOOP-16152) Upgrade Eclipse Jetty version to 9.4.x

2019-10-04 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944951#comment-16944951 ] Siyao Meng commented on HADOOP-16152: - shadedclient -1 was due to client integration test failure:

[GitHub] [hadoop] szetszwo commented on issue #1595: HDDS-2222. Add a method to update ByteBuffer in PureJavaCrc32/PureJavaCrc32C

2019-10-04 Thread GitBox
szetszwo commented on issue #1595: HDDS-. Add a method to update ByteBuffer in PureJavaCrc32/PureJavaCrc32C URL: https://github.com/apache/hadoop/pull/1595#issuecomment-538604170 Sorry about that. I thought we may ignore the checkstyle warnings like we are doing in Hadoop.

[GitHub] [hadoop] szetszwo commented on issue #1517: HDDS-2169. Avoid buffer copies while submitting client requests in Ratis

2019-10-04 Thread GitBox
szetszwo commented on issue #1517: HDDS-2169. Avoid buffer copies while submitting client requests in Ratis URL: https://github.com/apache/hadoop/pull/1517#issuecomment-538603606 > ... I tried to run the tests in TestDataValidateWithUnsafeByteOperations and i see the following exception

[GitHub] [hadoop] sidseth commented on issue #1587: HADOOP-16626. S3A ITestRestrictedReadAccess fails

2019-10-04 Thread GitBox
sidseth commented on issue #1587: HADOOP-16626. S3A ITestRestrictedReadAccess fails URL: https://github.com/apache/hadoop/pull/1587#issuecomment-538602765 LGTM. +1 This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] hadoop-yetus commented on issue #1593: HDDS-2204. Avoid buffer coping in checksum verification.

2019-10-04 Thread GitBox
hadoop-yetus commented on issue #1593: HDDS-2204. Avoid buffer coping in checksum verification. URL: https://github.com/apache/hadoop/pull/1593#issuecomment-538599692 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus commented on issue #1589: HDDS-2244. Use new ReadWrite lock in OzoneManager.

2019-10-04 Thread GitBox
hadoop-yetus commented on issue #1589: HDDS-2244. Use new ReadWrite lock in OzoneManager. URL: https://github.com/apache/hadoop/pull/1589#issuecomment-538598469 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus commented on issue #1588: HDDS-1986. Fix listkeys API.

2019-10-04 Thread GitBox
hadoop-yetus commented on issue #1588: HDDS-1986. Fix listkeys API. URL: https://github.com/apache/hadoop/pull/1588#issuecomment-538597832 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 |

[GitHub] [hadoop] hadoop-yetus commented on issue #1588: HDDS-1986. Fix listkeys API.

2019-10-04 Thread GitBox
hadoop-yetus commented on issue #1588: HDDS-1986. Fix listkeys API. URL: https://github.com/apache/hadoop/pull/1588#issuecomment-538597298 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 |

[jira] [Comment Edited] (HADOOP-16152) Upgrade Eclipse Jetty version to 9.4.x

2019-10-04 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944909#comment-16944909 ] Siyao Meng edited comment on HADOOP-16152 at 10/4/19 11:39 PM: --- Uploaded

[jira] [Updated] (HADOOP-16152) Upgrade Eclipse Jetty version to 9.4.x

2019-10-04 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HADOOP-16152: Attachment: HADOOP-16152.004.patch Status: Patch Available (was: In Progress) Updates

[jira] [Updated] (HADOOP-16152) Upgrade Eclipse Jetty version to 9.4.x

2019-10-04 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HADOOP-16152: Status: In Progress (was: Patch Available) > Upgrade Eclipse Jetty version to 9.4.x >

[jira] [Updated] (HADOOP-16152) Upgrade Eclipse Jetty version to 9.4.x

2019-10-04 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HADOOP-16152: Attachment: HADOOP-16152.003.patch Status: Patch Available (was: In Progress) Uploaded

[GitHub] [hadoop] bharatviswa504 merged pull request #1603: HDDS-2257. Fix checkstyle issues in ChecksumByteBuffer

2019-10-04 Thread GitBox
bharatviswa504 merged pull request #1603: HDDS-2257. Fix checkstyle issues in ChecksumByteBuffer URL: https://github.com/apache/hadoop/pull/1603 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] hadoop-yetus commented on issue #1603: HDDS-2257. Fix checkstyle issues in ChecksumByteBuffer

2019-10-04 Thread GitBox
hadoop-yetus commented on issue #1603: HDDS-2257. Fix checkstyle issues in ChecksumByteBuffer URL: https://github.com/apache/hadoop/pull/1603#issuecomment-538589620 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Updated] (HADOOP-16152) Upgrade Eclipse Jetty version to 9.4.x

2019-10-04 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HADOOP-16152: Status: In Progress (was: Patch Available) > Upgrade Eclipse Jetty version to 9.4.x >

[GitHub] [hadoop] hadoop-yetus commented on issue #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…

2019-10-04 Thread GitBox
hadoop-yetus commented on issue #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests… URL: https://github.com/apache/hadoop/pull/1528#issuecomment-538585997 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] vivekratnavel commented on issue #1603: HDDS-2257. Fix checkstyle issues in ChecksumByteBuffer

2019-10-04 Thread GitBox
vivekratnavel commented on issue #1603: HDDS-2257. Fix checkstyle issues in ChecksumByteBuffer URL: https://github.com/apache/hadoop/pull/1603#issuecomment-538580729 /label ozone This is an automated message from the Apache

[GitHub] [hadoop] vivekratnavel commented on issue #1603: HDDS-2257. Fix checkstyle issues in ChecksumByteBuffer

2019-10-04 Thread GitBox
vivekratnavel commented on issue #1603: HDDS-2257. Fix checkstyle issues in ChecksumByteBuffer URL: https://github.com/apache/hadoop/pull/1603#issuecomment-538580780 cc @bharatviswa504 This is an automated message from the

[GitHub] [hadoop] vivekratnavel opened a new pull request #1603: HDDS-2257. Fix checkstyle issues in ChecksumByteBuffer

2019-10-04 Thread GitBox
vivekratnavel opened a new pull request #1603: HDDS-2257. Fix checkstyle issues in ChecksumByteBuffer URL: https://github.com/apache/hadoop/pull/1603 Fix these checkstyle issues ``` hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/common/ChecksumByteBuffer.java 84: Inner

[jira] [Commented] (HADOOP-16543) Cached DNS name resolution error

2019-10-04 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944865#comment-16944865 ] Hadoop QA commented on HADOOP-16543: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hadoop] hadoop-yetus commented on issue #1399: HADOOP-16543: Cached DNS name resolution error

2019-10-04 Thread GitBox
hadoop-yetus commented on issue #1399: HADOOP-16543: Cached DNS name resolution error URL: https://github.com/apache/hadoop/pull/1399#issuecomment-538574907 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] bharatviswa504 commented on issue #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…

2019-10-04 Thread GitBox
bharatviswa504 commented on issue #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests… URL: https://github.com/apache/hadoop/pull/1528#issuecomment-538572646 New changes LGTM. There are some acceptance tests still failing, can you check if they are related or not.

[GitHub] [hadoop] hadoop-yetus commented on issue #1602: HDDS-2252. Enable gdpr robot test in daily build

2019-10-04 Thread GitBox
hadoop-yetus commented on issue #1602: HDDS-2252. Enable gdpr robot test in daily build URL: https://github.com/apache/hadoop/pull/1602#issuecomment-538567222 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus commented on issue #1601: HADOOP-16635. S3A innerGetFileStatus scans for directories-only still does a HEAD.

2019-10-04 Thread GitBox
hadoop-yetus commented on issue #1601: HADOOP-16635. S3A innerGetFileStatus scans for directories-only still does a HEAD. URL: https://github.com/apache/hadoop/pull/1601#issuecomment-538566972 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] dineshchitlangia commented on issue #1602: HDDS-2252. Enable gdpr robot test in daily build

2019-10-04 Thread GitBox
dineshchitlangia commented on issue #1602: HDDS-2252. Enable gdpr robot test in daily build URL: https://github.com/apache/hadoop/pull/1602#issuecomment-538566605 Checkstyle issue is unrelated to patch. Filed HDDS-2257 to address it.

[GitHub] [hadoop] elek closed pull request #1597: HDDS-2250. Generated configs missing from ozone-filesystem-lib jars

2019-10-04 Thread GitBox
elek closed pull request #1597: HDDS-2250. Generated configs missing from ozone-filesystem-lib jars URL: https://github.com/apache/hadoop/pull/1597 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] elek commented on issue #1597: HDDS-2250. Generated configs missing from ozone-filesystem-lib jars

2019-10-04 Thread GitBox
elek commented on issue #1597: HDDS-2250. Generated configs missing from ozone-filesystem-lib jars URL: https://github.com/apache/hadoop/pull/1597#issuecomment-538566511 +1 thank you very much the fix. And the continuous work to resolve all the acceptance test failures.

[GitHub] [hadoop] dineshchitlangia commented on issue #1542: HDDS-2140. Add robot test for GDPR feature

2019-10-04 Thread GitBox
dineshchitlangia commented on issue #1542: HDDS-2140. Add robot test for GDPR feature URL: https://github.com/apache/hadoop/pull/1542#issuecomment-538566236 > But let's do it in a follow-up jira. To many issues in the queue. I will commit it right now... Addressed this

[GitHub] [hadoop] hadoop-yetus commented on issue #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…

2019-10-04 Thread GitBox
hadoop-yetus commented on issue #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests… URL: https://github.com/apache/hadoop/pull/1528#issuecomment-538561240 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] anuengineer commented on issue #1602: HDDS-2252. Enable gdpr robot test in daily build

2019-10-04 Thread GitBox
anuengineer commented on issue #1602: HDDS-2252. Enable gdpr robot test in daily build URL: https://github.com/apache/hadoop/pull/1602#issuecomment-538551306 +1, pending Jenkins. This is an automated message from the Apache

[GitHub] [hadoop] anuengineer commented on issue #1602: HDDS-2252. Enable gdpr robot test in daily build

2019-10-04 Thread GitBox
anuengineer commented on issue #1602: HDDS-2252. Enable gdpr robot test in daily build URL: https://github.com/apache/hadoop/pull/1602#issuecomment-538551274 /label ozone This is an automated message from the Apache Git

[GitHub] [hadoop] hadoop-yetus commented on issue #1600: HDDS-2239. Fix TestOzoneFsHAUrls

2019-10-04 Thread GitBox
hadoop-yetus commented on issue #1600: HDDS-2239. Fix TestOzoneFsHAUrls URL: https://github.com/apache/hadoop/pull/1600#issuecomment-538551062 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0

[GitHub] [hadoop] dineshchitlangia opened a new pull request #1602: HDDS-2252. Enable gdpr robot test in daily build

2019-10-04 Thread GitBox
dineshchitlangia opened a new pull request #1602: HDDS-2252. Enable gdpr robot test in daily build URL: https://github.com/apache/hadoop/pull/1602 **What changes were proposed in this pull request?** Updated test.sh script to include gdpr.robot test so that it gets triggered as part of

[GitHub] [hadoop] steveloughran opened a new pull request #1601: HADOOP-16635. S3A innerGetFileStatus scans for directories-only still does a HEAD.

2019-10-04 Thread GitBox
steveloughran opened a new pull request #1601: HADOOP-16635. S3A innerGetFileStatus scans for directories-only still does a HEAD. URL: https://github.com/apache/hadoop/pull/1601 1. Make sure the probe set is passed down. 2. check for Head probe wraps only HEAD request.

[jira] [Commented] (HADOOP-16633) Tune hadoop-aws parallel test surefire/failsafe settings

2019-10-04 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944803#comment-16944803 ] Steve Loughran commented on HADOOP-16633: - need to add .surefire-* as a .gitignore pattern or

[jira] [Commented] (HADOOP-16634) S3A ITest failures without S3Guard

2019-10-04 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944802#comment-16944802 ] Steve Loughran commented on HADOOP-16634: - This has shown HADOOP-16635; I'm creating a PR for

[GitHub] [hadoop] hadoop-yetus commented on issue #1480: HDFS-14857 FS operations fail in HA mode: DataNode fails to connect to NameNode

2019-10-04 Thread GitBox
hadoop-yetus commented on issue #1480: HDFS-14857 FS operations fail in HA mode: DataNode fails to connect to NameNode URL: https://github.com/apache/hadoop/pull/1480#issuecomment-538546876 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] goiri commented on a change in pull request #1399: HADOOP-16543: Cached DNS name resolution error

2019-10-04 Thread GitBox
goiri commented on a change in pull request #1399: HADOOP-16543: Cached DNS name resolution error URL: https://github.com/apache/hadoop/pull/1399#discussion_r331669589 ## File path:

[GitHub] [hadoop] goiri commented on a change in pull request #1399: HADOOP-16543: Cached DNS name resolution error

2019-10-04 Thread GitBox
goiri commented on a change in pull request #1399: HADOOP-16543: Cached DNS name resolution error URL: https://github.com/apache/hadoop/pull/1399#discussion_r331669429 ## File path:

[jira] [Updated] (HADOOP-16635) S3A innerGetFileStatus scans for directories-only still does a HEAD

2019-10-04 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16635: Summary: S3A innerGetFileStatus scans for directories-only still does a HEAD (was: S3A

[GitHub] [hadoop] goiri commented on a change in pull request #1399: HADOOP-16543: Cached DNS name resolution error

2019-10-04 Thread GitBox
goiri commented on a change in pull request #1399: HADOOP-16543: Cached DNS name resolution error URL: https://github.com/apache/hadoop/pull/1399#discussion_r327258424 ## File path:

[jira] [Created] (HADOOP-16635) S3A innerGetFileStatus scans for directories only still does a HEAD

2019-10-04 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-16635: --- Summary: S3A innerGetFileStatus scans for directories only still does a HEAD Key: HADOOP-16635 URL: https://issues.apache.org/jira/browse/HADOOP-16635 Project:

[GitHub] [hadoop] hadoop-yetus commented on issue #1587: HADOOP-16626. S3A ITestRestrictedReadAccess fails

2019-10-04 Thread GitBox
hadoop-yetus commented on issue #1587: HADOOP-16626. S3A ITestRestrictedReadAccess fails URL: https://github.com/apache/hadoop/pull/1587#issuecomment-538541390 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hanishakoneru merged pull request #1486: HDDS-2158. Fixing Json Injection Issue in JsonUtils.

2019-10-04 Thread GitBox
hanishakoneru merged pull request #1486: HDDS-2158. Fixing Json Injection Issue in JsonUtils. URL: https://github.com/apache/hadoop/pull/1486 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] hanishakoneru commented on issue #1486: HDDS-2158. Fixing Json Injection Issue in JsonUtils.

2019-10-04 Thread GitBox
hanishakoneru commented on issue #1486: HDDS-2158. Fixing Json Injection Issue in JsonUtils. URL: https://github.com/apache/hadoop/pull/1486#issuecomment-538537962 Remaining failures are not related to this patch. Committing it.

[GitHub] [hadoop] anuengineer merged pull request #1536: HDDS-2164 : om.db.checkpoints is getting filling up fast.

2019-10-04 Thread GitBox
anuengineer merged pull request #1536: HDDS-2164 : om.db.checkpoints is getting filling up fast. URL: https://github.com/apache/hadoop/pull/1536 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] RogPodge commented on a change in pull request #1399: HADOOP-16543: Cached DNS name resolution error

2019-10-04 Thread GitBox
RogPodge commented on a change in pull request #1399: HADOOP-16543: Cached DNS name resolution error URL: https://github.com/apache/hadoop/pull/1399#discussion_r331656394 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml

[jira] [Commented] (HADOOP-16633) Tune hadoop-aws parallel test surefire/failsafe settings

2019-10-04 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944779#comment-16944779 ] Steve Loughran commented on HADOOP-16633: - bq. alphabetical, reversealphabetical, random,

[jira] [Commented] (HADOOP-16634) S3A ITest failures without S3Guard

2019-10-04 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944774#comment-16944774 ] Steve Loughran commented on HADOOP-16634: - {code:java} [INFO] [ERROR] Failures: [ERROR]

[GitHub] [hadoop] hadoop-yetus commented on issue #1600: HDDS-2239. Fix TestOzoneFsHAUrls

2019-10-04 Thread GitBox
hadoop-yetus commented on issue #1600: HDDS-2239. Fix TestOzoneFsHAUrls URL: https://github.com/apache/hadoop/pull/1600#issuecomment-538529702 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0

[jira] [Created] (HADOOP-16634) S3A ITest failures without S3Guard

2019-10-04 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-16634: --- Summary: S3A ITest failures without S3Guard Key: HADOOP-16634 URL: https://issues.apache.org/jira/browse/HADOOP-16634 Project: Hadoop Common Issue

[jira] [Updated] (HADOOP-16591) S3A ITest*MRjob failures

2019-10-04 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16591: Parent: HADOOP-15620 Issue Type: Sub-task (was: Test) > S3A ITest*MRjob

[GitHub] [hadoop] hadoop-yetus commented on issue #1599: HADOOP-16632. Speculating & Partitioned S3A magic committers can leave pending files under __magic

2019-10-04 Thread GitBox
hadoop-yetus commented on issue #1599: HADOOP-16632. Speculating & Partitioned S3A magic committers can leave pending files under __magic URL: https://github.com/apache/hadoop/pull/1599#issuecomment-538521435 :confetti_ball: **+1 overall** | Vote | Subsystem |

[GitHub] [hadoop] steveloughran commented on issue #1587: HADOOP-16626. S3A ITestRestrictedReadAccess fails

2019-10-04 Thread GitBox
steveloughran commented on issue #1587: HADOOP-16626. S3A ITestRestrictedReadAccess fails URL: https://github.com/apache/hadoop/pull/1587#issuecomment-538521306 latest patch skips all the s3guard test runs if the store is local; you must be running with DDB enabled for it to work. That is

[GitHub] [hadoop] adoroszlai commented on issue #1600: HDDS-2239. Fix TestOzoneFsHAUrls

2019-10-04 Thread GitBox
adoroszlai commented on issue #1600: HDDS-2239. Fix TestOzoneFsHAUrls URL: https://github.com/apache/hadoop/pull/1600#issuecomment-538514512 /label ozone This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop] adoroszlai opened a new pull request #1600: HDDS-2239. Fix TestOzoneFsHAUrls

2019-10-04 Thread GitBox
adoroszlai opened a new pull request #1600: HDDS-2239. Fix TestOzoneFsHAUrls URL: https://github.com/apache/hadoop/pull/1600 ## What changes were proposed in this pull request? Make sure context classloader is restored to avoid NPE during shutdown.

[GitHub] [hadoop] hadoop-yetus commented on issue #1536: HDDS-2164 : om.db.checkpoints is getting filling up fast.

2019-10-04 Thread GitBox
hadoop-yetus commented on issue #1536: HDDS-2164 : om.db.checkpoints is getting filling up fast. URL: https://github.com/apache/hadoop/pull/1536#issuecomment-538511398 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HADOOP-16579) Upgrade to Apache Curator 4.2.0 in Hadoop

2019-10-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944742#comment-16944742 ] Hudson commented on HADOOP-16579: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17481 (See

[jira] [Commented] (HADOOP-16570) S3A committers leak threads/raises OOM on job/task commit at scale

2019-10-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944731#comment-16944731 ] Hudson commented on HADOOP-16570: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17480 (See

[GitHub] [hadoop] fapifta commented on issue #1596: HDDS-2233 - Remove ByteStringHelper and refactor the code to the place where it used

2019-10-04 Thread GitBox
fapifta commented on issue #1596: HDDS-2233 - Remove ByteStringHelper and refactor the code to the place where it used URL: https://github.com/apache/hadoop/pull/1596#issuecomment-538504664 Acceptance test failures seems to be related to an internally examined similar failure in

[GitHub] [hadoop] steveloughran opened a new pull request #1599: HADOOP-16632. Speculating & Partitioned S3A magic committers can leave pending files under __magic

2019-10-04 Thread GitBox
steveloughran opened a new pull request #1599: HADOOP-16632. Speculating & Partitioned S3A magic committers can leave pending files under __magic URL: https://github.com/apache/hadoop/pull/1599 Downgrade the checks for leftover __magic entries from fail to warn now the parallel

[jira] [Updated] (HADOOP-16632) Speculating & Partitioned S3A magic committers can leave pending files under __magic

2019-10-04 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16632: Summary: Speculating & Partitioned S3A magic committers can leave pending files under

[jira] [Updated] (HADOOP-16633) Tune hadoop-aws parallel test surefire/failsafe settings

2019-10-04 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16633: Description: We can do more to improve our test runs by looking at the failsafe docs

[jira] [Updated] (HADOOP-16579) Upgrade to Apache Curator 4.2.0 in Hadoop

2019-10-04 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-16579: - Fix Version/s: 3.3.0 Resolution: Fixed Status: Resolved (was: Patch

[jira] [Resolved] (HADOOP-16570) S3A committers leak threads/raises OOM on job/task commit at scale

2019-10-04 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-16570. - Fix Version/s: 3.3.0 Resolution: Fixed done. I do have a backlog of things to

[GitHub] [hadoop] jojochuang merged pull request #1531: HADOOP-16579 - Upgrade to Apache Curator 4.2.0 excluding ZK

2019-10-04 Thread GitBox
jojochuang merged pull request #1531: HADOOP-16579 - Upgrade to Apache Curator 4.2.0 excluding ZK URL: https://github.com/apache/hadoop/pull/1531 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] steveloughran closed pull request #1442: HADOOP-16570. S3A committers encounter scale issues

2019-10-04 Thread GitBox
steveloughran closed pull request #1442: HADOOP-16570. S3A committers encounter scale issues URL: https://github.com/apache/hadoop/pull/1442 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] steveloughran commented on issue #1442: HADOOP-16570. S3A committers encounter scale issues

2019-10-04 Thread GitBox
steveloughran commented on issue #1442: HADOOP-16570. S3A committers encounter scale issues URL: https://github.com/apache/hadoop/pull/1442#issuecomment-538499572 ok, merged in. thank you for the reviews. This is an

[GitHub] [hadoop] avijayanhwx commented on issue #1536: HDDS-2164 : om.db.checkpoints is getting filling up fast.

2019-10-04 Thread GitBox
avijayanhwx commented on issue #1536: HDDS-2164 : om.db.checkpoints is getting filling up fast. URL: https://github.com/apache/hadoop/pull/1536#issuecomment-538497245 > @avijayanhwx findbugs violations are related to this change, can you take a look at it? My latest patch should

[GitHub] [hadoop] anuengineer commented on issue #1536: HDDS-2164 : om.db.checkpoints is getting filling up fast.

2019-10-04 Thread GitBox
anuengineer commented on issue #1536: HDDS-2164 : om.db.checkpoints is getting filling up fast. URL: https://github.com/apache/hadoop/pull/1536#issuecomment-538496672 /retest This is an automated message from the Apache

[GitHub] [hadoop] bshashikant commented on issue #1517: HDDS-2169. Avoid buffer copies while submitting client requests in Ratis

2019-10-04 Thread GitBox
bshashikant commented on issue #1517: HDDS-2169. Avoid buffer copies while submitting client requests in Ratis URL: https://github.com/apache/hadoop/pull/1517#issuecomment-538495734 Thanks @szetszwo for updating the patch. I tried to run the tests in

[GitHub] [hadoop] xiaoyuyao commented on issue #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…

2019-10-04 Thread GitBox
xiaoyuyao commented on issue #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests… URL: https://github.com/apache/hadoop/pull/1528#issuecomment-538495750 Thanks @vivekratnavel for the update. The latest change in OzoneNativeAuthorizer LGTM. Can you take look at

[GitHub] [hadoop] hadoop-yetus commented on issue #1598: HDDS-2251. Add an option to customize unit.sh and integration.sh parameters

2019-10-04 Thread GitBox
hadoop-yetus commented on issue #1598: HDDS-2251. Add an option to customize unit.sh and integration.sh parameters URL: https://github.com/apache/hadoop/pull/1598#issuecomment-538494612 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Updated] (HADOOP-16633) Tune hadoop-aws parallel test surefire/failsafe settings

2019-10-04 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16633: Summary: Tune hadoop-aws parallel test surefire/failsafe settings (was: Tunehadoop-aws

[jira] [Created] (HADOOP-16633) Tunehadoop-aws parallel tests to use balanced runorder for parallel tests

2019-10-04 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-16633: --- Summary: Tunehadoop-aws parallel tests to use balanced runorder for parallel tests Key: HADOOP-16633 URL: https://issues.apache.org/jira/browse/HADOOP-16633

[GitHub] [hadoop] dineshchitlangia commented on issue #1542: HDDS-2140. Add robot test for GDPR feature

2019-10-04 Thread GitBox
dineshchitlangia commented on issue #1542: HDDS-2140. Add robot test for GDPR feature URL: https://github.com/apache/hadoop/pull/1542#issuecomment-538492692 > > @elek Such a test exists in UT at TestOzoneRpcClientAbstract#testKeyReadWriteForGDPR > > Wow, and with perfect java

[GitHub] [hadoop] hanishakoneru commented on issue #1486: HDDS-2158. Fixing Json Injection Issue in JsonUtils.

2019-10-04 Thread GitBox
hanishakoneru commented on issue #1486: HDDS-2158. Fixing Json Injection Issue in JsonUtils. URL: https://github.com/apache/hadoop/pull/1486#issuecomment-538492516 Thanks @bharatviswa504 and @arp7 for the reviews. Checkstyle issues were related. Fixed that. Opened HDDS-2255 to for

[GitHub] [hadoop] adoroszlai commented on issue #1585: HDDS-2230. Invalid entries in ozonesecure-mr config

2019-10-04 Thread GitBox
adoroszlai commented on issue #1585: HDDS-2230. Invalid entries in ozonesecure-mr config URL: https://github.com/apache/hadoop/pull/1585#issuecomment-538492308 Thanks @xiaoyuyao and @elek for reviewing. This is an automated

[GitHub] [hadoop] hadoop-yetus commented on issue #1442: HADOOP-16570. S3A committers encounter scale issues

2019-10-04 Thread GitBox
hadoop-yetus commented on issue #1442: HADOOP-16570. S3A committers encounter scale issues URL: https://github.com/apache/hadoop/pull/1442#issuecomment-538491961 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HADOOP-16632) Partitioned S3A magic committers can leave pending files under __magic, maybe uploads

2019-10-04 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944698#comment-16944698 ] Steve Loughran commented on HADOOP-16632: - (FWIW this is surfacing because with the move of the

[jira] [Commented] (HADOOP-16466) Clean up the Assert usage in tests

2019-10-04 Thread Jira
[ https://issues.apache.org/jira/browse/HADOOP-16466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944697#comment-16944697 ] Íñigo Goiri commented on HADOOP-16466: -- There is one of the checkstyles that we introduced.

[GitHub] [hadoop] hadoop-yetus commented on issue #1486: HDDS-2158. Fixing Json Injection Issue in JsonUtils.

2019-10-04 Thread GitBox
hadoop-yetus commented on issue #1486: HDDS-2158. Fixing Json Injection Issue in JsonUtils. URL: https://github.com/apache/hadoop/pull/1486#issuecomment-538483912 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] steveloughran commented on issue #1481: HADOOP-16587: Made auth endpoints configurable for MSI and refresh token flows

2019-10-04 Thread GitBox
steveloughran commented on issue #1481: HADOOP-16587: Made auth endpoints configurable for MSI and refresh token flows URL: https://github.com/apache/hadoop/pull/1481#issuecomment-538483491 Ok, all LGTM. One final little nit about the debug string concatenation (SLF4J does it itself when

[GitHub] [hadoop] steveloughran commented on a change in pull request #1481: HADOOP-16587: Made auth endpoints configurable for MSI and refresh token flows

2019-10-04 Thread GitBox
steveloughran commented on a change in pull request #1481: HADOOP-16587: Made auth endpoints configurable for MSI and refresh token flows URL: https://github.com/apache/hadoop/pull/1481#discussion_r331600662 ## File path:

[GitHub] [hadoop] elek opened a new pull request #1598: HDDS-2251. Add an option to customize unit.sh and integration.sh parameters

2019-10-04 Thread GitBox
elek opened a new pull request #1598: HDDS-2251. Add an option to customize unit.sh and integration.sh parameters URL: https://github.com/apache/hadoop/pull/1598 hadoop-ozone/dev-support/checks/unit.sh (and same with integration) provides an easy entrypoint to execute all the

[GitHub] [hadoop] elek commented on issue #1595: HDDS-2222. Add a method to update ByteBuffer in PureJavaCrc32/PureJavaCrc32C

2019-10-04 Thread GitBox
elek commented on issue #1595: HDDS-. Add a method to update ByteBuffer in PureJavaCrc32/PureJavaCrc32C URL: https://github.com/apache/hadoop/pull/1595#issuecomment-538477400 Checkstyle errors seem to be introduced: ```

  1   2   >