hadoop-yetus commented on issue #1673: HDFS-14638. [Dynamometer] Fix scripts to
refer to current build structure.
URL: https://github.com/apache/hadoop/pull/1673#issuecomment-545735831
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
jojochuang commented on issue #1673: HDFS-14638. [Dynamometer] Fix scripts to
refer to current build structure.
URL: https://github.com/apache/hadoop/pull/1673#issuecomment-545732915
@smengcl would you like to review this?
tasanuma opened a new pull request #1673: HDFS-14638. [Dynamometer] Fix scripts
to refer to current build structure.
URL: https://github.com/apache/hadoop/pull/1673
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the
hadoop-yetus commented on issue #1670: HDFS-14925. Rename operation should
check nest snapshot
URL: https://github.com/apache/hadoop/pull/1670#issuecomment-545708834
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
hadoop-yetus commented on issue #1672: HDFS-14910. Rename Snapshot with Pre
Descendants Fail With IllegalArgumentException
URL: https://github.com/apache/hadoop/pull/1672#issuecomment-545705717
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment
zhjwpku commented on issue #1670: HDFS-14925. Rename operation should check
nest snapshot
URL: https://github.com/apache/hadoop/pull/1670#issuecomment-545695573
This patch misses considering dir to dir overwrite scenario, will modify and
push later, thx.
hadoop-yetus commented on issue #1671: HADOOP-16665. Filesystems to be closed
if they failed during initialize().
URL: https://github.com/apache/hadoop/pull/1671#issuecomment-545666451
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
jojochuang opened a new pull request #1672: HDFS-14910. Rename Snapshot with
Pre Descendants Fail With IllegalArgumentException
URL: https://github.com/apache/hadoop/pull/1672
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the
dineshchitlangia commented on a change in pull request #1670: HDFS-14925.
Rename operation should check nest snapshot
URL: https://github.com/apache/hadoop/pull/1670#discussion_r338241039
##
File path:
hadoop-yetus commented on issue #1670: HDFS-14925. Rename operation should
check nest snapshot
URL: https://github.com/apache/hadoop/pull/1670#issuecomment-545602150
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
steveloughran commented on issue #1671: HADOOP-16665. Filesystems to be closed
if they failed during initialize().
URL: https://github.com/apache/hadoop/pull/1671#issuecomment-545585572
regression testing in progress.
I haven't written any tests to explicitly explore the new
steveloughran opened a new pull request #1671: HADOOP-16665. Filesystems to be
closed if they failed during initialize().
URL: https://github.com/apache/hadoop/pull/1671
Patches FileSystem to do this, and for S3A have it stop services
during init exception handling.
Also
[
https://issues.apache.org/jira/browse/HADOOP-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958151#comment-16958151
]
Steve Loughran commented on HADOOP-16665:
-
I'm implementing robust cleanup in s3afs init in
[
https://issues.apache.org/jira/browse/HADOOP-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran reassigned HADOOP-16665:
---
Assignee: Steve Loughran
> Filesystems to be closed if they failed during
avijayanhwx commented on a change in pull request #1667: HDFS-14308.
DFSStripedInputStream curStripeBuf is not freed by unbuff…
URL: https://github.com/apache/hadoop/pull/1667#discussion_r338210796
##
File path:
avijayanhwx commented on a change in pull request #1667: HDFS-14308.
DFSStripedInputStream curStripeBuf is not freed by unbuff…
URL: https://github.com/apache/hadoop/pull/1667#discussion_r338210796
##
File path:
cxorm commented on issue #1640: HADOOP-16637. Fix findbugs warnings in
hadoop-cos.
URL: https://github.com/apache/hadoop/pull/1640#issuecomment-545553004
> Most of the changes look good; that input stream cleanup looks like it
will break the code as a closed stream will always get passed
jojochuang commented on issue #1670: HDFS-14925. Rename operation should check
nest snapshot
URL: https://github.com/apache/hadoop/pull/1670#issuecomment-545538271
@bshashikant could you help review this PR?
This is an
steveloughran commented on issue #1668: HADOOP-16645. S3A Delegation Token
extension point to use StoreContext.
URL: https://github.com/apache/hadoop/pull/1668#issuecomment-545531745
Happy to take the patch.
I have my own PR to clean up the binding;
steveloughran commented on issue #1640: HADOOP-16637. Fix findbugs warnings in
hadoop-cos.
URL: https://github.com/apache/hadoop/pull/1640#issuecomment-545529030
Most of the changes look good; that input stream cleanup looks like it will
break the code as a closed stream will always get
hadoop-yetus commented on issue #1661: HADOOP-16484. S3A to warn or fail if
S3Guard is disabled
URL: https://github.com/apache/hadoop/pull/1661#issuecomment-545527968
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
steveloughran commented on a change in pull request #1640: HADOOP-16637. Fix
findbugs warnings in hadoop-cos.
URL: https://github.com/apache/hadoop/pull/1640#discussion_r338152515
##
File path:
steveloughran commented on issue #1614: HADOOP-16615. Add password check for
credential provider
URL: https://github.com/apache/hadoop/pull/1614#issuecomment-545526777
I like all tests in our code to provide enough diagnostics on failure that
we can work out what went wrong purely from
steveloughran commented on issue #1661: HADOOP-16484. S3A to warn or fail if
S3Guard is disabled
URL: https://github.com/apache/hadoop/pull/1661#issuecomment-545518267
Thanks for the changes; looks good.
One issue: is "org.apache.hadoop.fs.s3a.s3guard.disabled_warn_level" the
right
zhjwpku commented on issue #1670: HDFS-14925. Rename operation should check
nest snapshot
URL: https://github.com/apache/hadoop/pull/1670#issuecomment-545517326
@manojpec, please help to review this patch :)
This is an
hadoop-yetus removed a comment on issue #1661: HADOOP-16484. S3A to warn or
fail if S3Guard is disabled
URL: https://github.com/apache/hadoop/pull/1661#issuecomment-543251581
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
steveloughran closed pull request #1591: HADOOP-16629: support copyFile in
s3afilesystem
URL: https://github.com/apache/hadoop/pull/1591
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/HADOOP-16658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957984#comment-16957984
]
Hudson commented on HADOOP-16658:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17564 (See
zhjwpku opened a new pull request #1670: HDFS-14925. Rename operation should
check nest snapshot
URL: https://github.com/apache/hadoop/pull/1670
If the src directory or any of its descendant is snapshottable
and the dst directory or its any of its ancestors is snapshottable,
we
[
https://issues.apache.org/jira/browse/HADOOP-16658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran resolved HADOOP-16658.
-
Fix Version/s: 3.3.0
Resolution: Fixed
> S3A connector does not support
steveloughran commented on issue #1664: HADOOP-16658 - S3A connector does not
support including the token ren…
URL: https://github.com/apache/hadoop/pull/1664#issuecomment-545502822
LGTM; thanks for changes
+1 and merged to trunk
steveloughran closed pull request #1664: HADOOP-16658 - S3A connector does not
support including the token ren…
URL: https://github.com/apache/hadoop/pull/1664
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/HADOOP-16658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran reassigned HADOOP-16658:
---
Assignee: Philip Zampino
> S3A connector does not support including the token
[
https://issues.apache.org/jira/browse/HADOOP-16614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957953#comment-16957953
]
Eric Yang commented on HADOOP-16614:
The patch looks good to me. I will commit if no objections.
[
https://issues.apache.org/jira/browse/HADOOP-16316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran resolved HADOOP-16316.
-
Resolution: Duplicate
HADOOP-16477 is the same issue; this came first but that has a
hadoop-yetus commented on issue #1664: HADOOP-16658 - S3A connector does not
support including the token ren…
URL: https://github.com/apache/hadoop/pull/1664#issuecomment-545480247
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
bgaborg commented on issue #1661: HADOOP-16484. S3A to warn or fail if S3Guard
is disabled
URL: https://github.com/apache/hadoop/pull/1661#issuecomment-545472813
The last commit contains fixes based on the review.
This is an
pzampino commented on issue #1664: HADOOP-16658 - S3A connector does not
support including the token ren…
URL: https://github.com/apache/hadoop/pull/1664#issuecomment-545440963
I've made the suggested changes, and re-ran the tests (which passed again).
[
https://issues.apache.org/jira/browse/HADOOP-16656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957846#comment-16957846
]
Dinesh Chitlangia commented on HADOOP-16656:
[~smeng] Thank you for checking. Your
[
https://issues.apache.org/jira/browse/HADOOP-16657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957803#comment-16957803
]
Minni Mittal edited comment on HADOOP-16657 at 10/23/19 11:57 AM:
--
[
https://issues.apache.org/jira/browse/HADOOP-16657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957803#comment-16957803
]
Minni Mittal edited comment on HADOOP-16657 at 10/23/19 11:56 AM:
--
[
https://issues.apache.org/jira/browse/HADOOP-16657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957803#comment-16957803
]
Minni Mittal commented on HADOOP-16657:
---
Following files in hadoop-common project are modified
[
https://issues.apache.org/jira/browse/HADOOP-16657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Minni Mittal updated HADOOP-16657:
--
Attachment: HADOOP-16657.001.patch
> Move remaining log4j APIs over to slf4j in
hadoop-yetus commented on issue #1667: HDFS-14308. DFSStripedInputStream
curStripeBuf is not freed by unbuff…
URL: https://github.com/apache/hadoop/pull/1667#issuecomment-545340879
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
[
https://issues.apache.org/jira/browse/HADOOP-16656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957628#comment-16957628
]
Siyao Meng commented on HADOOP-16656:
-
[~dineshchitlangia] Thanks for the comment.
Yes, in the
45 matches
Mail list logo
