[GitHub] [hadoop] aajisaka commented on pull request #2018: HADOOP-15353. use sudo instead of su to allow nologin user for secure DataNode

2020-05-14 Thread GitBox
aajisaka commented on pull request #2018: URL: https://github.com/apache/hadoop/pull/2018#issuecomment-629036703 Hi @2k0ri, would you fix or ignore shellcheck warnings? https://builds.apache.org/job/hadoop-multibranch/job/PR-2018/1/artifact/out/diff-patch-shellcheck.txt Before this

[GitHub] [hadoop] snvijaya commented on a change in pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
snvijaya commented on a change in pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#discussion_r425545588 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/FileSystemConfigurations.java ## @@ -81,5 +81,7 @@

[GitHub] [hadoop] hadoop-yetus commented on pull request #1892: HADOOP-16769 LocalDirAllocator to provide diagnostics when file creat…

2020-05-14 Thread GitBox
hadoop-yetus commented on pull request #1892: URL: https://github.com/apache/hadoop/pull/1892#issuecomment-628973570 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 33m

[GitHub] [hadoop] hadoop-yetus commented on pull request #2006: HDFS-15306. Make mount-table to read from central place ( Let's say from HDFS).

2020-05-14 Thread GitBox
hadoop-yetus commented on pull request #2006: URL: https://github.com/apache/hadoop/pull/2006#issuecomment-628973064 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 22m

[jira] [Resolved] (HADOOP-16690) Update dependency com.nimbusds:nimbus-jose-jwt due to security vulnerability

2020-05-14 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka resolved HADOOP-16690. Fix Version/s: (was: 3.2.2) Resolution: Done > Update dependency

[jira] [Reopened] (HADOOP-16690) Update dependency com.nimbusds:nimbus-jose-jwt due to security vulnerability

2020-05-14 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka reopened HADOOP-16690: > Update dependency com.nimbusds:nimbus-jose-jwt due to security vulnerability >

[GitHub] [hadoop] umamaheswararao commented on pull request #2006: HDFS-15306. Make mount-table to read from central place ( Let's say from HDFS).

2020-05-14 Thread GitBox
umamaheswararao commented on pull request #2006: URL: https://github.com/apache/hadoop/pull/2006#issuecomment-628956428 Thanks @jojochuang for reviews! I have pushed it to trunk. This is an automated message from the

[GitHub] [hadoop] umamaheswararao merged pull request #2006: HDFS-15306. Make mount-table to read from central place ( Let's say from HDFS).

2020-05-14 Thread GitBox
umamaheswararao merged pull request #2006: URL: https://github.com/apache/hadoop/pull/2006 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop] umamaheswararao commented on a change in pull request #2010: HADOOP-17024. ListStatus on ViewFS root should list the linkFallBack root

2020-05-14 Thread GitBox
umamaheswararao commented on a change in pull request #2010: URL: https://github.com/apache/hadoop/pull/2010#discussion_r425487375 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java ## @@ -1226,7 +1227,39 @@ public

[GitHub] [hadoop] ramesh0201 commented on pull request #1892: HADOOP-16769 LocalDirAllocator to provide diagnostics when file creat…

2020-05-14 Thread GitBox
ramesh0201 commented on pull request #1892: URL: https://github.com/apache/hadoop/pull/1892#issuecomment-628925386 Thank you for the comments. For some reason I am not getting any email notifications about these git PR review comments. I just manually verified and found I missed to

[GitHub] [hadoop] umamaheswararao commented on a change in pull request #2010: HADOOP-17024. ListStatus on ViewFS root should list the linkFallBack root

2020-05-14 Thread GitBox
umamaheswararao commented on a change in pull request #2010: URL: https://github.com/apache/hadoop/pull/2010#discussion_r425469062 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java ## @@ -1226,7 +1229,38 @@ public

[GitHub] [hadoop] umamaheswararao commented on a change in pull request #2006: HDFS-15306. Make mount-table to read from central place ( Let's say from HDFS).

2020-05-14 Thread GitBox
umamaheswararao commented on a change in pull request #2006: URL: https://github.com/apache/hadoop/pull/2006#discussion_r425441928 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/HCFSMountTableConfigLoader.java ## @@ -0,0 +1,122 @@

[GitHub] [hadoop] bilaharith commented on a change in pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
bilaharith commented on a change in pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#discussion_r425332603 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemRename.java ## @@ -28,20 +29,39 @@ import

[jira] [Created] (HADOOP-17043) Potential Race in class org.apache.hadoop.hbase.io.crypto.Encryption

2020-05-14 Thread Bozhen Liu (Jira)
Bozhen Liu created HADOOP-17043: --- Summary: Potential Race in class org.apache.hadoop.hbase.io.crypto.Encryption Key: HADOOP-17043 URL: https://issues.apache.org/jira/browse/HADOOP-17043 Project: Hadoop

[GitHub] [hadoop] hadoop-yetus commented on pull request #2023: Revert "HADOOP-8143. Change distcp to have -pb on by default."

2020-05-14 Thread GitBox
hadoop-yetus commented on pull request #2023: URL: https://github.com/apache/hadoop/pull/2023#issuecomment-628823678 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hadoop] bilaharith commented on a change in pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
bilaharith commented on a change in pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#discussion_r425354829 ## File path: hadoop-tools/hadoop-azure/src/site/markdown/abfs.md ## @@ -691,6 +691,18 @@ Config `fs.azure.account.hns.enabled` provides an option to

[GitHub] [hadoop] bilaharith commented on a change in pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
bilaharith commented on a change in pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#discussion_r425354829 ## File path: hadoop-tools/hadoop-azure/src/site/markdown/abfs.md ## @@ -691,6 +691,18 @@ Config `fs.azure.account.hns.enabled` provides an option to

[GitHub] [hadoop] hadoop-yetus commented on pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
hadoop-yetus commented on pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#issuecomment-628817519 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HADOOP-17036) TestFTPFileSystem failing as ftp server dir already exists

2020-05-14 Thread Mikhail Pryakhin (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107554#comment-17107554 ] Mikhail Pryakhin commented on HADOOP-17036: --- Why did it fail to integrate changes? Can I help

[GitHub] [hadoop] bilaharith commented on a change in pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
bilaharith commented on a change in pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#discussion_r425350762 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsConfiguration.java ## @@ -764,6 +764,11 @@ public void

[GitHub] [hadoop] bilaharith commented on a change in pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
bilaharith commented on a change in pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#discussion_r425350762 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsConfiguration.java ## @@ -764,6 +764,11 @@ public void

[GitHub] [hadoop] bilaharith commented on a change in pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
bilaharith commented on a change in pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#discussion_r425349071 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemDelete.java ## @@ -130,4 +148,50 @@ public

[GitHub] [hadoop] bilaharith commented on a change in pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
bilaharith commented on a change in pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#discussion_r425343840 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemRename.java ## @@ -149,4 +166,135 @@

[GitHub] [hadoop] bilaharith commented on a change in pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
bilaharith commented on a change in pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#discussion_r425343840 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemRename.java ## @@ -149,4 +166,135 @@

[jira] [Commented] (HADOOP-8143) Change distcp to have -pb on by default

2020-05-14 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-8143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107540#comment-17107540 ] Hudson commented on HADOOP-8143: FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #18259 (See

[jira] [Commented] (HADOOP-14557) Document HADOOP-8143 (Change distcp to have -pb on by default)

2020-05-14 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-14557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107541#comment-17107541 ] Hudson commented on HADOOP-14557: - FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #18259 (See

[GitHub] [hadoop] bilaharith commented on a change in pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
bilaharith commented on a change in pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#discussion_r425332603 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemRename.java ## @@ -28,20 +29,39 @@ import

[GitHub] [hadoop] bilaharith commented on a change in pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
bilaharith commented on a change in pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#discussion_r425319356 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/FileSystemConfigurations.java ## @@ -81,5 +81,7 @@

[GitHub] [hadoop] bilaharith commented on a change in pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
bilaharith commented on a change in pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#discussion_r425317447 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java ## @@ -321,9 +324,81 @@ public

[GitHub] [hadoop] bilaharith commented on a change in pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
bilaharith commented on a change in pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#discussion_r425328917 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java ## @@ -321,9 +324,81 @@ public

[GitHub] [hadoop] bilaharith commented on a change in pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
bilaharith commented on a change in pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#discussion_r425332603 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemRename.java ## @@ -28,20 +29,39 @@ import

[GitHub] [hadoop] bilaharith commented on a change in pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
bilaharith commented on a change in pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#discussion_r425329924 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/FileSystemConfigurations.java ## @@ -81,5 +81,7 @@

[GitHub] [hadoop] bilaharith commented on a change in pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
bilaharith commented on a change in pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#discussion_r425328917 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java ## @@ -321,9 +324,81 @@ public

[GitHub] [hadoop] bilaharith commented on a change in pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
bilaharith commented on a change in pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#discussion_r425324373 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java ## @@ -131,7 +135,7 @@ public String

[GitHub] [hadoop] bilaharith commented on a change in pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
bilaharith commented on a change in pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#discussion_r425319356 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/FileSystemConfigurations.java ## @@ -81,5 +81,7 @@

[jira] [Updated] (HADOOP-17042) Hadoop distcp throws "ERROR: Tools helper ///usr/lib/hadoop/libexec/tools/hadoop-distcp.sh was not found"

2020-05-14 Thread Aki Tanaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Tanaka updated HADOOP-17042: Attachment: HADOOP-17042.patch > Hadoop distcp throws "ERROR: Tools helper >

[jira] [Created] (HADOOP-17042) Hadoop distcp throws "ERROR: Tools helper ///usr/lib/hadoop/libexec/tools/hadoop-distcp.sh was not found"

2020-05-14 Thread Aki Tanaka (Jira)
Aki Tanaka created HADOOP-17042: --- Summary: Hadoop distcp throws "ERROR: Tools helper ///usr/lib/hadoop/libexec/tools/hadoop-distcp.sh was not found" Key: HADOOP-17042 URL:

[jira] [Commented] (HADOOP-17036) TestFTPFileSystem failing as ftp server dir already exists

2020-05-14 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107499#comment-17107499 ] Hudson commented on HADOOP-17036: - FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #18258 (See

[GitHub] [hadoop] bilaharith commented on a change in pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
bilaharith commented on a change in pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#discussion_r425317447 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java ## @@ -321,9 +324,81 @@ public

[GitHub] [hadoop] mukund-thakur commented on a change in pull request #1944: HADOOP-16900. Very large files can be truncated when written through S3AFileSystem

2020-05-14 Thread GitBox
mukund-thakur commented on a change in pull request #1944: URL: https://github.com/apache/hadoop/pull/1944#discussion_r425317038 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/WriteOperationHelper.java ## @@ -384,6 +387,7 @@ public void

[GitHub] [hadoop] mukund-thakur commented on a change in pull request #1944: HADOOP-16900. Very large files can be truncated when written through S3AFileSystem

2020-05-14 Thread GitBox
mukund-thakur commented on a change in pull request #1944: URL: https://github.com/apache/hadoop/pull/1944#discussion_r425159231 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/WriteOperationHelper.java ## @@ -384,6 +387,7 @@ public void

[GitHub] [hadoop] steveloughran opened a new pull request #2023: Revert "HADOOP-8143. Change distcp to have -pb on by default."

2020-05-14 Thread GitBox
steveloughran opened a new pull request #2023: URL: https://github.com/apache/hadoop/pull/2023 This reverts commit dd65eea74b1f9dde858ff34df8111e5340115511. Change-Id: I74180cf59d5bbad8c9f66cb331535addcbea863e

[jira] [Commented] (HADOOP-17036) TestFTPFileSystem failing as ftp server dir already exists

2020-05-14 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107488#comment-17107488 ] Steve Loughran commented on HADOOP-17036: - +1, merged. thanks! > TestFTPFileSystem failing as

[jira] [Updated] (HADOOP-17036) TestFTPFileSystem failing as ftp server dir already exists

2020-05-14 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-17036: Fix Version/s: 3.4.0 Resolution: Fixed Status: Resolved (was: Patch

[GitHub] [hadoop] steveloughran merged pull request #2009: HADOOP-17036. TestFTPFileSystem failing as ftp server dir already exists

2020-05-14 Thread GitBox
steveloughran merged pull request #2009: URL: https://github.com/apache/hadoop/pull/2009 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop] steveloughran commented on pull request #2009: HADOOP-17036. TestFTPFileSystem failing as ftp server dir already exists

2020-05-14 Thread GitBox
steveloughran commented on pull request #2009: URL: https://github.com/apache/hadoop/pull/2009#issuecomment-628779669 +1, merged. thanks for a timely followup! This is an automated message from the Apache Git Service.

[jira] [Resolved] (HADOOP-16965) Introduce StreamContext for Abfs Input and Output streams.

2020-05-14 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukund Thakur resolved HADOOP-16965. Resolution: Fixed > Introduce StreamContext for Abfs Input and Output streams. >

[GitHub] [hadoop] hadoop-yetus commented on pull request #2022: Revert "HADOOP-14557. Document HADOOP-8143 (Change distcp to have -pb on by default)."

2020-05-14 Thread GitBox
hadoop-yetus commented on pull request #2022: URL: https://github.com/apache/hadoop/pull/2022#issuecomment-628741733 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hadoop] steveloughran opened a new pull request #2022: Revert "HADOOP-14557. Document HADOOP-8143 (Change distcp to have -pb on by default)."

2020-05-14 Thread GitBox
steveloughran opened a new pull request #2022: URL: https://github.com/apache/hadoop/pull/2022 This reverts commit 44350fdf495f5cf1bb15b1fe6f6e9587d3de0a59. Change-Id: If48e3dd670c920ada702dc36461ff398fe9d35cc

[jira] [Resolved] (HADOOP-16690) Update dependency com.nimbusds:nimbus-jose-jwt due to security vulnerability

2020-05-14 Thread Colm O hEigeartaigh (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colm O hEigeartaigh resolved HADOOP-16690. -- Resolution: Fixed Already fixed:

[jira] [Updated] (HADOOP-16690) Update dependency com.nimbusds:nimbus-jose-jwt due to security vulnerability

2020-05-14 Thread Colm O hEigeartaigh (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colm O hEigeartaigh updated HADOOP-16690: - Fix Version/s: 3.2.2 > Update dependency com.nimbusds:nimbus-jose-jwt due to

[GitHub] [hadoop] mukund-thakur commented on a change in pull request #1944: HADOOP-16900. Very large files can be truncated when written through S3AFileSystem

2020-05-14 Thread GitBox
mukund-thakur commented on a change in pull request #1944: URL: https://github.com/apache/hadoop/pull/1944#discussion_r425159231 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/WriteOperationHelper.java ## @@ -384,6 +387,7 @@ public void

[GitHub] [hadoop] mukund-thakur commented on a change in pull request #1944: HADOOP-16900. Very large files can be truncated when written through S3AFileSystem

2020-05-14 Thread GitBox
mukund-thakur commented on a change in pull request #1944: URL: https://github.com/apache/hadoop/pull/1944#discussion_r425154462 ## File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3ABlocksize.java ## @@ -18,9 +18,12 @@ package

[GitHub] [hadoop] steveloughran commented on pull request #1982: HADOOP-16830. IOStatistics API.

2020-05-14 Thread GitBox
steveloughran commented on pull request #1982: URL: https://github.com/apache/hadoop/pull/1982#issuecomment-628616574 add methods to add two iostatistics instances, and to subtract one from the other. This will help merging stats from multiple file read/writes, and for when we add the API

[GitHub] [hadoop] hadoop-yetus commented on pull request #2010: HADOOP-17024. ListStatus on ViewFS root should list the linkFallBack root

2020-05-14 Thread GitBox
hadoop-yetus commented on pull request #2010: URL: https://github.com/apache/hadoop/pull/2010#issuecomment-628614834 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HADOOP-17036) TestFTPFileSystem failing as ftp server dir already exists

2020-05-14 Thread Mikhail Pryakhin (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107263#comment-17107263 ] Mikhail Pryakhin commented on HADOOP-17036: --- Hey [~ste...@apache.org], the test runner

[GitHub] [hadoop] hadoop-yetus commented on pull request #1861: HADOOP-13230. Optionally retain directory markers

2020-05-14 Thread GitBox
hadoop-yetus commented on pull request #1861: URL: https://github.com/apache/hadoop/pull/1861#issuecomment-628608819 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hadoop] hadoop-yetus commented on pull request #2009: HADOOP-17036. TestFTPFileSystem failing as ftp server dir already exists

2020-05-14 Thread GitBox
hadoop-yetus commented on pull request #2009: URL: https://github.com/apache/hadoop/pull/2009#issuecomment-628607274 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hadoop] steveloughran commented on a change in pull request #2002: HADOOP-17020. RawFileSystem could localize default block size to avoi…

2020-05-14 Thread GitBox
steveloughran commented on a change in pull request #2002: URL: https://github.com/apache/hadoop/pull/2002#discussion_r425031079 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java ## @@ -100,6 +101,7 @@ public File

[GitHub] [hadoop] hadoop-yetus commented on pull request #2019: HADOOP-17029. Return correct permission and owner for listing on internal directories in ViewFs

2020-05-14 Thread GitBox
hadoop-yetus commented on pull request #2019: URL: https://github.com/apache/hadoop/pull/2019#issuecomment-628539169 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 22m

[GitHub] [hadoop] hadoop-yetus commented on pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
hadoop-yetus commented on pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#issuecomment-628521143 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hadoop] snvijaya commented on pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
snvijaya commented on pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#issuecomment-628481922 Test results from latest updates: HNS [INFO] Tests run: 63, Failures: 0, Errors: 0, Skipped: 0 [WARNING] Tests run: 436, Failures: 0, Errors: 0, Skipped: 74 [WARNING]

[GitHub] [hadoop] snvijaya edited a comment on pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
snvijaya edited a comment on pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#issuecomment-628481170 @bilaharith Comments have been addressed. Please take a look. For the latest > > Requests failing due to server timeouts and network failures are

[GitHub] [hadoop] snvijaya commented on pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
snvijaya commented on pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#issuecomment-628481424 > Change the heading as follows. > HADOOP-17015. ABFS: Handling Rename and Delete idempotency I believe you were highlighting a space needed before ABFS. Have made that

[GitHub] [hadoop] snvijaya commented on pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
snvijaya commented on pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#issuecomment-628481170 Comments have been addressed. Please take a look. For the latest > > Requests failing due to server timeouts and network failures are exponentially retries. At

[GitHub] [hadoop] snvijaya commented on a change in pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
snvijaya commented on a change in pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#discussion_r424960964 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java ## @@ -157,7 +175,7 @@ void

[GitHub] [hadoop] snvijaya commented on a change in pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
snvijaya commented on a change in pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#discussion_r424960326 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemRename.java ## @@ -149,4 +166,135 @@ public

[GitHub] [hadoop] snvijaya commented on a change in pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
snvijaya commented on a change in pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#discussion_r424958799 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/FileSystemConfigurations.java ## @@ -81,5 +81,7 @@

[GitHub] [hadoop] snvijaya commented on a change in pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
snvijaya commented on a change in pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#discussion_r424957649 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java ## @@ -321,9 +324,81 @@ public

[GitHub] [hadoop] snvijaya commented on a change in pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-14 Thread GitBox
snvijaya commented on a change in pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#discussion_r424956423 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/DateTimeUtils.java ## @@ -0,0 +1,47 @@ +/** + * Licensed to