[GitHub] [hadoop] hadoop-yetus commented on pull request #2200: MAPREDUCE-7290. ShuffleHeader should be compatible between client…

2020-08-07 Thread GitBox
hadoop-yetus commented on pull request #2200: URL: https://github.com/apache/hadoop/pull/2200#issuecomment-670828565 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hadoop] swamirishi commented on pull request #2133: HADOOP-17122: Preserving Directory Attributes in DistCp with Atomic Copy

2020-08-07 Thread GitBox
swamirishi commented on pull request #2133: URL: https://github.com/apache/hadoop/pull/2133#issuecomment-670827651 @steveloughran Did you take a look at this? This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] hadoop-yetus commented on pull request #2203: HDFS-15520 Use visitor pattern to visit namespace tree

2020-08-07 Thread GitBox
hadoop-yetus commented on pull request #2203: URL: https://github.com/apache/hadoop/pull/2203#issuecomment-670825716 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HADOOP-17068) client fails forever when namenode ipaddr changed

2020-08-07 Thread zhenzhao wang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173544#comment-17173544 ] zhenzhao wang commented on HADOOP-17068: We had seen the problem multiple times too. One

[GitHub] [hadoop] JohnZZGithub commented on pull request #2185: HADOOP-15891. provide Regex Based Mount Point In Inode Tree

2020-08-07 Thread GitBox
JohnZZGithub commented on pull request #2185: URL: https://github.com/apache/hadoop/pull/2185#issuecomment-670807166 The UTs failure are not related to the change. Here're some references: https://issues.apache.org/jira/browse/HADOOP-15891 Design doc:

[jira] [Commented] (HADOOP-17144) Update Hadoop's lz4 to v1.9.2

2020-08-07 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173539#comment-17173539 ] Hadoop QA commented on HADOOP-17144: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hadoop] hadoop-yetus commented on pull request #2176: HDFS-15492. Make trash root inside each snapshottable directory

2020-08-07 Thread GitBox
hadoop-yetus commented on pull request #2176: URL: https://github.com/apache/hadoop/pull/2176#issuecomment-670804682 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hadoop] szetszwo opened a new pull request #2203: HDFS-15520 Use visitor pattern to visit namespace tree

2020-08-07 Thread GitBox
szetszwo opened a new pull request #2203: URL: https://github.com/apache/hadoop/pull/2203 https://issues.apache.org/jira/browse/HDFS-15520 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] smengcl commented on pull request #2176: HDFS-15492. Make trash root inside each snapshottable directory

2020-08-07 Thread GitBox
smengcl commented on pull request #2176: URL: https://github.com/apache/hadoop/pull/2176#issuecomment-670697255 I rebased the commits on to the latest trunk. Also made `dfs.namenode.snapshot.trashroot.enabled` a private config in FSNameSystem.

[GitHub] [hadoop] dbtsai commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

2020-08-07 Thread GitBox
dbtsai commented on pull request #2201: URL: https://github.com/apache/hadoop/pull/2201#issuecomment-670685339 @hemanthboyina The performance should be similar since the java-snappy also uses native lib that is bundled in the jar file. I don't benchmark yet, and I will try to find time to

[GitHub] [hadoop] hadoop-yetus commented on pull request #2069: HADOOP-16830. IOStatistics API.

2020-08-07 Thread GitBox
hadoop-yetus commented on pull request #2069: URL: https://github.com/apache/hadoop/pull/2069#issuecomment-670674319 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hadoop] smengcl commented on a change in pull request #2176: HDFS-15492. Make trash root inside each snapshottable directory

2020-08-07 Thread GitBox
smengcl commented on a change in pull request #2176: URL: https://github.com/apache/hadoop/pull/2176#discussion_r467222131 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java ## @@ -516,6 +516,11 @@ public static final int

[GitHub] [hadoop] liuml07 commented on pull request #2190: HADOOP-17182. Remove breadcrumbs from web site

2020-08-07 Thread GitBox
liuml07 commented on pull request #2190: URL: https://github.com/apache/hadoop/pull/2190#issuecomment-670667507 Thank you @ayushtkn Yes that's what I was asking. Since we still have the information clearly in the page, I guess the change to remove the dead link makes more sense.

[GitHub] [hadoop] ayushtkn edited a comment on pull request #2190: HADOOP-17182. Remove breadcrumbs from web site

2020-08-07 Thread GitBox
ayushtkn edited a comment on pull request #2190: URL: https://github.com/apache/hadoop/pull/2190#issuecomment-670654455 `After removing it, when we click one left menu, is it straightforward to tell the current version from the page/header?` Do you mean to say, the Hadoop Version? If

[GitHub] [hadoop] ayushtkn commented on pull request #2190: HADOOP-17182. Remove breadcrumbs from web site

2020-08-07 Thread GitBox
ayushtkn commented on pull request #2190: URL: https://github.com/apache/hadoop/pull/2190#issuecomment-670654455 `After removing it, when we click one left menu, is it straightforward to tell the current version from the page/header?` Do you mean to say, the Hadoop Version? If so, It

[GitHub] [hadoop] hadoop-yetus commented on pull request #2200: MAPREDUCE-7290. ShuffleHeader should be compatible between client…

2020-08-07 Thread GitBox
hadoop-yetus commented on pull request #2200: URL: https://github.com/apache/hadoop/pull/2200#issuecomment-670649392 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hadoop] liuml07 commented on pull request #2197: HADOOP-17159 Ability for forceful relogin in UserGroupInformation class

2020-08-07 Thread GitBox
liuml07 commented on pull request #2197: URL: https://github.com/apache/hadoop/pull/2197#issuecomment-670640493 Thanks @steveloughran I added Arpit and kihwal as reviewers. This is an automated message from the Apache Git

[GitHub] [hadoop] smengcl commented on a change in pull request #2176: HDFS-15492. Make trash root inside each snapshottable directory

2020-08-07 Thread GitBox
smengcl commented on a change in pull request #2176: URL: https://github.com/apache/hadoop/pull/2176#discussion_r467189530 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java ## @@ -2144,4 +2146,293 @@ public void

[jira] [Commented] (HADOOP-11219) Upgrade to netty 4

2020-08-07 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-11219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173383#comment-17173383 ] Kevin Risden commented on HADOOP-11219: --- https://snyk.io/vuln/SNYK-JAVA-IONETTY-473694

[GitHub] [hadoop] JohnZZGithub commented on a change in pull request #2185: HADOOP-15891. provide Regex Based Mount Point In Inode Tree

2020-08-07 Thread GitBox
JohnZZGithub commented on a change in pull request #2185: URL: https://github.com/apache/hadoop/pull/2185#discussion_r467176661 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java ## @@ -486,84 +506,113 @@ protected

[GitHub] [hadoop] JohnZZGithub commented on a change in pull request #2185: HADOOP-15891. provide Regex Based Mount Point In Inode Tree

2020-08-07 Thread GitBox
JohnZZGithub commented on a change in pull request #2185: URL: https://github.com/apache/hadoop/pull/2185#discussion_r467176661 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java ## @@ -486,84 +506,113 @@ protected

[jira] [Commented] (HADOOP-17145) Unauthenticated users are not authorized to access this page message is misleading in HttpServer2.java

2020-08-07 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173337#comment-17173337 ] Hadoop QA commented on HADOOP-17145: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hadoop] hadoop-yetus commented on pull request #2202: HADOOP-17191. ABFS: Run tests with all AuthTypes

2020-08-07 Thread GitBox
hadoop-yetus commented on pull request #2202: URL: https://github.com/apache/hadoop/pull/2202#issuecomment-670609097 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hadoop] swamirishi commented on pull request #2133: HADOOP-17122: Preserving Directory Attributes in DistCp with Atomic Copy

2020-08-07 Thread GitBox
swamirishi commented on pull request #2133: URL: https://github.com/apache/hadoop/pull/2133#issuecomment-670593741 Sure Thanks This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hadoop] bilaharith opened a new pull request #2202: HADOOP-17191. ABFS: Run tests with all AuthTypes

2020-08-07 Thread GitBox
bilaharith opened a new pull request #2202: URL: https://github.com/apache/hadoop/pull/2202 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop] hemanthboyina commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

2020-08-07 Thread GitBox
hemanthboyina commented on pull request #2201: URL: https://github.com/apache/hadoop/pull/2201#issuecomment-670567445 thanks for the proposal and thanks for the PR have you done any performance test with native snappy and java snappy ? is there any sort of decrease or increase ? and

[jira] [Updated] (HADOOP-17145) Unauthenticated users are not authorized to access this page message is misleading in HttpServer2.java

2020-08-07 Thread Andras Bokor (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Bokor updated HADOOP-17145: -- Attachment: HADOOP-17145.007.patch > Unauthenticated users are not authorized to access this

[GitHub] [hadoop] steveloughran commented on pull request #2069: HADOOP-16830. IOStatistics API.

2020-08-07 Thread GitBox
steveloughran commented on pull request #2069: URL: https://github.com/apache/hadoop/pull/2069#issuecomment-670536132 FFS. I slightly expand the synchronization of MeanStatistic and now findbugs gets even more upset than before. I'm going to declare all as sync even though it will hurt

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #2170: HADOOP-1320. Dir Marker getFileStatus() changes backport

2020-08-07 Thread GitBox
hadoop-yetus removed a comment on pull request #2170: URL: https://github.com/apache/hadoop/pull/2170#issuecomment-663656386 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec

[GitHub] [hadoop] steveloughran commented on pull request #2197: HADOOP-17159 Ability for forceful relogin in UserGroupInformation class

2020-08-07 Thread GitBox
steveloughran commented on pull request #2197: URL: https://github.com/apache/hadoop/pull/2197#issuecomment-670533722 LGTM, though I'll leave to someone who understands UGI to give the final vote This is an automated message

[GitHub] [hadoop] hadoop-yetus commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

2020-08-07 Thread GitBox
hadoop-yetus commented on pull request #2201: URL: https://github.com/apache/hadoop/pull/2201#issuecomment-670468155 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HADOOP-17192) ITestS3AHugeFilesSSECDiskBlock failing because of bucket overrides

2020-08-07 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173030#comment-17173030 ] Steve Loughran commented on HADOOP-17192: - remove the override in config creation, the way we

[jira] [Commented] (HADOOP-17192) ITestS3AHugeFilesSSECDiskBlock failing because of bucket overrides

2020-08-07 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173032#comment-17173032 ] Steve Loughran commented on HADOOP-17192: - via "removeBaseAndBucketOverrides()" >

[jira] [Commented] (HADOOP-17188) Support for AWS STSAssumeRoleWithWebIdentitySessionCredentialsProvider based credential provider to support use of IRSA on deployments on AWS EKS Cluster

2020-08-07 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173027#comment-17173027 ] Steve Loughran commented on HADOOP-17188: - If its in the aws SDK JAR we ship -a matter of just

[jira] [Updated] (HADOOP-17188) Support for AWS STSAssumeRoleWithWebIdentitySessionCredentialsProvider based credential provider to support use of IRSA on deployments on AWS EKS Cluster

2020-08-07 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-17188: Affects Version/s: 3.3.0 > Support for AWS

[jira] [Updated] (HADOOP-17188) Support for AWS STSAssumeRoleWithWebIdentitySessionCredentialsProvider based credential provider to support use of IRSA on deployments on AWS EKS Cluster

2020-08-07 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-17188: Priority: Minor (was: Major) > Support for AWS

[jira] [Created] (HADOOP-17192) ITestS3AHugeFilesSSECDiskBlock failing because of bucket overrides

2020-08-07 Thread Mukund Thakur (Jira)
Mukund Thakur created HADOOP-17192: -- Summary: ITestS3AHugeFilesSSECDiskBlock failing because of bucket overrides Key: HADOOP-17192 URL: https://issues.apache.org/jira/browse/HADOOP-17192 Project:

[GitHub] [hadoop] dbtsai opened a new pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

2020-08-07 Thread GitBox
dbtsai opened a new pull request #2201: URL: https://github.com/apache/hadoop/pull/2201 See https://issues.apache.org/jira/browse/HADOOP-17125 for details This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop] hadoop-yetus commented on pull request #2198: YARN-10390. LeafQueue: retain user limits cache across assignContainers() calls.

2020-08-07 Thread GitBox
hadoop-yetus commented on pull request #2198: URL: https://github.com/apache/hadoop/pull/2198#issuecomment-670372361 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hadoop] hadoop-yetus commented on pull request #2200: MAPREDUCE-7290. ShuffleHeader should be compatible between client…

2020-08-07 Thread GitBox
hadoop-yetus commented on pull request #2200: URL: https://github.com/apache/hadoop/pull/2200#issuecomment-670355906 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m