ayushtkn edited a comment on pull request #2881:
URL: https://github.com/apache/hadoop/pull/2881#issuecomment-819242460
I think We should hold this off, I think the code has issues, as I said.
Earlier I thought, there is some catch but I don’t think. It is misbehaving
only. Ideally such
ayushtkn commented on pull request #2881:
URL: https://github.com/apache/hadoop/pull/2881#issuecomment-819242460
I think We should hold this oफf, I think the code has issues, as I said.
Earlier I thought, there is some catch but I don’t think. It is misbehaving
only. Ideally such features
bshashikant commented on pull request #2881:
URL: https://github.com/apache/hadoop/pull/2881#issuecomment-819237562
@smengcl , can you please have a look again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=582188=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582188
]
ASF GitHub Bot logged work on HADOOP-17633:
---
Author: ASF GitHub Bot
hadoop-yetus commented on pull request #2895:
URL: https://github.com/apache/hadoop/pull/2895#issuecomment-819217518
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
ferhui commented on pull request #2902:
URL: https://github.com/apache/hadoop/pull/2902#issuecomment-819171302
@jojochuang Thanks.
Failed tests passed locally
There are some unused imports in TestBlockRecovery.java
--
This is an automated message from the Apache Git Service.
To
hadoop-yetus commented on pull request #2860:
URL: https://github.com/apache/hadoop/pull/2860#issuecomment-819153675
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
[
https://issues.apache.org/jira/browse/HADOOP-17524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320616#comment-17320616
]
Akira Ajisaka commented on HADOOP-17524:
[~vjasani] Yes, go ahead!
> Remove EventCounter
>
[
https://issues.apache.org/jira/browse/HADOOP-16524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320580#comment-17320580
]
Michael Stack commented on HADOOP-16524:
ACK [~ayushtkn] Thanks for ping. Looking...
>
fengnanli commented on pull request #2903:
URL: https://github.com/apache/hadoop/pull/2903#issuecomment-819115602
@goiri Mind merging this? The test failures are flaky and I got them
working locally.
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/HADOOP-17604?focusedWorklogId=582106=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582106
]
ASF GitHub Bot logged work on HADOOP-17604:
---
Author: ASF GitHub Bot
hadoop-yetus commented on pull request #2904:
URL: https://github.com/apache/hadoop/pull/2904#issuecomment-819114365
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
hadoop-yetus commented on pull request #2905:
URL: https://github.com/apache/hadoop/pull/2905#issuecomment-819107509
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
hadoop-yetus commented on pull request #2903:
URL: https://github.com/apache/hadoop/pull/2903#issuecomment-819090454
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
hadoop-yetus commented on pull request #2903:
URL: https://github.com/apache/hadoop/pull/2903#issuecomment-819084728
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
hchaverri opened a new pull request #2905:
URL: https://github.com/apache/hadoop/pull/2905
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g.
[
https://issues.apache.org/jira/browse/HADOOP-15566?focusedWorklogId=582032=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582032
]
ASF GitHub Bot logged work on HADOOP-15566:
---
Author: ASF GitHub Bot
hadoop-yetus commented on pull request #2816:
URL: https://github.com/apache/hadoop/pull/2816#issuecomment-819017936
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
hchaverri closed pull request #2901:
URL: https://github.com/apache/hadoop/pull/2901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
hadoop-yetus commented on pull request #2903:
URL: https://github.com/apache/hadoop/pull/2903#issuecomment-819013126
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
hadoop-yetus commented on pull request #2901:
URL: https://github.com/apache/hadoop/pull/2901#issuecomment-819009254
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
hadoop-yetus commented on pull request #2860:
URL: https://github.com/apache/hadoop/pull/2860#issuecomment-818990572
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
[
https://issues.apache.org/jira/browse/HADOOP-17604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fengnan Li updated HADOOP-17604:
Status: Patch Available (was: Open)
> Separate string metric from tag in hadoop metrics2
>
[
https://issues.apache.org/jira/browse/HADOOP-17604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HADOOP-17604:
Labels: pull-request-available (was: )
> Separate string metric from tag in hadoop
fengnanli opened a new pull request #2904:
URL: https://github.com/apache/hadoop/pull/2904
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g.
[
https://issues.apache.org/jira/browse/HADOOP-17604?focusedWorklogId=581986=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-581986
]
ASF GitHub Bot logged work on HADOOP-17604:
---
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/HADOOP-15457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Siyao Meng updated HADOOP-15457:
Description:
As of today, YARN web-ui lacks certain security related http response headers.
We
xiaoyuyao edited a comment on pull request #2784:
URL: https://github.com/apache/hadoop/pull/2784#issuecomment-818962252
Thanks @vivekratnavel for the update. The latest change LGTM, +1.
The unit test failure does not relate to the change here. I will merge the
PR EOD tomorrow if
xiaoyuyao commented on pull request #2784:
URL: https://github.com/apache/hadoop/pull/2784#issuecomment-818962252
Thanks @vivekratnavel for the update. The latest change LGTM, +1.
The unit test failure does not relate to the change here. I will merge the
PR shortly.
--
This is an
[
https://issues.apache.org/jira/browse/HADOOP-17611?focusedWorklogId=581946=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-581946
]
ASF GitHub Bot logged work on HADOOP-17611:
---
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/HADOOP-17611?focusedWorklogId=581945=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-581945
]
ASF GitHub Bot logged work on HADOOP-17611:
---
Author: ASF GitHub Bot
virajjasani commented on pull request #2892:
URL: https://github.com/apache/hadoop/pull/2892#issuecomment-818959488
Closing this PR as this is being tracked actively on #2897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
virajjasani closed pull request #2892:
URL: https://github.com/apache/hadoop/pull/2892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
[
https://issues.apache.org/jira/browse/HADOOP-17611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320445#comment-17320445
]
Ayush Saxena commented on HADOOP-17611:
---
Seems there are two PRs, More or less doing the same
fengnanli opened a new pull request #2903:
URL: https://github.com/apache/hadoop/pull/2903
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g.
[
https://issues.apache.org/jira/browse/HADOOP-16206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320439#comment-17320439
]
Ahmed Hussein commented on HADOOP-16206:
[~zhangduo] Sure, Go ahead and give it a try!
>
[
https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=581924=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-581924
]
ASF GitHub Bot logged work on HADOOP-17633:
---
Author: ASF GitHub Bot
hadoop-yetus commented on pull request #2860:
URL: https://github.com/apache/hadoop/pull/2860#issuecomment-818918160
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
virajjasani edited a comment on pull request #2895:
URL: https://github.com/apache/hadoop/pull/2895#issuecomment-818917758
FYI @ayushtkn @jojochuang , if you would also like to take a look.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=581922=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-581922
]
ASF GitHub Bot logged work on HADOOP-17633:
---
Author: ASF GitHub Bot
virajjasani commented on pull request #2895:
URL: https://github.com/apache/hadoop/pull/2895#issuecomment-818917758
FYI @ayushtkn @jojochuang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/HADOOP-15566?focusedWorklogId=581921=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-581921
]
ASF GitHub Bot logged work on HADOOP-15566:
---
Author: ASF GitHub Bot
ArkenKiran commented on a change in pull request #2816:
URL: https://github.com/apache/hadoop/pull/2816#discussion_r612646490
##
File path: hadoop-common-project/hadoop-common/pom.xml
##
@@ -371,6 +371,31 @@
lz4-java
provided
+
+ io.opentelemetry
+
[
https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=581910=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-581910
]
ASF GitHub Bot logged work on HADOOP-17633:
---
Author: ASF GitHub Bot
virajjasani commented on pull request #2895:
URL: https://github.com/apache/hadoop/pull/2895#issuecomment-818903880
`json-smart` is used directly by hadoop-auth and through hadoop-auth, it is
used by multiple modules as transitive dependency in hadoop-common, hadoop-nfs,
hadoop-hdfs,
hadoop-yetus commented on pull request #2889:
URL: https://github.com/apache/hadoop/pull/2889#issuecomment-818875816
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
goiri merged pull request #2898:
URL: https://github.com/apache/hadoop/pull/2898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
[
https://issues.apache.org/jira/browse/HADOOP-17524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani reassigned HADOOP-17524:
-
Assignee: Viraj Jasani
> Remove EventCounter
> ---
>
>
jojochuang commented on a change in pull request #2849:
URL: https://github.com/apache/hadoop/pull/2849#discussion_r612493208
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsVolumeSpi.java
##
@@ -297,23 +281,18 @@
[
https://issues.apache.org/jira/browse/HADOOP-16524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320222#comment-17320222
]
Ayush Saxena commented on HADOOP-16524:
---
[~stack]/[~borislav.iordanov]
There is a test failing :
[
https://issues.apache.org/jira/browse/HADOOP-17524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320200#comment-17320200
]
Duo Zhang commented on HADOOP-17524:
I'm OK with removing it.
> Remove EventCounter
>
[
https://issues.apache.org/jira/browse/HADOOP-17524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320178#comment-17320178
]
Viraj Jasani edited comment on HADOOP-17524 at 4/13/21, 1:30 PM:
-
FYI
[
https://issues.apache.org/jira/browse/HADOOP-17524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320178#comment-17320178
]
Viraj Jasani commented on HADOOP-17524:
---
FYI [~zhangduo], in case you have any specific
[
https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=581771=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-581771
]
ASF GitHub Bot logged work on HADOOP-17511:
---
Author: ASF GitHub Bot
hadoop-yetus commented on pull request #2807:
URL: https://github.com/apache/hadoop/pull/2807#issuecomment-818733840
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
hadoop-yetus commented on pull request #2902:
URL: https://github.com/apache/hadoop/pull/2902#issuecomment-818725828
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
[
https://issues.apache.org/jira/browse/HADOOP-16206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320152#comment-17320152
]
Duo Zhang commented on HADOOP-16206:
Sounds good to me.
So [~ahussein] you would like to provide a
[
https://issues.apache.org/jira/browse/HADOOP-16206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320140#comment-17320140
]
Ahmed Hussein commented on HADOOP-16206:
Thanks [~weichiu] and [~zhangduo] for the suggestions.
[
https://issues.apache.org/jira/browse/HADOOP-16206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320140#comment-17320140
]
Ahmed Hussein edited comment on HADOOP-16206 at 4/13/21, 12:39 PM:
---
[
https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=581713=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-581713
]
ASF GitHub Bot logged work on HADOOP-17633:
---
Author: ASF GitHub Bot
virajjasani commented on pull request #2895:
URL: https://github.com/apache/hadoop/pull/2895#issuecomment-818678822
@steveloughran I have run tests locally for some affected modules and they
seem fine.
However, this PR's build seems to be stuck (build#2 is still not over after
17+
hadoop-yetus commented on pull request #2860:
URL: https://github.com/apache/hadoop/pull/2860#issuecomment-818664661
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
[
https://issues.apache.org/jira/browse/HADOOP-17524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320089#comment-17320089
]
Viraj Jasani commented on HADOOP-17524:
---
[~aajisaka] If you don't mind, can I take this up?
>
tasanuma commented on pull request #2868:
URL: https://github.com/apache/hadoop/pull/2868#issuecomment-818649530
Thanks for your work, @jojochuang and @ferhui.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/HADOOP-11245?focusedWorklogId=581671=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-581671
]
ASF GitHub Bot logged work on HADOOP-11245:
---
Author: ASF GitHub Bot
szetszwo commented on a change in pull request #2832:
URL: https://github.com/apache/hadoop/pull/2832#discussion_r612218129
##
File path:
hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/oncrpc/RpcUtil.java
##
@@ -62,75 +64,84 @@ public static FrameDecoder
tomscut commented on pull request #2896:
URL: https://github.com/apache/hadoop/pull/2896#issuecomment-818622111
Those failed unit tests were unrelated to the change. And they work fine
locally.
--
This is an automated message from the Apache Git Service.
To respond to the message,
hadoop-yetus commented on pull request #2896:
URL: https://github.com/apache/hadoop/pull/2896#issuecomment-818611027
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
[
https://issues.apache.org/jira/browse/HADOOP-11245?focusedWorklogId=581658=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-581658
]
ASF GitHub Bot logged work on HADOOP-11245:
---
Author: ASF GitHub Bot
szetszwo commented on pull request #2832:
URL: https://github.com/apache/hadoop/pull/2832#issuecomment-818602960
> ... verified to contain no memory leak via
-Dio.netty.leakDetectionLevel=paranoid.
Hi @jojochuang , according to
https://netty.io/wiki/reference-counted-objects.html ,
hadoop-yetus commented on pull request #2819:
URL: https://github.com/apache/hadoop/pull/2819#issuecomment-818588736
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
hadoop-yetus commented on pull request #2901:
URL: https://github.com/apache/hadoop/pull/2901#issuecomment-818587189
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
[
https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=581646=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-581646
]
ASF GitHub Bot logged work on HADOOP-17633:
---
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=581645=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-581645
]
ASF GitHub Bot logged work on HADOOP-17633:
---
Author: ASF GitHub Bot
virajjasani edited a comment on pull request #2895:
URL: https://github.com/apache/hadoop/pull/2895#issuecomment-818578359
```
[INFO] org.apache.hadoop:hadoop-minikdc:jar:3.4.0-SNAPSHOT
[INFO] +- commons-io:commons-io:jar:2.5:compile
[INFO] +-
virajjasani commented on pull request #2895:
URL: https://github.com/apache/hadoop/pull/2895#issuecomment-818578359
```
[INFO] org.apache.hadoop:hadoop-minikdc:jar:3.4.0-SNAPSHOT
[INFO] +- commons-io:commons-io:jar:2.5:compile
[INFO] +-
[
https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=581638=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-581638
]
ASF GitHub Bot logged work on HADOOP-17633:
---
Author: ASF GitHub Bot
virajjasani commented on pull request #2895:
URL: https://github.com/apache/hadoop/pull/2895#issuecomment-818572599
I just tested locally and realized that `nimbus-jose-jwt` 9.8 does not even
produce `json-smart` hence all the places where we have excluded `json-smart`
from
[
https://issues.apache.org/jira/browse/HADOOP-17611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318843#comment-17318843
]
Adam Maroti edited comment on HADOOP-17611 at 4/13/21, 8:29 AM:
It
[
https://issues.apache.org/jira/browse/HADOOP-17611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318851#comment-17318851
]
Adam Maroti edited comment on HADOOP-17611 at 4/13/21, 8:28 AM:
Yes,
[
https://issues.apache.org/jira/browse/HADOOP-17611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319615#comment-17319615
]
Adam Maroti edited comment on HADOOP-17611 at 4/13/21, 8:28 AM:
When
jojochuang opened a new pull request #2902:
URL: https://github.com/apache/hadoop/pull/2902
HDFS-15940 for branch-3.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
[
https://issues.apache.org/jira/browse/HADOOP-17630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akira Ajisaka updated HADOOP-17630:
---
Fix Version/s: 3.2.3
3.1.5
3.4.0
[
https://issues.apache.org/jira/browse/HADOOP-17630?focusedWorklogId=581613=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-581613
]
ASF GitHub Bot logged work on HADOOP-17630:
---
Author: ASF GitHub Bot
aajisaka commented on pull request #2890:
URL: https://github.com/apache/hadoop/pull/2890#issuecomment-818537893
Merged. Thanks @jojochuang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hadoop-yetus commented on pull request #2898:
URL: https://github.com/apache/hadoop/pull/2898#issuecomment-818538528
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
[
https://issues.apache.org/jira/browse/HADOOP-17630?focusedWorklogId=581614=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-581614
]
ASF GitHub Bot logged work on HADOOP-17630:
---
Author: ASF GitHub Bot
aajisaka merged pull request #2890:
URL: https://github.com/apache/hadoop/pull/2890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
jojochuang commented on a change in pull request #2889:
URL: https://github.com/apache/hadoop/pull/2889#discussion_r612221274
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDataTransferProtocol.java
##
@@ -562,4 +565,57 @@ void
hadoop-yetus commented on pull request #2896:
URL: https://github.com/apache/hadoop/pull/2896#issuecomment-818532881
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
jojochuang merged pull request #2882:
URL: https://github.com/apache/hadoop/pull/2882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
hadoop-yetus commented on pull request #2896:
URL: https://github.com/apache/hadoop/pull/2896#issuecomment-818480937
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
GauthamBanasandra edited a comment on pull request #2898:
URL: https://github.com/apache/hadoop/pull/2898#issuecomment-818472914
I've refactored TempFile class to implement the `Rule of 5` C++ idiom for
efficient and correct management of the temporary file resource -
GauthamBanasandra commented on pull request #2898:
URL: https://github.com/apache/hadoop/pull/2898#issuecomment-818472914
I've refactored TempFile class to implement the `Rule of 5` C++ idiom -
https://cpppatterns.com/patterns/rule-of-five.html.
--
This is an automated message from the
94 matches
Mail list logo
