[GitHub] [hadoop] aajisaka commented on pull request #2974: Bump commons-io from 2.5 to 2.7 in /hadoop-project

2021-05-05 Thread GitBox
aajisaka commented on pull request #2974: URL: https://github.com/apache/hadoop/pull/2974#issuecomment-833238123 TestFileUtils failure is related. https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2974/2/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt ```

[GitHub] [hadoop] zhuxiangyi commented on pull request #2981: HDFS-16008. RBF: Tool to initialize ViewFS Mapping to Router

2021-05-05 Thread GitBox
zhuxiangyi commented on pull request #2981: URL: https://github.com/apache/hadoop/pull/2981#issuecomment-833235149 @goiri Thank you for your detailed review. I will modify and add unit tests according to your comments. -- This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] hadoop-yetus commented on pull request #2981: HDFS-16008. RBF: Tool to initialize ViewFS Mapping to Router

2021-05-05 Thread GitBox
hadoop-yetus commented on pull request #2981: URL: https://github.com/apache/hadoop/pull/2981#issuecomment-833227893 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #2819: HDFS-15923. RBF: Authentication failed when rename accross sub clusters.

2021-05-05 Thread GitBox
hadoop-yetus commented on pull request #2819: URL: https://github.com/apache/hadoop/pull/2819#issuecomment-833209976 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] goiri commented on a change in pull request #2981: HDFS-16008. RBF: Tool to initialize ViewFS Mapping to Router

2021-05-05 Thread GitBox
goiri commented on a change in pull request #2981: URL: https://github.com/apache/hadoop/pull/2981#discussion_r627061466 ## File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java ## @@ -1035,7 +1049,56 @@ private

[GitHub] [hadoop] zhuxiangyi opened a new pull request #2981: HDFS-16008. RBF: Initialize the ViewFS Maping tool to the Router

2021-05-05 Thread GitBox
zhuxiangyi opened a new pull request #2981: URL: https://github.com/apache/hadoop/pull/2981 [HDFS-16008](https://issues.apache.org/jira/browse/HDFS-16008) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (HADOOP-17665) Ignore missing keystore configuration in reloading mechanism

2021-05-05 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339964#comment-17339964 ] Hadoop QA commented on HADOOP-17665: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hadoop] hadoop-yetus commented on pull request #2979: HADOOP-17665

2021-05-05 Thread GitBox
hadoop-yetus commented on pull request #2979: URL: https://github.com/apache/hadoop/pull/2979#issuecomment-833173707 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #2974: Bump commons-io from 2.5 to 2.7 in /hadoop-project

2021-05-05 Thread GitBox
hadoop-yetus commented on pull request #2974: URL: https://github.com/apache/hadoop/pull/2974#issuecomment-833103370 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #2975: HADOOP-17682. ABFS: Support FileStatus input to OpenFileWithOptions() via OpenFileParameters

2021-05-05 Thread GitBox
hadoop-yetus commented on pull request #2975: URL: https://github.com/apache/hadoop/pull/2975#issuecomment-833013347 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #2978: HADOOP-17665

2021-05-05 Thread GitBox
hadoop-yetus commented on pull request #2978: URL: https://github.com/apache/hadoop/pull/2978#issuecomment-833012321 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #2980: HDFS-16001. TestOfflineEditsViewer.testStored() fails reading negative value of FSEditsLogOpCodes

2021-05-05 Thread GitBox
hadoop-yetus commented on pull request #2980: URL: https://github.com/apache/hadoop/pull/2980#issuecomment-833010879 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #2976: HDFS-15982. HTTP API to consider default value of skiptrash true (ADDENDUM)

2021-05-05 Thread GitBox
hadoop-yetus commented on pull request #2976: URL: https://github.com/apache/hadoop/pull/2976#issuecomment-832999849 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Updated] (HADOOP-11616) Remove workaround for Curator's ChildReaper requiring Guava 15+

2021-05-05 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-11616: --- Fix Version/s: 3.4.0 3.3.1 Hadoop Flags: Reviewed

[jira] [Commented] (HADOOP-16524) Automatic keystore reloading for HttpServer2

2021-05-05 Thread Borislav Iordanov (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339870#comment-17339870 ] Borislav Iordanov commented on HADOOP-16524: [~ayushtkn] I submitted a PR:

[GitHub] [hadoop] sumangala-patki commented on pull request #2975: HADOOP-17682. ABFS: Support FileStatus input to OpenFileWithOptions() via OpenFileParameters

2021-05-05 Thread GitBox
sumangala-patki commented on pull request #2975: URL: https://github.com/apache/hadoop/pull/2975#issuecomment-832967214 TEST RESULTS HNS Account Location: East US 2 NonHNS Account Location: East US 2, Central US ``` HNS OAuth [INFO] Tests run: 98, Failures: 0,

[GitHub] [hadoop] aajisaka commented on pull request #2973: HADOOP-11616. Remove workaround for Curator's ChildReaper requiring Guava 15+

2021-05-05 Thread GitBox
aajisaka commented on pull request #2973: URL: https://github.com/apache/hadoop/pull/2973#issuecomment-832964263 Merged. Thank you @virajjasani and @jojochuang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] aajisaka merged pull request #2973: HADOOP-11616. Remove workaround for Curator's ChildReaper requiring Guava 15+

2021-05-05 Thread GitBox
aajisaka merged pull request #2973: URL: https://github.com/apache/hadoop/pull/2973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hadoop] hadoop-yetus commented on pull request #2977: HADOOP-17631. Configuration ${env.VAR:-FALLBACK} to eval FALLBACK when restrictSystemProps=true

2021-05-05 Thread GitBox
hadoop-yetus commented on pull request #2977: URL: https://github.com/apache/hadoop/pull/2977#issuecomment-832963883 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Commented] (HADOOP-16524) Automatic keystore reloading for HttpServer2

2021-05-05 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339869#comment-17339869 ] Ayush Saxena commented on HADOOP-16524: --- In case there is no solution found, Can try this:

[GitHub] [hadoop] hadoop-yetus commented on pull request #2975: HADOOP-17682. ABFS: Support FileStatus input to OpenFileWithOptions() via OpenFileParameters

2021-05-05 Thread GitBox
hadoop-yetus commented on pull request #2975: URL: https://github.com/apache/hadoop/pull/2975#issuecomment-832958054 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] aajisaka opened a new pull request #2980: HDFS-16001. TestOfflineEditsViewer.testStored() fails reading negative value of FSEditsLogOpCodes

2021-05-05 Thread GitBox
aajisaka opened a new pull request #2980: URL: https://github.com/apache/hadoop/pull/2980 - Updated the edits version to -67 (The latest version in trunk). - Built Hadoop and created the editsStored by `bin/hdfs oev -i editsStored.xml -o editsStored -p binary` Since the edits

[jira] [Commented] (HADOOP-17152) Implement wrapper for guava newArrayList and newLinkedList

2021-05-05 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339864#comment-17339864 ] Viraj Jasani commented on HADOOP-17152: --- Oh yes, it seems we are using multiple implementation of

[jira] [Commented] (HADOOP-17152) Implement wrapper for guava newArrayList and newLinkedList

2021-05-05 Thread Ahmed Hussein (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339856#comment-17339856 ] Ahmed Hussein commented on HADOOP-17152: As far as I remember, there were some calls to

[jira] [Commented] (HADOOP-17152) Implement wrapper for guava newArrayList and newLinkedList

2021-05-05 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339832#comment-17339832 ] Viraj Jasani commented on HADOOP-17152: --- [~ahussein] Thanks. Btw I was wondering if we really

[jira] [Commented] (HADOOP-17152) Implement wrapper for guava newArrayList and newLinkedList

2021-05-05 Thread Ahmed Hussein (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339831#comment-17339831 ] Ahmed Hussein commented on HADOOP-17152: I assigned the jira to [~vjasani] as he suggested in

[jira] [Commented] (HADOOP-17115) Replace Guava initialization of Sets.newHashSet

2021-05-05 Thread Ahmed Hussein (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339830#comment-17339830 ] Ahmed Hussein commented on HADOOP-17115: Thanks [~vjasani]! Sure feel free to work on it. >

[jira] [Assigned] (HADOOP-17152) Implement wrapper for guava newArrayList and newLinkedList

2021-05-05 Thread Ahmed Hussein (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hussein reassigned HADOOP-17152: -- Assignee: Viraj Jasani (was: Ahmed Hussein) > Implement wrapper for guava

[jira] [Comment Edited] (HADOOP-17115) Replace Guava initialization of Sets.newHashSet

2021-05-05 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339820#comment-17339820 ] Viraj Jasani edited comment on HADOOP-17115 at 5/5/21, 6:22 PM:

[GitHub] [hadoop] bolerio opened a new pull request #2979: HADOOP-17665

2021-05-05 Thread GitBox
bolerio opened a new pull request #2979: URL: https://github.com/apache/hadoop/pull/2979 Handle properly missing SSL key/trust store configurations when monitoring file changes in HttpServer2. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Assigned] (HADOOP-17115) Replace Guava initialization of Sets.newHashSet

2021-05-05 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HADOOP-17115: - Assignee: Viraj Jasani > Replace Guava initialization of Sets.newHashSet >

[jira] [Commented] (HADOOP-17115) Replace Guava initialization of Sets.newHashSet

2021-05-05 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339820#comment-17339820 ] Viraj Jasani commented on HADOOP-17115: --- [~ahussein] I think this makes sense. If you are fine,

[GitHub] [hadoop] hadoop-yetus commented on pull request #2971: MAPREDUCE-7341. Intermediate Manifest Committer

2021-05-05 Thread GitBox
hadoop-yetus commented on pull request #2971: URL: https://github.com/apache/hadoop/pull/2971#issuecomment-832905980 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] bolerio closed pull request #2978: HADOOP-17665

2021-05-05 Thread GitBox
bolerio closed pull request #2978: URL: https://github.com/apache/hadoop/pull/2978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hadoop] bolerio opened a new pull request #2978: HADOOP-17665

2021-05-05 Thread GitBox
bolerio opened a new pull request #2978: URL: https://github.com/apache/hadoop/pull/2978 Handle properly missing SSL key/trust store configurations when monitoring file changes in HttpServer2. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] GauthamBanasandra commented on pull request #2967: HADOOP-17678. Add Dockerfile for Centos 7

2021-05-05 Thread GitBox
GauthamBanasandra commented on pull request #2967: URL: https://github.com/apache/hadoop/pull/2967#issuecomment-832871289 @aajisaka , @iwasakims , @ericbadger I've created Dockerfile for Centos 7. I'll be creating similar Dockerfiles for the platforms mentioned in

[GitHub] [hadoop] steveloughran opened a new pull request #2977: HADOOP-17631. Configuration ${env.VAR:-FALLBACK} to eval FALLBACK when restrictSystemProps=true

2021-05-05 Thread GitBox
steveloughran opened a new pull request #2977: URL: https://github.com/apache/hadoop/pull/2977 Moves the checking on restricted access to when env vars and system props are retrieved, rather than the actual parsing of the string. With tests to verify this. I've looked

[jira] [Assigned] (HADOOP-17631) Configuration ${env.VAR:-FALLBACK} should eval FALLBACK when restrictSystemProps=true

2021-05-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reassigned HADOOP-17631: --- Assignee: Steve Loughran > Configuration ${env.VAR:-FALLBACK} should eval

[GitHub] [hadoop] ayushtkn commented on pull request #2833: HDFS-15934: Make DirectoryScanner reconcile blocks batch size and int…

2021-05-05 Thread GitBox
ayushtkn commented on pull request #2833: URL: https://github.com/apache/hadoop/pull/2833#issuecomment-832787902 Thanx @qizhu-lucas for the contribution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop] ayushtkn merged pull request #2833: HDFS-15934: Make DirectoryScanner reconcile blocks batch size and int…

2021-05-05 Thread GitBox
ayushtkn merged pull request #2833: URL: https://github.com/apache/hadoop/pull/2833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hadoop] hadoop-yetus commented on pull request #2963: HADOOP-17670. S3AFS and ABFS to log IOStats at DEBUG mode or optionally at INFO level in close()

2021-05-05 Thread GitBox
hadoop-yetus commented on pull request #2963: URL: https://github.com/apache/hadoop/pull/2963#issuecomment-832742039 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #2971: MAPREDUCE-7341. Intermediate Manifest Committer

2021-05-05 Thread GitBox
hadoop-yetus removed a comment on pull request #2971: URL: https://github.com/apache/hadoop/pull/2971#issuecomment-832267182 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:|

[GitHub] [hadoop] virajjasani edited a comment on pull request #2976: HDFS-15982. HTTP API to consider default value of skiptrash true (ADDENDUM)

2021-05-05 Thread GitBox
virajjasani edited a comment on pull request #2976: URL: https://github.com/apache/hadoop/pull/2976#issuecomment-832654675 FYI @ayushtkn @jojochuang, addendum to consider default value of skiptrash true and thereby making HDFS-15982 compatible w.r.t DELETE API's behaviour by default. --

[GitHub] [hadoop] hadoop-yetus commented on pull request #2833: HDFS-15934: Make DirectoryScanner reconcile blocks batch size and int…

2021-05-05 Thread GitBox
hadoop-yetus commented on pull request #2833: URL: https://github.com/apache/hadoop/pull/2833#issuecomment-832665989 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] virajjasani edited a comment on pull request #2976: HDFS-15982. HTTP API to consider default value of skiptrash true (ADDENDUM)

2021-05-05 Thread GitBox
virajjasani edited a comment on pull request #2976: URL: https://github.com/apache/hadoop/pull/2976#issuecomment-832654675 FYI @ayushtkn, addendum to consider default value of skiptrash true and thereby making HDFS-15982 compatible w.r.t DELETE API's behaviour by default. -- This is an

[GitHub] [hadoop] virajjasani commented on pull request #2976: HDFS-15982. HTTP API to consider default value of skiptrash true (ADDENDUM)

2021-05-05 Thread GitBox
virajjasani commented on pull request #2976: URL: https://github.com/apache/hadoop/pull/2976#issuecomment-832654675 FYI @ayushtkn, addendum to consider default value of skiptrash true and thereby making HDFS-15982 compatible with DELETE API behaviour by default. -- This is an automated

[GitHub] [hadoop] virajjasani opened a new pull request #2976: HDFS-15982. WebHdfs REST API to consider default value of skiptrash true (ADDENDUM)

2021-05-05 Thread GitBox
virajjasani opened a new pull request #2976: URL: https://github.com/apache/hadoop/pull/2976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hadoop] mehakmeet commented on pull request #2963: HADOOP-17670. S3AFS and ABFS to log IOStats at DEBUG mode or optionally at INFO level in close()

2021-05-05 Thread GitBox
mehakmeet commented on pull request #2963: URL: https://github.com/apache/hadoop/pull/2963#issuecomment-832604419 > Don't know if we need any tests for these? @steveloughran -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] qizhu-lucas commented on pull request #2833: HDFS-15934: Make DirectoryScanner reconcile blocks batch size and int…

2021-05-05 Thread GitBox
qizhu-lucas commented on pull request #2833: URL: https://github.com/apache/hadoop/pull/2833#issuecomment-832482902 Thanks @ayushtkn for patient review. I have updated in latest PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on