hadoop-yetus commented on PR #4258:
URL: https://github.com/apache/hadoop/pull/4258#issuecomment-1115739795
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #4252:
URL: https://github.com/apache/hadoop/pull/4252#issuecomment-1115722396
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
iwasakims commented on code in PR #4247:
URL: https://github.com/apache/hadoop/pull/4247#discussion_r863342147
##
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml:
##
@@ -286,6 +286,13 @@
+
+
tomscut commented on PR #4209:
URL: https://github.com/apache/hadoop/pull/4209#issuecomment-1115568961
> I think this change is a bit too restrictive. There may well be valid use
cases for setting it above the 90% threshold. For example if you configured a
100GB heap, you really don't need
virajjasani commented on PR #4107:
URL: https://github.com/apache/hadoop/pull/4107#issuecomment-1115523698
Thanks everyone for the reviews, here is the branch-3.3 backport PR #4259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
virajjasani opened a new pull request, #4259:
URL: https://github.com/apache/hadoop/pull/4259
branch-3.3 backport PR of #4107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ashutoshcipher opened a new pull request, #4258:
URL: https://github.com/apache/hadoop/pull/4258
### Description of PR
Backport YARN-6483 to branch-2.10
* JIRA: YARN-11125
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your
ashutoshcipher commented on code in PR #4244:
URL: https://github.com/apache/hadoop/pull/4244#discussion_r863294688
##
hadoop-yetus commented on PR #4257:
URL: https://github.com/apache/hadoop/pull/4257#issuecomment-1115499005
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
tomscut commented on code in PR #4201:
URL: https://github.com/apache/hadoop/pull/4201#discussion_r863251873
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java:
##
@@ -1899,6 +1899,10 @@ synchronized void transitionToStandby()
tomscut commented on code in PR #4201:
URL: https://github.com/apache/hadoop/pull/4201#discussion_r863251873
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java:
##
@@ -1899,6 +1899,10 @@ synchronized void transitionToStandby()
[
https://issues.apache.org/jira/browse/HADOOP-17890?focusedWorklogId=765218=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765218
]
ASF GitHub Bot logged work on HADOOP-17890:
---
Author: ASF GitHub Bot
raymondlam12 commented on code in PR #3381:
URL: https://github.com/apache/hadoop/pull/3381#discussion_r863255244
##
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsHttpOperation.java:
##
@@ -336,95 +347,141 @@ public void sendRequest(byte[]
tomscut commented on code in PR #4201:
URL: https://github.com/apache/hadoop/pull/4201#discussion_r863251873
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java:
##
@@ -1899,6 +1899,10 @@ synchronized void transitionToStandby()
hadoop-yetus commented on PR #4257:
URL: https://github.com/apache/hadoop/pull/4257#issuecomment-1115416677
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
RuinanGu commented on code in PR #4252:
URL: https://github.com/apache/hadoop/pull/4252#discussion_r863162303
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/erasurecode/StripedReconstructionInfo.java:
##
@@ -41,26 +41,28 @@ public class
RuinanGu commented on code in PR #4252:
URL: https://github.com/apache/hadoop/pull/4252#discussion_r863162303
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/erasurecode/StripedReconstructionInfo.java:
##
@@ -41,26 +41,28 @@ public class
[
https://issues.apache.org/jira/browse/HADOOP-18193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lei Yang updated HADOOP-18193:
--
Attachment: Nested Mount Point in ViewFs.pdf
> Support nested mount points in INodeTree
>
jojochuang merged PR #4107:
URL: https://github.com/apache/hadoop/pull/4107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hadoop-yetus commented on PR #4257:
URL: https://github.com/apache/hadoop/pull/4257#issuecomment-1115360668
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
jojochuang commented on code in PR #4252:
URL: https://github.com/apache/hadoop/pull/4252#discussion_r863164865
##
hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/erasurecoding.proto:
##
@@ -107,7 +107,8 @@ message BlockECReconstructionInfoProto {
required
RuinanGu commented on code in PR #4252:
URL: https://github.com/apache/hadoop/pull/4252#discussion_r863162214
##
hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/erasurecoding.proto:
##
@@ -107,7 +107,8 @@ message BlockECReconstructionInfoProto {
required
xkrogen commented on code in PR #4201:
URL: https://github.com/apache/hadoop/pull/4201#discussion_r863153584
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java:
##
@@ -1899,6 +1899,10 @@ synchronized void transitionToStandby()
xkrogen commented on PR #4209:
URL: https://github.com/apache/hadoop/pull/4209#issuecomment-1115302581
I think this change is a bit too restrictive. There may well be valid use
cases for setting it above the 90% threshold. For example if you configured a
100GB heap, you really don't need
jojochuang commented on code in PR #4107:
URL: https://github.com/apache/hadoop/pull/4107#discussion_r863122472
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java:
##
@@ -632,6 +638,20 @@ private static void
hadoop-yetus commented on PR #4256:
URL: https://github.com/apache/hadoop/pull/4256#issuecomment-1115269243
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
jojochuang commented on PR #4252:
URL: https://github.com/apache/hadoop/pull/4252#issuecomment-1115254568
@tasanuma @ferhui it would be great to have your review on EC PRs.
@umamaheswararao @sodonnel FYI. Please check if Ozone EC is susceptible to
the same issue.
--
This is an
ayushtkn opened a new pull request, #4257:
URL: https://github.com/apache/hadoop/pull/4257
### Description of PR
Fixes AggregateWordCount
### How was this patch tested?
```
hadoop-3.4.0-SNAPSHOT % bin/hadoop jar
jojochuang commented on code in PR #4252:
URL: https://github.com/apache/hadoop/pull/4252#discussion_r863097191
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestReconstructStripedBlocks.java:
##
@@ -430,4 +433,86 @@ public void
[
https://issues.apache.org/jira/browse/HADOOP-18219?focusedWorklogId=765098=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765098
]
ASF GitHub Bot logged work on HADOOP-18219:
---
Author: ASF GitHub Bot
pjfanning commented on PR #4254:
URL: https://github.com/apache/hadoop/pull/4254#issuecomment-1115242681
Thanks @aajisaka formaking this fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jteagles commented on PR #4242:
URL: https://github.com/apache/hadoop/pull/4242#issuecomment-1115230847
@aajisaka, good catch on jdk 7. Thanks so much on this jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
aajisaka commented on PR #4242:
URL: https://github.com/apache/hadoop/pull/4242#issuecomment-1115223462
@jteagles, I cannot backport this to 2.10.x because 2.10.x still supports
JDK 7.
> How to update the release branches
Just cherry-picking the trunk commit to the branches is
jteagles commented on PR #4242:
URL: https://github.com/apache/hadoop/pull/4242#issuecomment-1115215449
@aajisaka, I was hoping to backport this to earlier lines. Do you see any
problem with me backporting to 2.10.x? Perhaps that is too far back.
I was taking a look at
aajisaka merged PR #4242:
URL: https://github.com/apache/hadoop/pull/4242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
aajisaka commented on PR #4222:
URL: https://github.com/apache/hadoop/pull/4222#issuecomment-1115201904
Merged. Thank you @ashutoshcipher
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
aajisaka merged PR #4222:
URL: https://github.com/apache/hadoop/pull/4222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
aajisaka opened a new pull request, #4256:
URL: https://github.com/apache/hadoop/pull/4256
### Description of PR
Testing https://github.com/apache/yetus/pull/261 in Apache Hadoop repo for
upcoming Yetus 0.14.0 release.
### How was this patch tested?
Not tested
[
https://issues.apache.org/jira/browse/HADOOP-18069?focusedWorklogId=765063=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765063
]
ASF GitHub Bot logged work on HADOOP-18069:
---
Author: ASF GitHub Bot
aajisaka commented on code in PR #4229:
URL: https://github.com/apache/hadoop/pull/4229#discussion_r863056324
##
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/ConfRefreshTokenBasedAccessTokenProvider.java:
##
@@ -102,32 +102,29 @@ public
[
https://issues.apache.org/jira/browse/HADOOP-18069?focusedWorklogId=765062=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765062
]
ASF GitHub Bot logged work on HADOOP-18069:
---
Author: ASF GitHub Bot
aajisaka commented on PR #4229:
URL: https://github.com/apache/hadoop/pull/4229#issuecomment-1115177416
> spotbugs still thinks there is a problem. what is it that it is warning
about?
> I already used try-with-resources for OkHttpClient and added request
checks as well. The warning is
aajisaka commented on code in PR #4244:
URL: https://github.com/apache/hadoop/pull/4244#discussion_r863034596
##
[
https://issues.apache.org/jira/browse/HADOOP-18219?focusedWorklogId=765050=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765050
]
ASF GitHub Bot logged work on HADOOP-18219:
---
Author: ASF GitHub Bot
aajisaka commented on PR #4254:
URL: https://github.com/apache/hadoop/pull/4254#issuecomment-1115131143
Thank you @GauthamBanasandra @ashutoshcipher @steveloughran for your reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/HADOOP-18219?focusedWorklogId=765033=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765033
]
ASF GitHub Bot logged work on HADOOP-18219:
---
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/HADOOP-18219?focusedWorklogId=765032=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765032
]
ASF GitHub Bot logged work on HADOOP-18219:
---
Author: ASF GitHub Bot
GauthamBanasandra closed pull request #4253: HADOOP-18219. Revert
"HADOOP-15983. Use jersey-json that is built to use jackson2 (#3988)"
URL: https://github.com/apache/hadoop/pull/4253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
GauthamBanasandra commented on PR #4253:
URL: https://github.com/apache/hadoop/pull/4253#issuecomment-1115108791
Abandoning this PR since the issue was fixed by
https://github.com/apache/hadoop/pull/4254.
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/HADOOP-18167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530789#comment-17530789
]
Ayush Saxena commented on HADOOP-18167:
---
Not sure though but seems this is creating some problem
[
https://issues.apache.org/jira/browse/HADOOP-18219?focusedWorklogId=764986=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-764986
]
ASF GitHub Bot logged work on HADOOP-18219:
---
Author: ASF GitHub Bot
hadoop-yetus commented on PR #4253:
URL: https://github.com/apache/hadoop/pull/4253#issuecomment-1115024879
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
slfan1989 commented on PR #4250:
URL: https://github.com/apache/hadoop/pull/4250#issuecomment-1114894552
When the PR was automatically checked, it was found that the test could not
pass, and the following error was reported in the local test.
```
Caused by:
[
https://issues.apache.org/jira/browse/HADOOP-18217?focusedWorklogId=764920=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-764920
]
ASF GitHub Bot logged work on HADOOP-18217:
---
Author: ASF GitHub Bot
hadoop-yetus commented on PR #4255:
URL: https://github.com/apache/hadoop/pull/4255#issuecomment-1114806690
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #4235:
URL: https://github.com/apache/hadoop/pull/4235#issuecomment-1114764977
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-15983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-15983:
Release Note:
Use modified jersey-json 1.20 in
[
https://issues.apache.org/jira/browse/HADOOP-15983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-15983:
Description:
moves to a fork of jersey 1 which removes the jackson 1 dependency.
when
[
https://issues.apache.org/jira/browse/HADOOP-18219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran resolved HADOOP-18219.
-
Resolution: Fixed
merged to trunk
> Fix shadedclient test failure
>
[
https://issues.apache.org/jira/browse/HADOOP-18219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran reassigned HADOOP-18219:
---
Assignee: Akira Ajisaka (was: PJ Fanning)
> Fix shadedclient test failure
>
[
https://issues.apache.org/jira/browse/HADOOP-18219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-18219:
Fix Version/s: 3.4.0
> Fix shadedclient test failure
> -
>
>
[
https://issues.apache.org/jira/browse/HADOOP-18219?focusedWorklogId=764900=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-764900
]
ASF GitHub Bot logged work on HADOOP-18219:
---
Author: ASF GitHub Bot
steveloughran merged PR #4254:
URL: https://github.com/apache/hadoop/pull/4254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/HADOOP-18217?focusedWorklogId=764899=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-764899
]
ASF GitHub Bot logged work on HADOOP-18217:
---
Author: ASF GitHub Bot
steveloughran commented on code in PR #4255:
URL: https://github.com/apache/hadoop/pull/4255#discussion_r862765210
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ExitUtil.java:
##
@@ -226,25 +251,48 @@ public static synchronized void
[
https://issues.apache.org/jira/browse/HADOOP-18217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530644#comment-17530644
]
Catherinot Remi commented on HADOOP-18217:
--
Hi,
I've added a pull request for the ExitUtil
[
https://issues.apache.org/jira/browse/HADOOP-18217?focusedWorklogId=764877=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-764877
]
ASF GitHub Bot logged work on HADOOP-18217:
---
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/HADOOP-18217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HADOOP-18217:
Labels: pull-request-available (was: )
> shutdownhookmanager should not be
HerCath opened a new pull request, #4255:
URL: https://github.com/apache/hadoop/pull/4255
…king halt + enlarged catches (robustness) to all Throwables (not just
Exceptions)
### Description of PR
I've reduced the synchronized blocks scope so System.exit and Runtime.halt
hadoop-yetus commented on PR #4250:
URL: https://github.com/apache/hadoop/pull/4250#issuecomment-1114604502
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18219?focusedWorklogId=764873=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-764873
]
ASF GitHub Bot logged work on HADOOP-18219:
---
Author: ASF GitHub Bot
GauthamBanasandra commented on PR #4254:
URL: https://github.com/apache/hadoop/pull/4254#issuecomment-1114595025
Thanks @aajisaka. I was able to verify that this PR fixes the issue
[build.log](https://github.com/apache/hadoop/files/8601569/build.log)
.
--
This is an automated
slfan1989 commented on PR #4250:
URL: https://github.com/apache/hadoop/pull/4250#issuecomment-1114552633
I need to ask a question, is it necessary to use a multi-threaded method
when acquiring sub-clusters, can it not be traversed directly through a for
loop? I tried to rewrite part of the
ashutoshcipher commented on PR #4244:
URL: https://github.com/apache/hadoop/pull/4244#issuecomment-1114538988
@aajisaka - Please review this PR. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
74 matches
Mail list logo
