[GitHub] [hadoop] hadoop-yetus commented on pull request #4259: HDFS-16521. DFS API to retrieve slow datanodes (#4107)

2022-05-03 Thread GitBox
hadoop-yetus commented on PR #4259: URL: https://github.com/apache/hadoop/pull/4259#issuecomment-1116837508 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4259: HDFS-16521. DFS API to retrieve slow datanodes (#4107)

2022-05-03 Thread GitBox
hadoop-yetus commented on PR #4259: URL: https://github.com/apache/hadoop/pull/4259#issuecomment-1116812093 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Work logged] (HADOOP-18193) Support nested mount points in INodeTree

2022-05-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18193?focusedWorklogId=765749=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765749 ] ASF GitHub Bot logged work on HADOOP-18193: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #4181: HADOOP-18193:Support nested mount points in INodeTree

2022-05-03 Thread GitBox
hadoop-yetus commented on PR #4181: URL: https://github.com/apache/hadoop/pull/4181#issuecomment-1116769957 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4252: HDFS-16566 Erasure Coding: Recovery may causes excess replicas when busy DN exsits

2022-05-03 Thread GitBox
hadoop-yetus commented on PR #4252: URL: https://github.com/apache/hadoop/pull/4252#issuecomment-1116768483 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Comment Edited] (HADOOP-16159) Deadlock when using FsUrlStreamHandlerFactory

2022-05-03 Thread John Zhuge (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531434#comment-17531434 ] John Zhuge edited comment on HADOOP-16159 at 5/3/22 11:33 PM: -- Here is the

[jira] [Comment Edited] (HADOOP-16159) Deadlock when using FsUrlStreamHandlerFactory

2022-05-03 Thread John Zhuge (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531437#comment-17531437 ] John Zhuge edited comment on HADOOP-16159 at 5/3/22 10:29 PM: -- I think

[jira] [Commented] (HADOOP-16159) Deadlock when using FsUrlStreamHandlerFactory

2022-05-03 Thread John Zhuge (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531437#comment-17531437 ] John Zhuge commented on HADOOP-16159: - I think HADOOP-15331 actually fixed this issue because it

[jira] (HADOOP-16159) Deadlock when using FsUrlStreamHandlerFactory

2022-05-03 Thread John Zhuge (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16159 ] John Zhuge deleted comment on HADOOP-16159: - was (Author: jzhuge): Can we fix it by replacing `conf` with `this.conf` in this constructor? {code:java} public

[jira] [Comment Edited] (HADOOP-16159) Deadlock when using FsUrlStreamHandlerFactory

2022-05-03 Thread John Zhuge (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531435#comment-17531435 ] John Zhuge edited comment on HADOOP-16159 at 5/3/22 10:19 PM: -- Can we fix

[jira] [Commented] (HADOOP-16159) Deadlock when using FsUrlStreamHandlerFactory

2022-05-03 Thread John Zhuge (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531435#comment-17531435 ] John Zhuge commented on HADOOP-16159: - Is this a possible fix by replacing `conf` with `this.conf`

[jira] [Commented] (HADOOP-16159) Deadlock when using FsUrlStreamHandlerFactory

2022-05-03 Thread John Zhuge (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531434#comment-17531434 ] John Zhuge commented on HADOOP-16159: - thread-1 {noformat} t0: URL.setURLStreamHandlerFactory(new

[jira] [Updated] (HADOOP-18193) Support nested mount points in INodeTree

2022-05-03 Thread Lei Yang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lei Yang updated HADOOP-18193: -- Description: Defining following client mount table config is not supported in  INodeTree and will

[jira] [Updated] (HADOOP-18193) Support nested mount points in INodeTree

2022-05-03 Thread Lei Yang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lei Yang updated HADOOP-18193: -- Description: Defining following client mount table config is not supported in  INodeTree and will

[jira] [Updated] (HADOOP-18193) Support nested mount points in INodeTree

2022-05-03 Thread Lei Yang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lei Yang updated HADOOP-18193: -- Description: Defining following client mount table config is not supported in  INodeTree and will

[jira] [Work logged] (HADOOP-18217) shutdownhookmanager should not be multithreaded (deadlock possible)

2022-05-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18217?focusedWorklogId=765676=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765676 ] ASF GitHub Bot logged work on HADOOP-18217: --- Author: ASF GitHub Bot

[GitHub] [hadoop] HerCath commented on pull request #4255: HADOOP-18217. ExitUtil synchronized blocks reduced to avoid exit bloc…

2022-05-03 Thread GitBox
HerCath commented on PR #4255: URL: https://github.com/apache/hadoop/pull/4255#issuecomment-1116496071 Hi, Thanks for the reviews. I've started to adjust my code to integrate them. Ok, I'll adjust code style about comment + rename the variable to caught. I'm also adjusting the

[GitHub] [hadoop] hadoop-yetus commented on pull request #4261: Hadoop 17215 branch 2.10

2022-05-03 Thread GitBox
hadoop-yetus commented on PR #4261: URL: https://github.com/apache/hadoop/pull/4261#issuecomment-1116469483 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4261: Hadoop 17215 branch 2.10

2022-05-03 Thread GitBox
hadoop-yetus commented on PR #4261: URL: https://github.com/apache/hadoop/pull/4261#issuecomment-1116428013 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] GauthamBanasandra commented on a diff in pull request #4245: HDFS-16564. Use uint32_t for hdfs_find

2022-05-03 Thread GitBox
GauthamBanasandra commented on code in PR #4245: URL: https://github.com/apache/hadoop/pull/4245#discussion_r864029472 ## hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tests/hdfspp_mini_dfs_smoke.cc: ## @@ -34,7 +34,6 @@ TEST_F(HdfsMiniDfsSmokeTest,

[jira] [Commented] (HADOOP-18193) Support nested mount points in INodeTree

2022-05-03 Thread Virajith Jalaparti (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531329#comment-17531329 ] Virajith Jalaparti commented on HADOOP-18193: - Ping on this [~umamaheswararao],

[jira] [Commented] (HADOOP-18160) `org.wildfly.openssl` should not be shaded by Hadoop build

2022-05-03 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531317#comment-17531317 ] Steve Loughran commented on HADOOP-18160: - [~andre.amorimfons...@gmail.com] can you grab the

[jira] [Created] (HADOOP-18220) Improve build performance of modules

2022-05-03 Thread Bing-ok (Jira)
Bing-ok created HADOOP-18220: Summary: Improve build performance of modules Key: HADOOP-18220 URL: https://issues.apache.org/jira/browse/HADOOP-18220 Project: Hadoop Common Issue Type:

[jira] [Work logged] (HADOOP-16965) Introduce StreamContext for Abfs Input and Output streams.

2022-05-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16965?focusedWorklogId=765551=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765551 ] ASF GitHub Bot logged work on HADOOP-16965: --- Author: ASF GitHub Bot

[GitHub] [hadoop] arjun4084346 commented on pull request #4171: HADOOP-16965. Refactor abfs stream configuration. (#1956)

2022-05-03 Thread GitBox
arjun4084346 commented on PR #4171: URL: https://github.com/apache/hadoop/pull/4171#issuecomment-1116339417 > can you submit a single PR with that chain and we can review/verify the final output. The individual commits would still need merging one by one, but reviewing is a lot easier.

[GitHub] [hadoop] hadoop-yetus commented on pull request #4252: HDFS-16566 Erasure Coding: Recovery may causes excess replicas when busy DN exsits

2022-05-03 Thread GitBox
hadoop-yetus commented on PR #4252: URL: https://github.com/apache/hadoop/pull/4252#issuecomment-1116330757 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] prasad-acit commented on pull request #3373: HDFS-16193. Append & Rename APIs to support FGL.

2022-05-03 Thread GitBox
prasad-acit commented on PR #3373: URL: https://github.com/apache/hadoop/pull/3373#issuecomment-1116326894 @shvachko @xinglin Can you please take a look into this PR when you find time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hadoop] prasad-acit commented on pull request #3376: HDFS-16208. Support Delete API with FGL.

2022-05-03 Thread GitBox
prasad-acit commented on PR #3376: URL: https://github.com/apache/hadoop/pull/3376#issuecomment-1116324730 @shvachko @xinglin Can you please review the PR? We had similar implementation in our version and verified it. -- This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] prasad-acit commented on pull request #4184: HADOOP-18209. Fix links to DataNodes in NameNode UI to support IPv6

2022-05-03 Thread GitBox
prasad-acit commented on PR #4184: URL: https://github.com/apache/hadoop/pull/4184#issuecomment-1116306155 > Thank you @liuml07 , [HADOOP-17800](https://issues.apache.org/jira/browse/HADOOP-17800) got branched out from trunk recently & started merging from older IPv6 branch

[jira] [Work logged] (HADOOP-18209) Fix links to DataNodes in NameNode UI to support IPv6

2022-05-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18209?focusedWorklogId=765528=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765528 ] ASF GitHub Bot logged work on HADOOP-18209: --- Author: ASF GitHub Bot

[GitHub] [hadoop] arjun4084346 opened a new pull request, #4261: Hadoop 17215 branch 2.10

2022-05-03 Thread GitBox
arjun4084346 opened a new pull request, #4261: URL: https://github.com/apache/hadoop/pull/4261 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g.

[GitHub] [hadoop] hadoop-yetus commented on pull request #4260: YARN-11092. Upgrade jquery ui to 1.13.1

2022-05-03 Thread GitBox
hadoop-yetus commented on PR #4260: URL: https://github.com/apache/hadoop/pull/4260#issuecomment-1116230318 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Comment Edited] (HADOOP-18194) Public dataset class for S3A integration tests

2022-05-03 Thread Daniel Carl Jones (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531249#comment-17531249 ] Daniel Carl Jones edited comment on HADOOP-18194 at 5/3/22 3:20 PM:

[jira] [Commented] (HADOOP-18194) Public dataset class for S3A integration tests

2022-05-03 Thread Daniel Carl Jones (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531249#comment-17531249 ] Daniel Carl Jones commented on HADOOP-18194: I've introduced a simple

[jira] [Work logged] (HADOOP-18175) test failures with prefetching s3a input stream

2022-05-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18175?focusedWorklogId=765472=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765472 ] ASF GitHub Bot logged work on HADOOP-18175: --- Author: ASF GitHub Bot

[GitHub] [hadoop] monthonk commented on pull request #4212: HADOOP-18175. fix test failures with prefetching s3a input stream

2022-05-03 Thread GitBox
monthonk commented on PR #4212: URL: https://github.com/apache/hadoop/pull/4212#issuecomment-1116166223 @mukund-thakur @steveloughran would you be able to have a look at this one? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hadoop] hadoop-yetus commented on pull request #4247: MAPREDUCE-7369. Fixed MapReduce tasks timing out when spends more time on MultipleOutputs#close

2022-05-03 Thread GitBox
hadoop-yetus commented on PR #4247: URL: https://github.com/apache/hadoop/pull/4247#issuecomment-1116133466 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18168) ITestMarkerTool.testRunLimitedLandsatAudit failing due to most of bucket content purged

2022-05-03 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531211#comment-17531211 ] Steve Loughran commented on HADOOP-18168: - committed to branch-3.3. as it depends on the

[jira] [Updated] (HADOOP-18168) ITestMarkerTool.testRunLimitedLandsatAudit failing due to most of bucket content purged

2022-05-03 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18168: Description: {{ITestMarkerTool.testRunLimitedLandsatAudit}} is failing -a scan which was

[jira] [Resolved] (HADOOP-18168) ITestMarkerTool.testRunLimitedLandsatAudit failing due to most of bucket content purged

2022-05-03 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18168. - Fix Version/s: 3.3.4 Resolution: Fixed >

[jira] [Work logged] (HADOOP-16965) Introduce StreamContext for Abfs Input and Output streams.

2022-05-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16965?focusedWorklogId=765448=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765448 ] ASF GitHub Bot logged work on HADOOP-16965: --- Author: ASF GitHub Bot

[GitHub] [hadoop] ashutoshcipher opened a new pull request, #4260: YARN-11092. Upgrade jquery ui to 1.13.1

2022-05-03 Thread GitBox
ashutoshcipher opened a new pull request, #4260: URL: https://github.com/apache/hadoop/pull/4260 ### Description of PR Upgrade jquery ui to 1.13.1 due to handle vulnerabilities CVE-2021-41182, CVE-2021-41183, CVE-2021-41184 * JIRA: YARN-11092 - [x] Does the title or this PR

[GitHub] [hadoop] steveloughran commented on pull request #4171: HADOOP-16965. Refactor abfs stream configuration. (#1956)

2022-05-03 Thread GitBox
steveloughran commented on PR #4171: URL: https://github.com/apache/hadoop/pull/4171#issuecomment-1116104640 can you submit a single PR with that chain and we can review/verify the final output. The individual commits would still need merging one by one, but reviewing is a lot easier.

[jira] [Work logged] (HADOOP-18168) ITestMarkerTool.testRunLimitedLandsatAudit failing due to most of bucket content purged

2022-05-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18168?focusedWorklogId=765442=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765442 ] ASF GitHub Bot logged work on HADOOP-18168: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #4140: HADOOP-18168. Fix S3A ITestMarkerTool dep. on purged public bucket, introduce PublicDatasetTestUtils

2022-05-03 Thread GitBox
steveloughran commented on PR #4140: URL: https://github.com/apache/hadoop/pull/4140#issuecomment-1116099593 merged to trunk, albeit with the commit message partially cut. reverted that and recommitted with the full text. test with branch-3.3 in progress -- This is an automated message

[jira] [Work logged] (HADOOP-18168) ITestMarkerTool.testRunLimitedLandsatAudit failing due to most of bucket content purged

2022-05-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18168?focusedWorklogId=765439=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765439 ] ASF GitHub Bot logged work on HADOOP-18168: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran merged pull request #4140: HADOOP-18168. Fix S3A ITestMarkerTool dep. on purged public bucket, introduce PublicDatasetTestUtils

2022-05-03 Thread GitBox
steveloughran merged PR #4140: URL: https://github.com/apache/hadoop/pull/4140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Work logged] (HADOOP-18217) shutdownhookmanager should not be multithreaded (deadlock possible)

2022-05-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18217?focusedWorklogId=765435=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765435 ] ASF GitHub Bot logged work on HADOOP-18217: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #4255: HADOOP-18217. ExitUtil synchronized blocks reduced to avoid exit bloc…

2022-05-03 Thread GitBox
steveloughran commented on PR #4255: URL: https://github.com/apache/hadoop/pull/4255#issuecomment-1116084353 checkstyle is complaining about line length. move the comments to the lines above the source and all is good. we don't normally have comments of any kind on the same lines as code

[GitHub] [hadoop] hemanthboyina merged pull request #4240: HDFS-16562. Upgrade moment.min.js to 2.29.2

2022-05-03 Thread GitBox
hemanthboyina merged PR #4240: URL: https://github.com/apache/hadoop/pull/4240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4245: HDFS-16564. Use uint32_t for hdfs_find

2022-05-03 Thread GitBox
hadoop-yetus commented on PR #4245: URL: https://github.com/apache/hadoop/pull/4245#issuecomment-1116014699 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4247: MAPREDUCE-7369. Fixed MapReduce tasks timing out when spends more time on MultipleOutputs#close

2022-05-03 Thread GitBox
ashutoshcipher commented on code in PR #4247: URL: https://github.com/apache/hadoop/pull/4247#discussion_r863684387 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml: ## @@ -286,6 +286,13 @@ + +

[GitHub] [hadoop] ashutoshcipher commented on pull request #4258: YARN-11125. Backport YARN-6483 to branch-2.10

2022-05-03 Thread GitBox
ashutoshcipher commented on PR #4258: URL: https://github.com/apache/hadoop/pull/4258#issuecomment-1115989451 @aajisaka - Can you have look at this? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop] hadoop-yetus commented on pull request #4245: HDFS-16564. Use uint32_t for hdfs_find

2022-05-03 Thread GitBox
hadoop-yetus commented on PR #4245: URL: https://github.com/apache/hadoop/pull/4245#issuecomment-1115829483 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4259: HDFS-16521. DFS API to retrieve slow datanodes (#4107)

2022-05-03 Thread GitBox
hadoop-yetus commented on PR #4259: URL: https://github.com/apache/hadoop/pull/4259#issuecomment-1115816832 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] skysiders commented on pull request #4237: MAPREDUCE-7375 JobSubmissionFiles don't set right permission after mkdirs

2022-05-03 Thread GitBox
skysiders commented on PR #4237: URL: https://github.com/apache/hadoop/pull/4237#issuecomment-1115812936 Hi @iwasakims ,could you please take a look? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] skysiders commented on pull request #4237: MAPREDUCE-7375 JobSubmissionFiles don't set right permission after mkdirs

2022-05-03 Thread GitBox
skysiders commented on PR #4237: URL: https://github.com/apache/hadoop/pull/4237#issuecomment-1115812225 In this PR , I set permission for directory with special permission after mkdir, so that the directory can has right permission -- This is an automated message from the Apache Git

[GitHub] [hadoop] hadoop-yetus commented on pull request #4201: HDFS-16547. [SBN read] Namenode in safe mode should not be transfered to observer state

2022-05-03 Thread GitBox
hadoop-yetus commented on PR #4201: URL: https://github.com/apache/hadoop/pull/4201#issuecomment-1115773778 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4245: HDFS-16564. Use uint32_t for hdfs_find

2022-05-03 Thread GitBox
hadoop-yetus commented on PR #4245: URL: https://github.com/apache/hadoop/pull/4245#issuecomment-1115766934 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |