ZanderXu commented on code in PR #4662:
URL: https://github.com/apache/hadoop/pull/4662#discussion_r934146184
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java:
##
@@ -415,6 +447,34 @@ private void
[
https://issues.apache.org/jira/browse/HADOOP-18364?focusedWorklogId=796746=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796746
]
ASF GitHub Bot logged work on HADOOP-18364:
---
Author: ASF GitHub Bot
Hexiaoqiao commented on code in PR #4624:
URL: https://github.com/apache/hadoop/pull/4624#discussion_r934113442
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMetrics.java:
##
@@ -591,14 +592,24 @@ public Boolean get() {
}
hadoop-yetus commented on PR #4659:
URL: https://github.com/apache/hadoop/pull/4659#issuecomment-1200651371
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18364?focusedWorklogId=796715=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796715
]
ASF GitHub Bot logged work on HADOOP-18364:
---
Author: ASF GitHub Bot
hadoop-yetus commented on PR #4624:
URL: https://github.com/apache/hadoop/pull/4624#issuecomment-1200489072
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #4650:
URL: https://github.com/apache/hadoop/pull/4650#issuecomment-1200464438
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #4139:
URL: https://github.com/apache/hadoop/pull/4139#issuecomment-1200455674
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #4657:
URL: https://github.com/apache/hadoop/pull/4657#issuecomment-1200455512
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #4664:
URL: https://github.com/apache/hadoop/pull/4664#issuecomment-1200450882
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
slfan1989 commented on PR #4663:
URL: https://github.com/apache/hadoop/pull/4663#issuecomment-1200423525
Thank you very much for your contribution, but in JIRA, your description
needs to be clearer, you can refer to @ZanderXu's Jira description, he wrote
very well.
--
This is an
slfan1989 commented on code in PR #4662:
URL: https://github.com/apache/hadoop/pull/4662#discussion_r933985677
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java:
##
@@ -415,6 +447,34 @@ private
slfan1989 commented on code in PR #4662:
URL: https://github.com/apache/hadoop/pull/4662#discussion_r933985490
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java:
##
@@ -399,13 +356,58 @@ private
slfan1989 commented on PR #4650:
URL: https://github.com/apache/hadoop/pull/4650#issuecomment-1200422235
@goiri Please help to review the code again, thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
slfan1989 commented on PR #4656:
URL: https://github.com/apache/hadoop/pull/4656#issuecomment-1200422116
@goiri Please help to review the code again, thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
slfan1989 commented on PR #4657:
URL: https://github.com/apache/hadoop/pull/4657#issuecomment-1200422051
@goiri Please help to review the code again, thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
slfan1989 opened a new pull request, #4664:
URL: https://github.com/apache/hadoop/pull/4664
JIRA: YARN-8973. [Router] Add missing methods in RMWebProtocol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/HADOOP-18364?focusedWorklogId=796691=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796691
]
ASF GitHub Bot logged work on HADOOP-18364:
---
Author: ASF GitHub Bot
zhangshuyan0 commented on code in PR #4624:
URL: https://github.com/apache/hadoop/pull/4624#discussion_r933975418
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableRatesWithAggregation.java:
##
@@ -71,11 +74,20 @@ public void init(Class
SanQiMax commented on PR #4663:
URL: https://github.com/apache/hadoop/pull/4663#issuecomment-1200379842
> Thanks @SanQiMax for your PR. Can you explain how to reproduce it in
detail? Have used Observer Read in RBF?
I add logs，and build a jar ,The final log print confirmed my guess,
hadoop-yetus commented on PR #4662:
URL: https://github.com/apache/hadoop/pull/4662#issuecomment-1200379550
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
SanQiMax commented on PR #4663:
URL: https://github.com/apache/hadoop/pull/4663#issuecomment-1200378751
> Thanks @SanQiMax for your PR. Can you explain how to reproduce it in
detail? Have used Observer Read in RBF?
reproduce detail
I deployed three router,
two NameService,as ns1
ZanderXu commented on code in PR #4662:
URL: https://github.com/apache/hadoop/pull/4662#discussion_r933932381
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RBFConfigKeys.java:
##
@@ -96,6 +96,10 @@ public class
23 matches
Mail list logo
