[
https://issues.apache.org/jira/browse/HADOOP-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xinqiu.hu updated HADOOP-18395:
---
Attachment: (was:
0001-retrun-1-when-tgt-has-remaining-and-src-expired-firs.patch)
>
[
https://issues.apache.org/jira/browse/HADOOP-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xinqiu.hu updated HADOOP-18395:
---
Attachment: 0001-add-UT-with-timeout-for-Text-find-and-fix-comments.patch
> Performance
ZanderXu commented on code in PR #4697:
URL: https://github.com/apache/hadoop/pull/4697#discussion_r939827596
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java:
##
@@ -1544,6 +1544,39 @@ public FSDataOutputStream append(Path f, int
M1eyu2018 commented on code in PR #4697:
URL: https://github.com/apache/hadoop/pull/4697#discussion_r939799726
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java:
##
@@ -1544,6 +1544,39 @@ public FSDataOutputStream append(Path f, int
paulk-asert opened a new pull request, #4718:
URL: https://github.com/apache/hadoop/pull/4718
Fix link location
### Description of PR
### How was this patch tested?
### For code changes:
- [ ] Does the title or this PR starts with the corresponding
M1eyu2018 commented on code in PR #4697:
URL: https://github.com/apache/hadoop/pull/4697#discussion_r939799726
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java:
##
@@ -1544,6 +1544,39 @@ public FSDataOutputStream append(Path f, int
slfan1989 commented on PR #4687:
URL: https://github.com/apache/hadoop/pull/4687#issuecomment-1207612557
@9uapaw Can you help review this part of the code? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
ZanderXu commented on code in PR #4697:
URL: https://github.com/apache/hadoop/pull/4697#discussion_r939790736
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java:
##
@@ -1544,6 +1544,39 @@ public FSDataOutputStream append(Path f, int
M1eyu2018 commented on PR #4697:
URL: https://github.com/apache/hadoop/pull/4697#issuecomment-1207584779
@steveloughran @Hexiaoqiao Please help to review the code, thank you very
much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
hadoop-yetus commented on PR #4717:
URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1207541045
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
ZanderXu commented on PR #4661:
URL: https://github.com/apache/hadoop/pull/4661#issuecomment-1207529359
Yes, we are here, and I have create a new
[PR-4699](https://github.com/apache/hadoop/pull/4699) to fix other cases in
DataNode.java.
@ayushtkn @Hexiaoqiao Can you help me review
[
https://issues.apache.org/jira/browse/HADOOP-18387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576460#comment-17576460
]
fanshilun commented on HADOOP-18387:
[~ayushtkn] Thanks for your help in reviewing the code, I have
slfan1989 commented on PR #4679:
URL: https://github.com/apache/hadoop/pull/4679#issuecomment-1207507840
Thanks everyone!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/HADOOP-18387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576459#comment-17576459
]
ASF GitHub Bot commented on HADOOP-18387:
-
slfan1989 commented on PR #4679:
URL:
hadoop-yetus commented on PR #4717:
URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1207492386
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
ayushtkn commented on PR #4661:
URL: https://github.com/apache/hadoop/pull/4661#issuecomment-1207485847
Are we good here? or Waiting for some more modifications?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/HADOOP-18387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ayush Saxena resolved HADOOP-18387.
---
Hadoop Flags: Reviewed
Resolution: Fixed
> Fix incorrect placeholder in
[
https://issues.apache.org/jira/browse/HADOOP-18387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576443#comment-17576443
]
Ayush Saxena commented on HADOOP-18387:
---
Committed to trunk.
Thanx [~slfan1989] for the
[
https://issues.apache.org/jira/browse/HADOOP-18387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576441#comment-17576441
]
ASF GitHub Bot commented on HADOOP-18387:
-
ayushtkn merged PR #4679:
URL:
ayushtkn merged PR #4679:
URL: https://github.com/apache/hadoop/pull/4679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/HADOOP-18387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ayush Saxena updated HADOOP-18387:
--
Summary: Fix incorrect placeholder in hadoop-common (was: Fix incorrect
placeholder in
[
https://issues.apache.org/jira/browse/HADOOP-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
groot reassigned HADOOP-14693:
--
Assignee: groot
> Upgrade JUnit from 4 to 5
> -
>
> Key:
ashutoshcipher opened a new pull request, #4717:
URL: https://github.com/apache/hadoop/pull/4717
### Description of PR
[WIP] Upgrade JUnit from 4 to 5 in hadoop-yarn-common
### For code changes:
- [X] Does the title or this PR starts with the corresponding JIRA issue id
[
https://issues.apache.org/jira/browse/HADOOP-18365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576435#comment-17576435
]
ASF GitHub Bot commented on HADOOP-18365:
-
snmvaughan commented on PR #4692:
URL:
snmvaughan commented on PR #4692:
URL: https://github.com/apache/hadoop/pull/4692#issuecomment-1207471527
I need to add an additional test to demonstrate that the in addition to the
update being handled, it avoids having to repeat the process. The current
patch fixed the existing unit
hadoop-yetus commented on PR #4716:
URL: https://github.com/apache/hadoop/pull/4716#issuecomment-1207458890
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
ZanderXu opened a new pull request, #4716:
URL: https://github.com/apache/hadoop/pull/4716
### Description of PR
Incorrect code as below:
```
/**
* ...
* @throws SafeModeException If the Router is in safe mode and cannot serve
* client requests.
slfan1989 commented on PR #4594:
URL: https://github.com/apache/hadoop/pull/4594#issuecomment-1207436395
@goiri Can you help to merge this pr into trunk branch? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
hadoop-yetus commented on PR #4715:
URL: https://github.com/apache/hadoop/pull/4715#issuecomment-1207426564
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #4594:
URL: https://github.com/apache/hadoop/pull/4594#issuecomment-1207408239
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576367#comment-17576367
]
ASF GitHub Bot commented on HADOOP-18395:
-
hadoop-yetus commented on PR #4714:
URL:
hadoop-yetus commented on PR #4714:
URL: https://github.com/apache/hadoop/pull/4714#issuecomment-1207386452
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
slfan1989 commented on code in PR #4715:
URL: https://github.com/apache/hadoop/pull/4715#discussion_r939650563
##
slfan1989 commented on code in PR #4715:
URL: https://github.com/apache/hadoop/pull/4715#discussion_r939648814
##
hadoop-yetus commented on PR #4711:
URL: https://github.com/apache/hadoop/pull/4711#issuecomment-1207383885
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
slfan1989 commented on code in PR #4715:
URL: https://github.com/apache/hadoop/pull/4715#discussion_r939648814
##
slfan1989 opened a new pull request, #4715:
URL: https://github.com/apache/hadoop/pull/4715
JIRA:YARN-11227. [Federation] Add getAppTimeout, getAppTimeouts,
updateApplicationTimeout REST APIs for Router.
--
This is an automated message from the Apache Git Service.
To respond to the
hadoop-yetus commented on PR #4712:
URL: https://github.com/apache/hadoop/pull/4712#issuecomment-1207378479
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HADOOP-18395:
Labels: pull-request-available (was: )
> Performance improvement in
[
https://issues.apache.org/jira/browse/HADOOP-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576335#comment-17576335
]
ASF GitHub Bot commented on HADOOP-18395:
-
huxinqiu opened a new pull request, #4714:
URL:
huxinqiu opened a new pull request, #4714:
URL: https://github.com/apache/hadoop/pull/4714
### Description of PR
The current implementation reset src and tgt to the mark and continues
searching when tgt has remaining and src expired first. which is probably not
necessary.
For
[
https://issues.apache.org/jira/browse/HADOOP-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xinqiu.hu updated HADOOP-18395:
---
Summary: Performance improvement in org.apache.hadoop.io.Text#find (was:
Performance improvement
[
https://issues.apache.org/jira/browse/HADOOP-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xinqiu.hu updated HADOOP-18395:
---
Attachment: 0001-retrun-1-when-tgt-has-remaining-and-src-expired-firs.patch
Status: Patch
slfan1989 commented on code in PR #4711:
URL: https://github.com/apache/hadoop/pull/4711#discussion_r939620389
##
xinqiu.hu created HADOOP-18395:
--
Summary: Performance improvement in
org.apache.hadoop.io.Text.find()
Key: HADOOP-18395
URL: https://issues.apache.org/jira/browse/HADOOP-18395
Project: Hadoop Common
aajisaka merged PR #4603:
URL: https://github.com/apache/hadoop/pull/4603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/HADOOP-18321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akira Ajisaka updated HADOOP-18321:
---
Component/s: io
> Fix when to read an additional record from a BZip2 text file split
>
[
https://issues.apache.org/jira/browse/HADOOP-18390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akira Ajisaka updated HADOOP-18390:
---
Fix Version/s: 3.3.9
Target Version/s: 3.4.0, 3.3.9 (was: 3.4.0)
Affects
[
https://issues.apache.org/jira/browse/HADOOP-18321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akira Ajisaka updated HADOOP-18321:
---
Fix Version/s: 3.3.9
Backported to branch-3.3.
> Fix when to read an additional record
slfan1989 commented on code in PR #4711:
URL: https://github.com/apache/hadoop/pull/4711#discussion_r939617042
##
slfan1989 commented on code in PR #4711:
URL: https://github.com/apache/hadoop/pull/4711#discussion_r939616561
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/utils/FederationStateStoreFacade.java:
slfan1989 commented on code in PR #4711:
URL: https://github.com/apache/hadoop/pull/4711#discussion_r939616164
##
52 matches
Mail list logo