[jira] [Updated] (HADOOP-18395) Performance improvement in org.apache.hadoop.io.Text#find

2022-08-07 Thread xinqiu.hu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xinqiu.hu updated HADOOP-18395: --- Attachment: (was: 0001-retrun-1-when-tgt-has-remaining-and-src-expired-firs.patch) >

[jira] [Updated] (HADOOP-18395) Performance improvement in org.apache.hadoop.io.Text#find

2022-08-07 Thread xinqiu.hu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xinqiu.hu updated HADOOP-18395: --- Attachment: 0001-add-UT-with-timeout-for-Text-find-and-fix-comments.patch > Performance

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4697: HDFS-16716. Improve appendToFile command: support appending on file with new block

2022-08-07 Thread GitBox
ZanderXu commented on code in PR #4697: URL: https://github.com/apache/hadoop/pull/4697#discussion_r939827596 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java: ## @@ -1544,6 +1544,39 @@ public FSDataOutputStream append(Path f, int

[GitHub] [hadoop] M1eyu2018 commented on a diff in pull request #4697: HDFS-16716. Improve appendToFile command: support appending on file with new block

2022-08-07 Thread GitBox
M1eyu2018 commented on code in PR #4697: URL: https://github.com/apache/hadoop/pull/4697#discussion_r939799726 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java: ## @@ -1544,6 +1544,39 @@ public FSDataOutputStream append(Path f, int

[GitHub] [hadoop] paulk-asert opened a new pull request, #4718: Update Shell.java

2022-08-07 Thread GitBox
paulk-asert opened a new pull request, #4718: URL: https://github.com/apache/hadoop/pull/4718 Fix link location ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding

[GitHub] [hadoop] M1eyu2018 commented on a diff in pull request #4697: HDFS-16716. Improve appendToFile command: support appending on file with new block

2022-08-07 Thread GitBox
M1eyu2018 commented on code in PR #4697: URL: https://github.com/apache/hadoop/pull/4697#discussion_r939799726 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java: ## @@ -1544,6 +1544,39 @@ public FSDataOutputStream append(Path f, int

[GitHub] [hadoop] slfan1989 commented on pull request #4687: YARN-10846. Add dispatcher metrics to NM.

2022-08-07 Thread GitBox
slfan1989 commented on PR #4687: URL: https://github.com/apache/hadoop/pull/4687#issuecomment-1207612557 @9uapaw Can you help review this part of the code? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4697: HDFS-16716. Improve appendToFile command: support appending on file w…

2022-08-07 Thread GitBox
ZanderXu commented on code in PR #4697: URL: https://github.com/apache/hadoop/pull/4697#discussion_r939790736 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java: ## @@ -1544,6 +1544,39 @@ public FSDataOutputStream append(Path f, int

[GitHub] [hadoop] M1eyu2018 commented on pull request #4697: HDFS-16716. Improve appendToFile command: support appending on file w…

2022-08-07 Thread GitBox
M1eyu2018 commented on PR #4697: URL: https://github.com/apache/hadoop/pull/4697#issuecomment-1207584779 @steveloughran @Hexiaoqiao Please help to review the code, thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hadoop] hadoop-yetus commented on pull request #4717: [WIP]YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common

2022-08-07 Thread GitBox
hadoop-yetus commented on PR #4717: URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1207541045 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ZanderXu commented on pull request #4661: HDFS-16704. Datanode return empty response instead of NPE for GetVolumeInfo during restarting

2022-08-07 Thread GitBox
ZanderXu commented on PR #4661: URL: https://github.com/apache/hadoop/pull/4661#issuecomment-1207529359 Yes, we are here, and I have create a new [PR-4699](https://github.com/apache/hadoop/pull/4699) to fix other cases in DataNode.java. @ayushtkn @Hexiaoqiao Can you help me review

[jira] [Commented] (HADOOP-18387) Fix incorrect placeholder in hadoop-common

2022-08-07 Thread fanshilun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576460#comment-17576460 ] fanshilun commented on HADOOP-18387: [~ayushtkn] Thanks for your help in reviewing the code, I have

[GitHub] [hadoop] slfan1989 commented on pull request #4679: HADOOP-18387. Fix incorrect placeholder in hadoop-common

2022-08-07 Thread GitBox
slfan1989 commented on PR #4679: URL: https://github.com/apache/hadoop/pull/4679#issuecomment-1207507840 Thanks everyone! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (HADOOP-18387) Fix incorrect placeholder in hadoop-common

2022-08-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576459#comment-17576459 ] ASF GitHub Bot commented on HADOOP-18387: - slfan1989 commented on PR #4679: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4717: [WIP]YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common

2022-08-07 Thread GitBox
hadoop-yetus commented on PR #4717: URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1207492386 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ayushtkn commented on pull request #4661: HDFS-16704. Datanode return empty response instead of NPE for GetVolumeInfo during restarting

2022-08-07 Thread GitBox
ayushtkn commented on PR #4661: URL: https://github.com/apache/hadoop/pull/4661#issuecomment-1207485847 Are we good here? or Waiting for some more modifications? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Resolved] (HADOOP-18387) Fix incorrect placeholder in hadoop-common

2022-08-07 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena resolved HADOOP-18387. --- Hadoop Flags: Reviewed Resolution: Fixed > Fix incorrect placeholder in

[jira] [Commented] (HADOOP-18387) Fix incorrect placeholder in hadoop-common

2022-08-07 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576443#comment-17576443 ] Ayush Saxena commented on HADOOP-18387: --- Committed to trunk. Thanx [~slfan1989] for the

[jira] [Commented] (HADOOP-18387) Fix incorrect placeholder in hadoop-common

2022-08-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576441#comment-17576441 ] ASF GitHub Bot commented on HADOOP-18387: - ayushtkn merged PR #4679: URL:

[GitHub] [hadoop] ayushtkn merged pull request #4679: HADOOP-18387. Fix incorrect placeholder in hadoop-common

2022-08-07 Thread GitBox
ayushtkn merged PR #4679: URL: https://github.com/apache/hadoop/pull/4679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HADOOP-18387) Fix incorrect placeholder in hadoop-common

2022-08-07 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena updated HADOOP-18387: -- Summary: Fix incorrect placeholder in hadoop-common (was: Fix incorrect placeholder in

[jira] [Assigned] (HADOOP-14693) Upgrade JUnit from 4 to 5

2022-08-07 Thread groot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] groot reassigned HADOOP-14693: -- Assignee: groot > Upgrade JUnit from 4 to 5 > - > > Key:

[GitHub] [hadoop] ashutoshcipher opened a new pull request, #4717: [WIP]YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common

2022-08-07 Thread GitBox
ashutoshcipher opened a new pull request, #4717: URL: https://github.com/apache/hadoop/pull/4717 ### Description of PR [WIP] Upgrade JUnit from 4 to 5 in hadoop-yarn-common ### For code changes: - [X] Does the title or this PR starts with the corresponding JIRA issue id

[jira] [Commented] (HADOOP-18365) Updated addresses are still accessed using the old IP address

2022-08-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576435#comment-17576435 ] ASF GitHub Bot commented on HADOOP-18365: - snmvaughan commented on PR #4692: URL:

[GitHub] [hadoop] snmvaughan commented on pull request #4692: HADOOP-18365. Update the remote address when a change is detected

2022-08-07 Thread GitBox
snmvaughan commented on PR #4692: URL: https://github.com/apache/hadoop/pull/4692#issuecomment-1207471527 I need to add an additional test to demonstrate that the in addition to the update being handled, it avoids having to repeat the process. The current patch fixed the existing unit

[GitHub] [hadoop] hadoop-yetus commented on pull request #4716: HDFS-16723. Replace incorrect SafeModeException with StandbyException in RouterRpcServer.class

2022-08-07 Thread GitBox
hadoop-yetus commented on PR #4716: URL: https://github.com/apache/hadoop/pull/4716#issuecomment-1207458890 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ZanderXu opened a new pull request, #4716: HDFS-16723. Replace incorrect SafeModeException with StandbyException in RouterRpcServer.class

2022-08-07 Thread GitBox
ZanderXu opened a new pull request, #4716: URL: https://github.com/apache/hadoop/pull/4716 ### Description of PR Incorrect code as below: ``` /** * ... * @throws SafeModeException If the Router is in safe mode and cannot serve * client requests.

[GitHub] [hadoop] slfan1989 commented on pull request #4594: YARN-6572. Refactoring Router services to use common util classes for pipeline creations.

2022-08-07 Thread GitBox
slfan1989 commented on PR #4594: URL: https://github.com/apache/hadoop/pull/4594#issuecomment-1207436395 @goiri Can you help to merge this pr into trunk branch? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] hadoop-yetus commented on pull request #4715: YARN-11227. [Federation] Add getAppTimeout, getAppTimeouts, updateApplicationTimeout REST APIs for Router.

2022-08-07 Thread GitBox
hadoop-yetus commented on PR #4715: URL: https://github.com/apache/hadoop/pull/4715#issuecomment-1207426564 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4594: YARN-6572. Refactoring Router services to use common util classes for pipeline creations.

2022-08-07 Thread GitBox
hadoop-yetus commented on PR #4594: URL: https://github.com/apache/hadoop/pull/4594#issuecomment-1207408239 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18395) Performance improvement in org.apache.hadoop.io.Text#find

2022-08-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576367#comment-17576367 ] ASF GitHub Bot commented on HADOOP-18395: - hadoop-yetus commented on PR #4714: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4714: HADOOP-18395 Performance improvement in org.apache.hadoop.io.Text#find

2022-08-07 Thread GitBox
hadoop-yetus commented on PR #4714: URL: https://github.com/apache/hadoop/pull/4714#issuecomment-1207386452 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4715: YARN-11227. [Federation] Add getAppTimeout, getAppTimeouts, updateApplicationTimeout REST APIs for Router.

2022-08-07 Thread GitBox
slfan1989 commented on code in PR #4715: URL: https://github.com/apache/hadoop/pull/4715#discussion_r939650563 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4715: YARN-11227. [Federation] Add getAppTimeout, getAppTimeouts, updateApplicationTimeout REST APIs for Router.

2022-08-07 Thread GitBox
slfan1989 commented on code in PR #4715: URL: https://github.com/apache/hadoop/pull/4715#discussion_r939648814 ##

[GitHub] [hadoop] hadoop-yetus commented on pull request #4711: YARN-11236. Implement FederationReservationHomeSubClusterStore With MemoryStore.

2022-08-07 Thread GitBox
hadoop-yetus commented on PR #4711: URL: https://github.com/apache/hadoop/pull/4711#issuecomment-1207383885 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4715: YARN-11227. [Federation] Add getAppTimeout, getAppTimeouts, updateApplicationTimeout REST APIs for Router.

2022-08-07 Thread GitBox
slfan1989 commented on code in PR #4715: URL: https://github.com/apache/hadoop/pull/4715#discussion_r939648814 ##

[GitHub] [hadoop] slfan1989 opened a new pull request, #4715: YARN-11227. [Federation] Add getAppTimeout, getAppTimeouts, updateApplicationTimeout REST APIs for Router.

2022-08-07 Thread GitBox
slfan1989 opened a new pull request, #4715: URL: https://github.com/apache/hadoop/pull/4715 JIRA:YARN-11227. [Federation] Add getAppTimeout, getAppTimeouts, updateApplicationTimeout REST APIs for Router. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] hadoop-yetus commented on pull request #4712: YARN-6539. Create SecureLogin inside Router.

2022-08-07 Thread GitBox
hadoop-yetus commented on PR #4712: URL: https://github.com/apache/hadoop/pull/4712#issuecomment-1207378479 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-18395) Performance improvement in org.apache.hadoop.io.Text#find

2022-08-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18395: Labels: pull-request-available (was: ) > Performance improvement in

[jira] [Commented] (HADOOP-18395) Performance improvement in org.apache.hadoop.io.Text#find

2022-08-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576335#comment-17576335 ] ASF GitHub Bot commented on HADOOP-18395: - huxinqiu opened a new pull request, #4714: URL:

[GitHub] [hadoop] huxinqiu opened a new pull request, #4714: HADOOP-18395 Performance improvement in org.apache.hadoop.io.Text#find

2022-08-07 Thread GitBox
huxinqiu opened a new pull request, #4714: URL: https://github.com/apache/hadoop/pull/4714 ### Description of PR The current implementation reset src and tgt to the mark and continues searching when tgt has remaining and src expired first. which is probably not necessary. For

[jira] [Updated] (HADOOP-18395) Performance improvement in org.apache.hadoop.io.Text#find

2022-08-07 Thread xinqiu.hu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xinqiu.hu updated HADOOP-18395: --- Summary: Performance improvement in org.apache.hadoop.io.Text#find (was: Performance improvement

[jira] [Updated] (HADOOP-18395) Performance improvement in org.apache.hadoop.io.Text.find()

2022-08-07 Thread xinqiu.hu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xinqiu.hu updated HADOOP-18395: --- Attachment: 0001-retrun-1-when-tgt-has-remaining-and-src-expired-firs.patch Status: Patch

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4711: YARN-11236. Implement FederationReservationHomeSubClusterStore With MemoryStore.

2022-08-07 Thread GitBox
slfan1989 commented on code in PR #4711: URL: https://github.com/apache/hadoop/pull/4711#discussion_r939620389 ##

[jira] [Created] (HADOOP-18395) Performance improvement in org.apache.hadoop.io.Text.find()

2022-08-07 Thread xinqiu.hu (Jira)
xinqiu.hu created HADOOP-18395: -- Summary: Performance improvement in org.apache.hadoop.io.Text.find() Key: HADOOP-18395 URL: https://issues.apache.org/jira/browse/HADOOP-18395 Project: Hadoop Common

[GitHub] [hadoop] aajisaka merged pull request #4603: YARN-10793. Upgrade Junit from 4 to 5 in hadoop-yarn-server-applicationhistoryservice

2022-08-07 Thread GitBox
aajisaka merged PR #4603: URL: https://github.com/apache/hadoop/pull/4603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HADOOP-18321) Fix when to read an additional record from a BZip2 text file split

2022-08-07 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-18321: --- Component/s: io > Fix when to read an additional record from a BZip2 text file split >

[jira] [Updated] (HADOOP-18390) Fix out of sync import for HADOOP-18321

2022-08-07 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-18390: --- Fix Version/s: 3.3.9 Target Version/s: 3.4.0, 3.3.9 (was: 3.4.0) Affects

[jira] [Updated] (HADOOP-18321) Fix when to read an additional record from a BZip2 text file split

2022-08-07 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-18321: --- Fix Version/s: 3.3.9 Backported to branch-3.3. > Fix when to read an additional record

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4711: YARN-11236. Implement FederationReservationHomeSubClusterStore With MemoryStore.

2022-08-07 Thread GitBox
slfan1989 commented on code in PR #4711: URL: https://github.com/apache/hadoop/pull/4711#discussion_r939617042 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4711: YARN-11236. Implement FederationReservationHomeSubClusterStore With MemoryStore.

2022-08-07 Thread GitBox
slfan1989 commented on code in PR #4711: URL: https://github.com/apache/hadoop/pull/4711#discussion_r939616561 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/utils/FederationStateStoreFacade.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4711: YARN-11236. Implement FederationReservationHomeSubClusterStore With MemoryStore.

2022-08-07 Thread GitBox
slfan1989 commented on code in PR #4711: URL: https://github.com/apache/hadoop/pull/4711#discussion_r939616164 ##