[GitHub] [hadoop] hadoop-yetus commented on pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

2022-08-24 Thread GitBox
hadoop-yetus commented on PR #4311: URL: https://github.com/apache/hadoop/pull/4311#issuecomment-1225307012 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Assigned] (HADOOP-18377) hadoop-aws maven build to add a prefetch profile to run all tests with prefetching

2022-08-24 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HADOOP-18377: - Assignee: Viraj Jasani > hadoop-aws maven build to add a prefetch profile to run all

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4793: YARN-11276. Add lru cache for RMWebServices.getApps

2022-08-24 Thread GitBox
slfan1989 commented on code in PR #4793: URL: https://github.com/apache/hadoop/pull/4793#discussion_r953421783 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/AppsCacheKey.java: ## @@ -0,0 +1,142 @@ +/** + * Licensed to the Apache

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4793: YARN-11276. Add lru cache for RMWebServices.getApps

2022-08-24 Thread GitBox
slfan1989 commented on code in PR #4793: URL: https://github.com/apache/hadoop/pull/4793#discussion_r953421456 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java: ## @@ -4681,6 +4681,18 @@ public static boolean

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4793: YARN-11276. Add lru cache for RMWebServices.getApps

2022-08-24 Thread GitBox
slfan1989 commented on code in PR #4793: URL: https://github.com/apache/hadoop/pull/4793#discussion_r953418643 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4793: YARN-11276. Add lru cache for RMWebServices.getApps

2022-08-24 Thread GitBox
slfan1989 commented on code in PR #4793: URL: https://github.com/apache/hadoop/pull/4793#discussion_r953418043 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4793: YARN-11276. Add lru cache for RMWebServices.getApps

2022-08-24 Thread GitBox
slfan1989 commented on code in PR #4793: URL: https://github.com/apache/hadoop/pull/4793#discussion_r953417054 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4793: YARN-11276. Add lru cache for RMWebServices.getApps

2022-08-24 Thread GitBox
slfan1989 commented on code in PR #4793: URL: https://github.com/apache/hadoop/pull/4793#discussion_r953416707 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4793: YARN-11276. Add lru cache for RMWebServices.getApps

2022-08-24 Thread GitBox
slfan1989 commented on code in PR #4793: URL: https://github.com/apache/hadoop/pull/4793#discussion_r953416461 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4793: YARN-11276. Add lru cache for RMWebServices.getApps

2022-08-24 Thread GitBox
slfan1989 commented on code in PR #4793: URL: https://github.com/apache/hadoop/pull/4793#discussion_r953415622 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4793: YARN-11276. Add lru cache for RMWebServices.getApps

2022-08-24 Thread GitBox
slfan1989 commented on code in PR #4793: URL: https://github.com/apache/hadoop/pull/4793#discussion_r953415288 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4764: YARN-11177. Support getNewReservation, submit / update/ Reservation API's for Federation.

2022-08-24 Thread GitBox
hadoop-yetus commented on PR #4764: URL: https://github.com/apache/hadoop/pull/4764#issuecomment-1225272658 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4786: HDFS-16684. Exclude the current JournalNode

2022-08-24 Thread GitBox
hadoop-yetus commented on PR #4786: URL: https://github.com/apache/hadoop/pull/4786#issuecomment-1225266567 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

<    1   2   3