[GitHub] [hadoop] hadoop-yetus commented on pull request #4851: YARN-11226. [Federation] Add createNewReservation, submitReservation, updateReservation, deleteReservation REST APIs for Router

2022-09-04 Thread GitBox
hadoop-yetus commented on PR #4851: URL: https://github.com/apache/hadoop/pull/4851#issuecomment-1236607490 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.

2022-09-04 Thread GitBox
hadoop-yetus commented on PR #4846: URL: https://github.com/apache/hadoop/pull/4846#issuecomment-1236593039 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4843: YARN-7614. [RESERVATION] Support ListReservation APIs in Federation Router.

2022-09-04 Thread GitBox
hadoop-yetus commented on PR #4843: URL: https://github.com/apache/hadoop/pull/4843#issuecomment-1236587511 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4851: YARN-11226. [Federation] Add createNewReservation, submitReservation, updateReservation, deleteReservation REST APIs for Router

2022-09-04 Thread GitBox
hadoop-yetus commented on PR #4851: URL: https://github.com/apache/hadoop/pull/4851#issuecomment-1236545196 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 commented on pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.

2022-09-04 Thread GitBox
slfan1989 commented on PR #4846: URL: https://github.com/apache/hadoop/pull/4846#issuecomment-1236511195 This PR changes the execution script of the stored procedure, I will check the script against the major version of the database. SQL Server The change script of the stored p

[GitHub] [hadoop] slfan1989 opened a new pull request, #4851: YARN-11226. [Federation] Add createNewReservation, submitReservation, updateReservation, deleteReservation REST APIs for Router

2022-09-04 Thread GitBox
slfan1989 opened a new pull request, #4851: URL: https://github.com/apache/hadoop/pull/4851 JIRA: YARN-11226. [Federation] Add createNewReservation, submitReservation, updateReservation, deleteReservation REST APIs for Router. -- This is an automated message from the Apache Git Service. T

[jira] [Commented] (HADOOP-18441) remove org.apache.hadoop.maven.plugin.shade.resource.ServicesResourceTransformer

2022-09-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600125#comment-17600125 ] ASF GitHub Bot commented on HADOOP-18441: - hadoop-yetus commented on PR #4850:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4850: HADOOP-18441: remove hadoop custom ServicesResourceTransformer

2022-09-04 Thread GitBox
hadoop-yetus commented on PR #4850: URL: https://github.com/apache/hadoop/pull/4850#issuecomment-1236461981 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 commented on pull request #4848: HDFS-16653.Add error message for maxEvictableMmapedSize related Precondition check suite.

2022-09-04 Thread GitBox
slfan1989 commented on PR #4848: URL: https://github.com/apache/hadoop/pull/4848#issuecomment-1236434098 Can we provide the stack before and after modification ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] slfan1989 commented on pull request #4849: HDFS-16697.Add code to check for minimumRedundantVolumes.

2022-09-04 Thread GitBox
slfan1989 commented on PR #4849: URL: https://github.com/apache/hadoop/pull/4849#issuecomment-1236433689 please fix checkstyle -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [hadoop] slfan1989 commented on pull request #4847: HDFS-16721.Improve the check code of “dfs.client.socket-timeout”.

2022-09-04 Thread GitBox
slfan1989 commented on PR #4847: URL: https://github.com/apache/hadoop/pull/4847#issuecomment-1236432914 @Likkey I don't think this change is necessary, the possibility of timeout being configured as a negative number is very low, and the user will not configure it as a negative number.

[GitHub] [hadoop] hadoop-yetus commented on pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.

2022-09-04 Thread GitBox
hadoop-yetus commented on PR #4846: URL: https://github.com/apache/hadoop/pull/4846#issuecomment-1236421286 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18441) remove org.apache.hadoop.maven.plugin.shade.resource.ServicesResourceTransformer

2022-09-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600115#comment-17600115 ] ASF GitHub Bot commented on HADOOP-18441: - pjfanning opened a new pull request,

[jira] [Updated] (HADOOP-18441) remove org.apache.hadoop.maven.plugin.shade.resource.ServicesResourceTransformer

2022-09-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18441: Labels: pull-request-available (was: ) > remove > org.apache.hadoop.maven.plugin.shade.

[GitHub] [hadoop] pjfanning opened a new pull request, #4850: HADOOP-18441: remove hadoop custom ServicesResourceTransformer

2022-09-04 Thread GitBox
pjfanning opened a new pull request, #4850: URL: https://github.com/apache/hadoop/pull/4850 ### Description of PR This class is now in maven-shade-plugin ### How was this patch tested? CI build ### For code changes: - [ ] Does the title or this PR starts

[jira] [Created] (HADOOP-18441) remove org.apache.hadoop.maven.plugin.shade.resource.ServicesResourceTransformer

2022-09-04 Thread PJ Fanning (Jira)
PJ Fanning created HADOOP-18441: --- Summary: remove org.apache.hadoop.maven.plugin.shade.resource.ServicesResourceTransformer Key: HADOOP-18441 URL: https://issues.apache.org/jira/browse/HADOOP-18441 Proj

[GitHub] [hadoop] hadoop-yetus commented on pull request #4849: HDFS-16697.Add code to check for minimumRedundantVolumes.

2022-09-04 Thread GitBox
hadoop-yetus commented on PR #4849: URL: https://github.com/apache/hadoop/pull/4849#issuecomment-1236412769 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop-thirdparty] pjfanning commented on pull request #21: [HADOOP-18342] shaded avro jar

2022-09-04 Thread GitBox
pjfanning commented on PR #21: URL: https://github.com/apache/hadoop-thirdparty/pull/21#issuecomment-1236399887 @steveloughran I have made some progress with the hadoop-avro jar. I still need to test it in a hadoop build though. I have noticed that hadoop also uses avro-maven-plugin to comp

[GitHub] [hadoop] hadoop-yetus commented on pull request #4848: HDFS-16653.Add error message for maxEvictableMmapedSize related Precondition check suite.

2022-09-04 Thread GitBox
hadoop-yetus commented on PR #4848: URL: https://github.com/apache/hadoop/pull/4848#issuecomment-1236375953 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4847: HDFS-16721.Improve the check code of “dfs.client.socket-timeout”.

2022-09-04 Thread GitBox
hadoop-yetus commented on PR #4847: URL: https://github.com/apache/hadoop/pull/4847#issuecomment-1236374729 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4843: YARN-7614. [RESERVATION] Support ListReservation APIs in Federation Router.

2022-09-04 Thread GitBox
hadoop-yetus commented on PR #4843: URL: https://github.com/apache/hadoop/pull/4843#issuecomment-1236367011 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] Likkey opened a new pull request, #4849: HDFS-16697.Add code to check for minimumRedundantVolumes.

2022-09-04 Thread GitBox
Likkey opened a new pull request, #4849: URL: https://github.com/apache/hadoop/pull/4849 ### Description of PR It is found that “dfs.namenode.resource.checked.volumes.minimum” lacks a condition check and an associated exception handling mechanism, which makes it impossible to fin

[GitHub] [hadoop] Likkey opened a new pull request, #4848: HDFS-16653.Add error message for maxEvictableMmapedSize related Precondition check suite.

2022-09-04 Thread GitBox
Likkey opened a new pull request, #4848: URL: https://github.com/apache/hadoop/pull/4848 …ndition check suite. ### Description of PR When the configuration item “dfs.client.mmap.cache.size” is set to a negative number, it will cause /hadoop/bin hdfs dfsadmin -safemode provi

[jira] [Commented] (HADOOP-18401) release files miss hadoop-3.3.4-aarch64.tar.gz

2022-09-04 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600068#comment-17600068 ] Ayush Saxena commented on HADOOP-18401: --- Sorry, coming back late got stuck with s

[GitHub] [hadoop] Likkey opened a new pull request, #4847: HDFS-16721.Improve the check code of “dfs.client.socket-timeout”.

2022-09-04 Thread GitBox
Likkey opened a new pull request, #4847: URL: https://github.com/apache/hadoop/pull/4847 ### Description of PR "dfs.client.socket-timeout" as the default timeout value for all sockets is applied in multiple places, it is a configuration item with significant impact, but the value

[jira] [Commented] (HADOOP-18417) Upgrade Maven Surefire plugin to 3.0.0-M7

2022-09-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600057#comment-17600057 ] ASF GitHub Bot commented on HADOOP-18417: - ayushtkn commented on PR #4807: URL:

[GitHub] [hadoop] ayushtkn commented on pull request #4807: HADOOP-18417. Upgrade to M7 of surefire plugin

2022-09-04 Thread GitBox
ayushtkn commented on PR #4807: URL: https://github.com/apache/hadoop/pull/4807#issuecomment-1236341315 I am not sure what's happening here with the build, but the unit test results seems incomplete here: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4807/3/artifact/out/patc

[GitHub] [hadoop] ayushtkn closed pull request #4826: Update README.txt

2022-09-04 Thread GitBox
ayushtkn closed pull request #4826: Update README.txt URL: https://github.com/apache/hadoop/pull/4826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: co

[GitHub] [hadoop] ayushtkn commented on pull request #4826: Update README.txt

2022-09-04 Thread GitBox
ayushtkn commented on PR #4826: URL: https://github.com/apache/hadoop/pull/4826#issuecomment-1236338100 This just adds a new line, not required... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] ayushtkn closed pull request #4829: add some comments

2022-09-04 Thread GitBox
ayushtkn closed pull request #4829: add some comments URL: https://github.com/apache/hadoop/pull/4829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: co

[GitHub] [hadoop] ayushtkn commented on pull request #4829: add some comments

2022-09-04 Thread GitBox
ayushtkn commented on PR #4829: URL: https://github.com/apache/hadoop/pull/4829#issuecomment-1236337857 this has some 10K commits & no jira created, no idea what is the intent please read the contribution guide, and raise a proper PR: https://cwiki.apache.org/confluence/display/hadoop/how

[GitHub] [hadoop] ayushtkn closed pull request #4827: add method comments

2022-09-04 Thread GitBox
ayushtkn closed pull request #4827: add method comments URL: https://github.com/apache/hadoop/pull/4827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] ayushtkn commented on pull request #4827: add method comments

2022-09-04 Thread GitBox
ayushtkn commented on PR #4827: URL: https://github.com/apache/hadoop/pull/4827#issuecomment-1236337909 this has some 10K commits & no jira created, no idea what is the intent please read the contribution guide, and raise a proper PR: https://cwiki.apache.org/confluence/display/hadoop/how

[jira] [Commented] (HADOOP-18133) Add Dockerfile for Windows 10

2022-09-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600039#comment-17600039 ] ASF GitHub Bot commented on HADOOP-18133: - hadoop-yetus commented on PR #4765:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4765: HADOOP-18133. Add Dockerfile for Windows 10

2022-09-04 Thread GitBox
hadoop-yetus commented on PR #4765: URL: https://github.com/apache/hadoop/pull/4765#issuecomment-1236300296 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe