[jira] [Commented] (HADOOP-16769) LocalDirAllocator to provide diagnostics when file creation fails

2022-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605139#comment-17605139 ] ASF GitHub Bot commented on HADOOP-16769: - ashutoshcipher commented on code in

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4842: HADOOP-16769. LocalDirAllocator to provide diagnostics when file creation fails

2022-09-14 Thread GitBox
ashutoshcipher commented on code in PR #4842: URL: https://github.com/apache/hadoop/pull/4842#discussion_r971586373 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java: ## @@ -532,4 +533,19 @@ public void testGetLocalPathForWriteF

[jira] [Commented] (HADOOP-16769) LocalDirAllocator to provide diagnostics when file creation fails

2022-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605138#comment-17605138 ] ASF GitHub Bot commented on HADOOP-16769: - ashutoshcipher commented on code in

[jira] [Commented] (HADOOP-16769) LocalDirAllocator to provide diagnostics when file creation fails

2022-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605137#comment-17605137 ] ASF GitHub Bot commented on HADOOP-16769: - ashutoshcipher commented on PR #4842

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4842: HADOOP-16769. LocalDirAllocator to provide diagnostics when file creation fails

2022-09-14 Thread GitBox
ashutoshcipher commented on code in PR #4842: URL: https://github.com/apache/hadoop/pull/4842#discussion_r971585276 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java: ## @@ -532,4 +533,19 @@ public void testGetLocalPathForWriteF

[GitHub] [hadoop] ashutoshcipher commented on pull request #4842: HADOOP-16769. LocalDirAllocator to provide diagnostics when file creation fails

2022-09-14 Thread GitBox
ashutoshcipher commented on PR #4842: URL: https://github.com/apache/hadoop/pull/4842#issuecomment-1247649005 > LG, Can you also provide your test process, just a rule we follow for any PR. In the case of S3A ITs, we also ask for the region of the bucket used for testing. Thanks. Tha

[GitHub] [hadoop] slfan1989 commented on pull request #4720: YARN-11247. Remove unused classes introduced by YARN-9615.

2022-09-14 Thread GitBox
slfan1989 commented on PR #4720: URL: https://github.com/apache/hadoop/pull/4720#issuecomment-1247629168 @ayushtkn Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [hadoop] slfan1989 commented on pull request #4687: YARN-10846. Add dispatcher metrics to NM.

2022-09-14 Thread GitBox
slfan1989 commented on PR #4687: URL: https://github.com/apache/hadoop/pull/4687#issuecomment-1247626915 @jojochuang Can you help review the code? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [hadoop] hadoop-yetus commented on pull request #4720: YARN-11247. Remove unused classes introduced by YARN-9615.

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4720: URL: https://github.com/apache/hadoop/pull/4720#issuecomment-1247613927 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4621: Hadoop 18319: ABFS: ABFS: Fix FileSystemAlreadyExists error for AzureAD or other internal errors

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4621: URL: https://github.com/apache/hadoop/pull/4621#issuecomment-1247608085 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-16769) LocalDirAllocator to provide diagnostics when file creation fails

2022-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605117#comment-17605117 ] ASF GitHub Bot commented on HADOOP-16769: - mehakmeet commented on code in PR #4

[GitHub] [hadoop] mehakmeet commented on a diff in pull request #4842: HADOOP-16769. LocalDirAllocator to provide diagnostics when file creation fails

2022-09-14 Thread GitBox
mehakmeet commented on code in PR #4842: URL: https://github.com/apache/hadoop/pull/4842#discussion_r971527514 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java: ## @@ -532,4 +533,19 @@ public void testGetLocalPathForWriteForInv

[GitHub] [hadoop] hadoop-yetus commented on pull request #4852: YARN-11293. [Federation] StoreNewMasterKey/removeStoredMasterKey With MemoryStateStore.

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4852: URL: https://github.com/apache/hadoop/pull/4852#issuecomment-1247588629 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18449) Upgrade hadolint to 2.10.0

2022-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605111#comment-17605111 ] ASF GitHub Bot commented on HADOOP-18449: - hadoop-yetus commented on PR #4876:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4876: HADOOP-18449. Upgrade hadolint to 2.10.0

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4876: URL: https://github.com/apache/hadoop/pull/4876#issuecomment-1247585071 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job

[GitHub] [hadoop] PrabhuJoseph commented on pull request #4884: YARN-11255. Support loading alternative docker client config from system environment

2022-09-14 Thread GitBox
PrabhuJoseph commented on PR #4884: URL: https://github.com/apache/hadoop/pull/4884#issuecomment-1247563160 Thanks @ashutoshcipher for the patch. Overall looks good to me except a minor one. Could you also document the steps to run an application like Spark using this new environmen

[GitHub] [hadoop] PrabhuJoseph commented on a diff in pull request #4884: YARN-11255. Support loading alternative docker client config from system environment

2022-09-14 Thread GitBox
PrabhuJoseph commented on code in PR #4884: URL: https://github.com/apache/hadoop/pull/4884#discussion_r971506094 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/D

[GitHub] [hadoop] hadoop-yetus commented on pull request #4851: YARN-11226. [Federation] Add createNewReservation, submitReservation, updateReservation, deleteReservation REST APIs for Router

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4851: URL: https://github.com/apache/hadoop/pull/4851#issuecomment-1247552465 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] ZanderXu opened a new pull request, #4890: HDFS-16772. refreshHostsReader should use the latest configuration

2022-09-14 Thread GitBox
ZanderXu opened a new pull request, #4890: URL: https://github.com/apache/hadoop/pull/4890 ### Description of PR `refreshHostsReader` should use the latest configuration and the related code as bellow: ``` /** Reread include/exclude files. */ private void refreshHostsReader(C

[GitHub] [hadoop] hadoop-yetus commented on pull request #4779: MAPREDUCE-7407. Avoid stopContainer() on dead node

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4779: URL: https://github.com/apache/hadoop/pull/4779#issuecomment-1247528017 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4779: MAPREDUCE-7407. Avoid stopContainer() on dead node

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4779: URL: https://github.com/apache/hadoop/pull/4779#issuecomment-1247524250 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4779: MAPREDUCE-7407. Avoid stopContainer() on dead node

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4779: URL: https://github.com/apache/hadoop/pull/4779#issuecomment-1247518973 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4882: HDFS-16771. JN should tersely print logs about NewerTxnIdException

2022-09-14 Thread GitBox
ZanderXu commented on code in PR #4882: URL: https://github.com/apache/hadoop/pull/4882#discussion_r971454489 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/QuorumJournalManager.java: ## @@ -524,9 +524,6 @@ public void selectInputStreams

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.

2022-09-14 Thread GitBox
slfan1989 commented on code in PR #4846: URL: https://github.com/apache/hadoop/pull/4846#discussion_r971434340 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/ZookeeperFederationStateStore.

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4779: MAPREDUCE-7407. Avoid stopContainer() on dead node

2022-09-14 Thread GitBox
ashutoshcipher commented on code in PR #4779: URL: https://github.com/apache/hadoop/pull/4779#discussion_r971432338 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/launcher/TestContainerLauncherImpl.java: #

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4852: YARN-11293. [Federation] StoreNewMasterKey/removeStoredMasterKey With MemoryStateStore.

2022-09-14 Thread GitBox
slfan1989 commented on code in PR #4852: URL: https://github.com/apache/hadoop/pull/4852#discussion_r971429570 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/records/RouterMasterKey.java: #

[GitHub] [hadoop] goiri commented on a diff in pull request #4779: MAPREDUCE-7407. Avoid stopContainer() on dead node

2022-09-14 Thread GitBox
goiri commented on code in PR #4779: URL: https://github.com/apache/hadoop/pull/4779#discussion_r971428466 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/launcher/TestContainerLauncherImpl.java: ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-14 Thread GitBox
slfan1989 commented on code in PR #4858: URL: https://github.com/apache/hadoop/pull/4858#discussion_r971426352 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/store/impl/HSQLDBFederationStateStore.jav

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4779: MAPREDUCE-7407. Avoid stopContainer() on dead node

2022-09-14 Thread GitBox
ashutoshcipher commented on code in PR #4779: URL: https://github.com/apache/hadoop/pull/4779#discussion_r971426239 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/launcher/ContainerLauncherImpl.java: #

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-14 Thread GitBox
slfan1989 commented on code in PR #4858: URL: https://github.com/apache/hadoop/pull/4858#discussion_r971425926 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/store/impl/HSQLDBFederationStateStore.jav

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-14 Thread GitBox
slfan1989 commented on code in PR #4858: URL: https://github.com/apache/hadoop/pull/4858#discussion_r971414849 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/store/impl/HSQLDBFederationStateStore.jav

[GitHub] [hadoop] goiri commented on a diff in pull request #4779: MAPREDUCE-7407. Avoid stopContainer() on dead node

2022-09-14 Thread GitBox
goiri commented on code in PR #4779: URL: https://github.com/apache/hadoop/pull/4779#discussion_r971373007 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/launcher/ContainerLauncherImpl.java: ## @@

[GitHub] [hadoop] omalley closed pull request #4127: HDFS-16767. RBF: Support observer node from Router-Based Federation

2022-09-14 Thread GitBox
omalley closed pull request #4127: HDFS-16767. RBF: Support observer node from Router-Based Federation URL: https://github.com/apache/hadoop/pull/4127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-14 Thread GitBox
slfan1989 commented on code in PR #4858: URL: https://github.com/apache/hadoop/pull/4858#discussion_r971358346 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/store/impl/HSQLDBFederationStateStore.jav

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-14 Thread GitBox
slfan1989 commented on code in PR #4858: URL: https://github.com/apache/hadoop/pull/4858#discussion_r971358259 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/store/impl/HSQLDBFederationStateStore.jav

[GitHub] [hadoop] xkrogen commented on a diff in pull request #4882: HDFS-16771. JN should tersely print logs about NewerTxnIdException

2022-09-14 Thread GitBox
xkrogen commented on code in PR #4882: URL: https://github.com/apache/hadoop/pull/4882#discussion_r971240283 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/QuorumJournalManager.java: ## @@ -524,9 +524,6 @@ public void selectInputStreams(

[jira] [Commented] (HADOOP-18446) Add a re-queue metric to RpcMetrics.java to quantify the number of re-queue RPCs

2022-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604944#comment-17604944 ] ASF GitHub Bot commented on HADOOP-18446: - xkrogen commented on code in PR #487

[GitHub] [hadoop] xkrogen commented on a diff in pull request #4871: HADOOP-18446. Add a re-queue metric to RpcMetrics.java to quantify the number of re-queue RPCs

2022-09-14 Thread GitBox
xkrogen commented on code in PR #4871: URL: https://github.com/apache/hadoop/pull/4871#discussion_r971234834 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java: ## @@ -344,6 +353,15 @@ public long getRpcSlowCalls() { return rp

[GitHub] [hadoop] hadoop-yetus commented on pull request #4852: YARN-11293. [Federation] StoreNewMasterKey/removeStoredMasterKey With MemoryStateStore.

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4852: URL: https://github.com/apache/hadoop/pull/4852#issuecomment-1247215147 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4846: URL: https://github.com/apache/hadoop/pull/4846#issuecomment-1247192785 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4779: MAPREDUCE-7407. Avoid stopContainer() on dead node

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4779: URL: https://github.com/apache/hadoop/pull/4779#issuecomment-1247184309 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18453) Fix typo: a os-native -> an os-native

2022-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604873#comment-17604873 ] ASF GitHub Bot commented on HADOOP-18453: - hadoop-yetus commented on PR #4889:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4889: HADOOP-18453. Fix typo: a os-native -> an os-native

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4889: URL: https://github.com/apache/hadoop/pull/4889#issuecomment-1247104140 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4779: MAPREDUCE-7407. Avoid stopContainer() on dead node

2022-09-14 Thread GitBox
ashutoshcipher commented on code in PR #4779: URL: https://github.com/apache/hadoop/pull/4779#discussion_r971099286 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/launcher/ContainerLauncherImpl.java: #

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4779: MAPREDUCE-7407. Avoid stopContainer() on dead node

2022-09-14 Thread GitBox
ashutoshcipher commented on code in PR #4779: URL: https://github.com/apache/hadoop/pull/4779#discussion_r971090194 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/launcher/ContainerLauncherImpl.java: #

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4779: MAPREDUCE-7407. Avoid stopContainer() on dead node

2022-09-14 Thread GitBox
ashutoshcipher commented on code in PR #4779: URL: https://github.com/apache/hadoop/pull/4779#discussion_r971081749 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/launcher/ContainerLauncherImpl.java: #

[jira] [Commented] (HADOOP-18118) Fix KMS Accept Queue Size default value to 500

2022-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604853#comment-17604853 ] ASF GitHub Bot commented on HADOOP-18118: - jojochuang merged PR #3972: URL: htt

[jira] [Resolved] (HADOOP-18118) Fix KMS Accept Queue Size default value to 500

2022-09-14 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang resolved HADOOP-18118. -- Fix Version/s: 3.4.0 Resolution: Fixed > Fix KMS Accept Queue Size default val

[GitHub] [hadoop] jojochuang merged pull request #3972: HADOOP-18118. Fix KMS Accept Queue Size default value to 500

2022-09-14 Thread GitBox
jojochuang merged PR #3972: URL: https://github.com/apache/hadoop/pull/3972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@ha

[jira] [Updated] (HADOOP-15072) Upgrade Apache Kerby version to 2.0.x

2022-09-14 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-15072: - Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade Apache Ker

[jira] [Commented] (HADOOP-15072) Upgrade Apache Kerby version to 2.0.x

2022-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604847#comment-17604847 ] ASF GitHub Bot commented on HADOOP-15072: - jojochuang merged PR #4473: URL: htt

[GitHub] [hadoop] jojochuang merged pull request #4473: HADOOP-15072 - Update Apache Kerby to 2.0.2

2022-09-14 Thread GitBox
jojochuang merged PR #4473: URL: https://github.com/apache/hadoop/pull/4473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@ha

[GitHub] [hadoop] goiri commented on a diff in pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-14 Thread GitBox
goiri commented on code in PR #4858: URL: https://github.com/apache/hadoop/pull/4858#discussion_r971047522 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/store/impl/HSQLDBFederationStateStore.java: #

[GitHub] [hadoop] goiri commented on a diff in pull request #4852: YARN-11293. [Federation] StoreNewMasterKey/removeStoredMasterKey With MemoryStateStore.

2022-09-14 Thread GitBox
goiri commented on code in PR #4852: URL: https://github.com/apache/hadoop/pull/4852#discussion_r971043197 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/records/RouterMasterKey.java: #

[GitHub] [hadoop] goiri commented on a diff in pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.

2022-09-14 Thread GitBox
goiri commented on code in PR #4846: URL: https://github.com/apache/hadoop/pull/4846#discussion_r971038757 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/ZookeeperFederationStateStore.java

[jira] [Resolved] (HADOOP-18452) Fix TestKMS#testKMSHAZooKeeperDelegationToken Failed By Hadoop-18427

2022-09-14 Thread Jira
[ https://issues.apache.org/jira/browse/HADOOP-18452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Íñigo Goiri resolved HADOOP-18452. -- Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed > Fix TestKMS#testK

[jira] [Commented] (HADOOP-18452) Fix TestKMS#testKMSHAZooKeeperDelegationToken Failed By Hadoop-18427

2022-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604820#comment-17604820 ] ASF GitHub Bot commented on HADOOP-18452: - goiri merged PR #4885: URL: https://

[GitHub] [hadoop] goiri merged pull request #4885: HADOOP-18452. Fix TestKMS#testKMSHAZooKeeperDelegationToken Failed By Hadoop-18427.

2022-09-14 Thread GitBox
goiri merged PR #4885: URL: https://github.com/apache/hadoop/pull/4885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.

[GitHub] [hadoop] goiri commented on a diff in pull request #4779: MAPREDUCE-7407. Avoid stopContainer() on dead node

2022-09-14 Thread GitBox
goiri commented on code in PR #4779: URL: https://github.com/apache/hadoop/pull/4779#discussion_r971031212 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/launcher/ContainerLauncherImpl.java: ## @@

[GitHub] [hadoop] hadoop-yetus commented on pull request #4888: HDFS-16757. Add a new method copyBlockCrossNamespace to DataNode

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4888: URL: https://github.com/apache/hadoop/pull/4888#issuecomment-1246873645 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Updated] (HADOOP-18453) Fix typo: a os-native -> an os-native

2022-09-14 Thread Seokchan Yoon (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seokchan Yoon updated HADOOP-18453: --- Description: There is a comment in FileUtil.java: >  Convert a os-native filename to a pat

[jira] [Updated] (HADOOP-18453) Fix typo: a os-native -> an os-native

2022-09-14 Thread Seokchan Yoon (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seokchan Yoon updated HADOOP-18453: --- External issue URL: https://github.com/apache/hadoop/pull/4889 > Fix typo: a os-native -> a

[jira] [Commented] (HADOOP-18453) Fix typo: a os-native -> an os-native

2022-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604689#comment-17604689 ] ASF GitHub Bot commented on HADOOP-18453: - yoonsch217 opened a new pull request

[jira] [Updated] (HADOOP-18453) Fix typo: a os-native -> an os-native

2022-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18453: Labels: pull-request-available (was: ) > Fix typo: a os-native -> an os-native > ---

[GitHub] [hadoop] yoonsch217 opened a new pull request, #4889: HADOOP-18453. Fix typo: a os-native -> an os-native

2022-09-14 Thread GitBox
yoonsch217 opened a new pull request, #4889: URL: https://github.com/apache/hadoop/pull/4889 ### Description of PR There is a comment in FileUtil.java: > Convert a os-native filename to a path that works for the shell. That "a os-native" should be "an os-native".

[jira] [Commented] (HADOOP-18451) Update hsqldb.version from 2.3.4 to 2.5.2

2022-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604682#comment-17604682 ] ASF GitHub Bot commented on HADOOP-18451: - hadoop-yetus commented on PR #4880:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4880: HADOOP-18451. Update hsqldb.version from 2.3.4 to 2.5.2.

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4880: URL: https://github.com/apache/hadoop/pull/4880#issuecomment-1246775630 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Updated] (HADOOP-18453) Fix typo: a os-native -> an os-native

2022-09-14 Thread Seokchan Yoon (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seokchan Yoon updated HADOOP-18453: --- Summary: Fix typo: a os-native -> an os-native (was: Fix typo of comments in FileUtil.java

[jira] [Updated] (HADOOP-18453) Fix typo of comments in FileUtil.java

2022-09-14 Thread Seokchan Yoon (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seokchan Yoon updated HADOOP-18453: --- Description: There is a comment in FileUtil.java: >  Convert a os-native filename to a pat

[jira] [Created] (HADOOP-18453) Fix typo of comments in FileUtil.java

2022-09-14 Thread Seokchan Yoon (Jira)
Seokchan Yoon created HADOOP-18453: -- Summary: Fix typo of comments in FileUtil.java Key: HADOOP-18453 URL: https://issues.apache.org/jira/browse/HADOOP-18453 Project: Hadoop Common Issue Typ

[GitHub] [hadoop] prasad-acit commented on pull request #4881: HDFS-16770. [Documentation] RBF: Duplicate statement to be removed for better readability.

2022-09-14 Thread GitBox
prasad-acit commented on PR #4881: URL: https://github.com/apache/hadoop/pull/4881#issuecomment-1246741083 Thanks @goiri for quick review & merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (HADOOP-18449) Upgrade hadolint to 2.10.0

2022-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604051#comment-17604051 ] ASF GitHub Bot commented on HADOOP-18449: - hadoop-yetus commented on PR #4876:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4876: HADOOP-18449. Upgrade hadolint to 2.10.0

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4876: URL: https://github.com/apache/hadoop/pull/4876#issuecomment-1246667165 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4851: YARN-11226. [Federation] Add createNewReservation, submitReservation, updateReservation, deleteReservation REST APIs for Router

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4851: URL: https://github.com/apache/hadoop/pull/4851#issuecomment-1246632962 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4851: YARN-11226. [Federation] Add createNewReservation, submitReservation, updateReservation, deleteReservation REST APIs for Router

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4851: URL: https://github.com/apache/hadoop/pull/4851#issuecomment-1246625513 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-16769) LocalDirAllocator to provide diagnostics when file creation fails

2022-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604027#comment-17604027 ] ASF GitHub Bot commented on HADOOP-16769: - hadoop-yetus commented on PR #4842:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4842: HADOOP-16769. LocalDirAllocator to provide diagnostics when file creation fails

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4842: URL: https://github.com/apache/hadoop/pull/4842#issuecomment-1246620046 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4858: URL: https://github.com/apache/hadoop/pull/4858#issuecomment-1246562711 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4858: URL: https://github.com/apache/hadoop/pull/4858#issuecomment-1246560423 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] ZanderXu opened a new pull request, #4888: HDFS-16757. Add a new method copyBlockCrossNamespace to DataNode

2022-09-14 Thread GitBox
ZanderXu opened a new pull request, #4888: URL: https://github.com/apache/hadoop/pull/4888 ### Description of PR Add a new method copyBlockCrossNamespace to Datanode to support fast copy. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [hadoop] hadoop-yetus commented on pull request #4851: YARN-11226. [Federation] Add createNewReservation, submitReservation, updateReservation, deleteReservation REST APIs for Router

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4851: URL: https://github.com/apache/hadoop/pull/4851#issuecomment-1246507991 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4887: YARN-11304. Upgrade nodemanager's exception log level.

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4887: URL: https://github.com/apache/hadoop/pull/4887#issuecomment-1246453874 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4127: HDFS-16767. RBF: Support observer node from Router-Based Federation

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4127: URL: https://github.com/apache/hadoop/pull/4127#issuecomment-1246402899 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-16769) LocalDirAllocator to provide diagnostics when file creation fails

2022-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603929#comment-17603929 ] ASF GitHub Bot commented on HADOOP-16769: - ashutoshcipher commented on code in

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4842: HADOOP-16769. LocalDirAllocator to provide diagnostics when file creation fails

2022-09-14 Thread GitBox
ashutoshcipher commented on code in PR #4842: URL: https://github.com/apache/hadoop/pull/4842#discussion_r970425076 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java: ## @@ -396,6 +396,9 @@ public Path getLocalPathForWrite(String pa

[jira] [Commented] (HADOOP-18452) Fix TestKMS#testKMSHAZooKeeperDelegationToken Failed By Hadoop-18427

2022-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603924#comment-17603924 ] ASF GitHub Bot commented on HADOOP-18452: - hadoop-yetus commented on PR #4885:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4885: HADOOP-18452. Fix TestKMS#testKMSHAZooKeeperDelegationToken Failed By Hadoop-18427.

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4885: URL: https://github.com/apache/hadoop/pull/4885#issuecomment-1246350906 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4127: HDFS-16767. RBF: Support observer node from Router-Based Federation

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4127: URL: https://github.com/apache/hadoop/pull/4127#issuecomment-1246349274 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4127: HDFS-16767. RBF: Support observer node from Router-Based Federation

2022-09-14 Thread GitBox
hadoop-yetus commented on PR #4127: URL: https://github.com/apache/hadoop/pull/4127#issuecomment-1246347563 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-16769) LocalDirAllocator to provide diagnostics when file creation fails

2022-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603919#comment-17603919 ] ASF GitHub Bot commented on HADOOP-16769: - ashutoshcipher commented on code in

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4842: HADOOP-16769. LocalDirAllocator to provide diagnostics when file creation fails

2022-09-14 Thread GitBox
ashutoshcipher commented on code in PR #4842: URL: https://github.com/apache/hadoop/pull/4842#discussion_r970413854 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java: ## @@ -532,4 +533,19 @@ public void testGetLocalPathForWriteF