[GitHub] [hadoop] hadoop-yetus commented on pull request #5312: YARN-11375. [Federation] Support refreshAdminAcls、refreshServiceAcls API's for Federation.

2023-01-18 Thread GitBox
hadoop-yetus commented on PR #5312: URL: https://github.com/apache/hadoop/pull/5312#issuecomment-1396500494 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678497#comment-17678497 ] ASF GitHub Bot commented on HADOOP-18206: - slfan1989 commented on PR #5315: URL:

[GitHub] [hadoop] slfan1989 commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-18 Thread GitBox
slfan1989 commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1396473352 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-18 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206 ] Viraj Jasani deleted comment on HADOOP-18206: --- was (Author: vjasani): I can make sure we get full build test results for all modules on the PR. > Cleanup the commons-logging references

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-18 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678494#comment-17678494 ] Viraj Jasani commented on HADOOP-18206: --- Raised PR with all module changes for now

[jira] [Updated] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18206: Labels: pull-request-available (was: ) > Cleanup the commons-logging references in the

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678490#comment-17678490 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani opened a new pull request, #5315: URL:

[GitHub] [hadoop] virajjasani opened a new pull request, #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-18 Thread GitBox
virajjasani opened a new pull request, #5315: URL: https://github.com/apache/hadoop/pull/5315 Sub-task of HADOOP-16206 (Migrate from Log4j1 to Log4j2) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop] hadoop-yetus commented on pull request #5309: YARN-11419. Remove redundant exception capture in NMClientAsyncImpl and improve readability in ContainerShellWebSocket, etc

2023-01-18 Thread GitBox
hadoop-yetus commented on PR #5309: URL: https://github.com/apache/hadoop/pull/5309#issuecomment-1396450495 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-18 Thread Pranav Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678488#comment-17678488 ] Pranav Saxena commented on HADOOP-17912: Hi [~ste...@apache.org], requesting you to kindly

[GitHub] [hadoop] krishan1390 opened a new pull request, #5314: Yarn-11411 Concurrent user management

2023-01-18 Thread GitBox
krishan1390 opened a new pull request, #5314: URL: https://github.com/apache/hadoop/pull/5314 JIRA: [YARN-11411](https://issues.apache.org/jira/browse/YARN-11411). Create a Concurrent Users Manager to enable thread safe concurrent resource usage tracking of user Low level

[GitHub] [hadoop] krishan1390 opened a new pull request, #5313: YARN-11411 Encapsulating certain User Manager APIs by making it private

2023-01-18 Thread GitBox
krishan1390 opened a new pull request, #5313: URL: https://github.com/apache/hadoop/pull/5313 As part of https://issues.apache.org/jira/browse/YARN-11412 to build a concurrent users manager, I am planning to isolate user management into a package and limit its public APIs. This will help

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-18 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678482#comment-17678482 ] Viraj Jasani commented on HADOOP-18206: --- I can make sure we get full build test results for all

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-18 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678481#comment-17678481 ] Viraj Jasani commented on HADOOP-18206: --- I have the local patch ready for review, however now

[GitHub] [hadoop] mccormickt12 commented on pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-01-18 Thread GitBox
mccormickt12 commented on PR #4967: URL: https://github.com/apache/hadoop/pull/4967#issuecomment-1396405881 @steveloughran as I commented before, I added all the contract tests I could find that made sense. Some level of functionality couldn't practically be tested in the contract tests

[GitHub] [hadoop] hadoop-yetus commented on pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-01-18 Thread GitBox
hadoop-yetus commented on PR #4967: URL: https://github.com/apache/hadoop/pull/4967#issuecomment-1396401494 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 opened a new pull request, #5312: YARN-11375. [Federation] Support refreshAdminAcls、refreshServiceAcls API's for Federation.

2023-01-18 Thread GitBox
slfan1989 opened a new pull request, #5312: URL: https://github.com/apache/hadoop/pull/5312 JIRA: YARN-11375. [Federation] Support refreshAdminAcls、refreshServiceAcls API's for Federation. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hadoop] smallzhongfeng commented on a diff in pull request #5309: YARN-11419. Remove redundant exception capture in NMClientAsyncImpl and improve readability in ContainerShellWebSocket, etc

2023-01-18 Thread GitBox
smallzhongfeng commented on code in PR #5309: URL: https://github.com/apache/hadoop/pull/5309#discussion_r1080761997 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/SharedCacheClientImpl.java: ## @@ -158,14 +158,8 @@

[GitHub] [hadoop] zhtttylz commented on pull request #5303: HDFS-16893. Standardize the usage of DFSClient debug log

2023-01-18 Thread GitBox
zhtttylz commented on PR #5303: URL: https://github.com/apache/hadoop/pull/5303#issuecomment-1396375768 Thanks @ayushtkn @slfan1989 help review and merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop] hadoop-yetus commented on pull request #5298: HDFS-16890: RBF: Ensures router periodically refreshes its record of a namespace's state.

2023-01-18 Thread GitBox
hadoop-yetus commented on PR #5298: URL: https://github.com/apache/hadoop/pull/5298#issuecomment-1396369913 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #5303: HDFS-16893. Standardize the usage of DFSClient debug log

2023-01-18 Thread GitBox
slfan1989 commented on PR #5303: URL: https://github.com/apache/hadoop/pull/5303#issuecomment-1396248393 @zhtttylz, thank you for contributing this improvement. @ayushtkn, thank you for the help with code review. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop] slfan1989 merged pull request #5303: HDFS-16893. Standardize the usage of DFSClient debug log

2023-01-18 Thread GitBox
slfan1989 merged PR #5303: URL: https://github.com/apache/hadoop/pull/5303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5298: HDFS-16890: RBF: Ensures router periodically refreshes its record of a namespace's state.

2023-01-18 Thread GitBox
hadoop-yetus commented on PR #5298: URL: https://github.com/apache/hadoop/pull/5298#issuecomment-1396241879 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5309: YARN-11419. Remove redundant exception capture in NMClientAsyncImpl and improve readability in ContainerShellWebSocket, etc

2023-01-18 Thread GitBox
slfan1989 commented on code in PR #5309: URL: https://github.com/apache/hadoop/pull/5309#discussion_r1080674836 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/SharedCacheClientImpl.java: ## @@ -158,14 +158,8 @@ public

[GitHub] [hadoop] slfan1989 commented on pull request #5309: YARN-11419. Remove redundant exception capture in NMClientAsyncImpl and improve readability in ContainerShellWebSocket, etc

2023-01-18 Thread GitBox
slfan1989 commented on PR #5309: URL: https://github.com/apache/hadoop/pull/5309#issuecomment-1396240445 @smallzhongfeng Thank you very much for your contribution, We need to fix checkstyle -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5298: HDFS-16890: RBF: Ensures router periodically refreshes its record of a namespace's state.

2023-01-18 Thread GitBox
simbadzina commented on code in PR #5298: URL: https://github.com/apache/hadoop/pull/5298#discussion_r1080612475 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestObserverWithRouter.java: ## @@ -639,4 +643,36 @@ public void

[GitHub] [hadoop] cnauroth commented on pull request #5300: HDFS-16891 Avoid the overhead of copy-on-write exception list while loading inodes sub sections in parallel

2023-01-18 Thread GitBox
cnauroth commented on PR #5300: URL: https://github.com/apache/hadoop/pull/5300#issuecomment-1396142728 I have committed this to trunk and branch-3.3. I did not commit to branch-3.2, because the original HDFS-14617 changes for parallel fsimage loading are not present in branch-3.2.

[GitHub] [hadoop] cnauroth merged pull request #5300: HDFS-16891 Avoid the overhead of copy-on-write exception list while loading inodes sub sections in parallel

2023-01-18 Thread GitBox
cnauroth merged PR #5300: URL: https://github.com/apache/hadoop/pull/5300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5119: YARN-5607. Document TestContainerResourceUsage#waitForContainerCompletion

2023-01-18 Thread GitBox
hadoop-yetus commented on PR #5119: URL: https://github.com/apache/hadoop/pull/5119#issuecomment-1387717617 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Moved] (HADOOP-18599) Expose `listStatus(Path path, String startFrom)` on `AzureBlobFileSystem`

2023-01-18 Thread Chris Nauroth (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Nauroth moved HDFS-16894 to HADOOP-18599: --- Component/s: fs/azure (was:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5311: MAPREDUCE-7431. ShuffleHandler refactor and fix after Netty4 upgrade.

2023-01-18 Thread GitBox
hadoop-yetus commented on PR #5311: URL: https://github.com/apache/hadoop/pull/5311#issuecomment-1387533352 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5311: MAPREDUCE-7431. ShuffleHandler refactor and fix after Netty4 upgrade.

2023-01-18 Thread GitBox
hadoop-yetus commented on PR #5311: URL: https://github.com/apache/hadoop/pull/5311#issuecomment-1387525353 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5309: YARN-11419. Remove redundant exception capture in NMClientAsyncImpl and improve readability in ContainerShellWebSocket, etc

2023-01-18 Thread GitBox
hadoop-yetus commented on PR #5309: URL: https://github.com/apache/hadoop/pull/5309#issuecomment-1387445181 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] smallzhongfeng commented on pull request #5309: YARN-11419. Remove redundant exception capture in NMClientAsyncImpl and improve readability in ContainerShellWebSocket, etc

2023-01-18 Thread GitBox
smallzhongfeng commented on PR #5309: URL: https://github.com/apache/hadoop/pull/5309#issuecomment-1387422823 > Hi @smallzhongfeng , > > Could you be more specific with the title of PR / jira about what are you improving / cleaning up? Class name should be in it at least.

[GitHub] [hadoop] tomicooler opened a new pull request, #5311: MAPREDUCE-7431. ShuffleHandler refactor and fix after Netty4 upgrade.

2023-01-18 Thread GitBox
tomicooler opened a new pull request, #5311: URL: https://github.com/apache/hadoop/pull/5311 Change-Id: Ifedad2fae1ddd8f22623b5d44875b20a3b3fd318 ### Description of PR Work in Progress. No review is needed yet, I'll update when I'm ready with my manual end-to-end tests.

[GitHub] [hadoop] hadoop-yetus commented on pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-01-18 Thread GitBox
hadoop-yetus commented on PR #4967: URL: https://github.com/apache/hadoop/pull/4967#issuecomment-1387341443 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2023-01-18 Thread Ahmar Suhail (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678308#comment-17678308 ] Ahmar Suhail commented on HADOOP-18073: --- [~ste...@apache.org] / [~mthakur] , have just rebased my

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678305#comment-17678305 ] ASF GitHub Bot commented on HADOOP-18073: - hadoop-yetus commented on PR #5163: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5163: HADOOP-18073. Upgrade AWS SDK to v2 in S3A [work in progress]

2023-01-18 Thread GitBox
hadoop-yetus commented on PR #5163: URL: https://github.com/apache/hadoop/pull/5163#issuecomment-1387306117 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] szilard-nemeth commented on pull request #5309: YARN-11419. Simplify code and improve readability

2023-01-18 Thread GitBox
szilard-nemeth commented on PR #5309: URL: https://github.com/apache/hadoop/pull/5309#issuecomment-1387259387 Hi @smallzhongfeng , Could you be more specific with the title of PR / jira about what are you improving / cleaning up? Class name should be in it at least. -- This is an

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure

2023-01-18 Thread GitBox
p-szucs commented on code in PR #5295: URL: https://github.com/apache/hadoop/pull/5295#discussion_r1073624151 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestMapReduceChildJVM.java: ##

[jira] [Commented] (HADOOP-17717) Update wildfly openssl to 1.1.3.Final

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678276#comment-17678276 ] ASF GitHub Bot commented on HADOOP-17717: - steveloughran commented on PR #5310: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5310: HADOOP-17717. Update wildfly openssl to 1.1.3.Final

2023-01-18 Thread GitBox
steveloughran commented on PR #5310: URL: https://github.com/apache/hadoop/pull/5310#issuecomment-1387208196 hadoop-aws : london, hadoop-azure: cardiff, (non scale tests) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (HADOOP-18235) vulnerability: we may leak sensitive information in LocalKeyStoreProvider

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678275#comment-17678275 ] ASF GitHub Bot commented on HADOOP-18235: - steveloughran commented on PR #4998: URL:

[GitHub] [hadoop] steveloughran commented on pull request #4998: HADOOP-18235. vulnerability: we may leak sensitive information in LocalKeyStoreProvider

2023-01-18 Thread GitBox
steveloughran commented on PR #4998: URL: https://github.com/apache/hadoop/pull/4998#issuecomment-1387207281 where are we with this patch? can/should we get it into 3.3.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (HADOOP-18598) maven site generation doesn't include javadocs

2023-01-18 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678274#comment-17678274 ] Steve Loughran commented on HADOOP-18598: - mvn site on trunk {code} [INFO] Generating "Javadoc"

[jira] [Created] (HADOOP-18598) maven site generation doesn't include javadocs

2023-01-18 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-18598: --- Summary: maven site generation doesn't include javadocs Key: HADOOP-18598 URL: https://issues.apache.org/jira/browse/HADOOP-18598 Project: Hadoop Common

[GitHub] [hadoop] hadoop-yetus commented on pull request #5299: Add reason in in x-ms-client-request-id on a retry API call.

2023-01-18 Thread GitBox
hadoop-yetus commented on PR #5299: URL: https://github.com/apache/hadoop/pull/5299#issuecomment-1387199182 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5309: YARN-11419. Simplify code and improve readability

2023-01-18 Thread GitBox
hadoop-yetus commented on PR #5309: URL: https://github.com/apache/hadoop/pull/5309#issuecomment-1387193380 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678261#comment-17678261 ] ASF GitHub Bot commented on HADOOP-18073: - hadoop-yetus commented on PR #5163: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5163: HADOOP-18073. Upgrade AWS SDK to v2 in S3A [work in progress]

2023-01-18 Thread GitBox
hadoop-yetus commented on PR #5163: URL: https://github.com/apache/hadoop/pull/5163#issuecomment-1387164859 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-17717) Update wildfly openssl to 1.1.3.Final

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678257#comment-17678257 ] ASF GitHub Bot commented on HADOOP-17717: - steveloughran commented on PR #3029: URL:

[GitHub] [hadoop] steveloughran commented on pull request #3029: HADOOP-17717. Update wildfly openssl to 1.1.3.Final.

2023-01-18 Thread GitBox
steveloughran commented on PR #3029: URL: https://github.com/apache/hadoop/pull/3029#issuecomment-1387155768 rebased into #5310 and targeting 3.3.5 so as to tick off another CVE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (HADOOP-17717) Update wildfly openssl to 1.1.3.Final

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678255#comment-17678255 ] ASF GitHub Bot commented on HADOOP-17717: - steveloughran commented on PR #5310: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5310: HADOOP-17717. Update wildfly openssl to 1.1.3.Final

2023-01-18 Thread GitBox
steveloughran commented on PR #5310: URL: https://github.com/apache/hadoop/pull/5310#issuecomment-1387155021 s3 and azure tests in progress -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] hadoop-yetus commented on pull request #5302: YARN-11221. [Federation] Add replaceLabelsOnNodes, replaceLabelsOnNode REST APIs for Router.

2023-01-18 Thread GitBox
hadoop-yetus commented on PR #5302: URL: https://github.com/apache/hadoop/pull/5302#issuecomment-1387107056 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5284: YARN-11218. [Federation] Add getActivities, getBulkActivities REST APIs for Router.

2023-01-18 Thread GitBox
hadoop-yetus commented on PR #5284: URL: https://github.com/apache/hadoop/pull/5284#issuecomment-1387102811 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-17717) Update wildfly openssl to 1.1.3.Final

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678230#comment-17678230 ] ASF GitHub Bot commented on HADOOP-17717: - steveloughran commented on PR #3029: URL:

[GitHub] [hadoop] steveloughran commented on pull request #3029: HADOOP-17717. Update wildfly openssl to 1.1.3.Final.

2023-01-18 Thread GitBox
steveloughran commented on PR #3029: URL: https://github.com/apache/hadoop/pull/3029#issuecomment-1387074660 rebasing for 3.3.5 with testing, as there is a CVE related to the one we ship. this is lower risk than for the 2.2 upgrade -- This is an automated message from the Apache Git

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5299: Add reason in in x-ms-client-request-id on a retry API call.

2023-01-18 Thread GitBox
anmolanmol1234 commented on code in PR #5299: URL: https://github.com/apache/hadoop/pull/5299#discussion_r1073406497 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsRestOperation.java: ## @@ -0,0 +1,289 @@ +/** + * Licensed to the

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5299: Add reason in in x-ms-client-request-id on a retry API call.

2023-01-18 Thread GitBox
anmolanmol1234 commented on code in PR #5299: URL: https://github.com/apache/hadoop/pull/5299#discussion_r1073397140 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/RetryReason.java: ## @@ -0,0 +1,176 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (HADOOP-18596) Distcp -update between different cloud stores to use modification time while checking for file skip.

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678223#comment-17678223 ] ASF GitHub Bot commented on HADOOP-18596: - hadoop-yetus commented on PR #5308: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5308: HADOOP-18596. Distcp -update to use modification time while checking for file skip.

2023-01-18 Thread GitBox
hadoop-yetus commented on PR #5308: URL: https://github.com/apache/hadoop/pull/5308#issuecomment-1387042961 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] K0K0V0K commented on pull request #5113: YARN-6971 Clean up different ways to create resources

2023-01-18 Thread GitBox
K0K0V0K commented on PR #5113: URL: https://github.com/apache/hadoop/pull/5113#issuecomment-1387023751 +1, non-binding -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] K0K0V0K commented on a diff in pull request #5119: YARN-5607. Document TestContainerResourceUsage#waitForContainerCompletion

2023-01-18 Thread GitBox
K0K0V0K commented on code in PR #5119: URL: https://github.com/apache/hadoop/pull/5119#discussion_r1073495681 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java: ## @@

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #5299: Add reason in in x-ms-client-request-id on a retry API call.

2023-01-18 Thread GitBox
pranavsaxena-microsoft commented on code in PR #5299: URL: https://github.com/apache/hadoop/pull/5299#discussion_r1073493065 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsRestOperation.java: ## @@ -0,0 +1,289 @@ +/** + * Licensed to

[GitHub] [hadoop] K0K0V0K commented on pull request #5113: YARN-6971 Clean up different ways to create resources

2023-01-18 Thread GitBox
K0K0V0K commented on PR #5113: URL: https://github.com/apache/hadoop/pull/5113#issuecomment-1387009885 Thanks @riyakhdl for the contribution, this looks good to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] smallzhongfeng opened a new pull request, #5309: YARN-11419 Simplify code and improve readability

2023-01-18 Thread GitBox
smallzhongfeng opened a new pull request, #5309: URL: https://github.com/apache/hadoop/pull/5309 ### Description of PR 1. Remove `YarnException` and `IOException`, because they are all subclasses of `Throwable`. 2. Use `try-resource`. 3. A non-empty string should be on the

[GitHub] [hadoop] hadoop-yetus commented on pull request #5260: YARN-8900. [Follow Up] Fix FederationInterceptorREST#invokeConcurrent Inaccurate Order of Subclusters.

2023-01-18 Thread GitBox
hadoop-yetus commented on PR #5260: URL: https://github.com/apache/hadoop/pull/5260#issuecomment-1386984201 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18541) Upgrade grizzly version to 2.4.4

2023-01-18 Thread Rohit Kumar Badeau (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678214#comment-17678214 ] Rohit Kumar Badeau commented on HADOOP-18541: - [~dmmkr] , can we try to upgrade it to 4.0.0

[jira] [Commented] (HADOOP-18596) Distcp -update between different cloud stores to use modification time while checking for file skip.

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678206#comment-17678206 ] ASF GitHub Bot commented on HADOOP-18596: - mehakmeet commented on PR #5308: URL:

[GitHub] [hadoop] mehakmeet commented on pull request #5308: HADOOP-18596. Distcp -update to use modification time while checking for file skip.

2023-01-18 Thread GitBox
mehakmeet commented on PR #5308: URL: https://github.com/apache/hadoop/pull/5308#issuecomment-1386942938 CC: @steveloughran @mukund-thakur -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] hadoop-yetus commented on pull request #5272: YARN-11217. [Federation] Add dumpSchedulerLogs REST APIs for Router.

2023-01-18 Thread GitBox
hadoop-yetus commented on PR #5272: URL: https://github.com/apache/hadoop/pull/5272#issuecomment-1386932822 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18329) Add support for IBM Semeru OE JRE 11.0.15.0 and greater

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678198#comment-17678198 ] ASF GitHub Bot commented on HADOOP-18329: - steveloughran commented on PR #4537: URL:

[GitHub] [hadoop] steveloughran commented on pull request #4537: HADOOP-18329 - Support for IBM Semeru JVM v>11.0.15.0 Vendor Name Changes

2023-01-18 Thread GitBox
steveloughran commented on PR #4537: URL: https://github.com/apache/hadoop/pull/4537#issuecomment-1386898828 maybe start with logging that java.vendor sysprop at debug. reopened the JIRA -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Reopened] (HADOOP-18329) Add support for IBM Semeru OE JRE 11.0.15.0 and greater

2023-01-18 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reopened HADOOP-18329: - > Add support for IBM Semeru OE JRE 11.0.15.0 and greater >

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-18 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678196#comment-17678196 ] Steve Loughran commented on HADOOP-18206: - removing commons-logging has my support -we do need

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5299: Add reason in in x-ms-client-request-id on a retry API call.

2023-01-18 Thread GitBox
anmolanmol1234 commented on code in PR #5299: URL: https://github.com/apache/hadoop/pull/5299#discussion_r1073406497 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsRestOperation.java: ## @@ -0,0 +1,289 @@ +/** + * Licensed to the

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5299: Add reason in in x-ms-client-request-id on a retry API call.

2023-01-18 Thread GitBox
anmolanmol1234 commented on code in PR #5299: URL: https://github.com/apache/hadoop/pull/5299#discussion_r1073404476 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsRestOperation.java: ## @@ -0,0 +1,289 @@ +/** + * Licensed to the

[jira] [Updated] (HADOOP-18597) Simplify single node instructions for creating directories for Map Reduce

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18597: Labels: pull-request-available (was: ) > Simplify single node instructions for creating

[jira] [Commented] (HADOOP-18597) Simplify single node instructions for creating directories for Map Reduce

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678193#comment-17678193 ] ASF GitHub Bot commented on HADOOP-18597: - hadoop-yetus commented on PR #5305: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5305: HADOOP-18597 Simplify the single node setup instructions

2023-01-18 Thread GitBox
hadoop-yetus commented on PR #5305: URL: https://github.com/apache/hadoop/pull/5305#issuecomment-1386877318 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5299: Add reason in in x-ms-client-request-id on a retry API call.

2023-01-18 Thread GitBox
anmolanmol1234 commented on code in PR #5299: URL: https://github.com/apache/hadoop/pull/5299#discussion_r1073397140 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/RetryReason.java: ## @@ -0,0 +1,176 @@ +/** + * Licensed to the Apache Software

[jira] [Updated] (HADOOP-18597) Simplify single node instructions for creating directories for Map Reduce

2023-01-18 Thread Nikita Eshkeev (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikita Eshkeev updated HADOOP-18597: Summary: Simplify single node instructions for creating directories for Map Reduce

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5260: YARN-8900. [Follow Up] Fix FederationInterceptorREST#invokeConcurrent Inaccurate Order of Subclusters.

2023-01-18 Thread GitBox
slfan1989 commented on code in PR #5260: URL: https://github.com/apache/hadoop/pull/5260#discussion_r1073381491 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java:

[jira] [Updated] (HADOOP-18596) Distcp -update between different cloud stores to use modification time while checking for file skip.

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18596: Labels: pull-request-available (was: ) > Distcp -update between different cloud stores

[jira] [Commented] (HADOOP-18596) Distcp -update between different cloud stores to use modification time while checking for file skip.

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678178#comment-17678178 ] ASF GitHub Bot commented on HADOOP-18596: - mehakmeet opened a new pull request, #5308: URL:

[GitHub] [hadoop] mehakmeet opened a new pull request, #5308: HADOOP-18596. Distcp -update to use modification time while checking for file skip.

2023-01-18 Thread GitBox
mehakmeet opened a new pull request, #5308: URL: https://github.com/apache/hadoop/pull/5308 ### Description of PR Using modification time as a way to add more checks to determine if distcp -update should skip a file or not. In specific cases like the same file name, and size but

[GitHub] [hadoop] hadoop-yetus commented on pull request #5113: YARN-6971 Clean up different ways to create resources

2023-01-18 Thread GitBox
hadoop-yetus commented on PR #5113: URL: https://github.com/apache/hadoop/pull/5113#issuecomment-1386820383 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5284: YARN-11218. [Federation] Add getActivities, getBulkActivities REST APIs for Router.

2023-01-18 Thread GitBox
slfan1989 commented on code in PR #5284: URL: https://github.com/apache/hadoop/pull/5284#discussion_r1073320328 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/TestFederationInterceptorREST.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5302: YARN-11221. [Federation] Add replaceLabelsOnNodes, replaceLabelsOnNode REST APIs for Router.

2023-01-18 Thread GitBox
slfan1989 commented on code in PR #5302: URL: https://github.com/apache/hadoop/pull/5302#discussion_r1073300128 ##

[jira] [Commented] (HADOOP-18146) ABFS: Add changes for expect hundred continue header with append requests

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678166#comment-17678166 ] ASF GitHub Bot commented on HADOOP-18146: - anmolanmol1234 commented on PR #4039: URL:

[GitHub] [hadoop] anmolanmol1234 commented on pull request #4039: HADOOP-18146: ABFS: Added changes for expect hundred continue header

2023-01-18 Thread GitBox
anmolanmol1234 commented on PR #4039: URL: https://github.com/apache/hadoop/pull/4039#issuecomment-1386770445 > @steveloughran, I have addressed all the comments and added tests for the different failure scenarios as well. Requesting your review for the same. Thanks. -- This is an

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5302: YARN-11221. [Federation] Add replaceLabelsOnNodes, replaceLabelsOnNode REST APIs for Router.

2023-01-18 Thread GitBox
slfan1989 commented on code in PR #5302: URL: https://github.com/apache/hadoop/pull/5302#discussion_r1073307072 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5302: YARN-11221. [Federation] Add replaceLabelsOnNodes, replaceLabelsOnNode REST APIs for Router.

2023-01-18 Thread GitBox
slfan1989 commented on code in PR #5302: URL: https://github.com/apache/hadoop/pull/5302#discussion_r1073300128 ##

[jira] [Updated] (HADOOP-18597) Simplify single nice instructions for creating directories for Map Reduce

2023-01-18 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena updated HADOOP-18597: -- Fix Version/s: (was: 3.3.5) > Simplify single nice instructions for creating directories

[jira] [Created] (HADOOP-18597) Simplify single nice instructions for creating directories for Map Reduce

2023-01-18 Thread Nikita Eshkeev (Jira)
Nikita Eshkeev created HADOOP-18597: --- Summary: Simplify single nice instructions for creating directories for Map Reduce Key: HADOOP-18597 URL: https://issues.apache.org/jira/browse/HADOOP-18597

[GitHub] [hadoop] ayushtkn commented on pull request #5305: Simplify the single node setup instructions

2023-01-18 Thread GitBox
ayushtkn commented on PR #5305: URL: https://github.com/apache/hadoop/pull/5305#issuecomment-1386653344 @neshkeev you should have sent it to hadoop pmc mailing list, anyway I got a jira created, give a check you must have received a mail with the further steps -- This is an automated

[GitHub] [hadoop] neshkeev commented on pull request #5305: Simplify the single node setup instructions

2023-01-18 Thread GitBox
neshkeev commented on PR #5305: URL: https://github.com/apache/hadoop/pull/5305#issuecomment-1386644209 @ayushtkn , unfortunately I don't have an ASF Jira account yet and [jira guidelines](https://infra.apache.org/jira-guidelines.html#account) says that someone from the Hadoop PMC has to

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-18 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678119#comment-17678119 ] Duo Zhang commented on HADOOP-18206: There are not too many modules which reference commons-logging

  1   2   >