[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5326: YARN-11425. [Federation] Router Supports SubClusterCleaner.

slfan1989 commented on code in PR #5326: URL: https://github.com/apache/hadoop/pull/5326#discussion_r1088614242 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/cleaner/TestSubClusterCleaner.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5326: YARN-11425. [Federation] Router Supports SubClusterCleaner.

slfan1989 commented on code in PR #5326: URL: https://github.com/apache/hadoop/pull/5326#discussion_r1088613766 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/cleaner/TestSubClusterCleaner.java:

[GitHub] [hadoop] slfan1989 commented on pull request #5284: YARN-11218. [Federation] Add getActivities, getBulkActivities REST APIs for Router.

slfan1989 commented on PR #5284: URL: https://github.com/apache/hadoop/pull/5284#issuecomment-1406054688 @goiri Thank you very much for helping to review the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (HADOOP-18602) Remove netty3 dependency

[ https://issues.apache.org/jira/browse/HADOOP-18602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681143#comment-17681143 ] ASF GitHub Bot commented on HADOOP-18602: - hadoop-yetus commented on PR #5323: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5323: HADOOP-18602. Remove netty3 dependency

hadoop-yetus commented on PR #5323: URL: https://github.com/apache/hadoop/pull/5323#issuecomment-1405744193 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #3618: YARN-11000. Replace queue resource calculation logic in updateClusterResource

hadoop-yetus commented on PR #3618: URL: https://github.com/apache/hadoop/pull/3618#issuecomment-1405735022 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5322: HDFS-16896 clear ignoredNodes list when we clear deadnode list on ref…

hadoop-yetus commented on PR #5322: URL: https://github.com/apache/hadoop/pull/5322#issuecomment-1405715222 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #3618: YARN-11000. Replace queue resource calculation logic in updateClusterResource

hadoop-yetus commented on PR #3618: URL: https://github.com/apache/hadoop/pull/3618#issuecomment-1405695665 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681104#comment-17681104 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on PR #5315: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

virajjasani commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1405594849 @jojochuang merge conflicts resolved with latest sync from trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] goiri merged pull request #5284: YARN-11218. [Federation] Add getActivities, getBulkActivities REST APIs for Router.

goiri merged PR #5284: URL: https://github.com/apache/hadoop/pull/5284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] goiri commented on a diff in pull request #5326: YARN-11425. [Federation] Router Supports SubClusterCleaner.

goiri commented on code in PR #5326: URL: https://github.com/apache/hadoop/pull/5326#discussion_r1088242768 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/cleaner/TestSubClusterCleaner.java: ##

[GitHub] [hadoop] szilard-nemeth closed pull request #3470: YARN-10965. Centralize queue resource calculation based on CapacityVectors

szilard-nemeth closed pull request #3470: YARN-10965. Centralize queue resource calculation based on CapacityVectors URL: https://github.com/apache/hadoop/pull/3470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] szilard-nemeth commented on pull request #3470: YARN-10965. Centralize queue resource calculation based on CapacityVectors

szilard-nemeth commented on PR #3470: URL: https://github.com/apache/hadoop/pull/3470#issuecomment-1405447433 Thanks @9uapaw for this huge contribution. Latest patch LGTM, committed to trunk. Thanks @brumi1024 , @shuzirra for the reviews. -- This is an automated message from the

[GitHub] [hadoop] hadoop-yetus commented on pull request #3470: YARN-10965. Centralize queue resource calculation based on CapacityVectors

hadoop-yetus commented on PR #3470: URL: https://github.com/apache/hadoop/pull/3470#issuecomment-1405414803 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #1867: HADOOP-16983. Update ADLS client credential creation docs.

hadoop-yetus commented on PR #1867: URL: https://github.com/apache/hadoop/pull/1867#issuecomment-1405309988 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681044#comment-17681044 ] ASF GitHub Bot commented on HADOOP-18206: - hadoop-yetus commented on PR #5315: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

hadoop-yetus commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1405305703 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] brumi1024 commented on pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

brumi1024 commented on PR #5320: URL: https://github.com/apache/hadoop/pull/5320#issuecomment-1405165777 > > I added some comments where I saw further possibilities for using the convenience get methods beside the fixed ones. I also saw that there are some config settings in the

[jira] [Updated] (HADOOP-18602) Remove netty3 dependency

[ https://issues.apache.org/jira/browse/HADOOP-18602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szilard Nemeth updated HADOOP-18602: Status: Patch Available (was: Open) > Remove netty3 dependency >

[jira] [Commented] (HADOOP-18602) Remove netty3 dependency

[ https://issues.apache.org/jira/browse/HADOOP-18602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681008#comment-17681008 ] ASF GitHub Bot commented on HADOOP-18602: - szilard-nemeth commented on PR #5323: URL:

[GitHub] [hadoop] szilard-nemeth commented on pull request #5323: HADOOP-18602. Remove netty3 dependency

szilard-nemeth commented on PR #5323: URL: https://github.com/apache/hadoop/pull/5323#issuecomment-1405122747 Hi @tomicooler , LGTM +1, pending Jenkins Retriggered build to see if those HDFS tests are flaky. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop] susheel-gupta commented on pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

susheel-gupta commented on PR #5320: URL: https://github.com/apache/hadoop/pull/5320#issuecomment-1405059886 > I added some comments where I saw further possibilities for using the convenience get methods beside the fixed ones. I also saw that there are some config settings in the

[GitHub] [hadoop] szilard-nemeth commented on pull request #3470: YARN-10965. Centralize queue resource calculation based on CapacityVectors

szilard-nemeth commented on PR #3470: URL: https://github.com/apache/hadoop/pull/3470#issuecomment-1405041912 Added commit that fixes checkstyle issues. Except some of those fall into these types: - Variable 'configuredMaxCapacityVectors' must be private and have accessor

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #3470: YARN-10965. Centralize queue resource calculation based on CapacityVectors

szilard-nemeth commented on code in PR #3470: URL: https://github.com/apache/hadoop/pull/3470#discussion_r1087885157 ##

[GitHub] [hadoop] hadoop-yetus commented on pull request #3618: YARN-11000. Replace queue resource calculation logic in updateClusterResource

hadoop-yetus commented on PR #3618: URL: https://github.com/apache/hadoop/pull/3618#issuecomment-1405017142 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] p-szucs commented on pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

p-szucs commented on PR #5320: URL: https://github.com/apache/hadoop/pull/5320#issuecomment-1404951874 I added some comments where I saw further possibilities for using the convenience get methods beside the fixed ones. I also saw that there are some config settings in the FsQueueConverter

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

p-szucs commented on code in PR #5320: URL: https://github.com/apache/hadoop/pull/5320#discussion_r1087785053 ##

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

p-szucs commented on code in PR #5320: URL: https://github.com/apache/hadoop/pull/5320#discussion_r1087784312 ##

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

p-szucs commented on code in PR #5320: URL: https://github.com/apache/hadoop/pull/5320#discussion_r1087778061 ##

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

p-szucs commented on code in PR #5320: URL: https://github.com/apache/hadoop/pull/5320#discussion_r1087770675 ##

[GitHub] [hadoop] hadoop-yetus commented on pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

hadoop-yetus commented on PR #4967: URL: https://github.com/apache/hadoop/pull/4967#issuecomment-1404910003 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

p-szucs commented on code in PR #5320: URL: https://github.com/apache/hadoop/pull/5320#discussion_r1087762346 ##

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

p-szucs commented on code in PR #5320: URL: https://github.com/apache/hadoop/pull/5320#discussion_r1087764208 ##

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

p-szucs commented on code in PR #5320: URL: https://github.com/apache/hadoop/pull/5320#discussion_r1087762346 ##

[jira] [Commented] (HADOOP-17649) Update wildfly openssl to 2.1.3.Final

[ https://issues.apache.org/jira/browse/HADOOP-17649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680951#comment-17680951 ] ASF GitHub Bot commented on HADOOP-17649: - hadoop-yetus commented on PR #4539: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4539: HADOOP-17649. Update wildfly openssl to 2.2.1.Final

hadoop-yetus commented on PR #4539: URL: https://github.com/apache/hadoop/pull/4539#issuecomment-1404838245 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

hadoop-yetus commented on PR #4967: URL: https://github.com/apache/hadoop/pull/4967#issuecomment-1404723829 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5322: HDFS-16896 clear ignoredNodes list when we clear deadnode list on ref…

hadoop-yetus commented on PR #5322: URL: https://github.com/apache/hadoop/pull/5322#issuecomment-1404685864 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |