[jira] [Commented] (HADOOP-18631) Migrate Async appenders to log4j properties

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17692002#comment-17692002 ] ASF GitHub Bot commented on HADOOP-18631: - virajjasani commented on code in PR #5418: URL:

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
virajjasani commented on code in PR #5418: URL: https://github.com/apache/hadoop/pull/5418#discussion_r1113789406 ## hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties: ## @@ -49,4 +56,24 @@ log4j.appender.DNMETRICSRFA.MaxBackupIndex=1

[GitHub] [hadoop] ayushtkn commented on pull request #5311: MAPREDUCE-7431. ShuffleHandler refactor and fix after Netty4 upgrade.

2023-02-21 Thread via GitHub
ayushtkn commented on PR #5311: URL: https://github.com/apache/hadoop/pull/5311#issuecomment-1439571729 Thank you Tamas for volunteering!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (HADOOP-18632) ABFS: Customize and optimize timeouts made based on each separate request

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691981#comment-17691981 ] ASF GitHub Bot commented on HADOOP-18632: - hadoop-yetus commented on PR #5399: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5399: HADOOP-18632: [ABFS] Customize and optimize timeouts made based on each separate request

2023-02-21 Thread via GitHub
hadoop-yetus commented on PR #5399: URL: https://github.com/apache/hadoop/pull/5399#issuecomment-1439558099 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18631) Migrate Async appenders to log4j properties

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691977#comment-17691977 ] ASF GitHub Bot commented on HADOOP-18631: - hadoop-yetus commented on PR #5418: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
hadoop-yetus commented on PR #5418: URL: https://github.com/apache/hadoop/pull/5418#issuecomment-1439544600 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18631) Migrate Async appenders to log4j properties

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691974#comment-17691974 ] ASF GitHub Bot commented on HADOOP-18631: - hadoop-yetus commented on PR #5418: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
hadoop-yetus commented on PR #5418: URL: https://github.com/apache/hadoop/pull/5418#issuecomment-1439539082 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] tomicooler commented on pull request #5311: MAPREDUCE-7431. ShuffleHandler refactor and fix after Netty4 upgrade.

2023-02-21 Thread via GitHub
tomicooler commented on PR #5311: URL: https://github.com/apache/hadoop/pull/5311#issuecomment-1439525148 > the test is failing now:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5337: MAPREDUCE-7386. Maven parallel builds (skipping tests) fail

2023-02-21 Thread via GitHub
hadoop-yetus commented on PR #5337: URL: https://github.com/apache/hadoop/pull/5337#issuecomment-1439513930 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5423: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath

2023-02-21 Thread via GitHub
hfutatzhanghb commented on PR #5423: URL: https://github.com/apache/hadoop/pull/5423#issuecomment-1439505723 hi , @tomscut . i have backport the changes to branch-3.3. please take a look. thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] hfutatzhanghb opened a new pull request, #5423: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getD…

2023-02-21 Thread via GitHub
hfutatzhanghb opened a new pull request, #5423: URL: https://github.com/apache/hadoop/pull/5423 please see https://github.com/apache/hadoop/pull/5276. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HADOOP-18633) fix test AbstractContractDistCpTest#testDistCpUpdateCheckFileSkip

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691945#comment-17691945 ] ASF GitHub Bot commented on HADOOP-18633: - mehakmeet opened a new pull request, #5422: URL:

[GitHub] [hadoop] mehakmeet opened a new pull request, #5422: HADOOP-18633. fix test AbstractContractDistCpTest#testDistCpUpdateCheckFileSkip

2023-02-21 Thread via GitHub
mehakmeet opened a new pull request, #5422: URL: https://github.com/apache/hadoop/pull/5422 ### Description of PR Fixing the test `AbstractContractDistCpTest#testDistCpUpdateCheckFileSkip` ### How was this patch tested? Tested on s3a, abfs and local fs. ### For code

[jira] [Commented] (HADOOP-18631) Migrate Async appenders to log4j properties

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691926#comment-17691926 ] ASF GitHub Bot commented on HADOOP-18631: - virajjasani commented on code in PR #5418: URL:

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
virajjasani commented on code in PR #5418: URL: https://github.com/apache/hadoop/pull/5418#discussion_r1113770486 ## hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties: ## @@ -49,4 +56,24 @@ log4j.appender.DNMETRICSRFA.MaxBackupIndex=1

[GitHub] [hadoop] hadoop-yetus commented on pull request #5312: YARN-11375. [Federation] Support refreshAdminAcls、refreshServiceAcls API's for Federation.

2023-02-21 Thread via GitHub
hadoop-yetus commented on PR #5312: URL: https://github.com/apache/hadoop/pull/5312#issuecomment-1439436708 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18631) Migrate Async appenders to log4j properties

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691924#comment-17691924 ] ASF GitHub Bot commented on HADOOP-18631: - virajjasani commented on code in PR #5418: URL:

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
virajjasani commented on code in PR #5418: URL: https://github.com/apache/hadoop/pull/5418#discussion_r1113830663 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/AsyncRFAAppender.java: ## @@ -0,0 +1,139 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (HADOOP-18631) Migrate Async appenders to log4j properties

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691923#comment-17691923 ] ASF GitHub Bot commented on HADOOP-18631: - virajjasani commented on code in PR #5418: URL:

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
virajjasani commented on code in PR #5418: URL: https://github.com/apache/hadoop/pull/5418#discussion_r1113830663 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/AsyncRFAAppender.java: ## @@ -0,0 +1,139 @@ +/** + * Licensed to the Apache Software

[GitHub] [hadoop] hadoop-yetus commented on pull request #5335: YARN-11426. Improve YARN NodeLabel Memory Display.

2023-02-21 Thread via GitHub
hadoop-yetus commented on PR #5335: URL: https://github.com/apache/hadoop/pull/5335#issuecomment-1439421406 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5394: YARN-5604. [Federation] Add versioning for FederationStateStore.

2023-02-21 Thread via GitHub
hadoop-yetus commented on PR #5394: URL: https://github.com/apache/hadoop/pull/5394#issuecomment-1439414674 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5302: YARN-11221. [Federation] Add replaceLabelsOnNodes, replaceLabelsOnNode REST APIs for Router.

2023-02-21 Thread via GitHub
hadoop-yetus commented on PR #5302: URL: https://github.com/apache/hadoop/pull/5302#issuecomment-1439402375 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5276: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath

2023-02-21 Thread via GitHub
hfutatzhanghb commented on PR #5276: URL: https://github.com/apache/hadoop/pull/5276#issuecomment-1439392335 > @tomscut OK, I will do this soonly~ thanks tao brother -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (HADOOP-18631) Migrate Async appenders to log4j properties

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691901#comment-17691901 ] ASF GitHub Bot commented on HADOOP-18631: - virajjasani commented on code in PR #5418: URL:

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
virajjasani commented on code in PR #5418: URL: https://github.com/apache/hadoop/pull/5418#discussion_r1113789406 ## hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties: ## @@ -49,4 +56,24 @@ log4j.appender.DNMETRICSRFA.MaxBackupIndex=1

[GitHub] [hadoop] ayushtkn commented on pull request #5311: MAPREDUCE-7431. ShuffleHandler refactor and fix after Netty4 upgrade.

2023-02-21 Thread via GitHub
ayushtkn commented on PR #5311: URL: https://github.com/apache/hadoop/pull/5311#issuecomment-1439380291 the test is failing now:

[jira] [Commented] (HADOOP-18631) Migrate Async appenders to log4j properties

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691895#comment-17691895 ] ASF GitHub Bot commented on HADOOP-18631: - virajjasani commented on code in PR #5418: URL:

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
virajjasani commented on code in PR #5418: URL: https://github.com/apache/hadoop/pull/5418#discussion_r1113759661 ## hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties: ## @@ -49,4 +56,24 @@ log4j.appender.DNMETRICSRFA.MaxBackupIndex=1

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
virajjasani commented on code in PR #5418: URL: https://github.com/apache/hadoop/pull/5418#discussion_r1113779366 ## hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties: ## @@ -49,4 +56,24 @@ log4j.appender.DNMETRICSRFA.MaxBackupIndex=1

[jira] [Commented] (HADOOP-18631) Migrate Async appenders to log4j properties

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691894#comment-17691894 ] ASF GitHub Bot commented on HADOOP-18631: - virajjasani commented on code in PR #5418: URL:

[jira] [Commented] (HADOOP-18631) Migrate Async appenders to log4j properties

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691893#comment-17691893 ] ASF GitHub Bot commented on HADOOP-18631: - Apache9 commented on code in PR #5418: URL:

[GitHub] [hadoop] Apache9 commented on a diff in pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
Apache9 commented on code in PR #5418: URL: https://github.com/apache/hadoop/pull/5418#discussion_r1113776679 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/MetricsLoggerTask.java: ## @@ -115,8 +111,11 @@ private String trimLine(String

[jira] [Commented] (HADOOP-18631) Migrate Async appenders to log4j properties

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691891#comment-17691891 ] ASF GitHub Bot commented on HADOOP-18631: - virajjasani commented on code in PR #5418: URL:

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
virajjasani commented on code in PR #5418: URL: https://github.com/apache/hadoop/pull/5418#discussion_r1113759661 ## hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties: ## @@ -49,4 +56,24 @@ log4j.appender.DNMETRICSRFA.MaxBackupIndex=1

[GitHub] [hadoop] ayushtkn commented on pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure

2023-02-21 Thread via GitHub
ayushtkn commented on PR #5295: URL: https://github.com/apache/hadoop/pull/5295#issuecomment-1439366770 This seems to have broken the mapreduce tests. https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-linux-x86_64/1143/testReport/ Reverting this fixed it locally

[jira] [Commented] (HADOOP-18631) Migrate Async appenders to log4j properties

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691888#comment-17691888 ] ASF GitHub Bot commented on HADOOP-18631: - virajjasani commented on code in PR #5418: URL:

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
virajjasani commented on code in PR #5418: URL: https://github.com/apache/hadoop/pull/5418#discussion_r1113770486 ## hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties: ## @@ -49,4 +56,24 @@ log4j.appender.DNMETRICSRFA.MaxBackupIndex=1

[jira] [Commented] (HADOOP-18631) Migrate Async appenders to log4j properties

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691882#comment-17691882 ] ASF GitHub Bot commented on HADOOP-18631: - virajjasani commented on code in PR #5418: URL:

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
virajjasani commented on code in PR #5418: URL: https://github.com/apache/hadoop/pull/5418#discussion_r1113758871 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/MetricsLoggerTask.java: ## @@ -115,8 +111,11 @@ private String trimLine(String

[GitHub] [hadoop] haiyang1987 commented on pull request #5414: HDFS-16899. Fix TestAddOverReplicatedStripedBlocks#testProcessOverReplicatedAndCorruptStripedBlock failed

2023-02-21 Thread via GitHub
haiyang1987 commented on PR #5414: URL: https://github.com/apache/hadoop/pull/5414#issuecomment-1439347203 @ZanderXu @tomscut please help me review this PR when you are available, Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hadoop] haiyang1987 commented on pull request #5415: HDFS-16926. Fix Typo of ImageServlet#Put()

2023-02-21 Thread via GitHub
haiyang1987 commented on PR #5415: URL: https://github.com/apache/hadoop/pull/5415#issuecomment-1439347441 @ZanderXu @tomscut please help me review this PR when you are available, Thanks. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] Apache9 commented on a diff in pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
Apache9 commented on code in PR #5418: URL: https://github.com/apache/hadoop/pull/5418#discussion_r1113753403 ## hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties: ## @@ -49,4 +56,24 @@ log4j.appender.DNMETRICSRFA.MaxBackupIndex=1

[jira] [Commented] (HADOOP-18631) Migrate Async appenders to log4j properties

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691868#comment-17691868 ] ASF GitHub Bot commented on HADOOP-18631: - Apache9 commented on code in PR #5418: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4725: HDFS-16688. Unresolved Hosts during startup are not synced by JournalNodes

2023-02-21 Thread via GitHub
hadoop-yetus commented on PR #4725: URL: https://github.com/apache/hadoop/pull/4725#issuecomment-1439281473 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18631) Migrate Async appenders to log4j properties

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691835#comment-17691835 ] ASF GitHub Bot commented on HADOOP-18631: - hadoop-yetus commented on PR #5418: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
hadoop-yetus commented on PR #5418: URL: https://github.com/apache/hadoop/pull/5418#issuecomment-1439258598 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18631) Migrate Async appenders to log4j properties

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691834#comment-17691834 ] ASF GitHub Bot commented on HADOOP-18631: - hadoop-yetus commented on PR #5418: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
hadoop-yetus commented on PR #5418: URL: https://github.com/apache/hadoop/pull/5418#issuecomment-1439256459 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4834: HDFS-16753. WebHDFSHandler should reject non-compliant requests

2023-02-21 Thread via GitHub
hadoop-yetus commented on PR #4834: URL: https://github.com/apache/hadoop/pull/4834#issuecomment-1439253717 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #5288: YARN-11394. Fix hadoop-yarn-server-resourcemanager module Java Doc Errors.

2023-02-21 Thread via GitHub
slfan1989 commented on PR #5288: URL: https://github.com/apache/hadoop/pull/5288#issuecomment-1439251206 @ayushtkn @steveloughran Thank you for your help to review the code, I will cherrypick to branch3-3. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HADOOP-18637) S3A to support upload of files greater than 2 GB using DiskBlocks

2023-02-21 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691825#comment-17691825 ] Mukund Thakur commented on HADOOP-18637: As discussed offline, following changes will be

[jira] [Commented] (HADOOP-18565) AWS SDK V2 - Complete outstanding items

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691770#comment-17691770 ] ASF GitHub Bot commented on HADOOP-18565: - hadoop-yetus commented on PR #5421: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5421: HADOOP-18565. Completes outstanding items for the SDK V2 upgrade.

2023-02-21 Thread via GitHub
hadoop-yetus commented on PR #5421: URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1439017361 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-18565) AWS SDK V2 - Complete outstanding items

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18565: Labels: pull-request-available (was: ) > AWS SDK V2 - Complete outstanding items >

[jira] [Commented] (HADOOP-18565) AWS SDK V2 - Complete outstanding items

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691766#comment-17691766 ] ASF GitHub Bot commented on HADOOP-18565: - hadoop-yetus commented on PR #5421: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5421: HADOOP-18565. Completes outstanding items for the SDK V2 upgrade.

2023-02-21 Thread via GitHub
hadoop-yetus commented on PR #5421: URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1438999564 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] rdingankar commented on a diff in pull request #5397: HDFS-16917 Add transfer rate quantile metrics for DataNode reads

2023-02-21 Thread via GitHub
rdingankar commented on code in PR #5397: URL: https://github.com/apache/hadoop/pull/5397#discussion_r1113432082 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java: ## @@ -1936,4 +1936,20 @@ public static boolean isParentEntry(final String

[jira] [Commented] (HADOOP-18636) LocalDirAllocator cannot recover from directory tree deletion during the life of a filesystem client

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691741#comment-17691741 ] ASF GitHub Bot commented on HADOOP-18636: - hadoop-yetus commented on PR #5412: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5412: HADOOP-18636 LocalDirAllocator cannot recover from directory tree deletion

2023-02-21 Thread via GitHub
hadoop-yetus commented on PR #5412: URL: https://github.com/apache/hadoop/pull/5412#issuecomment-1438920330 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18631) Migrate Async appenders to log4j properties

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691733#comment-17691733 ] ASF GitHub Bot commented on HADOOP-18631: - virajjasani commented on PR #5418: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
virajjasani commented on PR #5418: URL: https://github.com/apache/hadoop/pull/5418#issuecomment-1438896144 @jojochuang could you please take a look in the meantime? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (HADOOP-18631) Migrate Async appenders to log4j properties

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691731#comment-17691731 ] ASF GitHub Bot commented on HADOOP-18631: - virajjasani commented on PR #5418: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
virajjasani commented on PR #5418: URL: https://github.com/apache/hadoop/pull/5418#issuecomment-1438895176 Tests are passing locally. Added more logs to check more on why they are failing on Jenkins build. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] hadoop-yetus commented on pull request #5312: YARN-11375. [Federation] Support refreshAdminAcls、refreshServiceAcls API's for Federation.

2023-02-21 Thread via GitHub
hadoop-yetus commented on PR #5312: URL: https://github.com/apache/hadoop/pull/5312#issuecomment-1438784034 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-18638) Encryption behaviour on copy

2023-02-21 Thread Daniel Carl Jones (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Carl Jones updated HADOOP-18638: --- Component/s: fs/s3 > Encryption behaviour on copy > >

[jira] [Updated] (HADOOP-18638) Encryption behaviour on copy

2023-02-21 Thread Ahmar Suhail (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmar Suhail updated HADOOP-18638: -- Summary: Encryption behaviour on copy (was: Encryption behaviour ) > Encryption behaviour

[jira] [Created] (HADOOP-18638) Encryption behaviour

2023-02-21 Thread Ahmar Suhail (Jira)
Ahmar Suhail created HADOOP-18638: - Summary: Encryption behaviour Key: HADOOP-18638 URL: https://issues.apache.org/jira/browse/HADOOP-18638 Project: Hadoop Common Issue Type: Sub-task

[GitHub] [hadoop] ahmarsuhail opened a new pull request, #5421: Feature hadoop 18565 custom signers

2023-02-21 Thread via GitHub
ahmarsuhail opened a new pull request, #5421: URL: https://github.com/apache/hadoop/pull/5421 ### Description of PR Jira: https://issues.apache.org/jira/browse/HADOOP-18565 This PR: - Removes TM dependency, as it’s in the bundle now - Removes SDK V1 bundle dependency,

[jira] [Updated] (HADOOP-18565) AWS SDK V2 - Complete outstanding items

2023-02-21 Thread Ahmar Suhail (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmar Suhail updated HADOOP-18565: -- Description: The following work remains to complete the SDK upgrade work: * S3A allows

[jira] [Updated] (HADOOP-18565) AWS SDK V2 - Complete outstanding items

2023-02-21 Thread Ahmar Suhail (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmar Suhail updated HADOOP-18565: -- Summary: AWS SDK V2 - Complete outstanding items (was: AWS SDK V2 - Add in support of

[GitHub] [hadoop] hadoop-yetus commented on pull request #5419: HDFS-16928. Both getCurrentEditLogTxid and getEditsFromTxid should be OperationCategory.WRITE

2023-02-21 Thread via GitHub
hadoop-yetus commented on PR #5419: URL: https://github.com/apache/hadoop/pull/5419#issuecomment-1438669964 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] steveloughran commented on a diff in pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-02-21 Thread via GitHub
steveloughran commented on code in PR #4967: URL: https://github.com/apache/hadoop/pull/4967#discussion_r1113171936 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java: ## @@ -1919,6 +1933,19 @@ public Collection

[GitHub] [hadoop] steveloughran commented on a diff in pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-02-21 Thread via GitHub
steveloughran commented on code in PR #4967: URL: https://github.com/apache/hadoop/pull/4967#discussion_r1113169004 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java: ## @@ -1638,6 +1638,24 @@ public MultipartUploaderBuilder

[GitHub] [hadoop] hadoop-yetus commented on pull request #5403: YARN-11340. [Federation] Improve SQLFederationStateStore DataSource Config.

2023-02-21 Thread via GitHub
hadoop-yetus commented on PR #5403: URL: https://github.com/apache/hadoop/pull/5403#issuecomment-1438617009 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5403: YARN-11340. [Federation] Improve SQLFederationStateStore DataSource Config.

2023-02-21 Thread via GitHub
hadoop-yetus commented on PR #5403: URL: https://github.com/apache/hadoop/pull/5403#issuecomment-1438615216 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18576) Java 11 JavaDoc fails due to missing package comments

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691645#comment-17691645 ] ASF GitHub Bot commented on HADOOP-18576: - steveloughran closed pull request #5226:

[GitHub] [hadoop] steveloughran closed pull request #5226: HADOOP-18576. hadoop common javadocs

2023-02-21 Thread via GitHub
steveloughran closed pull request #5226: HADOOP-18576. hadoop common javadocs URL: https://github.com/apache/hadoop/pull/5226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (HADOOP-18636) LocalDirAllocator cannot recover from directory tree deletion during the life of a filesystem client

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691644#comment-17691644 ] ASF GitHub Bot commented on HADOOP-18636: - steveloughran commented on PR #5412: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5412: HADOOP-18636 LocalDirAllocator cannot recover from directory tree deletion

2023-02-21 Thread via GitHub
steveloughran commented on PR #5412: URL: https://github.com/apache/hadoop/pull/5412#issuecomment-1438609730 spotbugs was complaining that mkdirs() result was ignored. logging at debug to get it to SFTU -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] steveloughran commented on pull request #5288: YARN-11394. Fix hadoop-yarn-server-resourcemanager module Java Doc Errors.

2023-02-21 Thread via GitHub
steveloughran commented on PR #5288: URL: https://github.com/apache/hadoop/pull/5288#issuecomment-1438602451 in trunk; cherrypick to branch-3.3 if you can... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] steveloughran merged pull request #5288: YARN-11394. Fix hadoop-yarn-server-resourcemanager module Java Doc Errors.

2023-02-21 Thread via GitHub
steveloughran merged PR #5288: URL: https://github.com/apache/hadoop/pull/5288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-17424) Replace HTrace with No-Op tracer

2023-02-21 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691638#comment-17691638 ] Siyao Meng commented on HADOOP-17424: - Hi [~bpatel], it should be easy to cherry-pick this onto the

[jira] [Commented] (HADOOP-18470) Release hadoop 3.3.5

2023-02-21 Thread Tobias Stadler (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691637#comment-17691637 ] Tobias Stadler commented on HADOOP-18470: - Thank you! > Release hadoop 3.3.5 >

[GitHub] [hadoop] hadoop-yetus commented on pull request #5420: YARN-11442. Refactor FederationInterceptorREST Code.

2023-02-21 Thread via GitHub
hadoop-yetus commented on PR #5420: URL: https://github.com/apache/hadoop/pull/5420#issuecomment-1438587846 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5126: YARN-11370. [Federation] Refactor MemoryFederationStateStore code.

2023-02-21 Thread via GitHub
hadoop-yetus commented on PR #5126: URL: https://github.com/apache/hadoop/pull/5126#issuecomment-1438493999 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Comment Edited] (HADOOP-18622) Upgrade ant to 1.10.13

2023-02-21 Thread Aleksandr Nikolaev (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691598#comment-17691598 ] Aleksandr Nikolaev edited comment on HADOOP-18622 at 2/21/23 1:19 PM:

[jira] [Commented] (HADOOP-18622) Upgrade ant to 1.10.13

2023-02-21 Thread Aleksandr Nikolaev (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691598#comment-17691598 ] Aleksandr Nikolaev commented on HADOOP-18622: - [~ayushtkn]  Thanks!  > Upgrade ant to

[jira] [Commented] (HADOOP-18631) Migrate Async appenders to log4j properties

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691581#comment-17691581 ] ASF GitHub Bot commented on HADOOP-18631: - hadoop-yetus commented on PR #5418: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-02-21 Thread via GitHub
hadoop-yetus commented on PR #5418: URL: https://github.com/apache/hadoop/pull/5418#issuecomment-1438422789 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 opened a new pull request, #5420: YARN-11442. Refactor FederationInterceptorREST Code.

2023-02-21 Thread via GitHub
slfan1989 opened a new pull request, #5420: URL: https://github.com/apache/hadoop/pull/5420 JIRA: YARN-11442. Refactor FederationInterceptorREST Code. Fix code issues to make code more readable 1. Add getOrCreateInterceptorForSubCluster method, the parameter is a parameter of type

[GitHub] [hadoop] slfan1989 commented on pull request #5288: YARN-11394. Fix hadoop-yarn-server-resourcemanager module Java Doc Errors.

2023-02-21 Thread via GitHub
slfan1989 commented on PR #5288: URL: https://github.com/apache/hadoop/pull/5288#issuecomment-1438320401 @steveloughran Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] slfan1989 commented on pull request #4435: YARN-11178. Avoid CPU busy idling and resource wasting in DelegationTokenRenewerPoolTracker thread

2023-02-21 Thread via GitHub
slfan1989 commented on PR #4435: URL: https://github.com/apache/hadoop/pull/4435#issuecomment-1438320061 @LennonChin Is this junit test error related to this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Updated] (HADOOP-18622) Upgrade ant to 1.10.13

2023-02-21 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena updated HADOOP-18622: -- Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed Status:

[jira] [Commented] (HADOOP-18622) Upgrade ant to 1.10.13

2023-02-21 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691528#comment-17691528 ] Ayush Saxena commented on HADOOP-18622: --- Committed to trunk. Thanx [~aonikolaev] for the

[jira] [Commented] (HADOOP-18622) Upgrade ant to 1.10.13

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691527#comment-17691527 ] ASF GitHub Bot commented on HADOOP-18622: - ayushtkn merged PR #5360: URL:

[GitHub] [hadoop] ayushtkn merged pull request #5360: HADOOP-18622. Upgrade ant to 1.10.13

2023-02-21 Thread via GitHub
ayushtkn merged PR #5360: URL: https://github.com/apache/hadoop/pull/5360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (HADOOP-18622) Upgrade ant to 1.10.13

2023-02-21 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena reassigned HADOOP-18622: - Assignee: Aleksandr Nikolaev (was: Ashutosh Gupta) > Upgrade ant to 1.10.13 >

  1   2   >