hadoop-yetus commented on PR #5700:
URL: https://github.com/apache/hadoop/pull/5700#issuecomment-1571402556
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728215#comment-17728215
]
ASF GitHub Bot commented on HADOOP-18740:
-
hadoop-yetus commented on PR #5675:
URL:
hadoop-yetus commented on PR #5675:
URL: https://github.com/apache/hadoop/pull/5675#issuecomment-1571346917
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
ayushtkn commented on code in PR #5636:
URL: https://github.com/apache/hadoop/pull/5636#discussion_r1212556425
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/TestRouterWebServiceUtil.java:
[
https://issues.apache.org/jira/browse/HADOOP-18740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728210#comment-17728210
]
ASF GitHub Bot commented on HADOOP-18740:
-
virajjasani commented on PR #5675:
URL:
virajjasani commented on PR #5675:
URL: https://github.com/apache/hadoop/pull/5675#issuecomment-1571320810
`us-west-2`:
```
mvn clean verify -Dparallel-tests -DtestsThreadCount=8 -Dscale
mvn clean verify -Dparallel-tests -DtestsThreadCount=8 -Dscale -Dprefetch
```
ayushtkn merged PR #5701:
URL: https://github.com/apache/hadoop/pull/5701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ayushtkn commented on code in PR #5671:
URL: https://github.com/apache/hadoop/pull/5671#discussion_r1212512606
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java:
##
@@ -2270,4 +2277,9 @@ public void
ayushtkn merged PR #5697:
URL: https://github.com/apache/hadoop/pull/5697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/HADOOP-18740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728181#comment-17728181
]
ASF GitHub Bot commented on HADOOP-18740:
-
virajjasani commented on code in PR #5675:
URL:
virajjasani commented on code in PR #5675:
URL: https://github.com/apache/hadoop/pull/5675#discussion_r1212472590
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/SingleFilePerBlockCache.java:
##
@@ -268,12 +310,15 @@ public void close()
[
https://issues.apache.org/jira/browse/HADOOP-18756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani reassigned HADOOP-18756:
-
Assignee: Viraj Jasani
> CachingBlockManager to use AtomicBoolean for closed flag
>
xinglin commented on code in PR #5700:
URL: https://github.com/apache/hadoop/pull/5700#discussion_r1212424086
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestObserverReadProxyProvider.java:
##
@@ -325,6 +357,94 @@ public void
xinglin commented on code in PR #5700:
URL: https://github.com/apache/hadoop/pull/5700#discussion_r1212423874
##
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ObserverReadProxyProvider.java:
##
@@ -284,13 +319,68 @@ private
xinglin commented on code in PR #5700:
URL: https://github.com/apache/hadoop/pull/5700#discussion_r1212423619
##
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ObserverReadProxyProvider.java:
##
@@ -213,6 +241,13 @@ public
xinglin commented on code in PR #5700:
URL: https://github.com/apache/hadoop/pull/5700#discussion_r1212422395
##
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ObserverReadProxyProvider.java:
##
@@ -88,6 +96,16 @@
/** Observer
xinglin commented on code in PR #5700:
URL: https://github.com/apache/hadoop/pull/5700#discussion_r1212421364
##
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ObserverReadProxyProvider.java:
##
@@ -155,12 +173,22 @@
*/
hadoop-yetus commented on PR #3618:
URL: https://github.com/apache/hadoop/pull/3618#issuecomment-1571060839
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728122#comment-17728122
]
ASF GitHub Bot commented on HADOOP-18752:
-
steveloughran commented on PR #5689:
URL:
steveloughran commented on PR #5689:
URL: https://github.com/apache/hadoop/pull/5689#issuecomment-1570827515
noted. well, let's target 3.4 at the very least and tag as incompatible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/HADOOP-18707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728118#comment-17728118
]
Steve Loughran commented on HADOOP-18707:
-
good to hear this is working.
# could you also try
[
https://issues.apache.org/jira/browse/HADOOP-18754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728117#comment-17728117
]
Steve Loughran commented on HADOOP-18754:
-
can you tag with affected and targeted fix versions.
[
https://issues.apache.org/jira/browse/HADOOP-18754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-18754:
Component/s: tools/distcp
> Make DistCp Split files hidden to prevent interfering with
hadoop-yetus commented on PR #5561:
URL: https://github.com/apache/hadoop/pull/5561#issuecomment-1570773154
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
goiri commented on code in PR #5705:
URL: https://github.com/apache/hadoop/pull/5705#discussion_r1212058864
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/FederationInterceptor.java:
simbadzina commented on code in PR #5700:
URL: https://github.com/apache/hadoop/pull/5700#discussion_r1212029782
##
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ObserverReadProxyProvider.java:
##
@@ -155,12 +173,22 @@
*/
goiri merged PR #5693:
URL: https://github.com/apache/hadoop/pull/5693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
goiri commented on PR #5691:
URL: https://github.com/apache/hadoop/pull/5691#issuecomment-1570615115
I think we have approval quorum.
I'll go ahead and merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
goiri commented on code in PR #5700:
URL: https://github.com/apache/hadoop/pull/5700#discussion_r1212047828
##
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ObserverReadProxyProvider.java:
##
@@ -284,13 +319,68 @@ private
hadoop-yetus commented on PR #3618:
URL: https://github.com/apache/hadoop/pull/3618#issuecomment-1570600750
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5705:
URL: https://github.com/apache/hadoop/pull/5705#issuecomment-1570592864
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
simbadzina commented on code in PR #5702:
URL: https://github.com/apache/hadoop/pull/5702#discussion_r1212010564
##
slfan1989 commented on PR #5676:
URL: https://github.com/apache/hadoop/pull/5676#issuecomment-1570412732
@goiri Can you help to merge this pr into the trunk branch? Thank you very
much! I will continue to backport YARN-7707.
--
This is an automated message from the Apache Git Service.
To
slfan1989 opened a new pull request, #5705:
URL: https://github.com/apache/hadoop/pull/5705
### Description of PR
JIRA: YARN-11502. Refactor
AMRMProxy#FederationInterceptor#registerApplicationMaster.
Refactor the code of FederationInterceptor#registerApplicationMaster
hadoop-yetus commented on PR #5698:
URL: https://github.com/apache/hadoop/pull/5698#issuecomment-1570384537
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17727999#comment-17727999
]
ASF GitHub Bot commented on HADOOP-18740:
-
steveloughran commented on code in PR #5675:
URL:
steveloughran commented on code in PR #5675:
URL: https://github.com/apache/hadoop/pull/5675#discussion_r1211811893
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/SingleFilePerBlockCache.java:
##
@@ -99,6 +106,32 @@ public String
[
https://issues.apache.org/jira/browse/HADOOP-18740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17727993#comment-17727993
]
ASF GitHub Bot commented on HADOOP-18740:
-
steveloughran commented on PR #5675:
URL:
steveloughran commented on PR #5675:
URL: https://github.com/apache/hadoop/pull/5675#issuecomment-1570335711
@MayankSinghParmar get on the hadoop hdfs mailing list and discuss there.
@virajjasani can you rebase and retest?
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/HADOOP-18756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-18756:
Summary: CachingBlockManager to use AtomicBoolean for closed flag (was:
Steve Loughran created HADOOP-18756:
---
Summary: CachingBlockManager to use AtomicBoolean for closed fiag
Key: HADOOP-18756
URL: https://issues.apache.org/jira/browse/HADOOP-18756
Project: Hadoop
tomicooler commented on PR #5623:
URL: https://github.com/apache/hadoop/pull/5623#issuecomment-1570310784
Hi @devaspatikrishnatri ,
you can re-trigger the build by creating an empty commit `git commit
--allow-empty -m "Trigger the jenkins job"` then pushing it to your fork's
branch
lfxy commented on code in PR #5561:
URL: https://github.com/apache/hadoop/pull/5561#discussion_r1211724811
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java:
##
@@ -564,4 +566,113 @@ public void testConcatOnSameFile()
[
https://issues.apache.org/jira/browse/HADOOP-18709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17727938#comment-17727938
]
ASF GitHub Bot commented on HADOOP-18709:
-
hadoop-yetus commented on PR #5638:
URL:
hadoop-yetus commented on PR #5638:
URL: https://github.com/apache/hadoop/pull/5638#issuecomment-1570164034
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
lfxy commented on code in PR #5561:
URL: https://github.com/apache/hadoop/pull/5561#discussion_r1211643942
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java:
##
@@ -564,4 +566,113 @@ public void testConcatOnSameFile()
ayushtkn commented on code in PR #5561:
URL: https://github.com/apache/hadoop/pull/5561#discussion_r1211602315
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java:
##
@@ -564,4 +566,113 @@ public void
lfxy commented on code in PR #5561:
URL: https://github.com/apache/hadoop/pull/5561#discussion_r1211583457
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java:
##
@@ -564,4 +566,113 @@ public void testConcatOnSameFile()
hadoop-yetus commented on PR #4990:
URL: https://github.com/apache/hadoop/pull/4990#issuecomment-1570039142
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
ayushtkn merged PR #5699:
URL: https://github.com/apache/hadoop/pull/5699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/HADOOP-18752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17727884#comment-17727884
]
ASF GitHub Bot commented on HADOOP-18752:
-
ayushtkn commented on PR #5689:
URL:
ayushtkn commented on PR #5689:
URL: https://github.com/apache/hadoop/pull/5689#issuecomment-1569931307
yep, it is like that, lot of discussions and tickets around this, example:
[HDFS-13505](https://issues.apache.org/jira/browse/HDFS-13505), this is also
marked as incompatible and was
ayushtkn commented on code in PR #5561:
URL: https://github.com/apache/hadoop/pull/5561#discussion_r1211469418
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java:
##
@@ -564,4 +566,113 @@ public void
lfxy commented on code in PR #5561:
URL: https://github.com/apache/hadoop/pull/5561#discussion_r1211433782
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java:
##
@@ -564,4 +566,113 @@ public void testConcatOnSameFile()
[
https://issues.apache.org/jira/browse/HADOOP-18752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HADOOP-18752:
Labels: pull-request-available (was: )
> Change fs.s3a.directory.marker.retention to
zhtttylz commented on code in PR #5698:
URL: https://github.com/apache/hadoop/pull/5698#discussion_r1211341558
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/JsonUtil.java:
##
@@ -741,4 +741,27 @@ public static Map toJsonMap(FsStatus
status) {
steveloughran commented on PR #5689:
URL: https://github.com/apache/hadoop/pull/5689#issuecomment-1569802418
@ayushtkn really? default values are immutable. not sure about that as a lot
of things change implicitly, or for good reason "the defaults weren't good".
while the
ayushtkn commented on code in PR #4990:
URL: https://github.com/apache/hadoop/pull/4990#discussion_r1211229496
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java:
##
@@ -699,32 +697,52 @@ public boolean
ayushtkn commented on code in PR #5561:
URL: https://github.com/apache/hadoop/pull/5561#discussion_r1211225704
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java:
##
@@ -564,4 +566,113 @@ public void
hadoop-yetus commented on PR #5700:
URL: https://github.com/apache/hadoop/pull/5700#issuecomment-1569577944
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
Hexiaoqiao commented on PR #5691:
URL: https://github.com/apache/hadoop/pull/5691#issuecomment-1569570682
Committed to trunk. Thanks @hchaverri for your contributions! And thanks
every reviewers (Too many to mentioned folks)!
--
This is an automated message from the Apache Git Service.
Hexiaoqiao merged PR #5691:
URL: https://github.com/apache/hadoop/pull/5691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
slfan1989 commented on PR #4797:
URL: https://github.com/apache/hadoop/pull/4797#issuecomment-1569562918
@leixm Thanks for the contribution! LGTM.
@aajisaka @ashutoshcipher Can you help to review this PR again?
--
This is an automated message from the Apache Git Service.
To respond to
hadoop-yetus commented on PR #5700:
URL: https://github.com/apache/hadoop/pull/5700#issuecomment-1569553809
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
slfan1989 commented on code in PR #5698:
URL: https://github.com/apache/hadoop/pull/5698#discussion_r1211125291
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/JsonUtil.java:
##
@@ -741,4 +741,27 @@ public static Map toJsonMap(FsStatus
status) {
65 matches
Mail list logo