hfutatzhanghb commented on PR #5744:
URL: https://github.com/apache/hadoop/pull/5744#issuecomment-1590517320
@Hexiaoqiao @ayushtkn Hi, Sir, could you please help me to review this PR if
you have bandwidth? Thanks a lot.
--
This is an automated message from the Apache Git Service.
To
hfutatzhanghb opened a new pull request, #5744:
URL: https://github.com/apache/hadoop/pull/5744
### Description of PR
### How was this patch tested?
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id
(e.g.
hadoop-yetus commented on PR #5700:
URL: https://github.com/apache/hadoop/pull/5700#issuecomment-1590491238
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5700:
URL: https://github.com/apache/hadoop/pull/5700#issuecomment-1590488797
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5700:
URL: https://github.com/apache/hadoop/pull/5700#issuecomment-1590474594
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5716:
URL: https://github.com/apache/hadoop/pull/5716#issuecomment-1590468238
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
gp1314 commented on PR #4435:
URL: https://github.com/apache/hadoop/pull/4435#issuecomment-1590396294
Thanks to LennonChin for his contributions and ideas, but why close this
commit? I don't think the problem has been fixed. Can I continue the work?
--
This is an automated message from
zhangshuyan0 opened a new pull request, #5743:
URL: https://github.com/apache/hadoop/pull/5743
…kGroupIdGenerator.
### Description of PR
When I used multiple clients to write EC files concurrently, I found that
NameNode generated the same block group ID for different
yl09099 commented on code in PR #5716:
URL: https://github.com/apache/hadoop/pull/5716#discussion_r1228907597
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/util/FormattingCLIUtils.java:
##
@@ -0,0 +1,185 @@
+/**
+ * Licensed
szetszwo commented on PR #5738:
URL: https://github.com/apache/hadoop/pull/5738#issuecomment-1590350314
@umamaheswararao , sure. Just added two assertions for rename within the
snapshot directory.
--
This is an automated message from the Apache Git Service.
To respond to the message,
umamaheswararao commented on PR #5738:
URL: https://github.com/apache/hadoop/pull/5738#issuecomment-1590341301
Can we add similar test for the case where rename happens within the
snapshot directory and make sure quotas are ok?
I just tried and it worked though. It would be good to have
slfan1989 commented on code in PR #5733:
URL: https://github.com/apache/hadoop/pull/5733#discussion_r1228866500
##
hadoop-yetus commented on PR #5730:
URL: https://github.com/apache/hadoop/pull/5730#issuecomment-1590242662
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17732287#comment-17732287
]
ASF GitHub Bot commented on HADOOP-18756:
-
virajjasani commented on code in PR #5718:
URL:
virajjasani commented on code in PR #5718:
URL: https://github.com/apache/hadoop/pull/5718#discussion_r1228809990
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/SingleFilePerBlockCache.java:
##
@@ -333,37 +335,31 @@ protected Path
[
https://issues.apache.org/jira/browse/HADOOP-18622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17732284#comment-17732284
]
ASF GitHub Bot commented on HADOOP-18622:
-
jojochuang closed pull request #5361: HADOOP-18622.
jojochuang closed pull request #5361: HADOOP-18622. Upgrade ant to 1.10.13
URL: https://github.com/apache/hadoop/pull/5361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
xinglin commented on code in PR #5700:
URL: https://github.com/apache/hadoop/pull/5700#discussion_r1228797424
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestObserverReadProxyProvider.java:
##
@@ -58,30 +74,53 @@
* NameNode to
hadoop-yetus commented on PR #5730:
URL: https://github.com/apache/hadoop/pull/5730#issuecomment-1590171248
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17732270#comment-17732270
]
ASF GitHub Bot commented on HADOOP-18763:
-
mukund-thakur commented on PR #5741:
URL:
mukund-thakur commented on PR #5741:
URL: https://github.com/apache/hadoop/pull/5741#issuecomment-1590087588
Running through most of the steps myself. Looking good.
Just assumed role and access point tests are pending.
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/HADOOP-18763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17732265#comment-17732265
]
ASF GitHub Bot commented on HADOOP-18763:
-
virajjasani commented on PR #5741:
URL:
virajjasani commented on PR #5741:
URL: https://github.com/apache/hadoop/pull/5741#issuecomment-1590053507
another round looks good:
`mvn clean verify -Dparallel-tests -DtestsThreadCount=8 -Dscale -Dprefetch`
--
This is an automated message from the Apache Git Service.
To respond to
xinglin commented on code in PR #5730:
URL: https://github.com/apache/hadoop/pull/5730#discussion_r1228698595
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##
@@ -636,10 +637,17 @@ void updateMetrics(Call call, long startTime, boolean
xinglin commented on code in PR #5730:
URL: https://github.com/apache/hadoop/pull/5730#discussion_r1228698595
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##
@@ -636,10 +637,17 @@ void updateMetrics(Call call, long startTime, boolean
xinglin commented on code in PR #5730:
URL: https://github.com/apache/hadoop/pull/5730#discussion_r1228698595
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##
@@ -636,10 +637,17 @@ void updateMetrics(Call call, long startTime, boolean
xinglin commented on code in PR #5730:
URL: https://github.com/apache/hadoop/pull/5730#discussion_r1228698595
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##
@@ -636,10 +637,17 @@ void updateMetrics(Call call, long startTime, boolean
goiri commented on code in PR #5700:
URL: https://github.com/apache/hadoop/pull/5700#discussion_r1228400308
##
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ObserverReadProxyProvider.java:
##
@@ -155,12 +174,21 @@
*/
goiri commented on code in PR #5730:
URL: https://github.com/apache/hadoop/pull/5730#discussion_r1228676060
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java:
##
@@ -330,6 +332,13 @@ public void incrRequeueCalls() {
goiri commented on code in PR #5730:
URL: https://github.com/apache/hadoop/pull/5730#discussion_r1228674650
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##
@@ -636,10 +637,17 @@ void updateMetrics(Call call, long startTime, boolean
hadoop-yetus commented on PR #5332:
URL: https://github.com/apache/hadoop/pull/5332#issuecomment-1589910057
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5730:
URL: https://github.com/apache/hadoop/pull/5730#issuecomment-1589968661
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17732234#comment-17732234
]
ASF GitHub Bot commented on HADOOP-18763:
-
virajjasani commented on PR #5741:
URL:
virajjasani commented on PR #5741:
URL: https://github.com/apache/hadoop/pull/5741#issuecomment-1589903411
> Those failed tests don't rely on awsk sdk so can be ignored.
agree, i will re-run the whole test suit against `us-west-2` again today.
--
This is an automated message from
[
https://issues.apache.org/jira/browse/HADOOP-18763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17732233#comment-17732233
]
ASF GitHub Bot commented on HADOOP-18763:
-
virajjasani commented on PR #5741:
URL:
virajjasani commented on PR #5741:
URL: https://github.com/apache/hadoop/pull/5741#issuecomment-1589901812
what i am not aware of is the failure on
TestFederationRMFailoverProxyProvider, and also the asf warning.
@goiri @slfan1989 could you please once take a look in case you are
[
https://issues.apache.org/jira/browse/HADOOP-18763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17732232#comment-17732232
]
ASF GitHub Bot commented on HADOOP-18763:
-
virajjasani commented on PR #5741:
URL:
virajjasani commented on PR #5741:
URL: https://github.com/apache/hadoop/pull/5741#issuecomment-1589899798
> Was going through the comments on Jira. Looking good. Will run some tests
myself.
>
> @virajjasani Some unit tests are failing in Yetus. Need to check those.
>
> This
[
https://issues.apache.org/jira/browse/HADOOP-18763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17732226#comment-17732226
]
ASF GitHub Bot commented on HADOOP-18763:
-
jojochuang commented on PR #5741:
URL:
jojochuang commented on PR #5741:
URL: https://github.com/apache/hadoop/pull/5741#issuecomment-1589888266
Those failed tests don't rely on awsk sdk so can be ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/HADOOP-18763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17732213#comment-17732213
]
ASF GitHub Bot commented on HADOOP-18763:
-
mukund-thakur commented on PR #5741:
URL:
mukund-thakur commented on PR #5741:
URL: https://github.com/apache/hadoop/pull/5741#issuecomment-1589846172
Was going through the comments on Jira. Looking good. Will run some tests
myself.
@virajjasani Some unit tests are failing in Yetus. Need to check those.
This license
xinglin commented on code in PR #5730:
URL: https://github.com/apache/hadoop/pull/5730#discussion_r1228468922
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##
@@ -636,10 +637,17 @@ void updateMetrics(Call call, long startTime, boolean
xinglin commented on code in PR #5730:
URL: https://github.com/apache/hadoop/pull/5730#discussion_r1228468230
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##
@@ -636,10 +637,17 @@ void updateMetrics(Call call, long startTime, boolean
xinglin commented on code in PR #5730:
URL: https://github.com/apache/hadoop/pull/5730#discussion_r1228468922
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##
@@ -636,10 +637,17 @@ void updateMetrics(Call call, long startTime, boolean
xinglin commented on code in PR #5730:
URL: https://github.com/apache/hadoop/pull/5730#discussion_r1228468230
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##
@@ -636,10 +637,17 @@ void updateMetrics(Call call, long startTime, boolean
goiri commented on code in PR #5730:
URL: https://github.com/apache/hadoop/pull/5730#discussion_r1228464911
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##
@@ -636,10 +637,17 @@ void updateMetrics(Call call, long startTime, boolean
[
https://issues.apache.org/jira/browse/HADOOP-18763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17732182#comment-17732182
]
ASF GitHub Bot commented on HADOOP-18763:
-
hadoop-yetus commented on PR #5741:
URL:
hadoop-yetus commented on PR #5741:
URL: https://github.com/apache/hadoop/pull/5741#issuecomment-1589717056
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
xinglin commented on code in PR #5730:
URL: https://github.com/apache/hadoop/pull/5730#discussion_r1228448128
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##
@@ -600,17 +600,18 @@ void logSlowRpcCalls(String methodName, Call call,
goiri merged PR #5723:
URL: https://github.com/apache/hadoop/pull/5723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
goiri commented on code in PR #5730:
URL: https://github.com/apache/hadoop/pull/5730#discussion_r1228393934
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##
@@ -600,17 +600,18 @@ void logSlowRpcCalls(String methodName, Call call,
}
[
https://issues.apache.org/jira/browse/HADOOP-18763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17732152#comment-17732152
]
ASF GitHub Bot commented on HADOOP-18763:
-
jojochuang commented on PR #5741:
URL:
jojochuang commented on PR #5741:
URL: https://github.com/apache/hadoop/pull/5741#issuecomment-1589611728
Just from a code and functionality perspective LGTM.
But folks like @steveloughran or @mukund-thakur or someone else more
familiar with S3A need to chime in too.
--
This is an
hadoop-yetus commented on PR #5742:
URL: https://github.com/apache/hadoop/pull/5742#issuecomment-1589587069
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmar Suhail updated HADOOP-18673:
--
Description:
* Factor getS3Region into its own ExecutingStoreOperation;
* Remove
[
https://issues.apache.org/jira/browse/HADOOP-18763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mukund Thakur reassigned HADOOP-18763:
--
Assignee: Viraj Jasani (was: Mukund Thakur)
> Upgrade aws-java-sdk to 1.12.367+
>
[
https://issues.apache.org/jira/browse/HADOOP-18763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mukund Thakur reassigned HADOOP-18763:
--
Assignee: Mukund Thakur
> Upgrade aws-java-sdk to 1.12.367+
>
hadoop-yetus commented on PR #5738:
URL: https://github.com/apache/hadoop/pull/5738#issuecomment-1589189260
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hfutatzhanghb commented on PR #5742:
URL: https://github.com/apache/hadoop/pull/5742#issuecomment-1589186399
@ayushtkn Sir, could you please help to review this minor modification？
Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/HADOOP-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17732027#comment-17732027
]
Ayush Saxena commented on HADOOP-18770:
---
for any new soul trying to fix.
the simple potential
[
https://issues.apache.org/jira/browse/HADOOP-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ayush Saxena updated HADOOP-18770:
--
Labels: newbie (was: )
> cmake CompileMojo resolution
>
>
>
Hexiaoqiao commented on PR #5735:
URL: https://github.com/apache/hadoop/pull/5735#issuecomment-1589027221
Great catch here. One nit comment, just suggest to add some explicit
annotations which avoid to useless notification from datanode after delete.
And, add new UT will be better here.
hfutatzhanghb opened a new pull request, #5742:
URL: https://github.com/apache/hadoop/pull/5742
### Description of PR
please see HDFS-17047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/HADOOP-18771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
farmmamba resolved HADOOP-18771.
Resolution: Abandoned
> BlockManager#addStoredBlock should log storage id when AddBlockResult is
farmmamba created HADOOP-18771:
--
Summary: BlockManager#addStoredBlock should log storage id when
AddBlockResult is REPLACED
Key: HADOOP-18771
URL: https://issues.apache.org/jira/browse/HADOOP-18771
Steve Loughran created HADOOP-18770:
---
Summary: cmake CompileMojo resolution
Key: HADOOP-18770
URL: https://issues.apache.org/jira/browse/HADOOP-18770
Project: Hadoop Common
Issue Type:
szetszwo commented on PR #5738:
URL: https://github.com/apache/hadoop/pull/5738#issuecomment-1588833542
The failed tests do not seem related. Triggered another build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
hadoop-yetus commented on PR #5738:
URL: https://github.com/apache/hadoop/pull/5738#issuecomment-1588605682
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
69 matches
Mail list logo
