[GitHub] [hadoop] hadoop-yetus commented on pull request #5828: YARN-11529 Add metrics for ContainerMonitorImpl.

2023-07-11 Thread via GitHub
hadoop-yetus commented on PR #5828: URL: https://github.com/apache/hadoop/pull/5828#issuecomment-1631893067 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18801) Delete path directly when it can not be parsed in trash

2023-07-11 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742268#comment-17742268 ] Ayush Saxena commented on HADOOP-18801: --- Moved to Hadoop-Common, this isn't just HDFS specific.

[jira] [Moved] (HADOOP-18801) Delete path directly when it can not be parsed in trash

2023-07-11 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena moved HDFS-17046 to HADOOP-18801: -- Key: HADOOP-18801 (was: HDFS-17046) Project: Hadoop Common

[jira] [Resolved] (HADOOP-18781) ABFS backReference passed down to streams to avoid GC closing the FS.

2023-07-11 Thread Mehakmeet Singh (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mehakmeet Singh resolved HADOOP-18781. -- Fix Version/s: 3.3.9 Resolution: Fixed > ABFS backReference passed down to

[jira] [Commented] (HADOOP-18781) ABFS backReference passed down to streams to avoid GC closing the FS.

2023-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742267#comment-17742267 ] ASF GitHub Bot commented on HADOOP-18781: - mehakmeet merged PR #5830: URL:

[GitHub] [hadoop] mehakmeet merged pull request #5830: HADOOP-18781. ABFS backReference passed down to streams to avoid GC closing the FS.(#5780)

2023-07-11 Thread via GitHub
mehakmeet merged PR #5830: URL: https://github.com/apache/hadoop/pull/5830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] Hexiaoqiao commented on a diff in pull request #5744: HDFS-17046. Delete path directly when it can not be parsed in trash.

2023-07-11 Thread via GitHub
Hexiaoqiao commented on code in PR #5744: URL: https://github.com/apache/hadoop/pull/5744#discussion_r1260563388 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java: ## @@ -786,6 +793,69 @@ public void testTrashEmptier() throws Exception {

[jira] [Created] (HADOOP-18800) Bad ipc.client.connection.idle-scan-interval.ms cause resource leaks

2023-07-11 Thread ConfX (Jira)
ConfX created HADOOP-18800: -- Summary: Bad ipc.client.connection.idle-scan-interval.ms cause resource leaks Key: HADOOP-18800 URL: https://issues.apache.org/jira/browse/HADOOP-18800 Project: Hadoop Common

[GitHub] [hadoop] slfan1989 commented on pull request #5727: YARN-11509. The FederationInterceptor#launchUAM Added retry logic.

2023-07-11 Thread via GitHub
slfan1989 commented on PR #5727: URL: https://github.com/apache/hadoop/pull/5727#issuecomment-1631767181 @goiri Thank you very much for your help in reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] slfan1989 commented on pull request #5797: YARN-11524. Improve the Policy Description in Federation.md.

2023-07-11 Thread via GitHub
slfan1989 commented on PR #5797: URL: https://github.com/apache/hadoop/pull/5797#issuecomment-1631766781 @goiri Thank you very much for your help in reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] Hexiaoqiao commented on pull request #5807: HDFS-17080. fix ec connection leak

2023-07-11 Thread via GitHub
Hexiaoqiao commented on PR #5807: URL: https://github.com/apache/hadoop/pull/5807#issuecomment-1631742621 @jojochuang Thanks WeiChiu for your help. @harris233 Would you mind to re-apply, and attach this PR link to the application form? I will try to trace and approve. -- This is an

[GitHub] [hadoop] goiri merged pull request #5752: YARN-11515. [Federation] Improve DefaultRequestInterceptor#init Code.

2023-07-11 Thread via GitHub
goiri merged PR #5752: URL: https://github.com/apache/hadoop/pull/5752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] goiri merged pull request #5727: YARN-11509. The FederationInterceptor#launchUAM Added retry logic.

2023-07-11 Thread via GitHub
goiri merged PR #5727: URL: https://github.com/apache/hadoop/pull/5727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18184) s3a prefetching stream to support unbuffer()

2023-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742211#comment-17742211 ] ASF GitHub Bot commented on HADOOP-18184: - hadoop-yetus commented on PR #5832: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5832: HADOOP-18184. S3A Prefetching unbuffer.

2023-07-11 Thread via GitHub
hadoop-yetus commented on PR #5832: URL: https://github.com/apache/hadoop/pull/5832#issuecomment-1631610252 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] jojochuang commented on pull request #5807: HDFS-17080. fix ec connection leak

2023-07-11 Thread via GitHub
jojochuang commented on PR #5807: URL: https://github.com/apache/hadoop/pull/5807#issuecomment-1631577162 Opened [HDFS-17080](https://issues.apache.org/jira/browse/HDFS-17080) to track this PR -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hadoop] hadoop-yetus commented on pull request #5816: YARN-11525. [Federation] Router CLI Supports Save the SubClusterPolicyConfiguration Of Queues.

2023-07-11 Thread via GitHub
hadoop-yetus commented on PR #5816: URL: https://github.com/apache/hadoop/pull/5816#issuecomment-1631574619 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5816: YARN-11525. [Federation] Router CLI Supports Save the SubClusterPolicyConfiguration Of Queues.

2023-07-11 Thread via GitHub
hadoop-yetus commented on PR #5816: URL: https://github.com/apache/hadoop/pull/5816#issuecomment-1631563602 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5831: HDFS-17079. Fix inccorect extraction of removeChildBool

2023-07-11 Thread via GitHub
hadoop-yetus commented on PR #5831: URL: https://github.com/apache/hadoop/pull/5831#issuecomment-1631548775 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5816: YARN-11525. [Federation] Router CLI Supports Save the SubClusterPolicyConfiguration Of Queues.

2023-07-11 Thread via GitHub
hadoop-yetus commented on PR #5816: URL: https://github.com/apache/hadoop/pull/5816#issuecomment-1631460608 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] Neilxzn commented on pull request #5829: HDFS-15413. add dfs.client.read.striped.datanode.max.attempts to fix read ecfile timeout

2023-07-11 Thread via GitHub
Neilxzn commented on PR #5829: URL: https://github.com/apache/hadoop/pull/5829#issuecomment-1631452001 这是自动回复邮件。来件已接收,谢谢。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [hadoop] hadoop-yetus commented on pull request #5829: HDFS-15413. add dfs.client.read.striped.datanode.max.attempts to fix read ecfile timeout

2023-07-11 Thread via GitHub
hadoop-yetus commented on PR #5829: URL: https://github.com/apache/hadoop/pull/5829#issuecomment-1631451493 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5816: YARN-11525. [Federation] Router CLI Supports Save the SubClusterPolicyConfiguration Of Queues.

2023-07-11 Thread via GitHub
hadoop-yetus commented on PR #5816: URL: https://github.com/apache/hadoop/pull/5816#issuecomment-1631433189 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5816: YARN-11525. [Federation] Router CLI Supports Save the SubClusterPolicyConfiguration Of Queues.

2023-07-11 Thread via GitHub
hadoop-yetus commented on PR #5816: URL: https://github.com/apache/hadoop/pull/5816#issuecomment-1631418109 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-18799) zstd compressor fails with Src size is incorrect

2023-07-11 Thread Frens Jan Rumph (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frens Jan Rumph updated HADOOP-18799: - Summary: zstd compressor fails with Src size is incorrect (was: zstd compressor fails

[jira] [Updated] (HADOOP-18799) Zstd compressor fails with src size is incorrect

2023-07-11 Thread Frens Jan Rumph (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frens Jan Rumph updated HADOOP-18799: - Summary: Zstd compressor fails with src size is incorrect (was: zstd compressor fails

[jira] [Created] (HADOOP-18799) zstd compressor fails

2023-07-11 Thread Frens Jan Rumph (Jira)
Frens Jan Rumph created HADOOP-18799: Summary: zstd compressor fails Key: HADOOP-18799 URL: https://issues.apache.org/jira/browse/HADOOP-18799 Project: Hadoop Common Issue Type: Bug

[jira] [Updated] (HADOOP-18799) zstd compressor fails

2023-07-11 Thread Frens Jan Rumph (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frens Jan Rumph updated HADOOP-18799: - Description: It seems like I've hit an issue similar to

[jira] [Updated] (HADOOP-18799) zstd compressor fails

2023-07-11 Thread Frens Jan Rumph (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frens Jan Rumph updated HADOOP-18799: - Description: It seems like I've hit an issue similar to

[jira] [Updated] (HADOOP-18799) zstd compressor fails with

2023-07-11 Thread Frens Jan Rumph (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frens Jan Rumph updated HADOOP-18799: - Summary: zstd compressor fails with (was: zstd compressor fails ) > zstd compressor

[jira] [Updated] (HADOOP-18799) zstd compressor fails

2023-07-11 Thread Frens Jan Rumph (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frens Jan Rumph updated HADOOP-18799: - Description: It seems like I've hit an issue similar to

[jira] [Commented] (HADOOP-18184) s3a prefetching stream to support unbuffer()

2023-07-11 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742131#comment-17742131 ] Steve Loughran commented on HADOOP-18184: - ok, back on this with

[jira] [Commented] (HADOOP-18184) s3a prefetching stream to support unbuffer()

2023-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742130#comment-17742130 ] ASF GitHub Bot commented on HADOOP-18184: - steveloughran commented on PR #5832: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5832: HADOOP-18184. S3A Prefetching unbuffer.

2023-07-11 Thread via GitHub
steveloughran commented on PR #5832: URL: https://github.com/apache/hadoop/pull/5832#issuecomment-1631294722 based on #4298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (HADOOP-18184) s3a prefetching stream to support unbuffer()

2023-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18184: Labels: pull-request-available (was: ) > s3a prefetching stream to support unbuffer() >

[jira] [Commented] (HADOOP-18184) s3a prefetching stream to support unbuffer()

2023-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742128#comment-17742128 ] ASF GitHub Bot commented on HADOOP-18184: - steveloughran opened a new pull request, #5832: URL:

[GitHub] [hadoop] goiri commented on a diff in pull request #5828: YARN-11529 Add metrics for ContainerMonitorImpl.

2023-07-11 Thread via GitHub
goiri commented on code in PR #5828: URL: https://github.com/apache/hadoop/pull/5828#discussion_r1260093389 ##

[jira] [Commented] (HADOOP-18781) ABFS backReference passed down to streams to avoid GC closing the FS.

2023-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742115#comment-17742115 ] ASF GitHub Bot commented on HADOOP-18781: - hadoop-yetus commented on PR #5830: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5830: HADOOP-18781. ABFS backReference passed down to streams to avoid GC closing the FS.(#5780)

2023-07-11 Thread via GitHub
hadoop-yetus commented on PR #5830: URL: https://github.com/apache/hadoop/pull/5830#issuecomment-1631229930 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] goiri merged pull request #5797: YARN-11524. Improve the Policy Description in Federation.md.

2023-07-11 Thread via GitHub
goiri merged PR #5797: URL: https://github.com/apache/hadoop/pull/5797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (HADOOP-18798) hadoop distcp -delete sends deleted data to null instead of trash

2023-07-11 Thread Ryan Blough (Jira)
Ryan Blough created HADOOP-18798: Summary: hadoop distcp -delete sends deleted data to null instead of trash Key: HADOOP-18798 URL: https://issues.apache.org/jira/browse/HADOOP-18798 Project: Hadoop

[GitHub] [hadoop] hadoop-yetus commented on pull request #5809: HDFS-17068. Datanode should record last directory scan time.

2023-07-11 Thread via GitHub
hadoop-yetus commented on PR #5809: URL: https://github.com/apache/hadoop/pull/5809#issuecomment-1631144007 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #5816: YARN-11525. [Federation] Router CLI Supports Save the SubClusterPolicyConfiguration Of Queues.

2023-07-11 Thread via GitHub
slfan1989 commented on PR #5816: URL: https://github.com/apache/hadoop/pull/5816#issuecomment-1631088776 @goiri Can you help review this pr? Thank you very much! We added a command to save Queue Policy. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] symious closed pull request #5831: HDFS-17079. Fix inccorect extraction of removeChildBool

2023-07-11 Thread via GitHub
symious closed pull request #5831: HDFS-17079. Fix inccorect extraction of removeChildBool URL: https://github.com/apache/hadoop/pull/5831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] symious commented on pull request #5831: HDFS-17079. Fix inccorect extraction of removeChildBool

2023-07-11 Thread via GitHub
symious commented on PR #5831: URL: https://github.com/apache/hadoop/pull/5831#issuecomment-1631085858 Found out it's not a bug, the presence of the record indicates true, no need the record to be with "true" content. -- This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] hadoop-yetus commented on pull request #5809: HDFS-17068. Datanode should record last directory scan time.

2023-07-11 Thread via GitHub
hadoop-yetus commented on PR #5809: URL: https://github.com/apache/hadoop/pull/5809#issuecomment-1631068944 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5816: YARN-11525. [Federation] Router CLI Supports Save the SubClusterPolicyConfiguration Of Queues.

2023-07-11 Thread via GitHub
hadoop-yetus commented on PR #5816: URL: https://github.com/apache/hadoop/pull/5816#issuecomment-1631065249 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18291) S3A prefetch - Implement LRU cache for SingleFilePerBlockCache

2023-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742079#comment-17742079 ] ASF GitHub Bot commented on HADOOP-18291: - virajjasani commented on PR #5754: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5754: HADOOP-18291. S3A prefetch - Implement thread-safe LRU cache for SingleFilePerBlockCache

2023-07-11 Thread via GitHub
virajjasani commented on PR #5754: URL: https://github.com/apache/hadoop/pull/5754#issuecomment-1631058598 > readFile() needs to always close the file channel, even of a read fails. sounds good for both read and write, will file a jira unless already filed. -- This is an automated

[GitHub] [hadoop] symious commented on pull request #5831: HDFS-17079. Fix inccorect extraction of removeChildBool

2023-07-11 Thread via GitHub
symious commented on PR #5831: URL: https://github.com/apache/hadoop/pull/5831#issuecomment-1631037639 @cmccabe Could you help to review the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] symious opened a new pull request, #5831: HDFS-17079. Fix inccorect extraction of removeChildBool

2023-07-11 Thread via GitHub
symious opened a new pull request, #5831: URL: https://github.com/apache/hadoop/pull/5831 ### Description of PR In OfflineImageReconstructor#removeChildBool, the value will always be recognized as "true" if the node is not null. ### How was this patch tested? Not

[GitHub] [hadoop] slfan1989 commented on pull request #5727: YARN-11509. The FederationInterceptor#launchUAM Added retry logic.

2023-07-11 Thread via GitHub
slfan1989 commented on PR #5727: URL: https://github.com/apache/hadoop/pull/5727#issuecomment-1631033356 @goiri Can you help to merge this pr into the trunk branch? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hadoop] slfan1989 commented on pull request #5752: YARN-11515. [Federation] Improve DefaultRequestInterceptor#init Code.

2023-07-11 Thread via GitHub
slfan1989 commented on PR #5752: URL: https://github.com/apache/hadoop/pull/5752#issuecomment-1631030216 @goiri Can you help to merge this pr into the trunk branch? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hadoop] slfan1989 commented on pull request #5797: YARN-11524. Improve the Policy Description in Federation.md.

2023-07-11 Thread via GitHub
slfan1989 commented on PR #5797: URL: https://github.com/apache/hadoop/pull/5797#issuecomment-1631027504 @goiri Can you help to review this PR again? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] slfan1989 commented on pull request #5828: YARN-11529 Add metrics for ContainerMonitorImpl.

2023-07-11 Thread via GitHub
slfan1989 commented on PR #5828: URL: https://github.com/apache/hadoop/pull/5828#issuecomment-1631022200 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (HADOOP-18184) s3a prefetching stream to support unbuffer()

2023-07-11 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742062#comment-17742062 ] Steve Loughran commented on HADOOP-18184: - it will do that, but as it doesn't use openFile() we

[GitHub] [hadoop] hadoop-yetus commented on pull request #5828: YARN-11529 Add metrics for ContainerMonitorImpl.

2023-07-11 Thread via GitHub
hadoop-yetus commented on PR #5828: URL: https://github.com/apache/hadoop/pull/5828#issuecomment-1630972860 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] harris233 commented on pull request #5807: fix ec connection leak

2023-07-11 Thread via GitHub
harris233 commented on PR #5807: URL: https://github.com/apache/hadoop/pull/5807#issuecomment-1630913909 > > @harris233 Thanks for your contributions. Would you mind to file new JIRA (https://issues.apache.org/jira/projects/HDFS) first, and link this PR? Please let me know

[jira] [Commented] (HADOOP-18781) ABFS backReference passed down to streams to avoid GC closing the FS.

2023-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742005#comment-17742005 ] ASF GitHub Bot commented on HADOOP-18781: - mehakmeet opened a new pull request, #5830: URL:

[GitHub] [hadoop] mehakmeet opened a new pull request, #5830: HADOOP-18781. ABFS backReference passed down to streams to avoid GC closing the FS.(#5780)

2023-07-11 Thread via GitHub
mehakmeet opened a new pull request, #5830: URL: https://github.com/apache/hadoop/pull/5830 ### Description of PR To avoid the ABFS instance getting closed due to GC while the streams are working, attach the ABFS instance to a backReference opaque object and passing down

[GitHub] [hadoop] brumi1024 commented on pull request #5792: YARN-11464: TestFSQueueConverter#testAutoCreateV2FlagsInWeightMode has a missing dot before auto-queue-creation-v2.enabled for method call

2023-07-11 Thread via GitHub
brumi1024 commented on PR #5792: URL: https://github.com/apache/hadoop/pull/5792#issuecomment-1630824455 Thanks @susheelgupta7, merged to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] brumi1024 merged pull request #5792: YARN-11464: TestFSQueueConverter#testAutoCreateV2FlagsInWeightMode has a missing dot before auto-queue-creation-v2.enabled for method call assert

2023-07-11 Thread via GitHub
brumi1024 merged PR #5792: URL: https://github.com/apache/hadoop/pull/5792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18757) S3A Committer finalizing the commits in a single thread

2023-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742000#comment-17742000 ] ASF GitHub Bot commented on HADOOP-18757: - steveloughran commented on code in PR #5706: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5706: HADOOP-18757: Bump corePoolSize of HadoopThreadPoolExecutor in s3a committer

2023-07-11 Thread via GitHub
steveloughran commented on code in PR #5706: URL: https://github.com/apache/hadoop/pull/5706#discussion_r1259712734 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/staging/integration/ITestStagingCommitProtocolFailure.java: ## @@ -32,8 +32,7 @@ import

[GitHub] [hadoop] steveloughran commented on pull request #5706: HADOOP-18757: Bump corePoolSize of HadoopThreadPoolExecutor in s3a committer

2023-07-11 Thread via GitHub
steveloughran commented on PR #5706: URL: https://github.com/apache/hadoop/pull/5706#issuecomment-1630797735 will do; i was offline for a few days -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (HADOOP-18757) S3A Committer finalizing the commits in a single thread

2023-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741996#comment-17741996 ] ASF GitHub Bot commented on HADOOP-18757: - steveloughran commented on PR #5706: URL:

[jira] [Commented] (HADOOP-18797) S3A committer fix lost data on concurrent jobs

2023-07-11 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741994#comment-17741994 ] Steve Loughran commented on HADOOP-18797: - (oh, and we should still allow for __magic cleanup

[GitHub] [hadoop] hadoop-yetus commented on pull request #5792: YARN-11464: TestFSQueueConverter#testAutoCreateV2FlagsInWeightMode has a missing dot before auto-queue-creation-v2.enabled for method ca

2023-07-11 Thread via GitHub
hadoop-yetus commented on PR #5792: URL: https://github.com/apache/hadoop/pull/5792#issuecomment-1630764372 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18797) S3A committer fix lost data on concurrent jobs

2023-07-11 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741982#comment-17741982 ] Steve Loughran commented on HADOOP-18797: - as mentioned in HADOOP-18793; HADOOP-18568 covers

[GitHub] [hadoop] Neilxzn opened a new pull request, #5829: HDFS-15413. add dfs.client.read.striped.datanode.max.attempts to fix read ecfile timeout

2023-07-11 Thread via GitHub
Neilxzn opened a new pull request, #5829: URL: https://github.com/apache/hadoop/pull/5829 ### Description of PR https://issues.apache.org/jira/browse/HDFS-15413 Offer a available patch to fix HDFS-15413. This patch add dfs.client.read.striped.datanode.max.attempts config

[jira] [Updated] (HADOOP-18781) ABFS backReference passed down to streams to avoid GC closing the FS.

2023-07-11 Thread Mehakmeet Singh (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mehakmeet Singh updated HADOOP-18781: - Summary: ABFS backReference passed down to streams to avoid GC closing the FS. (was:

[jira] [Commented] (HADOOP-18781) ABFS Output stream thread pools getting shutdown during GC.

2023-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741975#comment-17741975 ] ASF GitHub Bot commented on HADOOP-18781: - mehakmeet merged PR #5780: URL:

[GitHub] [hadoop] mehakmeet merged pull request #5780: HADOOP-18781. ABFS Output stream thread pools getting shutdown during GC.

2023-07-11 Thread via GitHub
mehakmeet merged PR #5780: URL: https://github.com/apache/hadoop/pull/5780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18283) Review s3a prefetching input stream retry code; synchronization

2023-07-11 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741971#comment-17741971 ] Steve Loughran commented on HADOOP-18283: - +SingleFilePerBlockCache. readFile() to close file

[jira] [Commented] (HADOOP-17719) DistCp with snapshot diff should support file systems supporting getSnapshotDiffReport

2023-07-11 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741969#comment-17741969 ] Steve Loughran commented on HADOOP-17719: - # is this a duplicate of HDFS-16911? # how about we

[jira] [Commented] (HADOOP-18794) ipc.server.handler.queue.size missing from core-default.xml

2023-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741967#comment-17741967 ] ASF GitHub Bot commented on HADOOP-18794: - YuanbenWang commented on PR #5819: URL:

[GitHub] [hadoop] YuanbenWang commented on pull request #5819: HADOOP-18794. ipc.server.handler.queue.size missing from core-default.xml

2023-07-11 Thread via GitHub
YuanbenWang commented on PR #5819: URL: https://github.com/apache/hadoop/pull/5819#issuecomment-1630700426 @slfan1989 @ayushtkn @zhtttylz Thank you for your review! Looking forward to the next. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (HADOOP-18781) ABFS Output stream thread pools getting shutdown during GC.

2023-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741964#comment-17741964 ] ASF GitHub Bot commented on HADOOP-18781: - hadoop-yetus commented on PR #5780: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5780: HADOOP-18781. ABFS Output stream thread pools getting shutdown during GC.

2023-07-11 Thread via GitHub
hadoop-yetus commented on PR #5780: URL: https://github.com/apache/hadoop/pull/5780#issuecomment-1630693617 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] leixm opened a new pull request, #5828: YARN-11529 Add metrics for ContainerMonitorImpl.

2023-07-11 Thread via GitHub
leixm opened a new pull request, #5828: URL: https://github.com/apache/hadoop/pull/5828 ### Description of PR JIRA: YARN-11529 Add metrics for ContainerMonitorImpl. In our production environment, we have ample machine resources and a significant number of active Containers. However,

[jira] [Resolved] (HADOOP-18794) ipc.server.handler.queue.size missing from core-default.xml

2023-07-11 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena resolved HADOOP-18794. --- Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed >

[jira] [Commented] (HADOOP-18794) ipc.server.handler.queue.size missing from core-default.xml

2023-07-11 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741947#comment-17741947 ] Ayush Saxena commented on HADOOP-18794: --- Committed to trunk. Thanx [~wangyuanben] for the

[jira] [Commented] (HADOOP-18794) ipc.server.handler.queue.size missing from core-default.xml

2023-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741946#comment-17741946 ] ASF GitHub Bot commented on HADOOP-18794: - ayushtkn merged PR #5819: URL:

[GitHub] [hadoop] ayushtkn merged pull request #5819: HADOOP-18794. ipc.server.handler.queue.size missing from core-default.xml

2023-07-11 Thread via GitHub
ayushtkn merged PR #5819: URL: https://github.com/apache/hadoop/pull/5819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (HADOOP-18794) ipc.server.handler.queue.size missing from core-default.xml

2023-07-11 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena reassigned HADOOP-18794: - Assignee: WangYuanben > ipc.server.handler.queue.size missing from core-default.xml >

[GitHub] [hadoop] hadoop-yetus commented on pull request #5727: YARN-11509. The FederationInterceptor#launchUAM Added retry logic.

2023-07-11 Thread via GitHub
hadoop-yetus commented on PR #5727: URL: https://github.com/apache/hadoop/pull/5727#issuecomment-1630614300 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18794) ipc.server.handler.queue.size missing from core-default.xml

2023-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741940#comment-17741940 ] ASF GitHub Bot commented on HADOOP-18794: - hadoop-yetus commented on PR #5819: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5819: HADOOP-18794. ipc.server.handler.queue.size missing from core-default.xml

2023-07-11 Thread via GitHub
hadoop-yetus commented on PR #5819: URL: https://github.com/apache/hadoop/pull/5819#issuecomment-1630611332 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] haiyang1987 commented on pull request #5824: HDFS-17076. Remove the unused method isSlownodeByNameserviceId in DataNode

2023-07-11 Thread via GitHub
haiyang1987 commented on PR #5824: URL: https://github.com/apache/hadoop/pull/5824#issuecomment-1630586142 Thanks @ayushtkn help me review and merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop] hadoop-yetus commented on pull request #5752: YARN-11515. [Federation] Improve DefaultRequestInterceptor#init Code.

2023-07-11 Thread via GitHub
hadoop-yetus commented on PR #5752: URL: https://github.com/apache/hadoop/pull/5752#issuecomment-1630438240 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5826: YARN-11527. Upgrade node.js to 14.0.0 in YARN application catalog webapp.

2023-07-11 Thread via GitHub
hadoop-yetus commented on PR #5826: URL: https://github.com/apache/hadoop/pull/5826#issuecomment-1630434508 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5816: YARN-11525. [Federation] Router CLI Supports Save the SubClusterPolicyConfiguration Of Queues.

2023-07-11 Thread via GitHub
hadoop-yetus commented on PR #5816: URL: https://github.com/apache/hadoop/pull/5816#issuecomment-1630419322 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5797: YARN-11524. Improve the Policy Description in Federation.md.

2023-07-11 Thread via GitHub
hadoop-yetus commented on PR #5797: URL: https://github.com/apache/hadoop/pull/5797#issuecomment-1630417907 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5825: HDFS-17072. DFSAdmin: add a triggerVolumeScanner command.

2023-07-11 Thread via GitHub
hadoop-yetus commented on PR #5825: URL: https://github.com/apache/hadoop/pull/5825#issuecomment-1630411375 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5809: HDFS-17068. Datanode should record last directory scan time.

2023-07-11 Thread via GitHub
hadoop-yetus commented on PR #5809: URL: https://github.com/apache/hadoop/pull/5809#issuecomment-1630400349 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5809: HDFS-17068. Datanode should record last directory scan time.

2023-07-11 Thread via GitHub
ayushtkn commented on code in PR #5809: URL: https://github.com/apache/hadoop/pull/5809#discussion_r1259331408 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java: ## @@ -250,6 +250,13 @@ public void

[GitHub] [hadoop] ayushtkn merged pull request #5824: HDFS-17076. Remove the unused method isSlownodeByNameserviceId in DataNode

2023-07-11 Thread via GitHub
ayushtkn merged PR #5824: URL: https://github.com/apache/hadoop/pull/5824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] slfan1989 commented on pull request #5826: YARN-11527. Upgrade node.js to 14.0.0 in YARN application catalog webapp.

2023-07-11 Thread via GitHub
slfan1989 commented on PR #5826: URL: https://github.com/apache/hadoop/pull/5826#issuecomment-1630303665 > @slfan1989 Since we have locked triple beam version to 1.3.0 in hadoop latest commit, I think triple beam version also should be updated to 1.4.1 along with node js 14.0. > >

[GitHub] [hadoop] rakeshadr commented on pull request #5826: YARN-11527. Upgrade node.js to 14.0.0 in YARN application catalog webapp.

2023-07-11 Thread via GitHub
rakeshadr commented on PR #5826: URL: https://github.com/apache/hadoop/pull/5826#issuecomment-1630266276 @slfan1989 Since we have locked triple beam version to 1.3.0 in hadoop latest commit, I think triple beam version also should be updated to 1.4.1 along with node js 14.0. Please

[GitHub] [hadoop] ayushtkn merged pull request #5827: YARN-11528. Lock triple-beam to the version compatible with node.js 12 to avoid compilation error.

2023-07-11 Thread via GitHub
ayushtkn merged PR #5827: URL: https://github.com/apache/hadoop/pull/5827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   >