[jira] [Commented] (HADOOP-18791) S3A prefetching: switch to prefetching for chosen read policies

2023-07-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742667#comment-17742667 ] Viraj Jasani commented on HADOOP-18791: --- sounds good, i just realized unbuffer is already

[jira] [Assigned] (HADOOP-18791) S3A prefetching: switch to prefetching for chosen read policies

2023-07-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HADOOP-18791: - Assignee: (was: Viraj Jasani) > S3A prefetching: switch to prefetching for chosen

[jira] [Resolved] (HADOOP-18776) Add OptimizedS3AMagicCommitter For Zero Rename Commits to S3 Endpoints

2023-07-12 Thread Syed Shameerur Rahman (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Syed Shameerur Rahman resolved HADOOP-18776. Target Version/s: (was: 3.4.0) Resolution: Won't Fix Thanks

[GitHub] [hadoop] jiwq commented on pull request #2496: YARN-10502. Add backlogs metric for CapacityScheduler

2023-07-12 Thread via GitHub
jiwq commented on PR #2496: URL: https://github.com/apache/hadoop/pull/2496#issuecomment-1633476221 No body help to merge, so close it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (HADOOP-17776) The java agent args should be passed as the VM arguments

2023-07-12 Thread Wanqiang Ji (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wanqiang Ji updated HADOOP-17776: - Resolution: Pending Closed Status: Resolved (was: Patch Available) Close this ticket,

[jira] [Commented] (HADOOP-17776) The java agent args should be passed as the VM arguments

2023-07-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742637#comment-17742637 ] ASF GitHub Bot commented on HADOOP-17776: - jiwq closed pull request #3147: HADOOP-17776. The

[GitHub] [hadoop] jiwq closed pull request #3147: HADOOP-17776. The java agent args should be passed as the VM arguments

2023-07-12 Thread via GitHub
jiwq closed pull request #3147: HADOOP-17776. The java agent args should be passed as the VM arguments URL: https://github.com/apache/hadoop/pull/3147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hadoop] jiwq closed pull request #2293: YARN-2098. App priority support in Fair Scheduler

2023-07-12 Thread via GitHub
jiwq closed pull request #2293: YARN-2098. App priority support in Fair Scheduler URL: https://github.com/apache/hadoop/pull/2293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] jiwq closed pull request #2496: YARN-10502. Add backlogs metric for CapacityScheduler

2023-07-12 Thread via GitHub
jiwq closed pull request #2496: YARN-10502. Add backlogs metric for CapacityScheduler URL: https://github.com/apache/hadoop/pull/2496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] slfan1989 commented on pull request #5834: HDFS-17082. Add documentation for provisionSnapshotTrash command to HDFSCommands.md and HdfsSnapshots.md"

2023-07-12 Thread via GitHub
slfan1989 commented on PR #5834: URL: https://github.com/apache/hadoop/pull/5834#issuecomment-1633451166 @haiyang1987 Thanks for the contribution, but we need to fix checkstyle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hadoop] haiyang1987 commented on pull request #5834: HDFS-17082. Add documentation for provisionSnapshotTrash command to HDFSCommands.md and HdfsSnapshots.md"

2023-07-12 Thread via GitHub
haiyang1987 commented on PR #5834: URL: https://github.com/apache/hadoop/pull/5834#issuecomment-1633444779 Update PR, @ayushtkn @slfan1989 please help me review it again, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] haiyang1987 commented on a diff in pull request #5834: HDFS-17082. Add documentation for provisionSnapshotTrash command to HDFSCommands.md and HdfsSnapshots.md"

2023-07-12 Thread via GitHub
haiyang1987 commented on code in PR #5834: URL: https://github.com/apache/hadoop/pull/5834#discussion_r1261901247 ## hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSCommands.md: ## @@ -722,8 +724,6 @@ Usage: `hdfs debug verifyEC -file ` |: |: | | [`-file`

[GitHub] [hadoop] slfan1989 commented on pull request #5828: YARN-11529 Add metrics for ContainerMonitorImpl.

2023-07-12 Thread via GitHub
slfan1989 commented on PR #5828: URL: https://github.com/apache/hadoop/pull/5828#issuecomment-1633418761 @leixm Thanks for your contribution! @goiri Thanks for helping to review the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hadoop] slfan1989 merged pull request #5828: YARN-11529 Add metrics for ContainerMonitorImpl.

2023-07-12 Thread via GitHub
slfan1989 merged PR #5828: URL: https://github.com/apache/hadoop/pull/5828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] slfan1989 commented on pull request #5836: HDFS-17083. Support getErasureCodeCodecs API in WebHDFS

2023-07-12 Thread via GitHub
slfan1989 commented on PR #5836: URL: https://github.com/apache/hadoop/pull/5836#issuecomment-1633417646 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5816: YARN-11525. [Federation] Router CLI Supports Save the SubClusterPolicyConfiguration Of Queues.

2023-07-12 Thread via GitHub
slfan1989 commented on code in PR #5816: URL: https://github.com/apache/hadoop/pull/5816#discussion_r1261885817 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/FederationQueueWeight.java: ## @@ -0,0 +1,141 @@

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5816: YARN-11525. [Federation] Router CLI Supports Save the SubClusterPolicyConfiguration Of Queues.

2023-07-12 Thread via GitHub
slfan1989 commented on code in PR #5816: URL: https://github.com/apache/hadoop/pull/5816#discussion_r1261885089 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/records/SubClusterIdInfo.java:

[jira] [Commented] (HADOOP-18184) s3a prefetching stream to support unbuffer()

2023-07-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742598#comment-17742598 ] ASF GitHub Bot commented on HADOOP-18184: - hadoop-yetus commented on PR #5832: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5832: HADOOP-18184. S3A Prefetching unbuffer.

2023-07-12 Thread via GitHub
hadoop-yetus commented on PR #5832: URL: https://github.com/apache/hadoop/pull/5832#issuecomment-1633363175 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5835: HDFS-17084. Utilize StringTable for numerable XAttributes

2023-07-12 Thread via GitHub
hadoop-yetus commented on PR #5835: URL: https://github.com/apache/hadoop/pull/5835#issuecomment-1633348418 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5836: HDFS-17083. Support getErasureCodeCodecs API in WebHDFS

2023-07-12 Thread via GitHub
hadoop-yetus commented on PR #5836: URL: https://github.com/apache/hadoop/pull/5836#issuecomment-161630 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

2023-07-12 Thread via GitHub
hadoop-yetus commented on PR #5320: URL: https://github.com/apache/hadoop/pull/5320#issuecomment-1633290629 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] goiri commented on a diff in pull request #5816: YARN-11525. [Federation] Router CLI Supports Save the SubClusterPolicyConfiguration Of Queues.

2023-07-12 Thread via GitHub
goiri commented on code in PR #5816: URL: https://github.com/apache/hadoop/pull/5816#discussion_r1261688169 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/records/SubClusterIdInfo.java:

[GitHub] [hadoop] goiri commented on a diff in pull request #5637: YARN-11491. [Federation] Use ZookeeperFederationStateStore as the DefaultStateStore.

2023-07-12 Thread via GitHub
goiri commented on code in PR #5637: URL: https://github.com/apache/hadoop/pull/5637#discussion_r1261674724 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java: ## @@ -4001,7 +4001,7 @@ public static boolean

[jira] [Commented] (HADOOP-18791) S3A prefetching: switch to prefetching for chosen read policies

2023-07-12 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742543#comment-17742543 ] Steve Loughran commented on HADOOP-18791: - lets get the other big bits in first; my unbuffer()

[jira] [Commented] (HADOOP-18184) s3a prefetching stream to support unbuffer()

2023-07-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742525#comment-17742525 ] ASF GitHub Bot commented on HADOOP-18184: - hadoop-yetus commented on PR #5832: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5832: HADOOP-18184. S3A Prefetching unbuffer.

2023-07-12 Thread via GitHub
hadoop-yetus commented on PR #5832: URL: https://github.com/apache/hadoop/pull/5832#issuecomment-1633058241 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5833: HDFS-17081. Append ec file check if a block is replicated to at least the minimum replication need consider striped block

2023-07-12 Thread via GitHub
hadoop-yetus commented on PR #5833: URL: https://github.com/apache/hadoop/pull/5833#issuecomment-1632950287 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5834: HDFS-17082. Add documentation for provisionSnapshotTrash command to HDFSCommands.md and HdfsSnapshots.md"

2023-07-12 Thread via GitHub
hadoop-yetus commented on PR #5834: URL: https://github.com/apache/hadoop/pull/5834#issuecomment-1632929487 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Assigned] (HADOOP-18791) S3A prefetching: switch to prefetching for chosen read policies

2023-07-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HADOOP-18791: - Assignee: Viraj Jasani > S3A prefetching: switch to prefetching for chosen read

[GitHub] [hadoop] zhtttylz opened a new pull request, #5836: HDFS-17083. Support getErasureCodeCodecs API in WebHDFS

2023-07-12 Thread via GitHub
zhtttylz opened a new pull request, #5836: URL: https://github.com/apache/hadoop/pull/5836 JIRA: HDFS-17083. Support getECPolices API in WebHDFS -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5809: HDFS-17068. Datanode should record last directory scan time.

2023-07-12 Thread via GitHub
ayushtkn commented on code in PR #5809: URL: https://github.com/apache/hadoop/pull/5809#discussion_r1261357967 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDirectoryScanner.java: ## @@ -1304,6 +1305,23 @@ public void

[GitHub] [hadoop] hadoop-yetus commented on pull request #5810: YARN-7707. BackPort [GPG] Policy generator framework.

2023-07-12 Thread via GitHub
hadoop-yetus commented on PR #5810: URL: https://github.com/apache/hadoop/pull/5810#issuecomment-1632751147 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5834: HDFS-17082. Add documentation for provisionSnapshotTrash command to HDFSCommands.md and HdfsSnapshots.md"

2023-07-12 Thread via GitHub
ayushtkn commented on code in PR #5834: URL: https://github.com/apache/hadoop/pull/5834#discussion_r1261335811 ## hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSCommands.md: ## @@ -722,8 +724,6 @@ Usage: `hdfs debug verifyEC -file ` |: |: | | [`-file`

[GitHub] [hadoop] slfan1989 commented on pull request #5816: YARN-11525. [Federation] Router CLI Supports Save the SubClusterPolicyConfiguration Of Queues.

2023-07-12 Thread via GitHub
slfan1989 commented on PR #5816: URL: https://github.com/apache/hadoop/pull/5816#issuecomment-1632730784 @goiri Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] symious opened a new pull request, #5835: HDFS-17084. Utilize StringTable for numerable XAttributes

2023-07-12 Thread via GitHub
symious opened a new pull request, #5835: URL: https://github.com/apache/hadoop/pull/5835 ### Description of PR Currently only the name of XAttr will utilize SerialNumber's StringTable to store values, for values they are stored as "byte[]". If the XAttr values are

[GitHub] [hadoop] hadoop-yetus commented on pull request #5816: YARN-11525. [Federation] Router CLI Supports Save the SubClusterPolicyConfiguration Of Queues.

2023-07-12 Thread via GitHub
hadoop-yetus commented on PR #5816: URL: https://github.com/apache/hadoop/pull/5816#issuecomment-1632573350 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5816: YARN-11525. [Federation] Router CLI Supports Save the SubClusterPolicyConfiguration Of Queues.

2023-07-12 Thread via GitHub
hadoop-yetus commented on PR #5816: URL: https://github.com/apache/hadoop/pull/5816#issuecomment-1632564203 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18291) S3A prefetch - Implement LRU cache for SingleFilePerBlockCache

2023-07-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742425#comment-17742425 ] ASF GitHub Bot commented on HADOOP-18291: - steveloughran commented on code in PR #5754: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5754: HADOOP-18291. S3A prefetch - Implement thread-safe LRU cache for SingleFilePerBlockCache

2023-07-12 Thread via GitHub
steveloughran commented on code in PR #5754: URL: https://github.com/apache/hadoop/pull/5754#discussion_r1261160595 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java: ## @@ -1276,4 +1276,16 @@ private Constants() { public static final String

[jira] [Commented] (HADOOP-18797) S3A committer fix lost data on concurrent jobs

2023-07-12 Thread Emanuel Velzi (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742423#comment-17742423 ] Emanuel Velzi commented on HADOOP-18797: The requirements are not exactly the same, but it's

[jira] [Commented] (HADOOP-18218) Ensure S3A prefetching stream memory consumption scales

2023-07-12 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742420#comment-17742420 ] Steve Loughran commented on HADOOP-18218: - think i will make memory consumption/release

[jira] [Assigned] (HADOOP-18792) s3a prefetching to use split start/end options to limit prefetch range

2023-07-12 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reassigned HADOOP-18792: --- Assignee: Steve Loughran > s3a prefetching to use split start/end options to

[jira] [Assigned] (HADOOP-18184) s3a prefetching stream to support unbuffer()

2023-07-12 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reassigned HADOOP-18184: --- Assignee: Steve Loughran (was: Ahmar Suhail) > s3a prefetching stream to support

[GitHub] [hadoop] slfan1989 commented on pull request #5834: HDFS-17082. Add documentation for provisionSnapshotTrash command to HDFSCommands.md and HdfsSnapshots.md"

2023-07-12 Thread via GitHub
slfan1989 commented on PR #5834: URL: https://github.com/apache/hadoop/pull/5834#issuecomment-1632453448 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (HADOOP-18801) Delete path directly when it can not be parsed in trash

2023-07-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742388#comment-17742388 ] ASF GitHub Bot commented on HADOOP-18801: - hadoop-yetus commented on PR #5744: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5744: HADOOP-18801. Delete path directly when it can not be parsed in trash.

2023-07-12 Thread via GitHub
hadoop-yetus commented on PR #5744: URL: https://github.com/apache/hadoop/pull/5744#issuecomment-1632372673 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5826: YARN-11527. Upgrade node.js to 14.0.0 in YARN application catalog webapp.

2023-07-12 Thread via GitHub
hadoop-yetus commented on PR #5826: URL: https://github.com/apache/hadoop/pull/5826#issuecomment-1632372343 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] haiyang1987 opened a new pull request, #5834: HDFS-17082. Add documentation for provisionSnapshotTrash command to HDFSCommands.md and HdfsSnapshots.md"

2023-07-12 Thread via GitHub
haiyang1987 opened a new pull request, #5834: URL: https://github.com/apache/hadoop/pull/5834 ### Description of PR https://issues.apache.org/jira/browse/HDFS-17082 [HDFS-15607](https://issues.apache.org/jira/browse/HDFS-15607) and

[jira] [Commented] (HADOOP-18801) Delete path directly when it can not be parsed in trash

2023-07-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742382#comment-17742382 ] ASF GitHub Bot commented on HADOOP-18801: - hadoop-yetus commented on PR #5744: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5744: HADOOP-18801. Delete path directly when it can not be parsed in trash.

2023-07-12 Thread via GitHub
hadoop-yetus commented on PR #5744: URL: https://github.com/apache/hadoop/pull/5744#issuecomment-1632352154 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] haiyang1987 opened a new pull request, #5833: HDFS-17081. Append ec file check if a block is replicated to at least the minimum replication need consider striped block

2023-07-12 Thread via GitHub
haiyang1987 opened a new pull request, #5833: URL: https://github.com/apache/hadoop/pull/5833 ### Description of PR https://issues.apache.org/jira/browse/HDFS-17081 Append ec file check if a block is replicated to at least the minimum replication need consider ec block.

[jira] [Commented] (HADOOP-18801) Delete path directly when it can not be parsed in trash

2023-07-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742377#comment-17742377 ] ASF GitHub Bot commented on HADOOP-18801: - hadoop-yetus commented on PR #5744: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5744: HADOOP-18801. Delete path directly when it can not be parsed in trash.

2023-07-12 Thread via GitHub
hadoop-yetus commented on PR #5744: URL: https://github.com/apache/hadoop/pull/5744#issuecomment-1632297089 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5637: YARN-11491. [Federation] Use ZookeeperFederationStateStore as the DefaultStateStore.

2023-07-12 Thread via GitHub
hadoop-yetus commented on PR #5637: URL: https://github.com/apache/hadoop/pull/5637#issuecomment-1632274411 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5726: YARN-11508. [Minor] Improve UnmanagedAMPoolManager/UnmanagedApplicationManager Code

2023-07-12 Thread via GitHub
hadoop-yetus commented on PR #5726: URL: https://github.com/apache/hadoop/pull/5726#issuecomment-1632271051 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5810: YARN-7707. BackPort [GPG] Policy generator framework.

2023-07-12 Thread via GitHub
hadoop-yetus commented on PR #5810: URL: https://github.com/apache/hadoop/pull/5810#issuecomment-1632260035 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18781) ABFS backReference passed down to streams to avoid GC closing the FS.

2023-07-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742349#comment-17742349 ] ASF GitHub Bot commented on HADOOP-18781: - steveloughran commented on PR #5830: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5830: HADOOP-18781. ABFS backReference passed down to streams to avoid GC closing the FS.(#5780)

2023-07-12 Thread via GitHub
steveloughran commented on PR #5830: URL: https://github.com/apache/hadoop/pull/5830#issuecomment-1632220778 thanks. nice bit of work. and we've learned something new which will forever taint our brains. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HADOOP-18798) hadoop distcp -delete sends deleted data to null instead of trash

2023-07-12 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742348#comment-17742348 ] Steve Loughran commented on HADOOP-18798: - looking through the code, I don't see it going

[GitHub] [hadoop] hadoop-yetus commented on pull request #5809: HDFS-17068. Datanode should record last directory scan time.

2023-07-12 Thread via GitHub
hadoop-yetus commented on PR #5809: URL: https://github.com/apache/hadoop/pull/5809#issuecomment-1632207612 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5816: YARN-11525. [Federation] Router CLI Supports Save the SubClusterPolicyConfiguration Of Queues.

2023-07-12 Thread via GitHub
hadoop-yetus commented on PR #5816: URL: https://github.com/apache/hadoop/pull/5816#issuecomment-1632116931 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5822: HDFS-17074. Remove incorrect comment in TestRedudantBlocks#setup.

2023-07-12 Thread via GitHub
hfutatzhanghb commented on PR #5822: URL: https://github.com/apache/hadoop/pull/5822#issuecomment-1632098271 @ayushtkn @zhangshuyan0 Hi, sir. Could you please help me review this simple modification when you have free time? Thanx a lot. -- This is an automated message from the Apache Git

[GitHub] [hadoop] hadoop-yetus commented on pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

2023-07-12 Thread via GitHub
hadoop-yetus commented on PR #5320: URL: https://github.com/apache/hadoop/pull/5320#issuecomment-1632075650 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18801) Delete path directly when it can not be parsed in trash

2023-07-12 Thread farmmamba (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742309#comment-17742309 ] farmmamba commented on HADOOP-18801: Thanks sir, I have fixed PR title.  But I did not modify

[jira] [Commented] (HADOOP-18801) Delete path directly when it can not be parsed in trash

2023-07-12 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742307#comment-17742307 ] Ayush Saxena commented on HADOOP-18801: --- yep, the PR title > Delete path directly when it can

[jira] [Commented] (HADOOP-18801) Delete path directly when it can not be parsed in trash

2023-07-12 Thread farmmamba (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742301#comment-17742301 ] farmmamba commented on HADOOP-18801: [~ayushtkn] [~hexiaoqiao] Hi, sir. Whether should i update git

[jira] [Commented] (HADOOP-18801) Delete path directly when it can not be parsed in trash

2023-07-12 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742300#comment-17742300 ] Ayush Saxena commented on HADOOP-18801: --- Thanx [~hexiaoqiao] for the details, I would prefer

[jira] [Commented] (HADOOP-18801) Delete path directly when it can not be parsed in trash

2023-07-12 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742274#comment-17742274 ] Xiaoqiao He commented on HADOOP-18801: -- Hi [~ayushtkn], In my practice, this case does exists.