[GitHub] [hadoop] ayushtkn merged pull request #5823: HDFS-17075. Reconfig disk balancer parameters for datanode

2023-07-15 Thread via GitHub
ayushtkn merged PR #5823: URL: https://github.com/apache/hadoop/pull/5823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] haiyang1987 commented on pull request #5845: HDFS-17087. Add Throttler for datanode reading block

2023-07-15 Thread via GitHub
haiyang1987 commented on PR #5845: URL: https://github.com/apache/hadoop/pull/5845#issuecomment-1636985126 Hi Sirs @Hexiaoqiao @ayushtkn @goiri Could you please help me review this pr when you have free time ? Thanks a lot~ -- This is an automated message from the Apache Git

[GitHub] [hadoop] haiyang1987 commented on pull request #5823: HDFS-17075. Reconfig disk balancer parameters for datanode

2023-07-15 Thread via GitHub
haiyang1987 commented on PR #5823: URL: https://github.com/apache/hadoop/pull/5823#issuecomment-1636984499 Hi @ayushtkn sir, has updated PR, please help me review this pr again when you have free time. Thanks a lot~ -- This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop] haiyang1987 commented on pull request #5846: HDFS-17088. Improve the debug verifyEC and dfsrouteradmin commands in HDFSCommands.md

2023-07-15 Thread via GitHub
haiyang1987 commented on PR #5846: URL: https://github.com/apache/hadoop/pull/5846#issuecomment-1636984055 > @haiyang1987 Thank you very much for your contribution! Whether the EC commands of HDFS are complete in the md document, can you help to check? If there is something missing, can we

[jira] [Commented] (HADOOP-18801) Delete path directly when it can not be parsed in trash

2023-07-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743489#comment-17743489 ] ASF GitHub Bot commented on HADOOP-18801: - hfutatzhanghb commented on PR #5744: URL:

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5744: HADOOP-18801. Delete path directly when it can not be parsed in trash.

2023-07-15 Thread via GitHub
hfutatzhanghb commented on PR #5744: URL: https://github.com/apache/hadoop/pull/5744#issuecomment-1636981711 @Hexiaoqiao @ayushtkn Thanks sir for reviewing and merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (HADOOP-18801) Delete path directly when it can not be parsed in trash

2023-07-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743488#comment-17743488 ] ASF GitHub Bot commented on HADOOP-18801: - Hexiaoqiao commented on PR #5744: URL:

[jira] [Resolved] (HADOOP-18801) Delete path directly when it can not be parsed in trash

2023-07-15 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoqiao He resolved HADOOP-18801. -- Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed > Delete path

[GitHub] [hadoop] Hexiaoqiao commented on pull request #5744: HADOOP-18801. Delete path directly when it can not be parsed in trash.

2023-07-15 Thread via GitHub
Hexiaoqiao commented on PR #5744: URL: https://github.com/apache/hadoop/pull/5744#issuecomment-1636977189 Committed to trunk. Thanks @hfutatzhanghb for your contribution and @ayushtkn for your reviews! -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HADOOP-18801) Delete path directly when it can not be parsed in trash

2023-07-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743487#comment-17743487 ] ASF GitHub Bot commented on HADOOP-18801: - Hexiaoqiao merged PR #5744: URL:

[GitHub] [hadoop] Hexiaoqiao merged pull request #5744: HADOOP-18801. Delete path directly when it can not be parsed in trash.

2023-07-15 Thread via GitHub
Hexiaoqiao merged PR #5744: URL: https://github.com/apache/hadoop/pull/5744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] slfan1989 commented on pull request #5846: HDFS-17088. Improve the debug verifyEC and dfsrouteradmin commands in HDFSCommands.md

2023-07-15 Thread via GitHub
slfan1989 commented on PR #5846: URL: https://github.com/apache/hadoop/pull/5846#issuecomment-1636933108 @haiyang1987 Thank you very much for your contribution! Whether the EC commands of HDFS are complete in the md document, can you help to check? If there is something missing, can we add

[GitHub] [hadoop] hadoop-yetus commented on pull request #5845: HDFS-17087. Add Throttler for datanode reading block

2023-07-15 Thread via GitHub
hadoop-yetus commented on PR #5845: URL: https://github.com/apache/hadoop/pull/5845#issuecomment-1636858032 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5823: HDFS-17075. Reconfig disk balancer parameters for datanode

2023-07-15 Thread via GitHub
hadoop-yetus commented on PR #5823: URL: https://github.com/apache/hadoop/pull/5823#issuecomment-1636812060 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5846: HDFS-17088. Improve the debug verifyEC and dfsrouteradmin commands in HDFSCommands.md

2023-07-15 Thread via GitHub
hadoop-yetus commented on PR #5846: URL: https://github.com/apache/hadoop/pull/5846#issuecomment-1636801591 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] haiyang1987 opened a new pull request, #5846: HDFS-17088. Improve the debug verifyEC and dfsrouteradmin commands in HDFSCommands.md

2023-07-15 Thread via GitHub
haiyang1987 opened a new pull request, #5846: URL: https://github.com/apache/hadoop/pull/5846 ### Description of PR https://issues.apache.org/jira/browse/HDFS-17088 Improve the debug verifyEC and dfsrouteradmin commands in HDFSCommands.md - the debug verifyEC add new

[GitHub] [hadoop] haiyang1987 opened a new pull request, #5845: HDFS-17087. Add Throttler for datanode reading block

2023-07-15 Thread via GitHub
haiyang1987 opened a new pull request, #5845: URL: https://github.com/apache/hadoop/pull/5845 ### Description of PR https://issues.apache.org/jira/browse/HDFS-17087 Current DataXceiver#readBlock doesn't throttler, maybe we can support throttle for reading block satisfied

[jira] [Commented] (HADOOP-18806) Document missing property (ipc.server.read.threadpool.size) in core-default.xml

2023-07-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743373#comment-17743373 ] ASF GitHub Bot commented on HADOOP-18806: - slfan1989 commented on PR #5844: URL:

[GitHub] [hadoop] slfan1989 commented on pull request #5844: HADOOP-18806. Document missing property (ipc.server.read.threadpool.size) in core-default.xml

2023-07-15 Thread via GitHub
slfan1989 commented on PR #5844: URL: https://github.com/apache/hadoop/pull/5844#issuecomment-1636734905 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] haiyang1987 commented on pull request #5842: HDFS-17086. Fix the parameter settings in TestDiskspaceQuotaUpdate#updateCountForQuota

2023-07-15 Thread via GitHub
haiyang1987 commented on PR #5842: URL: https://github.com/apache/hadoop/pull/5842#issuecomment-1636727695 Thanks @ayushtkn @slfan1989 help review and merge it !!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (HADOOP-18806) Document missing property (ipc.server.read.threadpool.size) in core-default.xml

2023-07-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743363#comment-17743363 ] ASF GitHub Bot commented on HADOOP-18806: - hadoop-yetus commented on PR #5844: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5844: HADOOP-18806. Document missing property (ipc.server.read.threadpool.size) in core-default.xml

2023-07-15 Thread via GitHub
hadoop-yetus commented on PR #5844: URL: https://github.com/apache/hadoop/pull/5844#issuecomment-1636718838 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18291) S3A prefetch - Implement LRU cache for SingleFilePerBlockCache

2023-07-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743361#comment-17743361 ] ASF GitHub Bot commented on HADOOP-18291: - hadoop-yetus commented on PR #5843: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5843: HADOOP-18291. ADDENDUM - S3A prefetch LRU test to work with small file

2023-07-15 Thread via GitHub
hadoop-yetus commented on PR #5843: URL: https://github.com/apache/hadoop/pull/5843#issuecomment-1636716817 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Comment Edited] (HADOOP-18805) s3a large file prefetch tests are too slow, don't validate data

2023-07-15 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743344#comment-17743344 ] Viraj Jasani edited comment on HADOOP-18805 at 7/15/23 6:48 AM: sorry

[GitHub] [hadoop] ayushtkn merged pull request #5842: HDFS-17086. Fix the parameter settings in TestDiskspaceQuotaUpdate#updateCountForQuota

2023-07-15 Thread via GitHub
ayushtkn merged PR #5842: URL: https://github.com/apache/hadoop/pull/5842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18772) remove use of com.google.common.base.Charsets;

2023-07-15 Thread Quan Li (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743348#comment-17743348 ] Quan Li commented on HADOOP-18772: -- I was waiting, not sure if it is ok to take without asking, that