[GitHub] [hadoop] haiyang1987 commented on pull request #5823: HDFS-17075. Reconfig disk balancer parameters for datanode

2023-07-17 Thread via GitHub
haiyang1987 commented on PR #5823: URL: https://github.com/apache/hadoop/pull/5823#issuecomment-1639465731 Thanks @ayushtkn help me review and merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HADOOP-18487) protobuf-2.5.0 dependencies => provided

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744063#comment-17744063 ] ASF GitHub Bot commented on HADOOP-18487: - hadoop-yetus commented on PR #4996: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4996: HADOOP-18487. protobuf 2.5.0 marked as provided.

2023-07-17 Thread via GitHub
hadoop-yetus commented on PR #4996: URL: https://github.com/apache/hadoop/pull/4996#issuecomment-1639436902 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] xinglin commented on pull request #5803: HDFS-17067 Use BlockingThreadPoolExecutorService for nnProbingThreadPool in ObserverReadProxy

2023-07-17 Thread via GitHub
xinglin commented on PR #5803: URL: https://github.com/apache/hadoop/pull/5803#issuecomment-1639427519 Hi @goiri, Could you review this PR as well? thanks, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (HADOOP-18809) s3a prefetch read/write file operations should guard channel close

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744034#comment-17744034 ] ASF GitHub Bot commented on HADOOP-18809: - virajjasani commented on PR #5853: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5853: HADOOP-18809. s3a prefetch read/write file operations should guard channel close

2023-07-17 Thread via GitHub
virajjasani commented on PR #5853: URL: https://github.com/apache/hadoop/pull/5853#issuecomment-1639179347 endpoint `us-west-2` (without any VPN) ``` $ mvn clean verify -Dparallel-tests -DtestsThreadCount=8 -Dscale -Dprefetch $ mvn clean verify -Dparallel-tests

[jira] [Commented] (HADOOP-18807) Close child file systems in ViewFileSystem when cache is disabled.

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744033#comment-17744033 ] ASF GitHub Bot commented on HADOOP-18807: - zhangshuyan0 commented on PR #5847: URL:

[GitHub] [hadoop] zhangshuyan0 commented on pull request #5847: HADOOP-18807. Close child file systems in ViewFileSystem when cache is disabled.

2023-07-17 Thread via GitHub
zhangshuyan0 commented on PR #5847: URL: https://github.com/apache/hadoop/pull/5847#issuecomment-1639176950 @steveloughran Thanks for your review and suggestions, which are very valuable. I have updated this PR based on your comment. Would you mind taking a look again? -- This is an

[jira] [Updated] (HADOOP-18809) s3a prefetch read/write file operations should guard channel close

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18809: Labels: pull-request-available (was: ) > s3a prefetch read/write file operations should

[jira] [Commented] (HADOOP-18809) s3a prefetch read/write file operations should guard channel close

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744032#comment-17744032 ] ASF GitHub Bot commented on HADOOP-18809: - virajjasani opened a new pull request, #5853: URL:

[GitHub] [hadoop] virajjasani opened a new pull request, #5853: HADOOP-18809. s3a prefetch read/write file operations should guard channel close

2023-07-17 Thread via GitHub
virajjasani opened a new pull request, #5853: URL: https://github.com/apache/hadoop/pull/5853 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Commented] (HADOOP-18807) Close child file systems in ViewFileSystem when cache is disabled.

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744031#comment-17744031 ] ASF GitHub Bot commented on HADOOP-18807: - zhangshuyan0 commented on code in PR #5847: URL:

[GitHub] [hadoop] zhangshuyan0 commented on a diff in pull request #5847: HADOOP-18807. Close child file systems in ViewFileSystem when cache is disabled.

2023-07-17 Thread via GitHub
zhangshuyan0 commented on code in PR #5847: URL: https://github.com/apache/hadoop/pull/5847#discussion_r1266100987 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemClose.java: ## @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache

[jira] [Commented] (HADOOP-18807) Close child file systems in ViewFileSystem when cache is disabled.

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744030#comment-17744030 ] ASF GitHub Bot commented on HADOOP-18807: - zhangshuyan0 commented on code in PR #5847: URL:

[GitHub] [hadoop] zhangshuyan0 commented on a diff in pull request #5847: HADOOP-18807. Close child file systems in ViewFileSystem when cache is disabled.

2023-07-17 Thread via GitHub
zhangshuyan0 commented on code in PR #5847: URL: https://github.com/apache/hadoop/pull/5847#discussion_r1266099967 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java: ## @@ -1926,12 +1926,41 @@ enum RenameStrategy {

[jira] [Created] (HADOOP-18809) s3a prefetch read/write file operations should guard channel close

2023-07-17 Thread Viraj Jasani (Jira)
Viraj Jasani created HADOOP-18809: - Summary: s3a prefetch read/write file operations should guard channel close Key: HADOOP-18809 URL: https://issues.apache.org/jira/browse/HADOOP-18809 Project:

[jira] [Commented] (HADOOP-18807) Close child file systems in ViewFileSystem when cache is disabled.

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744029#comment-17744029 ] ASF GitHub Bot commented on HADOOP-18807: - zhangshuyan0 commented on code in PR #5847: URL:

[GitHub] [hadoop] zhangshuyan0 commented on a diff in pull request #5847: HADOOP-18807. Close child file systems in ViewFileSystem when cache is disabled.

2023-07-17 Thread via GitHub
zhangshuyan0 commented on code in PR #5847: URL: https://github.com/apache/hadoop/pull/5847#discussion_r1266096591 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java: ## @@ -1926,12 +1926,41 @@ enum RenameStrategy {

[GitHub] [hadoop] xinglin commented on pull request #5804: HDFS-17042 Add rpcCallSuccesses and OverallRpcProcessingTime to RpcMetrics for Namenode (#5730)

2023-07-17 Thread via GitHub
xinglin commented on PR #5804: URL: https://github.com/apache/hadoop/pull/5804#issuecomment-1639043633 @goiri, ping for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] hadoop-yetus commented on pull request #5852: YARN-11533. CapacityScheduler CapacityConfigType changed in legacy queue allocation mode

2023-07-17 Thread via GitHub
hadoop-yetus commented on PR #5852: URL: https://github.com/apache/hadoop/pull/5852#issuecomment-1639025948 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18805) s3a large file prefetch tests are too slow, don't validate data

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743994#comment-17743994 ] ASF GitHub Bot commented on HADOOP-18805: - hadoop-yetus commented on PR #5851: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5851: HADOOP-18805. S3A prefetch LRU test to work with small files

2023-07-17 Thread via GitHub
hadoop-yetus commented on PR #5851: URL: https://github.com/apache/hadoop/pull/5851#issuecomment-1638965993 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] goiri commented on a diff in pull request #5841: YARN-11531. [Federation] Code cleanup for NodeManager#amrmproxy.

2023-07-17 Thread via GitHub
goiri commented on code in PR #5841: URL: https://github.com/apache/hadoop/pull/5841#discussion_r1265950558 ##

[GitHub] [hadoop] goiri commented on a diff in pull request #5810: YARN-7707. BackPort [GPG] Policy generator framework.

2023-07-17 Thread via GitHub
goiri commented on code in PR #5810: URL: https://github.com/apache/hadoop/pull/5810#discussion_r1265947134 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml: ## @@ -5426,4 +5426,36 @@ 100ms + + + The interval at

[jira] [Commented] (HADOOP-18805) s3a large file prefetch tests are too slow, don't validate data

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743989#comment-17743989 ] ASF GitHub Bot commented on HADOOP-18805: - virajjasani commented on PR #5851: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5851: HADOOP-18805. S3A prefetch LRU test to work with small files

2023-07-17 Thread via GitHub
virajjasani commented on PR #5851: URL: https://github.com/apache/hadoop/pull/5851#issuecomment-1638951638 jenkins build issue resolved as part of INFRA-24797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5637: YARN-11491. [Federation] Use ZookeeperFederationStateStore as the DefaultStateStore.

2023-07-17 Thread via GitHub
slfan1989 commented on code in PR #5637: URL: https://github.com/apache/hadoop/pull/5637#discussion_r1265919772 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java: ## @@ -4001,7 +4001,7 @@ public static boolean

[GitHub] [hadoop] slfan1989 commented on pull request #5846: HDFS-17088. Improve the debug verifyEC and dfsrouteradmin commands in HDFSCommands.md

2023-07-17 Thread via GitHub
slfan1989 commented on PR #5846: URL: https://github.com/apache/hadoop/pull/5846#issuecomment-1638902420 @haiyang1987 LGTM, let's look at other partners' suggestions, if there is no comment after 2 days, it will be merged to the trunk branch. -- This is an automated message from the

[GitHub] [hadoop] slfan1989 commented on pull request #5747: YARN-7707. BackPort [GPG] Policy generator framework.

2023-07-17 Thread via GitHub
slfan1989 commented on PR #5747: URL: https://github.com/apache/hadoop/pull/5747#issuecomment-1638899425 @goiri Can you help to merge this pr into the trunk branch? Thank you very much! I will continue to follow up bakcport [YARN-8934](https://issues.apache.org/jira/browse/YARN-8934). The

[GitHub] [hadoop] hadoop-yetus commented on pull request #3000: Bump ini from 1.3.5 to 1.3.8 in /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp

2023-07-17 Thread via GitHub
hadoop-yetus commented on PR #3000: URL: https://github.com/apache/hadoop/pull/3000#issuecomment-1638863883 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Comment Edited] (HADOOP-18805) s3a large file prefetch tests are too slow, don't validate data

2023-07-17 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743344#comment-17743344 ] Viraj Jasani edited comment on HADOOP-18805 at 7/17/23 8:15 PM: sorry

[GitHub] [hadoop] hadoop-yetus commented on pull request #5849: HDFS-17091. Blocks on DECOMMISSIONING DNs should be sorted properly in LocatedBlocks.

2023-07-17 Thread via GitHub
hadoop-yetus commented on PR #5849: URL: https://github.com/apache/hadoop/pull/5849#issuecomment-1638806249 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5784: YARN-9877 - Intermittent TIME_OUT of LogAggregationReport

2023-07-17 Thread via GitHub
hadoop-yetus commented on PR #5784: URL: https://github.com/apache/hadoop/pull/5784#issuecomment-1638750770 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5816: YARN-11525. [Federation] Router CLI Supports Save the SubClusterPolicyConfiguration Of Queues.

2023-07-17 Thread via GitHub
hadoop-yetus commented on PR #5816: URL: https://github.com/apache/hadoop/pull/5816#issuecomment-1638735062 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] brumi1024 opened a new pull request, #5852: YARN-11553. CapacityScheduler CapacityConfigType changed in legacy queue allocation mode

2023-07-17 Thread via GitHub
brumi1024 opened a new pull request, #5852: URL: https://github.com/apache/hadoop/pull/5852 ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: have the integration tests

[jira] [Commented] (HADOOP-18808) LogExactlyOnce to add a debug() method

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743933#comment-17743933 ] ASF GitHub Bot commented on HADOOP-18808: - hadoop-yetus commented on PR #5850: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5850: HADOOP-18808. LogExactlyOnce to add a debug() method

2023-07-17 Thread via GitHub
hadoop-yetus commented on PR #5850: URL: https://github.com/apache/hadoop/pull/5850#issuecomment-1638693346 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5849: HDFS-17091. Blocks on DECOMMISSIONING DNs should be sorted properly in LocatedBlocks.

2023-07-17 Thread via GitHub
hadoop-yetus commented on PR #5849: URL: https://github.com/apache/hadoop/pull/5849#issuecomment-163878 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5849: HDFS-17091. Blocks on DECOMMISSIONING DNs should be sorted properly in LocatedBlocks.

2023-07-17 Thread via GitHub
hadoop-yetus commented on PR #5849: URL: https://github.com/apache/hadoop/pull/5849#issuecomment-1638636174 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18805) s3a large file prefetch tests are too slow, don't validate data

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743918#comment-17743918 ] ASF GitHub Bot commented on HADOOP-18805: - virajjasani commented on PR #5843: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5843: HADOOP-18805. S3A prefetch LRU test to work with small files

2023-07-17 Thread via GitHub
virajjasani commented on PR #5843: URL: https://github.com/apache/hadoop/pull/5843#issuecomment-1638630837 created new PR #5851 for HADOOP-18805 (since we have new Jira) as the builds are not getting triggered successfully here -- This is an automated message from the Apache Git Service.

[jira] [Commented] (HADOOP-18805) s3a large file prefetch tests are too slow, don't validate data

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743917#comment-17743917 ] ASF GitHub Bot commented on HADOOP-18805: - virajjasani commented on PR #5851: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5851: HADOOP-18805. S3A prefetch LRU test to work with small files

2023-07-17 Thread via GitHub
virajjasani commented on PR #5851: URL: https://github.com/apache/hadoop/pull/5851#issuecomment-1638629315 This PR build is also failing with likely jenkins env issue https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5851/1/console ``` Error when executing cleanup post

[jira] [Commented] (HADOOP-18805) s3a large file prefetch tests are too slow, don't validate data

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743916#comment-17743916 ] ASF GitHub Bot commented on HADOOP-18805: - virajjasani opened a new pull request, #5851: URL:

[GitHub] [hadoop] virajjasani opened a new pull request, #5851: HADOOP-18805. S3A prefetch LRU test to work with small files

2023-07-17 Thread via GitHub
virajjasani opened a new pull request, #5851: URL: https://github.com/apache/hadoop/pull/5851 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Commented] (HADOOP-18805) s3a large file prefetch tests are too slow, don't validate data

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743914#comment-17743914 ] ASF GitHub Bot commented on HADOOP-18805: - virajjasani closed pull request #5843: HADOOP-18805.

[GitHub] [hadoop] virajjasani closed pull request #5843: HADOOP-18805. S3A prefetch LRU test to work with small files

2023-07-17 Thread via GitHub
virajjasani closed pull request #5843: HADOOP-18805. S3A prefetch LRU test to work with small files URL: https://github.com/apache/hadoop/pull/5843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (HADOOP-18805) s3a large file prefetch tests are too slow, don't validate data

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18805: Labels: pull-request-available (was: ) > s3a large file prefetch tests are too slow,

[jira] [Commented] (HADOOP-18805) s3a large file prefetch tests are too slow, don't validate data

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743913#comment-17743913 ] ASF GitHub Bot commented on HADOOP-18805: - virajjasani commented on PR #5843: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5843: HADOOP-18805. S3A prefetch LRU test to work with small files

2023-07-17 Thread via GitHub
virajjasani commented on PR #5843: URL: https://github.com/apache/hadoop/pull/5843#issuecomment-1638618095 there is clearly something wrong with jenkins env/config, i am going to close this addendum PR and create new one for HADOOP-18805 -- This is an automated message from the Apache

[jira] [Commented] (HADOOP-18291) S3A prefetch - Implement LRU cache for SingleFilePerBlockCache

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743900#comment-17743900 ] ASF GitHub Bot commented on HADOOP-18291: - virajjasani closed pull request #5843: HADOOP-18291.

[jira] [Commented] (HADOOP-18291) S3A prefetch - Implement LRU cache for SingleFilePerBlockCache

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743901#comment-17743901 ] ASF GitHub Bot commented on HADOOP-18291: - virajjasani opened a new pull request, #5843: URL:

[jira] [Commented] (HADOOP-18291) S3A prefetch - Implement LRU cache for SingleFilePerBlockCache

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743899#comment-17743899 ] ASF GitHub Bot commented on HADOOP-18291: - virajjasani commented on PR #5843: URL:

[GitHub] [hadoop] virajjasani closed pull request #5843: HADOOP-18291. ADDENDUM - S3A prefetch LRU test to work with small files

2023-07-17 Thread via GitHub
virajjasani closed pull request #5843: HADOOP-18291. ADDENDUM - S3A prefetch LRU test to work with small files URL: https://github.com/apache/hadoop/pull/5843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop] virajjasani commented on pull request #5843: HADOOP-18291. ADDENDUM - S3A prefetch LRU test to work with small files

2023-07-17 Thread via GitHub
virajjasani commented on PR #5843: URL: https://github.com/apache/hadoop/pull/5843#issuecomment-1638558569 somehow jenkins build is not getting triggered, let me re-open the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (HADOOP-18795) s3a DelegationToken plugin to expand return type of deploy/binding

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743856#comment-17743856 ] ASF GitHub Bot commented on HADOOP-18795: - hadoop-yetus commented on PR #5821: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5821: HADOOP-18795. S3A DelegationToken plugin to expand return type of binding

2023-07-17 Thread via GitHub
hadoop-yetus commented on PR #5821: URL: https://github.com/apache/hadoop/pull/5821#issuecomment-1638428011 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18808) LogExactlyOnce to add a debug() method

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743829#comment-17743829 ] ASF GitHub Bot commented on HADOOP-18808: - steveloughran opened a new pull request, #5850: URL:

[jira] [Updated] (HADOOP-18808) LogExactlyOnce to add a debug() method

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18808: Labels: pull-request-available (was: ) > LogExactlyOnce to add a debug() method >

[GitHub] [hadoop] steveloughran opened a new pull request, #5850: HADOOP-18808. LogExactlyOnce to add a debug() method

2023-07-17 Thread via GitHub
steveloughran opened a new pull request, #5850: URL: https://github.com/apache/hadoop/pull/5850 ### How was this patch tested? waiting for yetus ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g.

[jira] [Created] (HADOOP-18808) LogExactlyOnce to add a debug() method

2023-07-17 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-18808: --- Summary: LogExactlyOnce to add a debug() method Key: HADOOP-18808 URL: https://issues.apache.org/jira/browse/HADOOP-18808 Project: Hadoop Common Issue

[GitHub] [hadoop] hadoop-yetus commented on pull request #5846: HDFS-17088. Improve the debug verifyEC and dfsrouteradmin commands in HDFSCommands.md

2023-07-17 Thread via GitHub
hadoop-yetus commented on PR #5846: URL: https://github.com/apache/hadoop/pull/5846#issuecomment-1638209950 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] steveloughran closed pull request #5376: HADOOP-185768. followup

2023-07-17 Thread via GitHub
steveloughran closed pull request #5376: HADOOP-185768. followup URL: https://github.com/apache/hadoop/pull/5376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] slfan1989 commented on pull request #5849: HDFS-17091. Blocks on DECOMMISSIONING DNs should be sorted properly in LocatedBlocks.

2023-07-17 Thread via GitHub
slfan1989 commented on PR #5849: URL: https://github.com/apache/hadoop/pull/5849#issuecomment-1638064778 Good Catch! @tomscut Can you help to review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] hadoop-yetus commented on pull request #1747: HDFS-15042 Add more tests for ByteBufferPositionedReadable.

2023-07-17 Thread via GitHub
hadoop-yetus commented on PR #1747: URL: https://github.com/apache/hadoop/pull/1747#issuecomment-1638056754 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] YuanbenWang opened a new pull request, #5849: HDFS-17091. Blocks on DECOMMISSIONING DNs should be sorted properly in LocatedBlocks.

2023-07-17 Thread via GitHub
YuanbenWang opened a new pull request, #5849: URL: https://github.com/apache/hadoop/pull/5849 JIRA: [HDFS-17091](https://issues.apache.org/jira/browse/HDFS-17091). Blocks on DECOMMISSIONING DNs should be sorted properly in LocatedBlocks. -- This is an automated message from the Apache

[GitHub] [hadoop] haiyang1987 commented on pull request #5846: HDFS-17088. Improve the debug verifyEC and dfsrouteradmin commands in HDFSCommands.md

2023-07-17 Thread via GitHub
haiyang1987 commented on PR #5846: URL: https://github.com/apache/hadoop/pull/5846#issuecomment-1637984966 Hi @slfan1989 Sir, update EC command of HDFS in the md document. please help me review again when you have free time ? Thanks a lot~ -- This is an automated message from the

[GitHub] [hadoop] hadoop-yetus commented on pull request #5848: MAPREDUCE-7442. Exception message is not intusive when accessing the …

2023-07-17 Thread via GitHub
hadoop-yetus commented on PR #5848: URL: https://github.com/apache/hadoop/pull/5848#issuecomment-1637952535 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5816: YARN-11525. [Federation] Router CLI Supports Save the SubClusterPolicyConfiguration Of Queues.

2023-07-17 Thread via GitHub
hadoop-yetus commented on PR #5816: URL: https://github.com/apache/hadoop/pull/5816#issuecomment-1637924903 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5838: MAPREDUCE-7442. Fix exception message is not intusive when accessing the job configuration web UI

2023-07-17 Thread via GitHub
hadoop-yetus commented on PR #5838: URL: https://github.com/apache/hadoop/pull/5838#issuecomment-1637916326 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18807) Close child file systems in ViewFileSystem when cache is disabled.

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743751#comment-17743751 ] ASF GitHub Bot commented on HADOOP-18807: - hadoop-yetus commented on PR #5847: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5847: HADOOP-18807. Close child file systems in ViewFileSystem when cache is disabled.

2023-07-17 Thread via GitHub
hadoop-yetus commented on PR #5847: URL: https://github.com/apache/hadoop/pull/5847#issuecomment-1637892800 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18291) S3A prefetch - Implement LRU cache for SingleFilePerBlockCache

2023-07-17 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743723#comment-17743723 ] Steve Loughran commented on HADOOP-18291: - [~quanli] how is it failing? what is your test setup

[jira] [Commented] (HADOOP-18807) Close child file systems in ViewFileSystem when cache is disabled.

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743718#comment-17743718 ] ASF GitHub Bot commented on HADOOP-18807: - steveloughran commented on code in PR #5847: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5847: HADOOP-18807. Close child file systems in ViewFileSystem when cache is disabled.

2023-07-17 Thread via GitHub
steveloughran commented on code in PR #5847: URL: https://github.com/apache/hadoop/pull/5847#discussion_r1265143881 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java: ## @@ -1926,12 +1926,41 @@ enum RenameStrategy {

[GitHub] [hadoop] liangyu-1 commented on pull request #5848: MAPREDUCE-7442. Exception message is not intusive when accessing the …

2023-07-17 Thread via GitHub
liangyu-1 commented on PR #5848: URL: https://github.com/apache/hadoop/pull/5848#issuecomment-1637675746 @ferhui Is this pr submitted in a correct way ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] liangyu-1 opened a new pull request, #5848: MAPREDUCE-7442. Exception message is not intusive when accessing the …

2023-07-17 Thread via GitHub
liangyu-1 opened a new pull request, #5848: URL: https://github.com/apache/hadoop/pull/5848 ### Description of PR fix the bug is issue [MAPREDUCE-7442](https://issues.apache.org/jira/browse/MAPREDUCE-7442) this PR fix the bug that exception message is not intusive when

[jira] [Commented] (HADOOP-18807) Close child file systems in ViewFileSystem when cache is disabled.

2023-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743682#comment-17743682 ] ASF GitHub Bot commented on HADOOP-18807: - Hexiaoqiao commented on PR #5847: URL:

[GitHub] [hadoop] Hexiaoqiao commented on pull request #5847: HADOOP-18807. Close child file systems in ViewFileSystem when cache is disabled.

2023-07-17 Thread via GitHub
Hexiaoqiao commented on PR #5847: URL: https://github.com/apache/hadoop/pull/5847#issuecomment-1637629820 Make sense to me. +1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] hadoop-yetus commented on pull request #5810: YARN-7707. BackPort [GPG] Policy generator framework.

2023-07-17 Thread via GitHub
hadoop-yetus commented on PR #5810: URL: https://github.com/apache/hadoop/pull/5810#issuecomment-1637626654 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] liangyu-1 closed pull request #5838: fix MAPREDUCE-7442. Fix exception message is not intusive when accessing the job configuration web UI

2023-07-17 Thread via GitHub
liangyu-1 closed pull request #5838: fix MAPREDUCE-7442. Fix exception message is not intusive when accessing the job configuration web UI URL: https://github.com/apache/hadoop/pull/5838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] hadoop-yetus commented on pull request #5841: YARN-11531. [Federation] Code cleanup for NodeManager#amrmproxy.

2023-07-17 Thread via GitHub
hadoop-yetus commented on PR #5841: URL: https://github.com/apache/hadoop/pull/5841#issuecomment-1637556563 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ferhui commented on pull request #5838: fix MAPREDUCE-7442. Fix exception message is not intusive when accessing the job configuration web UI

2023-07-17 Thread via GitHub
ferhui commented on PR #5838: URL: https://github.com/apache/hadoop/pull/5838#issuecomment-1637451714 BTW can refer to https://cwiki.apache.org/confluence/display/hadoop/how+to+contribute and work with the community in the right way next time.Thanks -- This is an automated message

[GitHub] [hadoop] ferhui commented on pull request #5838: fix MAPREDUCE-7442. Fix exception message is not intusive when accessing the job configuration web UI

2023-07-17 Thread via GitHub
ferhui commented on PR #5838: URL: https://github.com/apache/hadoop/pull/5838#issuecomment-1637450624 @liangyu-1 Good catch. Thanks for your contribution. Could you please push an empty commit? So that I can rewrite the commit message when merging it. -- This is an automated message