hadoop-yetus commented on PR #5862:
URL: https://github.com/apache/hadoop/pull/5862#issuecomment-1650986267
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5810:
URL: https://github.com/apache/hadoop/pull/5810#issuecomment-1650983000
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
simbadzina commented on PR #5860:
URL: https://github.com/apache/hadoop/pull/5860#issuecomment-1650949591
> LGTM
Thanks for the review @ayushtkn . Could you please merge this PR for me when
you get a chance.
--
This is an automated message from the Apache Git Service.
To respond
hadoop-yetus commented on PR #5726:
URL: https://github.com/apache/hadoop/pull/5726#issuecomment-1650935014
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
yangjiandan opened a new pull request, #5890:
URL: https://github.com/apache/hadoop/pull/5890
I have noticed that the application can not be filtered correctly in the
CapacityScheduer page when I submit apps with leaf queue‘s name.
*Steps to Reproduce:*
1. create a mr app with
tomscut commented on PR #5888:
URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1650932324
>
I agree with @Hexiaoqiao . We have done something similar before, and here
we need to ensure the order of `FBR` and `IBR`.
--
This is an automated message from the Apache
Hexiaoqiao commented on PR #5888:
URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1650922152
Good improvement. Not think carefully but my first feeling, IBR - FBR
mis-order could trigger some issues, such as miss some block report? One case,
a. generate full block report,
Hexiaoqiao commented on PR #5889:
URL: https://github.com/apache/hadoop/pull/5889#issuecomment-1650917800
> I am still confused about the purpose of this order. Can you be more
specific?
+1. Why? some issues meet or it can improve performance? Thanks.
--
This is an automated
Hexiaoqiao commented on code in PR #5877:
URL: https://github.com/apache/hadoop/pull/5877#discussion_r1274324258
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/NamenodeBeanMetrics.java:
##
@@ -884,6 +884,11 @@ public int
umamaheswararao commented on code in PR #5885:
URL: https://github.com/apache/hadoop/pull/5885#discussion_r1274301605
##
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/SimpleCopyListing.java:
##
@@ -316,6 +303,42 @@ protected void
umamaheswararao commented on code in PR #5885:
URL: https://github.com/apache/hadoop/pull/5885#discussion_r1274292957
##
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/CopyListing.java:
##
@@ -305,6 +305,33 @@ public static CopyListing
umamaheswararao commented on code in PR #5885:
URL: https://github.com/apache/hadoop/pull/5885#discussion_r1274291510
##
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/CopyListing.java:
##
@@ -305,6 +305,33 @@ public static CopyListing
virajjasani commented on PR #5888:
URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1650693699
the changes look good at high level, could you please take care of
checkstyle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
hadoop-yetus commented on PR #5885:
URL: https://github.com/apache/hadoop/pull/5885#issuecomment-1650684670
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simbarashe Dzinamarira updated HADOOP-18827:
Issue Type: Bug (was: Improvement)
Priority: Minor (was: Major)
[
https://issues.apache.org/jira/browse/HADOOP-18827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simbarashe Dzinamarira updated HADOOP-18827:
Environment: (was: The "dfs.client.rbf.observer.enabled" flag was add
[
https://issues.apache.org/jira/browse/HADOOP-18827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simbarashe Dzinamarira updated HADOOP-18827:
Description:
The "dfs.client.rbf.observer.enabled" flag was add to allow
[
https://issues.apache.org/jira/browse/HADOOP-18827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simbarashe Dzinamarira reassigned HADOOP-18827:
---
Assignee: Simbarashe Dzinamarira
>
Simbarashe Dzinamarira created HADOOP-18827:
---
Summary: RouterObserverReadProxyProvider should respect observer
read opt-out via dfs.client.rbf.observer.enabled=false flag.
Key: HADOOP-18827
URL:
[
https://issues.apache.org/jira/browse/HADOOP-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747171#comment-17747171
]
ASF GitHub Bot commented on HADOOP-18805:
-
hadoop-yetus commented on PR #5887:
URL:
hadoop-yetus commented on PR #5887:
URL: https://github.com/apache/hadoop/pull/5887#issuecomment-1650563407
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747167#comment-17747167
]
ASF GitHub Bot commented on HADOOP-18805:
-
virajjasani commented on PR #5887:
URL:
virajjasani commented on PR #5887:
URL: https://github.com/apache/hadoop/pull/5887#issuecomment-1650546288
us-west-2:
`$ mvn clean verify -Dparallel-tests -DtestsThreadCount=8 -Dscale -Dprefetch`
```
[INFO]
sadanand48 commented on code in PR #5885:
URL: https://github.com/apache/hadoop/pull/5885#discussion_r1274102593
##
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/CopyListing.java:
##
@@ -305,6 +305,33 @@ public static CopyListing getCopyListing(Configuration
Sergey Shabalov created HADOOP-18826:
Summary: REST request fails with "Value for one of the query
parameters specified in the request URI is invalid.", 400,
Key: HADOOP-18826
URL:
[
https://issues.apache.org/jira/browse/HADOOP-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747104#comment-17747104
]
ASF GitHub Bot commented on HADOOP-18805:
-
virajjasani commented on PR #5887:
URL:
virajjasani commented on PR #5887:
URL: https://github.com/apache/hadoop/pull/5887#issuecomment-1650348987
rebased, re-testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
hadoop-yetus commented on PR #5889:
URL: https://github.com/apache/hadoop/pull/5889#issuecomment-1650329878
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
Eugene Shinn (Truveta) created HADOOP-18825:
---
Summary: Address Netty 4.x / CWE-295 by configuring hostname
verification
Key: HADOOP-18825
URL: https://issues.apache.org/jira/browse/HADOOP-18825
hadoop-yetus commented on PR #5855:
URL: https://github.com/apache/hadoop/pull/5855#issuecomment-1650254030
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747075#comment-17747075
]
Steve Loughran commented on HADOOP-18817:
-
we are actually happy to take an sdk update, whose
hadoop-yetus commented on PR #5877:
URL: https://github.com/apache/hadoop/pull/5877#issuecomment-1650208517
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5889:
URL: https://github.com/apache/hadoop/pull/5889#issuecomment-1650129935
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
swamirishi commented on code in PR #5885:
URL: https://github.com/apache/hadoop/pull/5885#discussion_r1273728074
##
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/CopyListing.java:
##
@@ -305,6 +305,33 @@ public static CopyListing getCopyListing(Configuration
hadoop-yetus commented on PR #5888:
URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1650088835
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5825:
URL: https://github.com/apache/hadoop/pull/5825#issuecomment-1649916114
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5879:
URL: https://github.com/apache/hadoop/pull/5879#issuecomment-1649896722
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5885:
URL: https://github.com/apache/hadoop/pull/5885#issuecomment-1649840700
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5879:
URL: https://github.com/apache/hadoop/pull/5879#issuecomment-1649755296
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hfutatzhanghb commented on PR #5889:
URL: https://github.com/apache/hadoop/pull/5889#issuecomment-1649746379
@Hexiaoqiao @ayushtkn @slfan1989 @tomscut Sir, could you please help me
review this code when you have free time ? Thanks a lot.
--
This is an automated message from the Apache
hfutatzhanghb commented on PR #5889:
URL: https://github.com/apache/hadoop/pull/5889#issuecomment-1649723105
> @hfutatzhanghb Thanks for your contribution! Can we apply for a JIRA
ticket?
@slfan1989 Sir, thanks for replying, have updated JIRA ticket~
--
This is an automated
[
https://issues.apache.org/jira/browse/HADOOP-18184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746944#comment-17746944
]
ASF GitHub Bot commented on HADOOP-18184:
-
steveloughran commented on code in PR #5832:
URL:
steveloughran commented on code in PR #5832:
URL: https://github.com/apache/hadoop/pull/5832#discussion_r1273422607
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/CachingBlockManager.java:
##
@@ -392,16 +413,41 @@ private void
[
https://issues.apache.org/jira/browse/HADOOP-18184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746939#comment-17746939
]
ASF GitHub Bot commented on HADOOP-18184:
-
steveloughran commented on code in PR #5832:
URL:
steveloughran commented on code in PR #5832:
URL: https://github.com/apache/hadoop/pull/5832#discussion_r1273419854
##
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/prefetch/S3ARemoteInputStream.java:
##
@@ -409,27 +455,54 @@ protected String getOffsetStr(long
hadoop-yetus commented on PR #5885:
URL: https://github.com/apache/hadoop/pull/5885#issuecomment-1649663453
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746926#comment-17746926
]
ASF GitHub Bot commented on HADOOP-18805:
-
steveloughran commented on PR #5887:
URL:
steveloughran commented on PR #5887:
URL: https://github.com/apache/hadoop/pull/5887#issuecomment-1649658882
ok, merged the dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
slfan1989 commented on PR #5889:
URL: https://github.com/apache/hadoop/pull/5889#issuecomment-1649624428
@hfutatzhanghb Thanks for your contribution! Can we apply for a JIRA ticket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
anujmodi2021 commented on code in PR #5881:
URL: https://github.com/apache/hadoop/pull/5881#discussion_r1273349708
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/TestTracingContext.java:
##
@@ -270,4 +273,71 @@ fileSystemId,
anujmodi2021 commented on code in PR #5881:
URL: https://github.com/apache/hadoop/pull/5881#discussion_r1273348707
##
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TracingContext.java:
##
@@ -217,10 +220,13 @@ private String
hfutatzhanghb opened a new pull request, #5889:
URL: https://github.com/apache/hadoop/pull/5889
### Description of PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/HADOOP-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746898#comment-17746898
]
ASF GitHub Bot commented on HADOOP-18805:
-
steveloughran commented on PR #5887:
URL:
steveloughran commented on PR #5887:
URL: https://github.com/apache/hadoop/pull/5887#issuecomment-1649550036
will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
haiyang1987 commented on PR #5845:
URL: https://github.com/apache/hadoop/pull/5845#issuecomment-1649535558
Hi Sir @ayushtkn @Hexiaoqiao @tomscut Could you please help me review this
pr again when you have free time ? Thanks a lot~
--
This is an automated message from the Apache Git
haiyang1987 commented on PR #5877:
URL: https://github.com/apache/hadoop/pull/5877#issuecomment-1649532827
Hi Sir @Hexiaoqiao @tomscut update PR, add UT and fix checkstyle.
please help review this PR when you have free time, Thanks a lot~
--
This is an automated message from the Apache
hadoop-yetus commented on PR #5878:
URL: https://github.com/apache/hadoop/pull/5878#issuecomment-1649502190
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5878:
URL: https://github.com/apache/hadoop/pull/5878#issuecomment-1649501545
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
LiuGuH opened a new pull request, #5888:
URL: https://github.com/apache/hadoop/pull/5888
### Description of PR
After [HDFS-16016](https://issues.apache.org/jira/browse/HDFS-16016) , it
makes ibr in a thread to avoid heartbeat blocking with ibr when require
readlock in Datanode.
hadoop-yetus commented on PR #5825:
URL: https://github.com/apache/hadoop/pull/5825#issuecomment-1649457646
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hfutatzhanghb commented on PR #5825:
URL: https://github.com/apache/hadoop/pull/5825#issuecomment-1649418822
The failed unit tests were all passed in my local.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
brumi1024 commented on code in PR #5871:
URL: https://github.com/apache/hadoop/pull/5871#discussion_r1273195384
##
hadoop-yetus commented on PR #5825:
URL: https://github.com/apache/hadoop/pull/5825#issuecomment-1649366206
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
brumi1024 commented on code in PR #5871:
URL: https://github.com/apache/hadoop/pull/5871#discussion_r1273182469
##
hadoop-yetus commented on PR #5885:
URL: https://github.com/apache/hadoop/pull/5885#issuecomment-1649328587
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5862:
URL: https://github.com/apache/hadoop/pull/5862#issuecomment-1649321336
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
zhiubok commented on PR #5879:
URL: https://github.com/apache/hadoop/pull/5879#issuecomment-1649312252
Hi @ayushtkn Could you help review this when you have time? And solved the
problem that some jira accounts could not be applied for, Thanks!
--
This is an automated message from the
sadanand48 commented on PR #5885:
URL: https://github.com/apache/hadoop/pull/5885#issuecomment-1649205250
@ayushtkn @steveloughran @umamaheswararao Can I please get a review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
68 matches
Mail list logo