[GitHub] [hadoop] hadoop-yetus commented on pull request #5862: YARN-11536. [Federation] Router CLI Supports Batch Save the SubClusterPolicyConfiguration Of Queues.

2023-07-25 Thread via GitHub
hadoop-yetus commented on PR #5862: URL: https://github.com/apache/hadoop/pull/5862#issuecomment-1650986267 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5810: YARN-7707. BackPort [GPG] Policy generator framework.

2023-07-25 Thread via GitHub
hadoop-yetus commented on PR #5810: URL: https://github.com/apache/hadoop/pull/5810#issuecomment-1650983000 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] simbadzina commented on pull request #5860: HDFS-17111. RBF: Optimize msync to only call nameservices that have observer reads enabled.

2023-07-25 Thread via GitHub
simbadzina commented on PR #5860: URL: https://github.com/apache/hadoop/pull/5860#issuecomment-1650949591 > LGTM Thanks for the review @ayushtkn . Could you please merge this PR for me when you get a chance. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop] hadoop-yetus commented on pull request #5726: YARN-11508. [Minor] Improve UnmanagedAMPoolManager/UnmanagedApplicationManager Code

2023-07-25 Thread via GitHub
hadoop-yetus commented on PR #5726: URL: https://github.com/apache/hadoop/pull/5726#issuecomment-1650935014 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] yangjiandan opened a new pull request, #5890: YARN-11538. CS UI: queue filter do not work as expected when submitti…

2023-07-25 Thread via GitHub
yangjiandan opened a new pull request, #5890: URL: https://github.com/apache/hadoop/pull/5890 I have noticed that the application can not be filtered correctly in the CapacityScheduer page when I submit apps with leaf queue‘s name. *Steps to Reproduce:* 1. create a mr app with

[GitHub] [hadoop] tomscut commented on pull request #5888: HDFS-17121. BPServiceActor to provide new thread to handle FBR

2023-07-25 Thread via GitHub
tomscut commented on PR #5888: URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1650932324 > I agree with @Hexiaoqiao . We have done something similar before, and here we need to ensure the order of `FBR` and `IBR`. -- This is an automated message from the Apache

[GitHub] [hadoop] Hexiaoqiao commented on pull request #5888: HDFS-17121. BPServiceActor to provide new thread to handle FBR

2023-07-25 Thread via GitHub
Hexiaoqiao commented on PR #5888: URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1650922152 Good improvement. Not think carefully but my first feeling, IBR - FBR mis-order could trigger some issues, such as miss some block report? One case, a. generate full block report,

[GitHub] [hadoop] Hexiaoqiao commented on pull request #5889: HDFS-17123. Sort datanodeStorages when generating StorageBlockReport[] in method BPServiceActor#blockReport for future convenience

2023-07-25 Thread via GitHub
Hexiaoqiao commented on PR #5889: URL: https://github.com/apache/hadoop/pull/5889#issuecomment-1650917800 > I am still confused about the purpose of this order. Can you be more specific? +1. Why? some issues meet or it can improve performance? Thanks. -- This is an automated

[GitHub] [hadoop] Hexiaoqiao commented on a diff in pull request #5877: HDFS-17117. BlockManager#processMisReplicatesAsync can periodically print reconstructionQueuesInitProgress

2023-07-25 Thread via GitHub
Hexiaoqiao commented on code in PR #5877: URL: https://github.com/apache/hadoop/pull/5877#discussion_r1274324258 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/NamenodeBeanMetrics.java: ## @@ -884,6 +884,11 @@ public int

[GitHub] [hadoop] umamaheswararao commented on a diff in pull request #5885: HDFS-17120. Support snapshot diff based copylisting for flat paths.

2023-07-25 Thread via GitHub
umamaheswararao commented on code in PR #5885: URL: https://github.com/apache/hadoop/pull/5885#discussion_r1274301605 ## hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/SimpleCopyListing.java: ## @@ -316,6 +303,42 @@ protected void

[GitHub] [hadoop] umamaheswararao commented on a diff in pull request #5885: HDFS-17120. Support snapshot diff based copylisting for flat paths.

2023-07-25 Thread via GitHub
umamaheswararao commented on code in PR #5885: URL: https://github.com/apache/hadoop/pull/5885#discussion_r1274292957 ## hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/CopyListing.java: ## @@ -305,6 +305,33 @@ public static CopyListing

[GitHub] [hadoop] umamaheswararao commented on a diff in pull request #5885: HDFS-17120. Support snapshot diff based copylisting for flat paths.

2023-07-25 Thread via GitHub
umamaheswararao commented on code in PR #5885: URL: https://github.com/apache/hadoop/pull/5885#discussion_r1274291510 ## hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/CopyListing.java: ## @@ -305,6 +305,33 @@ public static CopyListing

[GitHub] [hadoop] virajjasani commented on pull request #5888: HDFS-17121. BPServiceActor to provide new thread to handle FBR

2023-07-25 Thread via GitHub
virajjasani commented on PR #5888: URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1650693699 the changes look good at high level, could you please take care of checkstyle? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hadoop] hadoop-yetus commented on pull request #5885: HDFS-17120. Support snapshot diff based copylisting for flat paths.

2023-07-25 Thread via GitHub
hadoop-yetus commented on PR #5885: URL: https://github.com/apache/hadoop/pull/5885#issuecomment-1650684670 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-18827) RouterObserverReadProxyProvider should respect observer read opt-out via dfs.client.rbf.observer.enabled=false flag.

2023-07-25 Thread Simbarashe Dzinamarira (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simbarashe Dzinamarira updated HADOOP-18827: Issue Type: Bug (was: Improvement) Priority: Minor (was: Major)

[jira] [Updated] (HADOOP-18827) RouterObserverReadProxyProvider should respect observer read opt-out via dfs.client.rbf.observer.enabled=false flag.

2023-07-25 Thread Simbarashe Dzinamarira (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simbarashe Dzinamarira updated HADOOP-18827: Environment: (was: The "dfs.client.rbf.observer.enabled" flag was add

[jira] [Updated] (HADOOP-18827) RouterObserverReadProxyProvider should respect observer read opt-out via dfs.client.rbf.observer.enabled=false flag.

2023-07-25 Thread Simbarashe Dzinamarira (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simbarashe Dzinamarira updated HADOOP-18827: Description: The "dfs.client.rbf.observer.enabled" flag was add to allow

[jira] [Assigned] (HADOOP-18827) RouterObserverReadProxyProvider should respect observer read opt-out via dfs.client.rbf.observer.enabled=false flag.

2023-07-25 Thread Simbarashe Dzinamarira (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simbarashe Dzinamarira reassigned HADOOP-18827: --- Assignee: Simbarashe Dzinamarira >

[jira] [Created] (HADOOP-18827) RouterObserverReadProxyProvider should respect observer read opt-out via dfs.client.rbf.observer.enabled=false flag.

2023-07-25 Thread Simbarashe Dzinamarira (Jira)
Simbarashe Dzinamarira created HADOOP-18827: --- Summary: RouterObserverReadProxyProvider should respect observer read opt-out via dfs.client.rbf.observer.enabled=false flag. Key: HADOOP-18827 URL:

[jira] [Commented] (HADOOP-18805) s3a large file prefetch tests are too slow, don't validate data

2023-07-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747171#comment-17747171 ] ASF GitHub Bot commented on HADOOP-18805: - hadoop-yetus commented on PR #5887: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5887: HADOOP-18805. S3A prefetch tests to work with small files

2023-07-25 Thread via GitHub
hadoop-yetus commented on PR #5887: URL: https://github.com/apache/hadoop/pull/5887#issuecomment-1650563407 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18805) s3a large file prefetch tests are too slow, don't validate data

2023-07-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747167#comment-17747167 ] ASF GitHub Bot commented on HADOOP-18805: - virajjasani commented on PR #5887: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5887: HADOOP-18805. S3A prefetch tests to work with small files

2023-07-25 Thread via GitHub
virajjasani commented on PR #5887: URL: https://github.com/apache/hadoop/pull/5887#issuecomment-1650546288 us-west-2: `$ mvn clean verify -Dparallel-tests -DtestsThreadCount=8 -Dscale -Dprefetch` ``` [INFO]

[GitHub] [hadoop] sadanand48 commented on a diff in pull request #5885: HDFS-17120. Support snapshot diff based copylisting for flat paths.

2023-07-25 Thread via GitHub
sadanand48 commented on code in PR #5885: URL: https://github.com/apache/hadoop/pull/5885#discussion_r1274102593 ## hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/CopyListing.java: ## @@ -305,6 +305,33 @@ public static CopyListing getCopyListing(Configuration

[jira] [Created] (HADOOP-18826) REST request fails with "Value for one of the query parameters specified in the request URI is invalid.", 400,

2023-07-25 Thread Sergey Shabalov (Jira)
Sergey Shabalov created HADOOP-18826: Summary: REST request fails with "Value for one of the query parameters specified in the request URI is invalid.", 400, Key: HADOOP-18826 URL:

[jira] [Commented] (HADOOP-18805) s3a large file prefetch tests are too slow, don't validate data

2023-07-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747104#comment-17747104 ] ASF GitHub Bot commented on HADOOP-18805: - virajjasani commented on PR #5887: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5887: HADOOP-18805. S3A prefetch tests to work with small files

2023-07-25 Thread via GitHub
virajjasani commented on PR #5887: URL: https://github.com/apache/hadoop/pull/5887#issuecomment-1650348987 rebased, re-testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] hadoop-yetus commented on pull request #5889: HDFS-17123. Sort datanodeStorages when generating StorageBlockReport[] in method BPServiceActor#blockReport for future convenience

2023-07-25 Thread via GitHub
hadoop-yetus commented on PR #5889: URL: https://github.com/apache/hadoop/pull/5889#issuecomment-1650329878 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Created] (HADOOP-18825) Address Netty 4.x / CWE-295 by configuring hostname verification

2023-07-25 Thread Eugene Shinn (Truveta) (Jira)
Eugene Shinn (Truveta) created HADOOP-18825: --- Summary: Address Netty 4.x / CWE-295 by configuring hostname verification Key: HADOOP-18825 URL: https://issues.apache.org/jira/browse/HADOOP-18825

[GitHub] [hadoop] hadoop-yetus commented on pull request #5855: HDFS-17093. In the case of all datanodes sending FBR when the namenode restarts (large clusters), there is an issue with incomplete bloc

2023-07-25 Thread via GitHub
hadoop-yetus commented on PR #5855: URL: https://github.com/apache/hadoop/pull/5855#issuecomment-1650254030 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18817) Upgrade version of aws-java-sdk-bundle to 1.12.368 avoid verify error.

2023-07-25 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747075#comment-17747075 ] Steve Loughran commented on HADOOP-18817: - we are actually happy to take an sdk update, whose

[GitHub] [hadoop] hadoop-yetus commented on pull request #5877: HDFS-17117. BlockManager#processMisReplicatesAsync can periodically print reconstructionQueuesInitProgress

2023-07-25 Thread via GitHub
hadoop-yetus commented on PR #5877: URL: https://github.com/apache/hadoop/pull/5877#issuecomment-1650208517 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5889: HDFS-17123. Sort datanodeStorages when generating StorageBlockReport[] in method BPServiceActor#blockReport for future convenience

2023-07-25 Thread via GitHub
hadoop-yetus commented on PR #5889: URL: https://github.com/apache/hadoop/pull/5889#issuecomment-1650129935 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] swamirishi commented on a diff in pull request #5885: HDFS-17120. Support snapshot diff based copylisting for flat paths.

2023-07-25 Thread via GitHub
swamirishi commented on code in PR #5885: URL: https://github.com/apache/hadoop/pull/5885#discussion_r1273728074 ## hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/CopyListing.java: ## @@ -305,6 +305,33 @@ public static CopyListing getCopyListing(Configuration

[GitHub] [hadoop] hadoop-yetus commented on pull request #5888: HDFS-17121. BPServiceActor to provide new thread to handle FBR

2023-07-25 Thread via GitHub
hadoop-yetus commented on PR #5888: URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1650088835 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5825: HDFS-17072. DFSAdmin: add a triggerDirectoryScanner command.

2023-07-25 Thread via GitHub
hadoop-yetus commented on PR #5825: URL: https://github.com/apache/hadoop/pull/5825#issuecomment-1649916114 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5879: Blocks on IN_MAINTENANCE DNs should be sorted properly in LocatedBlocks.

2023-07-25 Thread via GitHub
hadoop-yetus commented on PR #5879: URL: https://github.com/apache/hadoop/pull/5879#issuecomment-1649896722 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5885: HDFS-17120. Support snapshot diff based copylisting for flat paths.

2023-07-25 Thread via GitHub
hadoop-yetus commented on PR #5885: URL: https://github.com/apache/hadoop/pull/5885#issuecomment-1649840700 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5879: Blocks on IN_MAINTENANCE DNs should be sorted properly in LocatedBlocks.

2023-07-25 Thread via GitHub
hadoop-yetus commented on PR #5879: URL: https://github.com/apache/hadoop/pull/5879#issuecomment-1649755296 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5889: HDFS-17123. Sort datanodeStorages when generating StorageBlockReport[] in method BPServiceActor#blockReport for future convenience

2023-07-25 Thread via GitHub
hfutatzhanghb commented on PR #5889: URL: https://github.com/apache/hadoop/pull/5889#issuecomment-1649746379 @Hexiaoqiao @ayushtkn @slfan1989 @tomscut Sir, could you please help me review this code when you have free time ? Thanks a lot. -- This is an automated message from the Apache

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5889: HDFS-17123. Sort datanodeStorages when generating StorageBlockReport[] in method BPServiceActor#blockReport for future convenience

2023-07-25 Thread via GitHub
hfutatzhanghb commented on PR #5889: URL: https://github.com/apache/hadoop/pull/5889#issuecomment-1649723105 > @hfutatzhanghb Thanks for your contribution! Can we apply for a JIRA ticket? @slfan1989 Sir, thanks for replying, have updated JIRA ticket~ -- This is an automated

[jira] [Commented] (HADOOP-18184) s3a prefetching stream to support unbuffer()

2023-07-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746944#comment-17746944 ] ASF GitHub Bot commented on HADOOP-18184: - steveloughran commented on code in PR #5832: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5832: HADOOP-18184. S3A Prefetching unbuffer.

2023-07-25 Thread via GitHub
steveloughran commented on code in PR #5832: URL: https://github.com/apache/hadoop/pull/5832#discussion_r1273422607 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/CachingBlockManager.java: ## @@ -392,16 +413,41 @@ private void

[jira] [Commented] (HADOOP-18184) s3a prefetching stream to support unbuffer()

2023-07-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746939#comment-17746939 ] ASF GitHub Bot commented on HADOOP-18184: - steveloughran commented on code in PR #5832: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5832: HADOOP-18184. S3A Prefetching unbuffer.

2023-07-25 Thread via GitHub
steveloughran commented on code in PR #5832: URL: https://github.com/apache/hadoop/pull/5832#discussion_r1273419854 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/prefetch/S3ARemoteInputStream.java: ## @@ -409,27 +455,54 @@ protected String getOffsetStr(long

[GitHub] [hadoop] hadoop-yetus commented on pull request #5885: HDFS-17120. Support snapshot diff based copylisting for flat paths.

2023-07-25 Thread via GitHub
hadoop-yetus commented on PR #5885: URL: https://github.com/apache/hadoop/pull/5885#issuecomment-1649663453 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18805) s3a large file prefetch tests are too slow, don't validate data

2023-07-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746926#comment-17746926 ] ASF GitHub Bot commented on HADOOP-18805: - steveloughran commented on PR #5887: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5887: HADOOP-18805. S3A prefetch tests to work with small files

2023-07-25 Thread via GitHub
steveloughran commented on PR #5887: URL: https://github.com/apache/hadoop/pull/5887#issuecomment-1649658882 ok, merged the dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] slfan1989 commented on pull request #5889: Sort datanodeStorages when generating StorageBlockReport[] in method BPServiceActor#blockReport for future convenience

2023-07-25 Thread via GitHub
slfan1989 commented on PR #5889: URL: https://github.com/apache/hadoop/pull/5889#issuecomment-1649624428 @hfutatzhanghb Thanks for your contribution! Can we apply for a JIRA ticket? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] anujmodi2021 commented on a diff in pull request #5881: Hadoop-18759: [ABFS][Backoff-Optimization] Have a Static retry policy for connection timeout.

2023-07-25 Thread via GitHub
anujmodi2021 commented on code in PR #5881: URL: https://github.com/apache/hadoop/pull/5881#discussion_r1273349708 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/TestTracingContext.java: ## @@ -270,4 +273,71 @@ fileSystemId,

[GitHub] [hadoop] anujmodi2021 commented on a diff in pull request #5881: Hadoop-18759: [ABFS][Backoff-Optimization] Have a Static retry policy for connection timeout.

2023-07-25 Thread via GitHub
anujmodi2021 commented on code in PR #5881: URL: https://github.com/apache/hadoop/pull/5881#discussion_r1273348707 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TracingContext.java: ## @@ -217,10 +220,13 @@ private String

[GitHub] [hadoop] hfutatzhanghb opened a new pull request, #5889: Sort datanodeStorages when generating StorageBlockReport[] in method BPServiceActor#blockReport for future convenience

2023-07-25 Thread via GitHub
hfutatzhanghb opened a new pull request, #5889: URL: https://github.com/apache/hadoop/pull/5889 ### Description of PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (HADOOP-18805) s3a large file prefetch tests are too slow, don't validate data

2023-07-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746898#comment-17746898 ] ASF GitHub Bot commented on HADOOP-18805: - steveloughran commented on PR #5887: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5887: HADOOP-18805. S3A prefetch tests to work with small files

2023-07-25 Thread via GitHub
steveloughran commented on PR #5887: URL: https://github.com/apache/hadoop/pull/5887#issuecomment-1649550036 will do -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] haiyang1987 commented on pull request #5845: HDFS-17087. Add Throttler for datanode reading block

2023-07-25 Thread via GitHub
haiyang1987 commented on PR #5845: URL: https://github.com/apache/hadoop/pull/5845#issuecomment-1649535558 Hi Sir @ayushtkn @Hexiaoqiao @tomscut Could you please help me review this pr again when you have free time ? Thanks a lot~ -- This is an automated message from the Apache Git

[GitHub] [hadoop] haiyang1987 commented on pull request #5877: HDFS-17117. BlockManager#processMisReplicatesAsync can periodically print reconstructionQueuesInitProgress

2023-07-25 Thread via GitHub
haiyang1987 commented on PR #5877: URL: https://github.com/apache/hadoop/pull/5877#issuecomment-1649532827 Hi Sir @Hexiaoqiao @tomscut update PR, add UT and fix checkstyle. please help review this PR when you have free time, Thanks a lot~ -- This is an automated message from the Apache

[GitHub] [hadoop] hadoop-yetus commented on pull request #5878: HDFS-17030 Limit wait time for getHAServiceState in ObserverReadProxyProvider

2023-07-25 Thread via GitHub
hadoop-yetus commented on PR #5878: URL: https://github.com/apache/hadoop/pull/5878#issuecomment-1649502190 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5878: HDFS-17030 Limit wait time for getHAServiceState in ObserverReadProxyProvider

2023-07-25 Thread via GitHub
hadoop-yetus commented on PR #5878: URL: https://github.com/apache/hadoop/pull/5878#issuecomment-1649501545 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] LiuGuH opened a new pull request, #5888: HDFS-17121. BPServiceActor to provide new thread to handle FBR

2023-07-25 Thread via GitHub
LiuGuH opened a new pull request, #5888: URL: https://github.com/apache/hadoop/pull/5888 ### Description of PR After [HDFS-16016](https://issues.apache.org/jira/browse/HDFS-16016) , it makes ibr in a thread to avoid heartbeat blocking with ibr when require readlock in Datanode.

[GitHub] [hadoop] hadoop-yetus commented on pull request #5825: HDFS-17072. DFSAdmin: add a triggerDirectoryScanner command.

2023-07-25 Thread via GitHub
hadoop-yetus commented on PR #5825: URL: https://github.com/apache/hadoop/pull/5825#issuecomment-1649457646 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5825: HDFS-17072. DFSAdmin: add a triggerDirectoryScanner command.

2023-07-25 Thread via GitHub
hfutatzhanghb commented on PR #5825: URL: https://github.com/apache/hadoop/pull/5825#issuecomment-1649418822 The failed unit tests were all passed in my local. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] brumi1024 commented on a diff in pull request #5871: YARN-11520. Support capacity vector for AQCv2 dynamic templates.

2023-07-25 Thread via GitHub
brumi1024 commented on code in PR #5871: URL: https://github.com/apache/hadoop/pull/5871#discussion_r1273195384 ##

[GitHub] [hadoop] hadoop-yetus commented on pull request #5825: HDFS-17072. DFSAdmin: add a triggerDirectoryScanner command.

2023-07-25 Thread via GitHub
hadoop-yetus commented on PR #5825: URL: https://github.com/apache/hadoop/pull/5825#issuecomment-1649366206 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] brumi1024 commented on a diff in pull request #5871: YARN-11520. Support capacity vector for AQCv2 dynamic templates.

2023-07-25 Thread via GitHub
brumi1024 commented on code in PR #5871: URL: https://github.com/apache/hadoop/pull/5871#discussion_r1273182469 ##

[GitHub] [hadoop] hadoop-yetus commented on pull request #5885: HDFS-17120. Support snapshot diff based copylisting for flat paths.

2023-07-25 Thread via GitHub
hadoop-yetus commented on PR #5885: URL: https://github.com/apache/hadoop/pull/5885#issuecomment-1649328587 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5862: YARN-11536. [Federation] Router CLI Supports Batch Save the SubClusterPolicyConfiguration Of Queues.

2023-07-25 Thread via GitHub
hadoop-yetus commented on PR #5862: URL: https://github.com/apache/hadoop/pull/5862#issuecomment-1649321336 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] zhiubok commented on pull request #5879: Blocks on IN_MAINTENANCE DNs should be sorted properly in LocatedBlocks.

2023-07-25 Thread via GitHub
zhiubok commented on PR #5879: URL: https://github.com/apache/hadoop/pull/5879#issuecomment-1649312252 Hi @ayushtkn Could you help review this when you have time? And solved the problem that some jira accounts could not be applied for, Thanks! -- This is an automated message from the

[GitHub] [hadoop] sadanand48 commented on pull request #5885: HDFS-17120. Support snapshot diff based copylisting for flat paths.

2023-07-25 Thread via GitHub
sadanand48 commented on PR #5885: URL: https://github.com/apache/hadoop/pull/5885#issuecomment-1649205250 @ayushtkn @steveloughran @umamaheswararao Can I please get a review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub