hfutatzhanghb commented on PR #5933:
URL: https://github.com/apache/hadoop/pull/5933#issuecomment-1674237225
@tomscut @slfan1989 Sir, thanks for your reviewing and merging~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
slfan1989 commented on PR #4314:
URL: https://github.com/apache/hadoop/pull/4314#issuecomment-1674237206
@goiri Can you double check this pr again? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
tomscut commented on PR #5933:
URL: https://github.com/apache/hadoop/pull/5933#issuecomment-1674233997
Thanks @hfutatzhanghb for your contribution! Thanks @slfan1989 for your
review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
tomscut merged PR #5933:
URL: https://github.com/apache/hadoop/pull/5933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
slfan1989 commented on PR #5933:
URL: https://github.com/apache/hadoop/pull/5933#issuecomment-1674215695
LGTM +1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
slfan1989 commented on code in PR #5920:
URL: https://github.com/apache/hadoop/pull/5920#discussion_r1290823841
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/Router.java:
##
@@ -209,7 +214,48
hadoop-yetus commented on PR #5936:
URL: https://github.com/apache/hadoop/pull/5936#issuecomment-1674107480
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
goiri commented on code in PR #5920:
URL: https://github.com/apache/hadoop/pull/5920#discussion_r1290803529
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/Router.java:
##
@@ -209,7 +214,48 @@
goiri commented on PR #5637:
URL: https://github.com/apache/hadoop/pull/5637#issuecomment-1674090911
I have mixed feelings now.
For prod, we should use better backends but for the default setting, the
memory one would work out of the box while ZK needs setup.
--
This is an automated
goiri merged PR #5878:
URL: https://github.com/apache/hadoop/pull/5878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hadoop-yetus commented on PR #5936:
URL: https://github.com/apache/hadoop/pull/5936#issuecomment-1674079972
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5935:
URL: https://github.com/apache/hadoop/pull/5935#issuecomment-1674059411
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5938:
URL: https://github.com/apache/hadoop/pull/5938#issuecomment-1674021639
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hchaverri commented on code in PR #5936:
URL: https://github.com/apache/hadoop/pull/5936#discussion_r1290725889
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/SQLDelegationTokenSecretManager.java:
##
@@ -458,8 +458,8 @@ public
brumi1024 merged PR #5935:
URL: https://github.com/apache/hadoop/pull/5935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
simbadzina commented on code in PR #5936:
URL: https://github.com/apache/hadoop/pull/5936#discussion_r1290614284
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/SQLDelegationTokenSecretManager.java:
##
@@ -458,8 +458,8 @@ public
simbadzina commented on code in PR #5936:
URL: https://github.com/apache/hadoop/pull/5936#discussion_r1290611209
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java:
##
@@ -190,6 +190,14 @@
hchaverri commented on code in PR #5936:
URL: https://github.com/apache/hadoop/pull/5936#discussion_r1290584078
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java:
##
@@ -190,6 +190,14 @@
[
https://issues.apache.org/jira/browse/HADOOP-18820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752910#comment-17752910
]
ASF GitHub Bot commented on HADOOP-18820:
-
steveloughran commented on PR #5872:
URL:
steveloughran commented on PR #5872:
URL: https://github.com/apache/hadoop/pull/5872#issuecomment-1673784146
thought of one more change; add a `hadoop s3guard sdk` command to support
probes for sdk version.
--
This is an automated message from the Apache Git Service.
To respond to the
hchaverri commented on code in PR #5936:
URL: https://github.com/apache/hadoop/pull/5936#discussion_r1290584223
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java:
##
@@ -766,6 +774,10 @@
simbadzina commented on code in PR #5936:
URL: https://github.com/apache/hadoop/pull/5936#discussion_r1290503777
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/SQLDelegationTokenSecretManager.java:
##
@@ -415,6 +458,8 @@ public
simbadzina commented on code in PR #5936:
URL: https://github.com/apache/hadoop/pull/5936#discussion_r1289577317
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java:
##
@@ -190,6 +190,14 @@
simbadzina commented on code in PR #5936:
URL: https://github.com/apache/hadoop/pull/5936#discussion_r1290503777
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/SQLDelegationTokenSecretManager.java:
##
@@ -415,6 +458,8 @@ public
simbadzina commented on code in PR #5936:
URL: https://github.com/apache/hadoop/pull/5936#discussion_r1290501755
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/SQLDelegationTokenSecretManager.java:
##
@@ -153,6 +163,39 @@ public
simbadzina commented on code in PR #5936:
URL: https://github.com/apache/hadoop/pull/5936#discussion_r1289577122
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java:
##
@@ -190,6 +190,14 @@
simbadzina commented on code in PR #5936:
URL: https://github.com/apache/hadoop/pull/5936#discussion_r1290498330
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java:
##
@@ -766,6 +774,10 @@
dongjoon-hyun commented on code in PR #5706:
URL: https://github.com/apache/hadoop/pull/5706#discussion_r1290419472
##
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/impl/CommitContext.java:
##
@@ -236,7 +236,7 @@ private ExecutorService buildThreadPool(
[
https://issues.apache.org/jira/browse/HADOOP-18757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752880#comment-17752880
]
ASF GitHub Bot commented on HADOOP-18757:
-
dongjoon-hyun commented on code in PR #5706:
URL:
hadoop-yetus commented on PR #5935:
URL: https://github.com/apache/hadoop/pull/5935#issuecomment-1673361440
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
slfan1989 commented on PR #5935:
URL: https://github.com/apache/hadoop/pull/5935#issuecomment-1673180291
> > @brumi1024 Thank you very much for your contribution! I have a question
to ask. Do you compile Hadoop using JDK17 in your production environment, or do
you use JDK8 to compile and
brumi1024 commented on PR #5935:
URL: https://github.com/apache/hadoop/pull/5935#issuecomment-1673152434
> @brumi1024 Thank you very much for your contribution! I have a question to
ask. Do you compile Hadoop using JDK17 in your production environment, or do
you use JDK8 to compile and run
slfan1989 commented on PR #5935:
URL: https://github.com/apache/hadoop/pull/5935#issuecomment-1673148285
@brumi1024 Thank you very much for your contribution! I have a question to
ask. Do you compile Hadoop using JDK17 in your production environment, or do
you use JDK8 to compile and run
zhangshuyan0 opened a new pull request, #5938:
URL: https://github.com/apache/hadoop/pull/5938
When the datanode completes a block recovery, it will call
`commitBlockSynchronization` method to notify NN the new locations of the
block. For a EC block group, NN determines the block index of
brumi1024 commented on code in PR #5935:
URL: https://github.com/apache/hadoop/pull/5935#discussion_r1290018339
##
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestMapReduceChildJVM.java:
[
https://issues.apache.org/jira/browse/HADOOP-18838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752760#comment-17752760
]
Steve Loughran commented on HADOOP-18838:
-
hadoop-common.jar, which is pulled into
[
https://issues.apache.org/jira/browse/HADOOP-18842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752759#comment-17752759
]
Syed Shameerur Rahman commented on HADOOP-18842:
[~ste...@apache.org] Thanks a lot for
[
https://issues.apache.org/jira/browse/HADOOP-18820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752758#comment-17752758
]
ASF GitHub Bot commented on HADOOP-18820:
-
hadoop-yetus commented on PR #5872:
URL:
hadoop-yetus commented on PR #5872:
URL: https://github.com/apache/hadoop/pull/5872#issuecomment-1673016473
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
slfan1989 commented on code in PR #5935:
URL: https://github.com/apache/hadoop/pull/5935#discussion_r1289855446
##
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestMapReduceChildJVM.java:
hadoop-yetus commented on PR #5937:
URL: https://github.com/apache/hadoop/pull/5937#issuecomment-1672842556
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
brumi1024 commented on PR #5935:
URL: https://github.com/apache/hadoop/pull/5935#issuecomment-1672807885
Uploaded a checkstyle fix. I've resolved most of them, however I've left the
indentation issues as is, where the rest of the file is similarly indented.
--
This is an automated
brumi1024 commented on PR #5935:
URL: https://github.com/apache/hadoop/pull/5935#issuecomment-1672791881
Unit tests are failing on trunk as well, MAPREDUCE-7436 was opened because
of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
hadoop-yetus commented on PR #5937:
URL: https://github.com/apache/hadoop/pull/5937#issuecomment-1672759197
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
brumi1024 commented on code in PR #5935:
URL: https://github.com/apache/hadoop/pull/5935#discussion_r1289730079
##
tomicooler commented on code in PR #5935:
URL: https://github.com/apache/hadoop/pull/5935#discussion_r1289724761
##
zhangshuyan0 commented on code in PR #5937:
URL: https://github.com/apache/hadoop/pull/5937#discussion_r1289707937
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##
@@ -3802,7 +3803,12 @@ boolean
Tre2878 commented on PR #5855:
URL: https://github.com/apache/hadoop/pull/5855#issuecomment-1672705328
@Hexiaoqiao Thank you for your patience. I have corrected it. What else is
wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
tomicooler commented on code in PR #5935:
URL: https://github.com/apache/hadoop/pull/5935#discussion_r1289663461
##
tomicooler commented on code in PR #5935:
URL: https://github.com/apache/hadoop/pull/5935#discussion_r1289663461
##
[
https://issues.apache.org/jira/browse/HADOOP-18847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chunyi Yang updated HADOOP-18847:
-
Labels: Observer RBF (was: )
> mapreduce job encounters java.io.IOException when
>
hfutatzhanghb commented on code in PR #5937:
URL: https://github.com/apache/hadoop/pull/5937#discussion_r1289651742
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##
@@ -3802,7 +3803,12 @@ boolean
zhangshuyan0 commented on code in PR #5937:
URL: https://github.com/apache/hadoop/pull/5937#discussion_r1289631865
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##
@@ -3802,16 +3803,26 @@ boolean
zhangshuyan0 commented on code in PR #5937:
URL: https://github.com/apache/hadoop/pull/5937#discussion_r1289626419
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##
@@ -3802,7 +3803,12 @@ boolean
[
https://issues.apache.org/jira/browse/HADOOP-18847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chunyi Yang updated HADOOP-18847:
-
Description:
While executing a mapreduce job in an environment utilizing Router-Based
[
https://issues.apache.org/jira/browse/HADOOP-18847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chunyi Yang updated HADOOP-18847:
-
Description:
While executing a mapreduce job in an environment utilizing Router-Based
[
https://issues.apache.org/jira/browse/HADOOP-18847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chunyi Yang updated HADOOP-18847:
-
Summary: mapreduce job encounters java.io.IOException when
dfs.client.rbf.observer.read.enable
[
https://issues.apache.org/jira/browse/HADOOP-18847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chunyi Yang updated HADOOP-18847:
-
Summary: mapreduce job encounters java.io.IOException when observer read is
enabled (was:
slfan1989 commented on PR #5924:
URL: https://github.com/apache/hadoop/pull/5924#issuecomment-1672614747
> @Hexiaoqiao @slfan1989 This improvement may not have much effect, but it
does reduce the creation of redundant and useless temporary objects. At the
same time, from the perspective of
59 matches
Mail list logo