[GitHub] [hadoop] hadoop-yetus commented on pull request #5934: YARN-7599. [BackPort][GPG] ApplicationCleaner in Global Policy Generator.

2023-08-12 Thread via GitHub
hadoop-yetus commented on PR #5934: URL: https://github.com/apache/hadoop/pull/5934#issuecomment-1676228448 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5515: YARN-11037. Add configurable logic to split resource request to the least loaded SC.

2023-08-12 Thread via GitHub
hadoop-yetus commented on PR #5515: URL: https://github.com/apache/hadoop/pull/5515#issuecomment-1676216795 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5946: YARN-11154. Make router support proxy server.

2023-08-12 Thread via GitHub
slfan1989 commented on code in PR #5946: URL: https://github.com/apache/hadoop/pull/5946#discussion_r1292595901 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/RouterClientRMService.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5946: YARN-11154. Make router support proxy server.

2023-08-12 Thread via GitHub
slfan1989 commented on code in PR #5946: URL: https://github.com/apache/hadoop/pull/5946#discussion_r1292597330 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/RouterClientRMService.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5946: YARN-11154. Make router support proxy server.

2023-08-12 Thread via GitHub
slfan1989 commented on code in PR #5946: URL: https://github.com/apache/hadoop/pull/5946#discussion_r1292595901 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/RouterClientRMService.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5946: YARN-11154. Make router support proxy server.

2023-08-12 Thread via GitHub
slfan1989 commented on code in PR #5946: URL: https://github.com/apache/hadoop/pull/5946#discussion_r1292594570 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/Router.java: ## @@ -209,9 +215,30

[GitHub] [hadoop] slfan1989 commented on pull request #5946: YARN-11154. Make router support proxy server.

2023-08-12 Thread via GitHub
slfan1989 commented on PR #5946: URL: https://github.com/apache/hadoop/pull/5946#issuecomment-1676167490 @zhengchenyu Thanks for your contribution! we need to add new properties in yarn-default.xml and fix blanks. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5946: YARN-11154. Make router support proxy server.

2023-08-12 Thread via GitHub
slfan1989 commented on code in PR #5946: URL: https://github.com/apache/hadoop/pull/5946#discussion_r1292578669 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/RouterClientRMService.java:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5943: [Testing] Fix shaded client for building Hadoop on Windows

2023-08-12 Thread via GitHub
hadoop-yetus commented on PR #5943: URL: https://github.com/apache/hadoop/pull/5943#issuecomment-1676081147 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5943: [Testing] Fix shaded client for building Hadoop on Windows

2023-08-12 Thread via GitHub
hadoop-yetus commented on PR #5943: URL: https://github.com/apache/hadoop/pull/5943#issuecomment-1676052613 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[jira] [Commented] (HADOOP-18848) Upgrade protobuf to 3.15.0 or newer

2023-08-12 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753569#comment-17753569 ] Steve Loughran commented on HADOOP-18848: - going to say this is the ongoing "protobuf is a

[GitHub] [hadoop] hadoop-yetus commented on pull request #5946: YARN-11154. Make router support proxy server.

2023-08-12 Thread via GitHub
hadoop-yetus commented on PR #5946: URL: https://github.com/apache/hadoop/pull/5946#issuecomment-1675956495 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5934: YARN-7599. [BackPort][GPG] ApplicationCleaner in Global Policy Generator.

2023-08-12 Thread via GitHub
hadoop-yetus commented on PR #5934: URL: https://github.com/apache/hadoop/pull/5934#issuecomment-1675925193 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5515: YARN-11037. Add configurable logic to split resource request to the least loaded SC.

2023-08-12 Thread via GitHub
hadoop-yetus commented on PR #5515: URL: https://github.com/apache/hadoop/pull/5515#issuecomment-1675905710 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] zhengchenyu opened a new pull request, #5946: YARN-11154. Make router support proxy server.

2023-08-12 Thread via GitHub
zhengchenyu opened a new pull request, #5946: URL: https://github.com/apache/hadoop/pull/5946 ### Description of PR Federation: YARN running app web can't be unable to connect, because AppMaster can't redirect to the right address. Two steps: * YARN-11153: make proxy

[GitHub] [hadoop] hadoop-yetus commented on pull request #5934: YARN-7599. [BackPort][GPG] ApplicationCleaner in Global Policy Generator.

2023-08-12 Thread via GitHub
hadoop-yetus commented on PR #5934: URL: https://github.com/apache/hadoop/pull/5934#issuecomment-1675813731 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5934: YARN-7599. [BackPort][GPG] ApplicationCleaner in Global Policy Generator.

2023-08-12 Thread via GitHub
hadoop-yetus commented on PR #5934: URL: https://github.com/apache/hadoop/pull/5934#issuecomment-1675811314 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5515: YARN-11037. Add configurable logic to split resource request to the least loaded SC.

2023-08-12 Thread via GitHub
hadoop-yetus commented on PR #5515: URL: https://github.com/apache/hadoop/pull/5515#issuecomment-1675794233 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5515: YARN-11037. Add configurable logic to split resource request to the least loaded SC.

2023-08-12 Thread via GitHub
hadoop-yetus commented on PR #5515: URL: https://github.com/apache/hadoop/pull/5515#issuecomment-1675788184 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5945: YARN-10218. [GPG] Support HTTPS in GPG.

2023-08-12 Thread via GitHub
hadoop-yetus commented on PR #5945: URL: https://github.com/apache/hadoop/pull/5945#issuecomment-1675772309 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] zhangshuyan0 commented on pull request #5938: HDFS-17151. EC: Fix wrong metadata in BlockInfoStriped after recovery.

2023-08-12 Thread via GitHub
zhangshuyan0 commented on PR #5938: URL: https://github.com/apache/hadoop/pull/5938#issuecomment-1675750338 @Hexiaoqiao Thanks for your review. The failed tests can pass in my local environment. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] zhangshuyan0 commented on a diff in pull request #5937: HDFS-17150. EC: Fix the bug of failed lease recovery.

2023-08-12 Thread via GitHub
zhangshuyan0 commented on code in PR #5937: URL: https://github.com/apache/hadoop/pull/5937#discussion_r1292104709 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -3802,16 +3803,26 @@ boolean