[GitHub] [hadoop] hadoop-yetus commented on pull request #6102: MAPREDUCE-7453. Revert HADOOP-18649.

2023-09-30 Thread via GitHub
hadoop-yetus commented on PR #6102: URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741961027 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #6102: MAPREDUCE-7453. Revert HADOOP-18649.

2023-09-30 Thread via GitHub
hadoop-yetus commented on PR #6102: URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741960646 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Assigned] (HADOOP-18850) Enable dual-layer server-side encryption with AWS KMS keys (DSSE-KMS)

2023-09-30 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HADOOP-18850: - Assignee: Viraj Jasani > Enable dual-layer server-side encryption with AWS KMS keys

[GitHub] [hadoop] pjfanning opened a new pull request, #6133: HADOOP-18917. commons-io 2.14.0

2023-09-30 Thread via GitHub
pjfanning opened a new pull request, #6133: URL: https://github.com/apache/hadoop/pull/6133 ### Description of PR ### How was this patch tested? ### For code changes: - [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g.

[jira] [Updated] (HADOOP-18917) upgrade to commons-io 2.14.0

2023-09-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18917: Labels: pull-request-available (was: ) > upgrade to commons-io 2.14.0 >

[jira] [Commented] (HADOOP-18917) upgrade to commons-io 2.14.0

2023-09-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770799#comment-17770799 ] ASF GitHub Bot commented on HADOOP-18917: - pjfanning opened a new pull request, #6133: URL:

[jira] [Created] (HADOOP-18917) upgrade to commons-io 2.14.0

2023-09-30 Thread PJ Fanning (Jira)
PJ Fanning created HADOOP-18917: --- Summary: upgrade to commons-io 2.14.0 Key: HADOOP-18917 URL: https://issues.apache.org/jira/browse/HADOOP-18917 Project: Hadoop Common Issue Type: Improvement

[GitHub] [hadoop] hadoop-yetus commented on pull request #6102: MAPREDUCE-7453. Revert HADOOP-18649.

2023-09-30 Thread via GitHub
hadoop-yetus commented on PR #6102: URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741861683 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #6102: MAPREDUCE-7453. Revert HADOOP-18649.

2023-09-30 Thread via GitHub
hadoop-yetus commented on PR #6102: URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741839974 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #6132: YARN-11484. [Federation] Router Supports Yarn Client CLI Cmds.

2023-09-30 Thread via GitHub
hadoop-yetus commented on PR #6132: URL: https://github.com/apache/hadoop/pull/6132#issuecomment-1741833024 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18915) HTTP timeouts are not set correctly

2023-09-30 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770745#comment-17770745 ] Viraj Jasani commented on HADOOP-18915: --- Nice find! > HTTP timeouts are not set correctly >

[GitHub] [hadoop] zhengchenyu commented on pull request #6102: MAPREDUCE-7453. Revert HADOOP-18649.

2023-09-30 Thread via GitHub
zhengchenyu commented on PR #6102: URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741801396 > Yahh, then we should revert only… Can you update this PR with the revert commit? We can get a test run & merge this OK, I have change the tittle to 'Revet Hadoop-18649'. --

[GitHub] [hadoop] ayushtkn commented on pull request #6102: MAPREDUCE-7453. Container logs are missing when yarn.app.container.log.filesize is set to default value 0.

2023-09-30 Thread via GitHub
ayushtkn commented on PR #6102: URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741796859 Yahh, then we should revert only… Can you update this PR with the revert commit? We can get a test run & merge this -- This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] zhengchenyu commented on pull request #6102: MAPREDUCE-7453. Container logs are missing when yarn.app.container.log.filesize is set to default value 0.

2023-09-30 Thread via GitHub
zhengchenyu commented on PR #6102: URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741787028 @ayushtkn We can get back the ContainerLogAppender for CLA. But how about CRLA? If we have to keep our old behavior, I think we can just revert HADOOP-18649. -- This is

[jira] [Commented] (HADOOP-18916) module-info classes from external dependencies appearing in uber jars

2023-09-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770721#comment-17770721 ] ASF GitHub Bot commented on HADOOP-18916: - hadoop-yetus commented on PR #6131: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #6131: HADOOP-18916. Exclude all module-info classes

2023-09-30 Thread via GitHub
hadoop-yetus commented on PR #6131: URL: https://github.com/apache/hadoop/pull/6131#issuecomment-1741783566 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ayushtkn commented on pull request #6102: MAPREDUCE-7453. Container logs are missing when yarn.app.container.log.filesize is set to default value 0.

2023-09-30 Thread via GitHub
ayushtkn commented on PR #6102: URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741778787 If I got you right, we are sorted with CRLA. For this ``` For CLA, I will replace with org.apache.log4j.FileAppender. But there will be no way to limit the size for FileAppender.

[GitHub] [hadoop] zhengchenyu commented on pull request #6102: MAPREDUCE-7453. Container logs are missing when yarn.app.container.log.filesize is set to default value 0.

2023-09-30 Thread via GitHub
zhengchenyu commented on PR #6102: URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741776757 @ayushtkn Thanks for your reply. I think what you said is reasonable. We should try to maintain old behaviour. There are two appender for regular container log: CLA,

[jira] [Commented] (HADOOP-18890) remove okhttp usage

2023-09-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770712#comment-17770712 ] ASF GitHub Bot commented on HADOOP-18890: - hadoop-yetus commented on PR #6130: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #6130: HADOOP-18890. Better to have explicit dependency on httpclient jar

2023-09-30 Thread via GitHub
hadoop-yetus commented on PR #6130: URL: https://github.com/apache/hadoop/pull/6130#issuecomment-1741767448 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ayushtkn commented on pull request #6129: YARN-11581. Fix compilation error in hadoop-yarn-applications-catalog-webapp due to unresolved dependency on hamcrest.

2023-09-30 Thread via GitHub
ayushtkn commented on PR #6129: URL: https://github.com/apache/hadoop/pull/6129#issuecomment-1741764745 @iwasakims what command you use, I tried on my mac, aarch64 and it passed (mvn clean install -DskipTests) ``` [INFO]

[GitHub] [hadoop] slfan1989 opened a new pull request, #6132: YARN-11484. [Federation] Router Supports Yarn Client CLI Cmds.

2023-09-30 Thread via GitHub
slfan1989 opened a new pull request, #6132: URL: https://github.com/apache/hadoop/pull/6132 ### Description of PR JIRA: YARN-11484. [Federation] Router Supports Yarn Client CLI Cmds. ### How was this patch tested? ### For code changes: - [ ] Does the

[jira] [Commented] (HADOOP-18916) module-info classes from external dependencies appearing in uber jars

2023-09-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770701#comment-17770701 ] ASF GitHub Bot commented on HADOOP-18916: - pjfanning opened a new pull request, #6131: URL:

[jira] [Updated] (HADOOP-18916) module-info classes from external dependencies appearing in uber jars

2023-09-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18916: Labels: pull-request-available (was: ) > module-info classes from external dependencies

[GitHub] [hadoop] pjfanning opened a new pull request, #6131: HADOOP-18916. Exclude all module-info classes

2023-09-30 Thread via GitHub
pjfanning opened a new pull request, #6131: URL: https://github.com/apache/hadoop/pull/6131 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g.

[jira] [Updated] (HADOOP-18916) module-info classes from external dependencies appearing in uber jars

2023-09-30 Thread PJ Fanning (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PJ Fanning updated HADOOP-18916: Description: hadoop-client-minicluster and hadoop-client-runtime try unsuccessfully to exclude

[jira] [Created] (HADOOP-18916) module-info classes from external dependencies appearing in uber jars

2023-09-30 Thread PJ Fanning (Jira)
PJ Fanning created HADOOP-18916: --- Summary: module-info classes from external dependencies appearing in uber jars Key: HADOOP-18916 URL: https://issues.apache.org/jira/browse/HADOOP-18916 Project:

[jira] [Commented] (HADOOP-18890) remove okhttp usage

2023-09-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770697#comment-17770697 ] ASF GitHub Bot commented on HADOOP-18890: - pjfanning opened a new pull request, #6130: URL:

[GitHub] [hadoop] pjfanning opened a new pull request, #6130: HADOOP-18890. Better to have explicit dependency on httpclient jar

2023-09-30 Thread via GitHub
pjfanning opened a new pull request, #6130: URL: https://github.com/apache/hadoop/pull/6130 ### Description of PR A previous PR for this issue removed okhttp usage and used Apache HttpClient instead. The dependency on HttpClient is indirect (a transitive dependency). I think it is

[GitHub] [hadoop] hadoop-yetus commented on pull request #6110: HDFS-17209. Correct comments to align with the code

2023-09-30 Thread via GitHub
hadoop-yetus commented on PR #6110: URL: https://github.com/apache/hadoop/pull/6110#issuecomment-1741749855 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-17225) Update jackson-mapper-asl-1.9.13 to atlassian version to mitigate: CVE-2019-10172

2023-09-30 Thread PJ Fanning (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770690#comment-17770690 ] PJ Fanning commented on HADOOP-17225: - This can probably be closed because latest hadoop 3.3

[GitHub] [hadoop] ayushtkn commented on pull request #6102: MAPREDUCE-7453. Container logs are missing when yarn.app.container.log.filesize is set to default value 0.

2023-09-30 Thread via GitHub
ayushtkn commented on PR #6102: URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741714717 It is there since long & maintained, those changes are breaking the existing tests as well since long I believe, so lets revert that & fix the existing problems. if it is required, folks

[GitHub] [hadoop] zhengchenyu commented on pull request #6102: MAPREDUCE-7453. Container logs are missing when yarn.app.container.log.filesize is set to default value 0.

2023-09-30 Thread via GitHub
zhengchenyu commented on PR #6102: URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741690367 @ayushtkn Thanks for you reply! I reproduce the problem of 'testThreadDumpOnTaskTimeout' in my laptop. Here we can see the log dir: ``` (base)