Re: [PR] HADOOP-18943. Addendum: Fix trademark description issue of Apache on website. [hadoop-site]

2023-10-18 Thread via GitHub
Hexiaoqiao commented on PR #47: URL: https://github.com/apache/hadoop-site/pull/47#issuecomment-1770113981 Try to run `hugo` then `git diff --stat`, it show `174 files changed, 2584 insertions(+), 664 deletions(-)`. Is it expected? Thanks. cc @ayushtkn @aajisaka -- This is an automated

Re: [PR] HADOOP-18943. Addendum: Fix trademark description issue of Apache on website. [hadoop-site]

2023-10-18 Thread via GitHub
Hexiaoqiao commented on PR #47: URL: https://github.com/apache/hadoop-site/pull/47#issuecomment-1770106427 > Probably we don't need to add HTML tags to make the mark smaller and upper. Got it. Let me update it for a while. > Did you run hugo? Hugo needs to generate the .html

Re: [PR] HADOOP-18943. Addendum: Fix trademark description issue of Apache on website. [hadoop-site]

2023-10-18 Thread via GitHub
ayushtkn commented on PR #47: URL: https://github.com/apache/hadoop-site/pull/47#issuecomment-1769991809 This file still has older stuff https://github.com/Hexiaoqiao/hadoop-site/blob/trademark/content/index.html#L164

[jira] [Commented] (HADOOP-18868) Optimize the configuration and use of callqueue overflow trigger failover

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1021#comment-1021 ] ASF GitHub Bot commented on HADOOP-18868: - haiyang1987 commented on PR #5998: URL:

Re: [PR] HADOOP-18868. Optimize the configuration and use of callqueue overflow trigger failover [hadoop]

2023-10-18 Thread via GitHub
haiyang1987 commented on PR #5998: URL: https://github.com/apache/hadoop/pull/5998#issuecomment-1769983365 > Let's get a clean run. Ok, since it's been a long time, i will rebase it. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (HADOOP-18942) Upgrade ZooKeeper to 3.7.2

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776997#comment-17776997 ] ASF GitHub Bot commented on HADOOP-18942: - iwasakims commented on PR #6200: URL:

Re: [PR] HADOOP-18942. Upgrade ZooKeeper to 3.7.2. [hadoop]

2023-10-18 Thread via GitHub
iwasakims commented on PR #6200: URL: https://github.com/apache/hadoop/pull/6200#issuecomment-1769855763 Test results on my local looks good. (ran tests of hadoop-auth, hadoop-common, hadoop-hdfs, hadoop-yarn-server-resourcemanager). -- This is an automated message from the Apache Git

Re: [PR] HADOOP-18943. Addendum: Fix trademark description issue of Apache on website. [hadoop-site]

2023-10-18 Thread via GitHub
Hexiaoqiao commented on PR #47: URL: https://github.com/apache/hadoop-site/pull/47#issuecomment-1769842255 Addendum: TBH, I am not familiar with HTML, Please let me know if anywhere I missed, I would like to try fix it. -- This is an automated message from the Apache Git Service. To

[PR] HADOOP-18943. Addendum: Fix trademark description issue of Apache on [hadoop-site]

2023-10-18 Thread via GitHub
Hexiaoqiao opened a new pull request, #47: URL: https://github.com/apache/hadoop-site/pull/47 …website. Switch to HTML character entity rather than the graphic symbols on website to improve display. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HADOOP-18918) ITestS3GuardTool fails if SSE/DSSE encryption is used

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776972#comment-17776972 ] ASF GitHub Bot commented on HADOOP-18918: - hadoop-yetus commented on PR #6165: URL:

Re: [PR] HADOOP-18918. ITestS3GuardTool fails if SSE/DSSE encryption is used [hadoop]

2023-10-18 Thread via GitHub
hadoop-yetus commented on PR #6165: URL: https://github.com/apache/hadoop/pull/6165#issuecomment-1769779868 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11592. Add timeout to GPGUtils#invokeRMWebService. [hadoop]

2023-10-18 Thread via GitHub
slfan1989 commented on code in PR #6189: URL: https://github.com/apache/hadoop/pull/6189#discussion_r1364784715 ##

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-18 Thread via GitHub
slfan1989 commented on code in PR #6199: URL: https://github.com/apache/hadoop/pull/6199#discussion_r1364784350 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RouterCLI.java: ## @@ -77,25 +79,70 @@ public class RouterCLI

Re: [PR] CVE-2023-2976 [hadoop-thirdparty]

2023-10-18 Thread via GitHub
Grimoren commented on PR #25: URL: https://github.com/apache/hadoop-thirdparty/pull/25#issuecomment-1769675664 > Note we already have a JIRA and PR #23 for this CVE Yeah I saw that. I just want to see someone merge the fix. Either way, as long as the cve is patched. I will close this

[jira] [Commented] (HADOOP-18918) ITestS3GuardTool fails if SSE/DSSE encryption is used

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776955#comment-17776955 ] ASF GitHub Bot commented on HADOOP-18918: - virajjasani commented on code in PR #6165: URL:

Re: [PR] HADOOP-18918. ITestS3GuardTool fails if SSE/DSSE encryption is used [hadoop]

2023-10-18 Thread via GitHub
virajjasani commented on code in PR #6165: URL: https://github.com/apache/hadoop/pull/6165#discussion_r1364714244 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestS3GuardTool.java: ## @@ -71,6 +72,7 @@ public void testLandsatBucketRequireGuarded()

Re: [PR] HADOOP-18711. upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code. [hadoop]

2023-10-18 Thread via GitHub
hadoop-yetus commented on PR #6201: URL: https://github.com/apache/hadoop/pull/6201#issuecomment-1769588697 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18945) S3A: IAMInstanceCredentialsProvider failing: Failed to load credentials from IMDS

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776948#comment-17776948 ] ASF GitHub Bot commented on HADOOP-18945: - mukund-thakur commented on PR #6202: URL:

Re: [PR] HADOOP-18945. S3A: IAMInstanceCredentialsProvider failing. [hadoop]

2023-10-18 Thread via GitHub
mukund-thakur commented on PR #6202: URL: https://github.com/apache/hadoop/pull/6202#issuecomment-1769580064 Some UT's failing `INFO] [ERROR] Failures: [ERROR]

[jira] [Commented] (HADOOP-18945) S3A: IAMInstanceCredentialsProvider failing: Failed to load credentials from IMDS

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776947#comment-17776947 ] ASF GitHub Bot commented on HADOOP-18945: - mukund-thakur commented on code in PR #6202: URL:

Re: [PR] HADOOP-18945. S3A: IAMInstanceCredentialsProvider failing. [hadoop]

2023-10-18 Thread via GitHub
mukund-thakur commented on code in PR #6202: URL: https://github.com/apache/hadoop/pull/6202#discussion_r1364691369 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/IAMInstanceCredentialsProvider.java: ## @@ -78,23 +117,52 @@ public AwsCredentials

[jira] [Commented] (HADOOP-18945) S3A: IAMInstanceCredentialsProvider failing: Failed to load credentials from IMDS

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776946#comment-17776946 ] ASF GitHub Bot commented on HADOOP-18945: - mukund-thakur commented on code in PR #6202: URL:

Re: [PR] HADOOP-18945. S3A: IAMInstanceCredentialsProvider failing. [hadoop]

2023-10-18 Thread via GitHub
mukund-thakur commented on code in PR #6202: URL: https://github.com/apache/hadoop/pull/6202#discussion_r1364689562 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/auth/TestIAMInstanceCredentialsProvider.java: ## @@ -0,0 +1,105 @@ +/** + * Licensed to the

Re: [PR] HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code [hadoop]

2023-10-18 Thread via GitHub
hadoop-yetus commented on PR #5639: URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1769575285 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] Add getEnclosingRoot API to FileSystem interface and all implementations [hadoop]

2023-10-18 Thread via GitHub
mccormickt12 commented on code in PR #6196: URL: https://github.com/apache/hadoop/pull/6196#discussion_r1364661597 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGetEnclosingRoot.java: ## @@ -0,0 +1,94 @@ +/** + * Licensed to the Apache Software

Re: [PR] Add getEnclosingRoot API to FileSystem interface and all implementations [hadoop]

2023-10-18 Thread via GitHub
goiri commented on code in PR #6196: URL: https://github.com/apache/hadoop/pull/6196#discussion_r1364560482 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGetEnclosingRoot.java: ## @@ -0,0 +1,94 @@ +/** + * Licensed to the Apache Software

Re: [PR] Add getEnclosingRoot API to FileSystem interface and all implementations [hadoop]

2023-10-18 Thread via GitHub
mccormickt12 commented on PR #6196: URL: https://github.com/apache/hadoop/pull/6196#issuecomment-1769333707 > Can you link the JIRA in the title and description too? I can, i think i actually need to close this in leu of https://github.com/apache/hadoop/pull/6198 and then open a new

Re: [PR] Add getEnclosingRoot API to FileSystem interface and all implementations [hadoop]

2023-10-18 Thread via GitHub
goiri commented on PR #6196: URL: https://github.com/apache/hadoop/pull/6196#issuecomment-1769331156 Can you link the JIRA in the title and description too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (HADOOP-18919) Zookeeper SSL/TLS support in HDFS ZKFC

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776900#comment-17776900 ] ASF GitHub Bot commented on HADOOP-18919: - jojochuang commented on code in PR #6194: URL:

Re: [PR] HADOOP-18919. Zookeeper SSL/TLS support in HDFS ZKFC [hadoop]

2023-10-18 Thread via GitHub
jojochuang commented on code in PR #6194: URL: https://github.com/apache/hadoop/pull/6194#discussion_r1364515887 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java: ## @@ -786,4 +789,96 @@ public static List

[jira] [Commented] (HADOOP-18919) Zookeeper SSL/TLS support in HDFS ZKFC

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776893#comment-17776893 ] ASF GitHub Bot commented on HADOOP-18919: - hadoop-yetus commented on PR #6194: URL:

Re: [PR] HADOOP-18919. Zookeeper SSL/TLS support in HDFS ZKFC [hadoop]

2023-10-18 Thread via GitHub
hadoop-yetus commented on PR #6194: URL: https://github.com/apache/hadoop/pull/6194#issuecomment-1769285674 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18920) RPC Metrics : Optimize logic for log slow RPCs

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776862#comment-17776862 ] ASF GitHub Bot commented on HADOOP-18920: - hadoop-yetus commented on PR #6146: URL:

Re: [PR] HADOOP-18920. RPC Metrics : Optimize logic for log slow RPCs [hadoop]

2023-10-18 Thread via GitHub
hadoop-yetus commented on PR #6146: URL: https://github.com/apache/hadoop/pull/6146#issuecomment-1769168892 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18945) S3A: IAMInstanceCredentialsProvider failing: Failed to load credentials from IMDS

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776848#comment-17776848 ] ASF GitHub Bot commented on HADOOP-18945: - hadoop-yetus commented on PR #6202: URL:

Re: [PR] HADOOP-18945. S3A: IAMInstanceCredentialsProvider failing. [hadoop]

2023-10-18 Thread via GitHub
hadoop-yetus commented on PR #6202: URL: https://github.com/apache/hadoop/pull/6202#issuecomment-1769098208 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-16791 Add getEnclosingRoot API to filesystem interface and all i… [hadoop]

2023-10-18 Thread via GitHub
mccormickt12 commented on PR #6198: URL: https://github.com/apache/hadoop/pull/6198#issuecomment-1769097888 cc @simbadzina @goiri this is related to https://github.com/apache/hadoop/pull/4967/files#diff-a07f38553cfc52416c1a9bc82110837c8d0c078a0f1ef9c62c290d7de5b3e745 -- This is an

[jira] [Commented] (HADOOP-18920) RPC Metrics : Optimize logic for log slow RPCs

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776832#comment-17776832 ] ASF GitHub Bot commented on HADOOP-18920: - hadoop-yetus commented on PR #6146: URL:

Re: [PR] HADOOP-18920. RPC Metrics : Optimize logic for log slow RPCs [hadoop]

2023-10-18 Thread via GitHub
hadoop-yetus commented on PR #6146: URL: https://github.com/apache/hadoop/pull/6146#issuecomment-1769061065 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18945) S3A: IAMInstanceCredentialsProvider failing: Failed to load credentials from IMDS

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776814#comment-17776814 ] ASF GitHub Bot commented on HADOOP-18945: - hadoop-yetus commented on PR #6202: URL:

Re: [PR] HADOOP-18945. S3A: IAMInstanceCredentialsProvider failing. [hadoop]

2023-10-18 Thread via GitHub
hadoop-yetus commented on PR #6202: URL: https://github.com/apache/hadoop/pull/6202#issuecomment-1768993012 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18868) Optimize the configuration and use of callqueue overflow trigger failover

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776797#comment-17776797 ] ASF GitHub Bot commented on HADOOP-18868: - goiri commented on PR #5998: URL:

Re: [PR] HADOOP-18868. Optimize the configuration and use of callqueue overflow trigger failover [hadoop]

2023-10-18 Thread via GitHub
goiri commented on PR #5998: URL: https://github.com/apache/hadoop/pull/5998#issuecomment-1768957138 Let's get a clean run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-18 Thread via GitHub
goiri commented on code in PR #6199: URL: https://github.com/apache/hadoop/pull/6199#discussion_r1364211542 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RouterCLI.java: ## @@ -77,25 +79,70 @@ public class RouterCLI

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-18 Thread via GitHub
hadoop-yetus commented on PR #6199: URL: https://github.com/apache/hadoop/pull/6199#issuecomment-1768853213 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18945) S3A: IAMInstanceCredentialsProvider failing: Failed to load credentials from IMDS

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776750#comment-17776750 ] ASF GitHub Bot commented on HADOOP-18945: - steveloughran commented on code in PR #6202: URL:

Re: [PR] HADOOP-18945. S3A: IAMInstanceCredentialsProvider failing. [hadoop]

2023-10-18 Thread via GitHub
steveloughran commented on code in PR #6202: URL: https://github.com/apache/hadoop/pull/6202#discussion_r1364111815 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/IAMInstanceCredentialsProvider.java: ## @@ -48,10 +53,18 @@ public class

[jira] [Commented] (HADOOP-18945) S3A: IAMInstanceCredentialsProvider failing: Failed to load credentials from IMDS

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776745#comment-17776745 ] ASF GitHub Bot commented on HADOOP-18945: - steveloughran commented on PR #6202: URL:

Re: [PR] HADOOP-18945. S3A: IAMInstanceCredentialsProvider failing. [hadoop]

2023-10-18 Thread via GitHub
steveloughran commented on PR #6202: URL: https://github.com/apache/hadoop/pull/6202#issuecomment-1768758729 tested s3 london with a vpn up to make things slower one failure in the new test from HADOOP-18939; created HADOOP-18946 to cover it ``` [ERROR]

[jira] [Created] (HADOOP-18946) S3A: testMultiObjectExceptionFilledIn() assertion error

2023-10-18 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-18946: --- Summary: S3A: testMultiObjectExceptionFilledIn() assertion error Key: HADOOP-18946 URL: https://issues.apache.org/jira/browse/HADOOP-18946 Project: Hadoop

[jira] [Commented] (HADOOP-18939) NPE in AWS v2 SDK RetryOnErrorCodeCondition.shouldRetry()

2023-10-18 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776741#comment-17776741 ] Steve Loughran commented on HADOOP-18939: - aah, added a new failure from an assert that is

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-18 Thread via GitHub
hadoop-yetus commented on PR #6199: URL: https://github.com/apache/hadoop/pull/6199#issuecomment-1768713789 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11584. Safely fail on leaf queue with empty name [hadoop]

2023-10-18 Thread via GitHub
brumi1024 commented on code in PR #6148: URL: https://github.com/apache/hadoop/pull/6148#discussion_r1364065198 ##

[jira] [Assigned] (HADOOP-17436) envtoconf broken for .conf and few other formats

2023-10-18 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai reassigned HADOOP-17436: - Assignee: (was: Attila Doroszlai) > envtoconf broken for .conf and few

[jira] [Updated] (HADOOP-17436) envtoconf broken for .conf and few other formats

2023-10-18 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HADOOP-17436: -- Target Version/s: (was: 3.4.0) > envtoconf broken for .conf and few other formats

[jira] [Updated] (HADOOP-18945) S3A: IAMInstanceCredentialsProvider failing: Failed to load credentials from IMDS

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18945: Labels: pull-request-available (was: ) > S3A: IAMInstanceCredentialsProvider failing:

[jira] [Commented] (HADOOP-18945) S3A: IAMInstanceCredentialsProvider failing: Failed to load credentials from IMDS

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776729#comment-17776729 ] ASF GitHub Bot commented on HADOOP-18945: - steveloughran opened a new pull request, #6202: URL:

[PR] HADOOP-18945. S3A: IAMInstanceCredentialsProvider failing. [hadoop]

2023-10-18 Thread via GitHub
steveloughran opened a new pull request, #6202: URL: https://github.com/apache/hadoop/pull/6202 - Enable async refresh in inner credential provider. - Store provider instance in a field; use synchronized() call to handle failure and switch from container to EC2 provider. - Close

Re: [PR] YARN-11576. Improve FederationInterceptorREST AuditLog. [hadoop]

2023-10-18 Thread via GitHub
hadoop-yetus commented on PR #6117: URL: https://github.com/apache/hadoop/pull/6117#issuecomment-1768566964 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-18 Thread via GitHub
hadoop-yetus commented on PR #6199: URL: https://github.com/apache/hadoop/pull/6199#issuecomment-1768559175 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18918) ITestS3GuardTool fails if SSE/DSSE encryption is used

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776636#comment-17776636 ] ASF GitHub Bot commented on HADOOP-18918: - ahmarsuhail commented on code in PR #6165: URL:

Re: [PR] HADOOP-18918. ITestS3GuardTool fails if SSE/DSSE encryption is used [hadoop]

2023-10-18 Thread via GitHub
ahmarsuhail commented on code in PR #6165: URL: https://github.com/apache/hadoop/pull/6165#discussion_r1363761971 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestS3GuardTool.java: ## @@ -71,6 +72,7 @@ public void testLandsatBucketRequireGuarded()

Re: [PR] HDFS-17220. Fix same available space policy in AvailableSpaceVolumeChoosingPolicy [hadoop]

2023-10-18 Thread via GitHub
GuoPhilipse commented on PR #6174: URL: https://github.com/apache/hadoop/pull/6174#issuecomment-1768311920 Thanks @tomscut @Hexiaoqiao @zhangshuyan0 for your review~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Resolved] (HADOOP-18943) Fix trademark description issue of Apache on website

2023-10-18 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoqiao He resolved HADOOP-18943. -- Hadoop Flags: Reviewed Resolution: Fixed > Fix trademark description issue of Apache

[jira] [Commented] (HADOOP-18945) S3A: IAMInstanceCredentialsProvider failing: Failed to load credentials from IMDS

2023-10-18 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776607#comment-17776607 ] Steve Loughran commented on HADOOP-18945: - looking for that error string "Failed to load

Re: [PR] HADOOP-18943. Fix trademark description issue of Apache on website. [hadoop-site]

2023-10-18 Thread via GitHub
Hexiaoqiao commented on PR #46: URL: https://github.com/apache/hadoop-site/pull/46#issuecomment-1768167099 Committed. Thanks @aajisaka , @ayushtkn ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] HADOOP-18943. Fix trademark description issue of Apache on website. [hadoop-site]

2023-10-18 Thread via GitHub
Hexiaoqiao merged PR #46: URL: https://github.com/apache/hadoop-site/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HADOOP-18945) S3A: IAMInstanceCredentialsProvider failing: Failed to load credentials from IMDS

2023-10-18 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18945: Description: Failures in impala test VMs using iAM for auth {code} Failed to open file

Re: [PR] HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code [hadoop]

2023-10-18 Thread via GitHub
pjfanning commented on PR #5639: URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1768160519 @rohit-kb I created https://github.com/apache/hadoop/pull/6201 - feel free to continue with this PR but I created 6201 just in case. -- This is an automated message from the Apache

[jira] [Updated] (HADOOP-18945) S3A: IAMInstanceCredentialsProvider failing: Failed to load credentials from IMDS

2023-10-18 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18945: Summary: S3A: IAMInstanceCredentialsProvider failing: Failed to load credentials from

[jira] [Created] (HADOOP-18945) S3A: IAMInstanceCredentialsProvider failing: NoAwsCredentialsException: +: Failed to load credentials from IMDS.{noformat}

2023-10-18 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-18945: --- Summary: S3A: IAMInstanceCredentialsProvider failing: NoAwsCredentialsException: +: Failed to load credentials from IMDS.{noformat} Key: HADOOP-18945 URL:

Re: [PR] HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code [hadoop]

2023-10-18 Thread via GitHub
rohit-kb commented on PR #5639: URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1768153646 @pjfanning my bad, kind of went a bit overboard while avoiding those blanks related checks assuming that these changes won't matter. Also, a bit doubtful regarding the rebase, I

Re: [PR] HADOOP-18920. RPC Metrics : Optimize logic for log slow RPCs [hadoop]

2023-10-18 Thread via GitHub
haiyang1987 commented on code in PR #6146: URL: https://github.com/apache/hadoop/pull/6146#discussion_r1363627747 ## hadoop-common-project/hadoop-common/src/main/resources/core-default.xml: ## @@ -2512,12 +2512,22 @@ The switch to turn S3A auditing on or off. -

[jira] [Commented] (HADOOP-18920) RPC Metrics : Optimize logic for log slow RPCs

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776597#comment-17776597 ] ASF GitHub Bot commented on HADOOP-18920: - haiyang1987 commented on code in PR #6146: URL:

Re: [PR] HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code [hadoop]

2023-10-18 Thread via GitHub
pjfanning commented on PR #5639: URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1768135406 @rohit-kb could you remove the edits to the 2 pom files? You have 4 edited files in this PR while you only need 2 (the ones that change the nimbus version). See

[jira] [Commented] (HADOOP-18920) RPC Metrics : Optimize logic for log slow RPCs

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776592#comment-17776592 ] ASF GitHub Bot commented on HADOOP-18920: - ZanderXu commented on code in PR #6146: URL:

Re: [PR] HADOOP-18920. RPC Metrics : Optimize logic for log slow RPCs [hadoop]

2023-10-18 Thread via GitHub
ZanderXu commented on code in PR #6146: URL: https://github.com/apache/hadoop/pull/6146#discussion_r1363614879 ## hadoop-common-project/hadoop-common/src/main/resources/core-default.xml: ## @@ -2512,12 +2512,22 @@ The switch to turn S3A auditing on or off. -

[jira] [Commented] (HADOOP-18944) s3a openfile is using readahead rather than async drain threshold to calculate drain threshold

2023-10-18 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776591#comment-17776591 ] Steve Loughran commented on HADOOP-18944: - one line fix and I don't even think we need a test

[jira] [Updated] (HADOOP-18944) s3a openfile is using readahead rather than async drain threshold to calculate drain threshold

2023-10-18 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18944: Description: we are using the wrong default value for the async drain threshold in

Re: [PR] HADOOP-18920. RPC Metrics : Optimize logic for log slow RPCs [hadoop]

2023-10-18 Thread via GitHub
haiyang1987 commented on PR #6146: URL: https://github.com/apache/hadoop/pull/6146#issuecomment-1768112080 Update PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (HADOOP-18920) RPC Metrics : Optimize logic for log slow RPCs

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776588#comment-17776588 ] ASF GitHub Bot commented on HADOOP-18920: - haiyang1987 commented on PR #6146: URL:

[jira] [Created] (HADOOP-18944) s3a openfile is using readahead rather than async drain threshold to calculate drain threshold

2023-10-18 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-18944: --- Summary: s3a openfile is using readahead rather than async drain threshold to calculate drain threshold Key: HADOOP-18944 URL:

Re: [PR] HADOOP-18943. Fix trademark description issue of Apache on website. [hadoop-site]

2023-10-18 Thread via GitHub
Hexiaoqiao commented on PR #46: URL: https://github.com/apache/hadoop-site/pull/46#issuecomment-1768071433 cc @jojochuang @ayushtkn Please take a review. Refer detail at mail list. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (HADOOP-18830) Cut S3 Select

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776576#comment-17776576 ] ASF GitHub Bot commented on HADOOP-18830: - steveloughran commented on code in PR #6144: URL:

Re: [PR] HADOOP-18830. Cut S3 Select [hadoop]

2023-10-18 Thread via GitHub
steveloughran commented on code in PR #6144: URL: https://github.com/apache/hadoop/pull/6144#discussion_r1363570103 ## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md: ## @@ -35,7 +35,6 @@ full details. * [Encryption](./encryption.html) *

[jira] [Commented] (HADOOP-18919) Zookeeper SSL/TLS support in HDFS ZKFC

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776575#comment-17776575 ] ASF GitHub Bot commented on HADOOP-18919: - dombizita commented on code in PR #6194: URL:

Re: [PR] HADOOP-18919. Zookeeper SSL/TLS support in HDFS ZKFC [hadoop]

2023-10-18 Thread via GitHub
dombizita commented on code in PR #6194: URL: https://github.com/apache/hadoop/pull/6194#discussion_r1363567945 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java: ## @@ -786,4 +789,96 @@ public static List

[PR] HADOOP-18943. Fix trademark description issue of Apache on website. [hadoop-site]

2023-10-18 Thread via GitHub
Hexiaoqiao opened a new pull request, #46: URL: https://github.com/apache/hadoop-site/pull/46 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Updated] (HADOOP-18943) Fix trademark description issue of Apache on website

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18943: Labels: pull-request-available (was: ) > Fix trademark description issue of Apache on

[jira] [Created] (HADOOP-18943) Fix trademark description issue of Apache on website

2023-10-18 Thread Xiaoqiao He (Jira)
Xiaoqiao He created HADOOP-18943: Summary: Fix trademark description issue of Apache on website Key: HADOOP-18943 URL: https://issues.apache.org/jira/browse/HADOOP-18943 Project: Hadoop Common

[jira] [Commented] (HADOOP-11890) Uber-JIRA: Hadoop should support IPv6

2023-10-18 Thread Danny (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-11890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776568#comment-17776568 ] Danny commented on HADOOP-11890: any progress on this feature?? > Uber-JIRA: Hadoop should support

Re: [PR] HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code [hadoop]

2023-10-18 Thread via GitHub
rohit-kb commented on PR #5639: URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1767946931 Sure @pjfanning, will do, thanks for the info. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [Testing] Fix shaded client for building Hadoop on Windows [hadoop]

2023-10-18 Thread via GitHub
hadoop-yetus commented on PR #5943: URL: https://github.com/apache/hadoop/pull/5943#issuecomment-1767898123 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18942) Upgrade ZooKeeper to 3.7.2

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776539#comment-17776539 ] ASF GitHub Bot commented on HADOOP-18942: - hadoop-yetus commented on PR #6200: URL:

Re: [PR] HADOOP-18942. Upgrade ZooKeeper to 3.7.2. [hadoop]

2023-10-18 Thread via GitHub
hadoop-yetus commented on PR #6200: URL: https://github.com/apache/hadoop/pull/6200#issuecomment-1767890327 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18920. RPC Metrics : Optimize logic for log slow RPCs [hadoop]

2023-10-18 Thread via GitHub
haiyang1987 commented on code in PR #6146: URL: https://github.com/apache/hadoop/pull/6146#discussion_r1363380147 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java: ## @@ -504,6 +504,10 @@ public class

[jira] [Commented] (HADOOP-18868) Optimize the configuration and use of callqueue overflow trigger failover

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776532#comment-17776532 ] ASF GitHub Bot commented on HADOOP-18868: - haiyang1987 commented on PR #5998: URL:

[jira] [Commented] (HADOOP-18920) RPC Metrics : Optimize logic for log slow RPCs

2023-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776531#comment-17776531 ] ASF GitHub Bot commented on HADOOP-18920: - haiyang1987 commented on code in PR #6146: URL:

Re: [PR] HADOOP-18868. Optimize the configuration and use of callqueue overflow trigger failover [hadoop]

2023-10-18 Thread via GitHub
haiyang1987 commented on PR #5998: URL: https://github.com/apache/hadoop/pull/5998#issuecomment-1767835847 Thanks @goiri help me review~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HDFS-17218. NameNode should remove its excess blocks from the ExcessRedundancyMap When a DN registers [hadoop]

2023-10-18 Thread via GitHub
haiyang1987 commented on PR #6176: URL: https://github.com/apache/hadoop/pull/6176#issuecomment-1767833407 > > > Back to this PR. > > > IMO, adding a timeout mechanism may not add much pressure on NameNode. However, it seems that the implementation of that solution is more

  1   2   >