[jira] [Commented] (HADOOP-18920) RPC Metrics : Optimize logic for log slow RPCs

2023-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779339#comment-17779339 ] ASF GitHub Bot commented on HADOOP-18920: - ZanderXu commented on PR #6146: URL:

[jira] [Commented] (HADOOP-18920) RPC Metrics : Optimize logic for log slow RPCs

2023-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779338#comment-17779338 ] ASF GitHub Bot commented on HADOOP-18920: - ZanderXu merged PR #6146: URL:

Re: [PR] HADOOP-18920. RPC Metrics : Optimize logic for log slow RPCs [hadoop]

2023-10-24 Thread via GitHub
ZanderXu merged PR #6146: URL: https://github.com/apache/hadoop/pull/6146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HADOOP-18920. RPC Metrics : Optimize logic for log slow RPCs [hadoop]

2023-10-24 Thread via GitHub
ZanderXu commented on PR #6146: URL: https://github.com/apache/hadoop/pull/6146#issuecomment-1778564624 Thank @haiyang1987 for your report and thanks @xinglin for your review. Merged -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (HADOOP-18912) upgrade snappy-java to 1.1.10.4 due to CVE

2023-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779331#comment-17779331 ] ASF GitHub Bot commented on HADOOP-18912: - rohit-kb commented on PR #6160: URL:

Re: [PR] HADOOP-18912. Upgrade snappy-java to 1.1.10.4 [hadoop]

2023-10-24 Thread via GitHub
rohit-kb commented on PR #6160: URL: https://github.com/apache/hadoop/pull/6160#issuecomment-1778511955 @pjfanning, sure, will do. Just give me sometime please and sorry for the delayed response as I was away. Thanks -- This is an automated message from the Apache Git Service. To respond

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

2023-10-24 Thread via GitHub
mudit1289 commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1778497256 @slfan1989 , can we merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HDFS-17231.HA: Safemode should exit when resources are from low to available [hadoop]

2023-10-24 Thread via GitHub
Hexiaoqiao commented on PR #6207: URL: https://github.com/apache/hadoop/pull/6207#issuecomment-1778458113 Committed to trunk. Thanks @gp1314 for your works and @xinglin for your reviews! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] HDFS-17231.HA: Safemode should exit when resources are from low to available [hadoop]

2023-10-24 Thread via GitHub
Hexiaoqiao merged PR #6207: URL: https://github.com/apache/hadoop/pull/6207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17232. RBF: Fix NoNamenodesAvailableException for a long time, when use observer. [hadoop]

2023-10-24 Thread via GitHub
KeeProMise commented on PR #6208: URL: https://github.com/apache/hadoop/pull/6208#issuecomment-1778453412 > Took a quick scan and added a few minor comments. I've limited bandwidth til mid Nov for an in-depth review. Thanks for reviewing this pr! -- This is an automated message

Re: [PR] HDFS-17232. RBF: Fix NoNamenodesAvailableException for a long time, when use observer. [hadoop]

2023-10-24 Thread via GitHub
KeeProMise commented on code in PR #6208: URL: https://github.com/apache/hadoop/pull/6208#discussion_r1371098912 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java: ## @@ -461,10 +461,12 @@ private static

[jira] [Commented] (HADOOP-11867) Add a high-performance vectored read API.

2023-10-24 Thread Yuanbo Liu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-11867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779307#comment-17779307 ] Yuanbo Liu commented on HADOOP-11867: - [~mthakur] [~ste...@apache.org]  Thanks to ship this

Re: [PR] HDFS-17232. RBF: Fix NoNamenodesAvailableException for a long time, when use observer. [hadoop]

2023-10-24 Thread via GitHub
KeeProMise commented on code in PR #6208: URL: https://github.com/apache/hadoop/pull/6208#discussion_r1371090354 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestNoNamenodesAvailableLongTime.java: ## @@ -0,0 +1,432 @@ +/**

Re: [PR] HDFS-17232. RBF: Fix NoNamenodesAvailableException for a long time, when use observer. [hadoop]

2023-10-24 Thread via GitHub
KeeProMise commented on code in PR #6208: URL: https://github.com/apache/hadoop/pull/6208#discussion_r1371090045 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MembershipNamenodeResolver.java: ## @@ -494,29 +494,31 @@

Re: [PR] YARN-11597. Fix NPE when loading static files in SLSWebApp [hadoop]

2023-10-24 Thread via GitHub
slfan1989 commented on PR #6216: URL: https://github.com/apache/hadoop/pull/6216#issuecomment-1778225160 @zuston Thank you for your contribution! Let us see if there are any suggestions from other partners. If there are no other suggestions, we will merge this PR in 2 days. -- This is

Re: [PR] HDFS-17232. RBF: Fix NoNamenodesAvailableException for a long time, when use observer. [hadoop]

2023-10-24 Thread via GitHub
simbadzina commented on code in PR #6208: URL: https://github.com/apache/hadoop/pull/6208#discussion_r1370906134 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MembershipNamenodeResolver.java: ## @@ -494,29 +494,31 @@

[jira] [Commented] (HADOOP-18930) make fs.s3a.create.performance an option you can set for the entire bucket

2023-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779266#comment-17779266 ] ASF GitHub Bot commented on HADOOP-18930: - hadoop-yetus commented on PR #6168: URL:

Re: [PR] HADOOP-18930. Make fs.s3a.create.performance a bucket-wide setting [hadoop]

2023-10-24 Thread via GitHub
hadoop-yetus commented on PR #6168: URL: https://github.com/apache/hadoop/pull/6168#issuecomment-1778168270 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18948) S3A. Add option fs.s3a.directory.operations.purge.uploads to purge on rename/delete

2023-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779241#comment-17779241 ] ASF GitHub Bot commented on HADOOP-18948: - hadoop-yetus commented on PR #6218: URL:

Re: [PR] HADOOP-18948. S3A. Add option fs.s3a.directory.operations.purge.uploads to purge on rename/delete [hadoop]

2023-10-24 Thread via GitHub
hadoop-yetus commented on PR #6218: URL: https://github.com/apache/hadoop/pull/6218#issuecomment-1778018485 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17237. Remove IPCLoggerChannelMetrics when the logger is closed [hadoop]

2023-10-24 Thread via GitHub
sodonnel commented on PR #6217: URL: https://github.com/apache/hadoop/pull/6217#issuecomment-1778001301 Merged to trunk. Thanks for the review @arp7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] HDFS-17237. Remove IPCLoggerChannelMetrics when the logger is closed [hadoop]

2023-10-24 Thread via GitHub
sodonnel merged PR #6217: URL: https://github.com/apache/hadoop/pull/6217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] YARN-11577. Improve FederationInterceptorREST Method Result. [hadoop]

2023-10-24 Thread via GitHub
hadoop-yetus commented on PR #6190: URL: https://github.com/apache/hadoop/pull/6190#issuecomment-114839 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18948) S3A. Add option fs.s3a.directory.operations.purge.uploads to purge on rename/delete

2023-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779188#comment-17779188 ] ASF GitHub Bot commented on HADOOP-18948: - hadoop-yetus commented on PR #6218: URL:

Re: [PR] HADOOP-18948. S3A. Add option fs.s3a.directory.operations.purge.uploads to purge on rename/delete [hadoop]

2023-10-24 Thread via GitHub
hadoop-yetus commented on PR #6218: URL: https://github.com/apache/hadoop/pull/6218#issuecomment-1777688442 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18889. Third party storage followup. [hadoop]

2023-10-24 Thread via GitHub
steveloughran merged PR #6186: URL: https://github.com/apache/hadoop/pull/6186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] YARN-11011. Make YARN Router throw Exception to client clearly. [hadoop]

2023-10-24 Thread via GitHub
hadoop-yetus commented on PR #6211: URL: https://github.com/apache/hadoop/pull/6211#issuecomment-1777680894 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11011. Make YARN Router throw Exception to client clearly. [hadoop]

2023-10-24 Thread via GitHub
hadoop-yetus commented on PR #6211: URL: https://github.com/apache/hadoop/pull/6211#issuecomment-1777661053 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18716) [JDK-17] Failed unit tests , with Java 17 runtime and compiled Java 8

2023-10-24 Thread Dheeren Beborrtha (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779174#comment-17779174 ] Dheeren Beborrtha commented on HADOOP-18716: Any target time to fix these ? Thx. >

[jira] [Commented] (HADOOP-18936) upgrade jetty to 9.4.53 due to CVEs

2023-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779167#comment-17779167 ] ASF GitHub Bot commented on HADOOP-18936: - hadoop-yetus commented on PR #6181: URL:

Re: [PR] HADOOP-18936. upgrade to jetty 9.4.53 [hadoop]

2023-10-24 Thread via GitHub
hadoop-yetus commented on PR #6181: URL: https://github.com/apache/hadoop/pull/6181#issuecomment-1777583207 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11592. Add timeout to GPGUtils#invokeRMWebService. [hadoop]

2023-10-24 Thread via GitHub
slfan1989 commented on PR #6189: URL: https://github.com/apache/hadoop/pull/6189#issuecomment-1777520879 @goiri Can you help review this PR? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] YARN-11011. Make YARN Router throw Exception to client clearly. [hadoop]

2023-10-24 Thread via GitHub
slfan1989 commented on PR #6211: URL: https://github.com/apache/hadoop/pull/6211#issuecomment-1777518516 @goiri Can you help review this PR? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HDFS-17237. Remove IPCLoggerChannelMetrics when the logger is closed [hadoop]

2023-10-24 Thread via GitHub
arp7 commented on PR #6217: URL: https://github.com/apache/hadoop/pull/6217#issuecomment-1777453473 LGTM. +1 binding. Thanks for fixing this Stephen. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (HADOOP-18948) S3A. Add option fs.s3a.directory.operations.purge.uploads to purge on rename/delete

2023-10-24 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18948: Summary: S3A. Add option fs.s3a.directory.operations.purge.uploads to purge on

[jira] [Commented] (HADOOP-18933) upgrade netty to 4.1.100 due to CVE

2023-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779080#comment-17779080 ] ASF GitHub Bot commented on HADOOP-18933: - pjfanning commented on PR #6173: URL:

Re: [PR] HADOOP-18933. upgrade to netty 4.1.100 due to CVE [hadoop]

2023-10-24 Thread via GitHub
pjfanning commented on PR #6173: URL: https://github.com/apache/hadoop/pull/6173#issuecomment-1777173672 @steveloughran @ayushtkn would either of you have time to review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (HADOOP-18933) upgrade netty to 4.1.100 due to CVE

2023-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779077#comment-17779077 ] ASF GitHub Bot commented on HADOOP-18933: - hadoop-yetus commented on PR #6173: URL:

Re: [PR] HADOOP-18933. upgrade to netty 4.1.100 due to CVE [hadoop]

2023-10-24 Thread via GitHub
hadoop-yetus commented on PR #6173: URL: https://github.com/apache/hadoop/pull/6173#issuecomment-1777169930 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17231.HA: Safemode should exit when resources are from low to available [hadoop]

2023-10-24 Thread via GitHub
hadoop-yetus commented on PR #6207: URL: https://github.com/apache/hadoop/pull/6207#issuecomment-1777119880 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18949) upgrade maven dependency plugin due to security issue

2023-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779033#comment-17779033 ] ASF GitHub Bot commented on HADOOP-18949: - pjfanning commented on PR #6219: URL:

Re: [PR] HADOOP-18949. upgrade maven dependency plugin due to security issue. [hadoop]

2023-10-24 Thread via GitHub
pjfanning commented on PR #6219: URL: https://github.com/apache/hadoop/pull/6219#issuecomment-1777038931 @steveloughran I'm neutral about backporting this. It doesn't seem like the biggest issue and there will eventually be a hadoop 3.4.0 release. -- This is an automated message from the

[jira] [Resolved] (HADOOP-18949) upgrade maven dependency plugin due to security issue

2023-10-24 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18949. - Fix Version/s: 3.4.0 Assignee: PJ Fanning Resolution: Fixed > upgrade

Re: [PR] HADOOP-18949. upgrade maven dependency plugin due to security issue. [hadoop]

2023-10-24 Thread via GitHub
steveloughran commented on PR #6219: URL: https://github.com/apache/hadoop/pull/6219#issuecomment-1777025295 merged. In need of backporting, presumably? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] HADOOP-18949. upgrade maven dependency plugin due to security issue. [hadoop]

2023-10-24 Thread via GitHub
steveloughran merged PR #6219: URL: https://github.com/apache/hadoop/pull/6219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HADOOP-18711. upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code. [hadoop]

2023-10-24 Thread via GitHub
hadoop-yetus commented on PR #6201: URL: https://github.com/apache/hadoop/pull/6201#issuecomment-1776722304 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17231.HA: Safemode should exit when resources are from low to available [hadoop]

2023-10-24 Thread via GitHub
gp1314 commented on PR #6207: URL: https://github.com/apache/hadoop/pull/6207#issuecomment-1776685191 Thank you very much @haiyang1987 for fixing the issue #6214. I have rebased trunk and now I am unable to proceed with the jenkins/pr-merge step as it is giving an error "Could not

Re: [PR] YARN-11597. Fix NPE when loading static files in SLSWebApp [hadoop]

2023-10-24 Thread via GitHub
zuston commented on PR #6216: URL: https://github.com/apache/hadoop/pull/6216#issuecomment-1776626239 The ci failure looks unrelated with this PR. @slfan1989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] MAPREDUCE-7458. Race condition in TaskReportPBImpl#getProto when generating task reports process in concurrency scenarios. [hadoop]

2023-10-24 Thread via GitHub
TaoYang526 commented on PR #6172: URL: https://github.com/apache/hadoop/pull/6172#issuecomment-1776594083 @steveloughran can you please help to review this RP or tag relevant folks if possible? Thanks. -- This is an automated message from the Apache Git Service. To respond to the