[jira] [Commented] (HADOOP-18980) S3A credential provider remapping: make extensible

2023-11-19 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787854#comment-17787854 ] Viraj Jasani commented on HADOOP-18980: --- Something like this maybe?   {code:java}  

[jira] [Commented] (HADOOP-18869) ABFS: Fixing Behavior of a File System APIs on root path

2023-11-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787816#comment-17787816 ] ASF GitHub Bot commented on HADOOP-18869: - hadoop-yetus commented on PR #6274: URL:

Re: [PR] HADOOP-18869: [Backport to branch-3.3] [ABFS] Fixing Behavior of a File System APIs on root path. [hadoop]

2023-11-19 Thread via GitHub
hadoop-yetus commented on PR #6274: URL: https://github.com/apache/hadoop/pull/6274#issuecomment-1818271806 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18959) Use builder for prefetch CachingBlockManager

2023-11-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787811#comment-17787811 ] ASF GitHub Bot commented on HADOOP-18959: - hadoop-yetus commented on PR #6240: URL:

Re: [PR] HADOOP-18959 Use builder for prefetch CachingBlockManager [hadoop]

2023-11-19 Thread via GitHub
hadoop-yetus commented on PR #6240: URL: https://github.com/apache/hadoop/pull/6240#issuecomment-1818251148 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17218. NameNode should process time out excess redundancy blocks [hadoop]

2023-11-19 Thread via GitHub
haiyang1987 commented on code in PR #6176: URL: https://github.com/apache/hadoop/pull/6176#discussion_r1398667667 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java: ## @@ -315,6 +315,13 @@ public class DFSConfigKeys extends

[jira] [Commented] (HADOOP-18981) Move oncrpc/portmap from hadoop-nfs to hadoop-common

2023-11-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787804#comment-17787804 ] ASF GitHub Bot commented on HADOOP-18981: - hadoop-yetus commented on PR #6280: URL:

Re: [PR] HADOOP-18981. moved oncrpc/portmap from hadoop-common-project/hadoop-nfs to hadoop-common-project/hadoop-common [hadoop]

2023-11-19 Thread via GitHub
hadoop-yetus commented on PR #6280: URL: https://github.com/apache/hadoop/pull/6280#issuecomment-1818217491 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18931) FileSystem.getFileSystemClass() to log at debug the jar the .class came from

2023-11-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787801#comment-17787801 ] ASF GitHub Bot commented on HADOOP-18931: - hadoop-yetus commented on PR #6197: URL:

Re: [PR] HADOOP-18931. FileSystem.getFileSystemClass() to log at debug the jar the .class came from [hadoop]

2023-11-19 Thread via GitHub
hadoop-yetus commented on PR #6197: URL: https://github.com/apache/hadoop/pull/6197#issuecomment-1818204301 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17250. EditLogTailer#triggerActiveLogRoll should handle thread Interrupted [hadoop]

2023-11-19 Thread via GitHub
ZanderXu commented on PR #6266: URL: https://github.com/apache/hadoop/pull/6266#issuecomment-1818151590 @xinglin Thanks for your review. > when we submit a task to an executorService and later on we cancel it due to timeout, and we don't capture interrupted exception in our task, what

[jira] [Commented] (HADOOP-18959) Use builder for prefetch CachingBlockManager

2023-11-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787787#comment-17787787 ] ASF GitHub Bot commented on HADOOP-18959: - virajjasani commented on code in PR #6240: URL:

Re: [PR] HADOOP-18959 Use builder for prefetch CachingBlockManager [hadoop]

2023-11-19 Thread via GitHub
virajjasani commented on code in PR #6240: URL: https://github.com/apache/hadoop/pull/6240#discussion_r1398616555 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/BlockManagerParams.java: ## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache

Re: [PR] HDFS-17260. Fix the logic for reconfigure slow peer enable for Namenode. [hadoop]

2023-11-19 Thread via GitHub
huangzhaobo99 commented on PR #6279: URL: https://github.com/apache/hadoop/pull/6279#issuecomment-1818109373 Hi @ayushtkn @haiyang1987, Please help review this pr when you are available, Thanks. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (HADOOP-18931) FileSystem.getFileSystemClass() to log at debug the jar the .class came from

2023-11-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787690#comment-17787690 ] ASF GitHub Bot commented on HADOOP-18931: - virajjasani commented on code in PR #6197: URL:

Re: [PR] HADOOP-18931. FileSystem.getFileSystemClass() to log at debug the jar the .class came from [hadoop]

2023-11-19 Thread via GitHub
virajjasani commented on code in PR #6197: URL: https://github.com/apache/hadoop/pull/6197#discussion_r1398534424 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ClassUtil.java: ## @@ -36,13 +36,25 @@ public class ClassUtil { * @return a jar file

[jira] [Commented] (HADOOP-18982) Fix doc about loading native libraries

2023-11-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787596#comment-17787596 ] ASF GitHub Bot commented on HADOOP-18982: - hadoop-yetus commented on PR #6281: URL:

Re: [PR] HADOOP-18982. Fix doc about loading native libraries. [hadoop]

2023-11-19 Thread via GitHub
hadoop-yetus commented on PR #6281: URL: https://github.com/apache/hadoop/pull/6281#issuecomment-1817849918 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18957) Use StandardCharsets.UTF_8 constant

2023-11-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787587#comment-17787587 ] ASF GitHub Bot commented on HADOOP-18957: - hadoop-yetus commented on PR #6231: URL:

Re: [PR] HADOOP-18957. Use StandardCharsets.UTF_8 [hadoop]

2023-11-19 Thread via GitHub
hadoop-yetus commented on PR #6231: URL: https://github.com/apache/hadoop/pull/6231#issuecomment-1817828183 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18981) Move oncrpc/portmap from hadoop-nfs to hadoop-common

2023-11-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787584#comment-17787584 ] ASF GitHub Bot commented on HADOOP-18981: - hadoop-yetus commented on PR #6280: URL:

Re: [PR] HADOOP-18981. moved oncrpc/portmap from hadoop-common-project/hadoop-nfs to hadoop-common-project/hadoop-common [hadoop]

2023-11-19 Thread via GitHub
hadoop-yetus commented on PR #6280: URL: https://github.com/apache/hadoop/pull/6280#issuecomment-1817823108 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18982) Fix doc about loading native libraries

2023-11-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787583#comment-17787583 ] ASF GitHub Bot commented on HADOOP-18982: - zhangshuyan0 opened a new pull request, #6281: URL:

[jira] [Updated] (HADOOP-18982) Fix doc about loading native libraries

2023-11-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18982: Labels: pull-request-available (was: ) > Fix doc about loading native libraries >

[PR] HADOOP-18982. Fix doc about loading native libraries. [hadoop]

2023-11-19 Thread via GitHub
zhangshuyan0 opened a new pull request, #6281: URL: https://github.com/apache/hadoop/pull/6281 ### Description of PR When we want load a native library libmyexample.so, the right way is to call `System.loadLibrary("myexample")` rather than `System.loadLibrary("libmyexample.so")`.

[jira] [Created] (HADOOP-18982) Fix doc about loading native libraries

2023-11-19 Thread Shuyan Zhang (Jira)
Shuyan Zhang created HADOOP-18982: - Summary: Fix doc about loading native libraries Key: HADOOP-18982 URL: https://issues.apache.org/jira/browse/HADOOP-18982 Project: Hadoop Common Issue

Re: [PR] HDFS-17218. NameNode should process time out excess redundancy blocks [hadoop]

2023-11-19 Thread via GitHub
zhangshuyan0 commented on code in PR #6176: URL: https://github.com/apache/hadoop/pull/6176#discussion_r1398373458 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java: ## @@ -315,6 +315,13 @@ public class DFSConfigKeys extends