Re: [PR] HDFS-17267. Client send the smae packet multiple times when method markSlowNode throws IOException. [hadoop]

2023-12-09 Thread via GitHub
hadoop-yetus commented on PR #6311: URL: https://github.com/apache/hadoop/pull/6311#issuecomment-1848868524 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11594. [Addendum] Improve Yarn Federation documentation. [hadoop]

2023-12-09 Thread via GitHub
hadoop-yetus commented on PR #6340: URL: https://github.com/apache/hadoop/pull/6340#issuecomment-1848838473 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11627. [GPG] Improve GPGPolicyFacade#getPolicyManager. [hadoop]

2023-12-09 Thread via GitHub
hadoop-yetus commented on PR #6332: URL: https://github.com/apache/hadoop/pull/6332#issuecomment-1848831585 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17267. Client send the smae packet multiple times when method markSlowNode throws IOException. [hadoop]

2023-12-09 Thread via GitHub
hfutatzhanghb commented on PR #6311: URL: https://github.com/apache/hadoop/pull/6311#issuecomment-1848801850 @Hexiaoqiao @tomscut @zhangshuyan0 Sir, could you please help me review this code when you have free time? Thanks a lot. -- This is an automated message from the Apache Git

Re: [PR] HDFS-17280. Pipeline recovery should better end block in advance when bytes acked greater than half of blocksize. [hadoop]

2023-12-09 Thread via GitHub
hadoop-yetus commented on PR #6336: URL: https://github.com/apache/hadoop/pull/6336#issuecomment-1848799592 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17280. Pipeline recovery should better end block in advance when bytes acked greater than half of blocksize. [hadoop]

2023-12-09 Thread via GitHub
hadoop-yetus commented on PR #6336: URL: https://github.com/apache/hadoop/pull/6336#issuecomment-1848798312 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] YARN-11594. [Addendum] Improve Yarn Federation documentation. [hadoop]

2023-12-09 Thread via GitHub
slfan1989 opened a new pull request, #6340: URL: https://github.com/apache/hadoop/pull/6340 ### Description of PR JIRA: YARN-11594. [Addendum] Improve Yarn Federation documentation. ### How was this patch tested? ### For code changes: - [ ]

Re: [PR] HDFS-17280. Pipeline recovery should better end block in advance when bytes acked greater than half of blocksize. [hadoop]

2023-12-09 Thread via GitHub
hadoop-yetus commented on PR #6336: URL: https://github.com/apache/hadoop/pull/6336#issuecomment-1848778684 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17282. Reconfig 'SlowIoWarningThreshold' parameters for datanode. [hadoop]

2023-12-09 Thread via GitHub
hadoop-yetus commented on PR #6338: URL: https://github.com/apache/hadoop/pull/6338#issuecomment-1848427672 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18830) S3A: Cut S3 Select

2023-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794959#comment-17794959 ] ASF GitHub Bot commented on HADOOP-18830: - hadoop-yetus commented on PR #6144: URL:

Re: [PR] HADOOP-18830. Cut S3 Select [hadoop]

2023-12-09 Thread via GitHub
hadoop-yetus commented on PR #6144: URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1848422873 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11627. [GPG] Improve GPGPolicyFacade#getPolicyManager. [hadoop]

2023-12-09 Thread via GitHub
hadoop-yetus commented on PR #6332: URL: https://github.com/apache/hadoop/pull/6332#issuecomment-1848408428 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11627. [GPG] Improve GPGPolicyFacade#getPolicyManager. [hadoop]

2023-12-09 Thread via GitHub
hadoop-yetus commented on PR #6332: URL: https://github.com/apache/hadoop/pull/6332#issuecomment-1848396198 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17283. Change the name of variable SECOND in HdfsClientConfigKeys. [hadoop]

2023-12-09 Thread via GitHub
hadoop-yetus commented on PR #6339: URL: https://github.com/apache/hadoop/pull/6339#issuecomment-1848394754 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17283. Change the name of variable SECOND in HdfsClientConfigKeys. [hadoop]

2023-12-09 Thread via GitHub
hadoop-yetus commented on PR #6339: URL: https://github.com/apache/hadoop/pull/6339#issuecomment-1848380063 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] HDFS-17283. Change the name of variable SECOND in HdfsClientConfigKeys. [hadoop]

2023-12-09 Thread via GitHub
hfutatzhanghb opened a new pull request, #6339: URL: https://github.com/apache/hadoop/pull/6339 ### Description of PR Currently, the value of variable SECOND in HdfsClientConfigKeys is 1000. But i think the name of variable SECOND is not proper. So i change it to MS_PER_SECOND.

Re: [PR] HDFS-17281 Added support of reporting rpc round-trip time at NN. [hadoop]

2023-12-09 Thread via GitHub
hadoop-yetus commented on PR #6337: URL: https://github.com/apache/hadoop/pull/6337#issuecomment-1848350897 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19008) S3A: Upgrade AWS SDK to 2.21.41

2023-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794933#comment-17794933 ] ASF GitHub Bot commented on HADOOP-19008: - hadoop-yetus commented on PR #6334: URL:

Re: [PR] HADOOP-19008. S3A: update aws-sdk version to 2.21.41 [hadoop]

2023-12-09 Thread via GitHub
hadoop-yetus commented on PR #6334: URL: https://github.com/apache/hadoop/pull/6334#issuecomment-1848337741 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17275: judge whether the block has been deleted in the block report [hadoop]

2023-12-09 Thread via GitHub
hadoop-yetus commented on PR #6335: URL: https://github.com/apache/hadoop/pull/6335#issuecomment-1848329944 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |