[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827376#comment-17827376 ] ASF GitHub Bot commented on HADOOP-19102: - saxenapranav commented on code in PR #6617: URL:

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-03-14 Thread via GitHub
saxenapranav commented on code in PR #6617: URL: https://github.com/apache/hadoop/pull/6617#discussion_r1525764372 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/functional/FutureIO.java: ## @@ -114,6 +117,70 @@ public static T awaitFuture(final

[PR] HDFS-17426. Remove Invalid FileSystemECReadStats logic in DFSInputStream [hadoop]

2024-03-14 Thread via GitHub
haiyang1987 opened a new pull request, #6628: URL: https://github.com/apache/hadoop/pull/6628 ### Description of PR https://issues.apache.org/jira/browse/HDFS-17426 When read the replication file, the following logic will be called when `readingWithStrategy` and

[jira] [Commented] (HADOOP-19098) Vector IO: consistent specified rejection of overlapping ranges

2024-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827342#comment-17827342 ] ASF GitHub Bot commented on HADOOP-19098: - hadoop-yetus commented on PR #6604: URL:

Re: [PR] HADOOP-19098 Vector IO: consistent specified rejection of overlapping ranges [hadoop]

2024-03-14 Thread via GitHub
hadoop-yetus commented on PR #6604: URL: https://github.com/apache/hadoop/pull/6604#issuecomment-1998889848 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19052) Hadoop use Shell command to get the count of the hard link which takes a lot of time

2024-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827315#comment-17827315 ] ASF GitHub Bot commented on HADOOP-19052: - liangyu-1 commented on code in PR #6587: URL:

Re: [PR] HADOOP-19052.Hadoop use Shell command to get the count of the hard link which takes a lot of time [hadoop]

2024-03-14 Thread via GitHub
liangyu-1 commented on code in PR #6587: URL: https://github.com/apache/hadoop/pull/6587#discussion_r1525675831 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HardLink.java: ## @@ -204,6 +209,20 @@ public static void createHardLinkMult(File parentDir,

[jira] [Commented] (HADOOP-19088) upgrade to jersey-json 1.22.0

2024-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827299#comment-17827299 ] ASF GitHub Bot commented on HADOOP-19088: - hadoop-yetus commented on PR #6626: URL:

Re: [PR] HADOOP-19088. Use jersey-json 1.22.0 (#6585) [hadoop]

2024-03-14 Thread via GitHub
hadoop-yetus commented on PR #6626: URL: https://github.com/apache/hadoop/pull/6626#issuecomment-1998692638 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19052) Hadoop use Shell command to get the count of the hard link which takes a lot of time

2024-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827297#comment-17827297 ] ASF GitHub Bot commented on HADOOP-19052: - slfan1989 commented on code in PR #6587: URL:

Re: [PR] HADOOP-19052.Hadoop use Shell command to get the count of the hard link which takes a lot of time [hadoop]

2024-03-14 Thread via GitHub
slfan1989 commented on code in PR #6587: URL: https://github.com/apache/hadoop/pull/6587#discussion_r1525621852 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HardLink.java: ## @@ -204,6 +209,20 @@ public static void createHardLinkMult(File parentDir,

[jira] [Commented] (HADOOP-19052) Hadoop use Shell command to get the count of the hard link which takes a lot of time

2024-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827296#comment-17827296 ] ASF GitHub Bot commented on HADOOP-19052: - slfan1989 commented on code in PR #6587: URL:

Re: [PR] HADOOP-19052.Hadoop use Shell command to get the count of the hard link which takes a lot of time [hadoop]

2024-03-14 Thread via GitHub
slfan1989 commented on code in PR #6587: URL: https://github.com/apache/hadoop/pull/6587#discussion_r1525621409 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/ValueQueue.java: ## @@ -328,8 +328,9 @@ public int getSize(String keyName) {

Re: [PR] YARN-11660. Fix huge performance regression for SingleConstraintAppPlacementAllocator [hadoop]

2024-03-14 Thread via GitHub
slfan1989 commented on PR #6623: URL: https://github.com/apache/hadoop/pull/6623#issuecomment-1998680750 @zuston Thanks for the contribution! @dineshchitlangia Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] YARN-11660. Fix huge performance regression for SingleConstraintAppPlacementAllocator [hadoop]

2024-03-14 Thread via GitHub
slfan1989 merged PR #6623: URL: https://github.com/apache/hadoop/pull/6623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-19088) upgrade to jersey-json 1.22.0

2024-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827292#comment-17827292 ] ASF GitHub Bot commented on HADOOP-19088: - pjfanning opened a new pull request, #6627: URL:

[PR] HADOOP-19088. Use jersey-json 1.22.0 (#6585) [hadoop]

2024-03-14 Thread via GitHub
pjfanning opened a new pull request, #6627: URL: https://github.com/apache/hadoop/pull/6627 backport #6585 for HADOOP-19088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (HADOOP-19088) upgrade to jersey-json 1.22.0

2024-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827290#comment-17827290 ] ASF GitHub Bot commented on HADOOP-19088: - pjfanning opened a new pull request, #6626: URL:

[PR] HADOOP-19088. Use jersey-json 1.22.0 (#6585) [hadoop]

2024-03-14 Thread via GitHub
pjfanning opened a new pull request, #6626: URL: https://github.com/apache/hadoop/pull/6626 backport #6585 for HADOOP-19088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] TestBuild - 3.3 [hadoop]

2024-03-14 Thread via GitHub
ritegarg closed pull request #6619: TestBuild - 3.3 URL: https://github.com/apache/hadoop/pull/6619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] TestBuild - 3.3 [hadoop]

2024-03-14 Thread via GitHub
hadoop-yetus commented on PR #6619: URL: https://github.com/apache/hadoop/pull/6619#issuecomment-1998617735 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827282#comment-17827282 ] ASF GitHub Bot commented on HADOOP-19102: - mukund-thakur commented on code in PR #6617: URL:

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-03-14 Thread via GitHub
mukund-thakur commented on code in PR #6617: URL: https://github.com/apache/hadoop/pull/6617#discussion_r1525577732 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/functional/FutureIO.java: ## @@ -114,6 +117,70 @@ public static T awaitFuture(final

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-14 Thread via GitHub
shahrs87 merged PR #6612: URL: https://github.com/apache/hadoop/pull/6612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-14 Thread via GitHub
shahrs87 commented on PR #6612: URL: https://github.com/apache/hadoop/pull/6612#issuecomment-1998589730 All the failed test in this build are flaky. Merging this PR. Thank you @ritegarg for your contribution ! -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-14 Thread via GitHub
hadoop-yetus commented on PR #6612: URL: https://github.com/apache/hadoop/pull/6612#issuecomment-1998524754 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18679) Add API for bulk/paged object deletion

2024-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827243#comment-17827243 ] ASF GitHub Bot commented on HADOOP-18679: - hadoop-yetus commented on PR #6494: URL:

Re: [PR] HADOOP-18679. Add API for bulk/paged object deletion [hadoop]

2024-03-14 Thread via GitHub
hadoop-yetus commented on PR #6494: URL: https://github.com/apache/hadoop/pull/6494#issuecomment-1998394225 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17408. Reduce quota calculation times in FSDirRenameOp. [hadoop]

2024-03-14 Thread via GitHub
hadoop-yetus commented on PR #6608: URL: https://github.com/apache/hadoop/pull/6608#issuecomment-1998128403 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-14 Thread via GitHub
shahrs87 commented on code in PR #6614: URL: https://github.com/apache/hadoop/pull/6614#discussion_r1525236336 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestCrcCorruption.java: ## @@ -86,7 +86,7 @@ public void setUp() throws IOException { *

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-14 Thread via GitHub
shahrs87 commented on PR #6614: URL: https://github.com/apache/hadoop/pull/6614#issuecomment-1997942382 @ritegarg Can you please check if the checkstyle warning is relevant? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Assigned] (HADOOP-19028) Bind abstract contract tests into JUnit5 lifecycle

2024-03-14 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai reassigned HADOOP-19028: - Assignee: (was: Attila Doroszlai) > Bind abstract contract tests into

[jira] [Commented] (HADOOP-19005) Upgrade Guava to 32.0.1 due to CVE-2023-2976

2024-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827141#comment-17827141 ] ASF GitHub Bot commented on HADOOP-19005: - eshwitha commented on PR #6344: URL:

Re: [PR] HADOOP-19005. Upgrade Guava to 32.0.1 due to CVE-2023-2976. [hadoop]

2024-03-14 Thread via GitHub
eshwitha commented on PR #6344: URL: https://github.com/apache/hadoop/pull/6344#issuecomment-1997748305 Please review @steveloughran, Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] YARN-5305. Allow log aggregation to discard expired delegation tokens [hadoop]

2024-03-14 Thread via GitHub
hadoop-yetus commented on PR #6625: URL: https://github.com/apache/hadoop/pull/6625#issuecomment-1997734839 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] Hadoop 18325: ABFS: Add correlated metric support for ABFS operations [hadoop]

2024-03-14 Thread via GitHub
hadoop-yetus commented on PR #6314: URL: https://github.com/apache/hadoop/pull/6314#issuecomment-1997269752 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19108) S3 Express: document use

2024-03-14 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827063#comment-17827063 ] Steve Loughran commented on HADOOP-19108: - yeah. got some internal docs which I can use as a

Re: [PR] YARN-11626. Optimize ResourceManager's operations on Zookeeper metadata [hadoop]

2024-03-14 Thread via GitHub
hadoop-yetus commented on PR #6616: URL: https://github.com/apache/hadoop/pull/6616#issuecomment-1997193295 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19041) further use of StandardCharsets

2024-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827045#comment-17827045 ] ASF GitHub Bot commented on HADOOP-19041: - pjfanning commented on PR #6449: URL:

Re: [PR] HADOOP-19041. Use StandardCharsets in more places [hadoop]

2024-03-14 Thread via GitHub
pjfanning commented on PR #6449: URL: https://github.com/apache/hadoop/pull/6449#issuecomment-1997154223 the test failures appear to be OOM exceptions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HADOOP-19041) further use of StandardCharsets

2024-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827043#comment-17827043 ] ASF GitHub Bot commented on HADOOP-19041: - hadoop-yetus commented on PR #6449: URL:

Re: [PR] HADOOP-19041. Use StandardCharsets in more places [hadoop]

2024-03-14 Thread via GitHub
hadoop-yetus commented on PR #6449: URL: https://github.com/apache/hadoop/pull/6449#issuecomment-1997147555 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17388. [FGL] Client RPCs involving write process supports fine-grained lock [hadoop]

2024-03-14 Thread via GitHub
hadoop-yetus commented on PR #6589: URL: https://github.com/apache/hadoop/pull/6589#issuecomment-1997067298 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11626. Optimize ResourceManager's operations on Zookeeper metadata [hadoop]

2024-03-14 Thread via GitHub
hadoop-yetus commented on PR #6616: URL: https://github.com/apache/hadoop/pull/6616#issuecomment-1997036293 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17121. BPServiceActor to provide new thread to handle FBR [hadoop]

2024-03-14 Thread via GitHub
LiuGuH commented on PR #5888: URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1996865204 > @LiuGuH are you still working on this PR? This version is running on my production environment for long time. It is almost already done in my side. Thanks -- This is an

[jira] [Commented] (HADOOP-19052) Hadoop use Shell command to get the count of the hard link which takes a lot of time

2024-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17826979#comment-17826979 ] ASF GitHub Bot commented on HADOOP-19052: - liangyu-1 commented on PR #6587: URL:

Re: [PR] HADOOP-19052.Hadoop use Shell command to get the count of the hard link which takes a lot of time [hadoop]

2024-03-14 Thread via GitHub
liangyu-1 commented on PR #6587: URL: https://github.com/apache/hadoop/pull/6587#issuecomment-1996753762 @slfan1989 Thanks for reply. We have add a judgement function `supportsHardLink()` to check if we can use `Files.getAttribute()` to get the hardlLink count. Thus this will not cause a

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2024-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17826958#comment-17826958 ] ASF GitHub Bot commented on HADOOP-18910: - anujmodi2021 commented on PR #6069: URL:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2024-03-14 Thread via GitHub
anujmodi2021 commented on PR #6069: URL: https://github.com/apache/hadoop/pull/6069#issuecomment-1996612955 > e more t Working on all the test fixes. Will create a common PR for all these related Jira. If required, will create a new Jira and link all these to that one.