[jira] [Commented] (HADOOP-19120) [ABFS]: ApacheHttpClient adaptation as network library

2024-03-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832738#comment-17832738 ] ASF GitHub Bot commented on HADOOP-19120: - saxenapranav commented on code in PR #6633: URL:

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-03-31 Thread via GitHub
saxenapranav commented on code in PR #6633: URL: https://github.com/apache/hadoop/pull/6633#discussion_r1545990964 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/kac/TestApacheClientConnectionPool.java: ## @@ -0,0 +1,129 @@ +/** + * Licensed

[jira] [Commented] (HADOOP-19120) [ABFS]: ApacheHttpClient adaptation as network library

2024-03-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832732#comment-17832732 ] ASF GitHub Bot commented on HADOOP-19120: - hadoop-yetus commented on PR #6633: URL:

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-03-31 Thread via GitHub
hadoop-yetus commented on PR #6633: URL: https://github.com/apache/hadoop/pull/6633#issuecomment-2029193479 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19129) ABFS: Fixing Test Script Bug and Some Known test Failures in ABFS Test Suite

2024-03-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832717#comment-17832717 ] ASF GitHub Bot commented on HADOOP-19129: - anmolanmol1234 commented on code in PR #6676: URL:

Re: [PR] HADOOP-19129: [ABFS] Test Fixes and Test Script Bug Fixes [hadoop]

2024-03-31 Thread via GitHub
anmolanmol1234 commented on code in PR #6676: URL: https://github.com/apache/hadoop/pull/6676#discussion_r1545973240 ## hadoop-tools/hadoop-azure/dev-support/testrun-scripts/testsupport.sh: ## @@ -170,3 +201,5 @@ init() { logOutput() { echo -e "$outputFormatOn" "$1"

[jira] [Commented] (HADOOP-19120) [ABFS]: ApacheHttpClient adaptation as network library

2024-03-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832715#comment-17832715 ] ASF GitHub Bot commented on HADOOP-19120: - hadoop-yetus commented on PR #6633: URL:

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-03-31 Thread via GitHub
hadoop-yetus commented on PR #6633: URL: https://github.com/apache/hadoop/pull/6633#issuecomment-2029161881 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11663. [Federation] Add Cache Entity Nums Limit. [hadoop]

2024-03-31 Thread via GitHub
slfan1989 commented on PR #6662: URL: https://github.com/apache/hadoop/pull/6662#issuecomment-2029137869 > +1 LGTM @dineshchitlangia Thank you very much for the review! @luoyuan3471 Do you have any other comments on this pr? -- This is an automated message from the Apache Git

Re: [PR] HDFS-17444. Add getJournalSyncerStarted jmx metrics, to Indicates whether the JournalSyncer thread has been started. [hadoop]

2024-03-31 Thread via GitHub
hiwangzhihui commented on code in PR #6694: URL: https://github.com/apache/hadoop/pull/6694#discussion_r1545917921 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java: ## @@ -40,30 +33,27 @@ import

Re: [PR] HDFS-17444. Add getJournalSyncerStarted jmx metrics, to Indicates whether the JournalSyncer thread has been started. [hadoop]

2024-03-31 Thread via GitHub
xiaojunxiang2023 commented on code in PR #6694: URL: https://github.com/apache/hadoop/pull/6694#discussion_r1545922274 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java: ## @@ -40,30 +33,27 @@ import

Re: [PR] HDFS-17446. The DataNode adds a log to report its progress during addToReplicasMap execution. [hadoop]

2024-03-31 Thread via GitHub
xiaojunxiang2023 commented on PR #6685: URL: https://github.com/apache/hadoop/pull/6685#issuecomment-2029037794 @hiwangzhihui, Hi~, please help me review it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HDFS-17444. Add getJournalSyncerStarted jmx metrics, to Indicates whether the JournalSyncer thread has been started. [hadoop]

2024-03-31 Thread via GitHub
xiaojunxiang2023 commented on PR #6694: URL: https://github.com/apache/hadoop/pull/6694#issuecomment-2029037464 @hiwangzhihui, Hi~, please help me review it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HDFS-17397. Choose another DN as soon as possible, when encountering network issues [hadoop]

2024-03-31 Thread via GitHub
xleoken commented on PR #6591: URL: https://github.com/apache/hadoop/pull/6591#issuecomment-2028999836 cc @Hexiaoqiao @ZanderXu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (HADOOP-19077) remove use of javax.ws.rs.core.HttpHeaders

2024-03-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832663#comment-17832663 ] ASF GitHub Bot commented on HADOOP-19077: - pjfanning commented on PR #6554: URL:

Re: [PR] HADOOP-19077. Remove use of javax.ws.rs.core.HttpHeaders [hadoop]

2024-03-31 Thread via GitHub
pjfanning commented on PR #6554: URL: https://github.com/apache/hadoop/pull/6554#issuecomment-2028924058 I don't think these spotbugs issues have been caused by this PR's changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HDFS-17444. Add getJournalSyncerStarted jmx metrics, to Indicates whether the JournalSyncer thread has been started. [hadoop]

2024-03-31 Thread via GitHub
hadoop-yetus commented on PR #6694: URL: https://github.com/apache/hadoop/pull/6694#issuecomment-2028919577 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19077) remove use of javax.ws.rs.core.HttpHeaders

2024-03-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832661#comment-17832661 ] ASF GitHub Bot commented on HADOOP-19077: - hadoop-yetus commented on PR #6554: URL:

Re: [PR] HADOOP-19077. Remove use of javax.ws.rs.core.HttpHeaders [hadoop]

2024-03-31 Thread via GitHub
hadoop-yetus commented on PR #6554: URL: https://github.com/apache/hadoop/pull/6554#issuecomment-2028918157 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17444. Add getJournalSyncerStarted jmx metrics, to Indicates whether the JournalSyncer thread has been started. [hadoop]

2024-03-31 Thread via GitHub
hadoop-yetus commented on PR #6694: URL: https://github.com/apache/hadoop/pull/6694#issuecomment-2028829436 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19081) move ssh/sftp code out of hadoop-common into a dedicated jar

2024-03-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832606#comment-17832606 ] ASF GitHub Bot commented on HADOOP-19081: - pjfanning commented on PR #6693: URL:

Re: [PR] [WIP] HADOOP-19081. Move some hadoop-common code to new hadoop-ftp module [hadoop]

2024-03-31 Thread via GitHub
pjfanning commented on PR #6693: URL: https://github.com/apache/hadoop/pull/6693#issuecomment-2028824453 @steveloughran I'm not sure that this PR is worth pursuing. The FTP classes are referenced in core-defaults.xml

[jira] [Commented] (HADOOP-18135) Produce Windows binaries of Hadoop

2024-03-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832597#comment-17832597 ] ASF GitHub Bot commented on HADOOP-18135: - hadoop-yetus commented on PR #6673: URL:

Re: [PR] HADOOP-18135. Produce Windows binaries of Hadoop [hadoop]

2024-03-31 Thread via GitHub
hadoop-yetus commented on PR #6673: URL: https://github.com/apache/hadoop/pull/6673#issuecomment-2028814135 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

Re: [PR] HDFS-17444. Add getJournalSyncerStarted jmx metrics, to Indicates whether the JournalSyncer thread has been started. [hadoop]

2024-03-31 Thread via GitHub
hadoop-yetus commented on PR #6684: URL: https://github.com/apache/hadoop/pull/6684#issuecomment-2028778585 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17408:Reduce the number of quota calculations in FSDirRenameOp [hadoop]

2024-03-31 Thread via GitHub
zhangshuyan0 commented on PR #6653: URL: https://github.com/apache/hadoop/pull/6653#issuecomment-2028674317 @ThinkerLei Thanks for your reply. So what you mean is: If src directory does not have any storage policy set (that is, files under src use the default storage policy, ALL_DISK

[PR] HDFS-17444. Add getJournalSyncerStarted jmx metrics, to Indicates whether the JournalSyncer thread has been started. [hadoop]

2024-03-31 Thread via GitHub
xiaojunxiang2023 opened a new pull request, #6694: URL: https://github.com/apache/hadoop/pull/6694 The JornalNode JVM process is not immediately in a normal state until the JournalSyncer thread is started. For some management platforms such as Ambari rolling restart JournalNode, we need

Re: [PR] HDFS-17444. Add getJournalSyncerStarted jmx metrics, to Indicates whether the JournalSyncer thread has been started. [hadoop]

2024-03-31 Thread via GitHub
xiaojunxiang2023 closed pull request #6684: HDFS-17444. Add getJournalSyncerStarted jmx metrics, to Indicates whether the JournalSyncer thread has been started. URL: https://github.com/apache/hadoop/pull/6684 -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HADOOP-19077) remove use of javax.ws.rs.core.HttpHeaders

2024-03-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832563#comment-17832563 ] ASF GitHub Bot commented on HADOOP-19077: - pjfanning commented on PR #6554: URL:

Re: [PR] HADOOP-19077. Remove use of javax.ws.rs.core.HttpHeaders [hadoop]

2024-03-31 Thread via GitHub
pjfanning commented on PR #6554: URL: https://github.com/apache/hadoop/pull/6554#issuecomment-2028614801 @ayushtkn rebased -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (HADOOP-19077) remove use of javax.ws.rs.core.HttpHeaders

2024-03-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832562#comment-17832562 ] ASF GitHub Bot commented on HADOOP-19077: - ayushtkn commented on PR #6554: URL:

Re: [PR] HADOOP-19077. Remove use of javax.ws.rs.core.HttpHeaders [hadoop]

2024-03-31 Thread via GitHub
ayushtkn commented on PR #6554: URL: https://github.com/apache/hadoop/pull/6554#issuecomment-2028613934 @pjfanning can you please rebase this, some issue with the build I believe, I triggered it twice, the test result link isn't working it is redirecting to the main build page rather than

[jira] [Commented] (HADOOP-19134) use StringBuilder instead of StringBuffer

2024-03-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832555#comment-17832555 ] ASF GitHub Bot commented on HADOOP-19134: - hadoop-yetus commented on PR #6692: URL:

Re: [PR] HADOOP-19134. Use StringBuilder instead of StringBuffer. [hadoop]

2024-03-31 Thread via GitHub
hadoop-yetus commented on PR #6692: URL: https://github.com/apache/hadoop/pull/6692#issuecomment-2028582320 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17444. Add getJournalSyncerStarted jmx metrics, to Indicates whether the JournalSyncer thread has been started. [hadoop]

2024-03-31 Thread via GitHub
hadoop-yetus commented on PR #6684: URL: https://github.com/apache/hadoop/pull/6684#issuecomment-2028573898 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |