vinayakumarb commented on code in PR #6809:
URL: https://github.com/apache/hadoop/pull/6809#discussion_r1597551434
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##
@@ -3738,7 +3738,7 @@ boolean
vinayakumarb commented on code in PR #6809:
URL: https://github.com/apache/hadoop/pull/6809#discussion_r1597551434
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##
@@ -3738,7 +3738,7 @@ boolean
hadoop-yetus commented on PR #6784:
URL: https://github.com/apache/hadoop/pull/6784#issuecomment-2105966551
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
_ Prechecks
hadoop-yetus commented on PR #6806:
URL: https://github.com/apache/hadoop/pull/6806#issuecomment-2105929542
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
_ Prechecks
hadoop-yetus commented on PR #6812:
URL: https://github.com/apache/hadoop/pull/6812#issuecomment-2105927891
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
_ Prechecks
hadoop-yetus commented on PR #6795:
URL: https://github.com/apache/hadoop/pull/6795#issuecomment-2105893097
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
_ Prechecks
hadoop-yetus commented on PR #6784:
URL: https://github.com/apache/hadoop/pull/6784#issuecomment-2105783690
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
zhengchenyu opened a new pull request, #6813:
URL: https://github.com/apache/hadoop/pull/6813
### Description of PR
I found that if the erasedIndexes distribution is such that the parity index
is in front of the data index, ec will produce wrong results when decoding.
In fact,
slfan1989 commented on PR #6812:
URL: https://github.com/apache/hadoop/pull/6812#issuecomment-2105740105
> @slfan1989 Master, I see you are familiar with
`testDecommissionDataNodesReconfig`, please help me review it. Thanks
@ZanderXu Thank you for your contribution! I will reply
hadoop-yetus commented on PR #6806:
URL: https://github.com/apache/hadoop/pull/6806#issuecomment-2105680116
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
ZanderXu commented on code in PR #6784:
URL: https://github.com/apache/hadoop/pull/6784#discussion_r1597413470
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterRpc.java:
##
@@ -1224,6 +1224,17 @@ public void
LiuGuH commented on code in PR #6784:
URL: https://github.com/apache/hadoop/pull/6784#discussion_r1597405273
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterRpc.java:
##
@@ -1224,6 +1224,17 @@ public void
LiuGuH commented on code in PR #6784:
URL: https://github.com/apache/hadoop/pull/6784#discussion_r1597404047
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java:
##
@@ -1009,6 +1000,20 @@ public
hfutatzhanghb commented on code in PR #6765:
URL: https://github.com/apache/hadoop/pull/6765#discussion_r1597392676
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java:
##
@@ -1105,15 +1106,12 @@ static void
hadoop-yetus commented on PR #6759:
URL: https://github.com/apache/hadoop/pull/6759#issuecomment-2105622801
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| -1 :x: | patch
ZanderXu commented on PR #6759:
URL: https://github.com/apache/hadoop/pull/6759#issuecomment-2105617264
Merged. Thanks @kokonguyen191 for your contribution and thanks @Hexiaoqiao
@haiyang1987 @hfutatzhanghb for your review.
--
This is an automated message from the Apache Git Service.
To
ZanderXu merged PR #6759:
URL: https://github.com/apache/hadoop/pull/6759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ZanderXu commented on code in PR #6784:
URL: https://github.com/apache/hadoop/pull/6784#discussion_r1597385087
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java:
##
@@ -1009,6 +1000,20 @@ public
ZanderXu commented on PR #6812:
URL: https://github.com/apache/hadoop/pull/6812#issuecomment-2105610789
@slfan1989 Master, I see you are familiar with
`testDecommissionDataNodesReconfig`, please help me review it. Thanks
--
This is an automated message from the Apache Git Service.
To
ZanderXu opened a new pull request, #6812:
URL: https://github.com/apache/hadoop/pull/6812
TestDFSAdmin.testAllDatanodesReconfig and
TestDFSAdmin.testDecommissionDataNodesReconfig failed.
[HDFS-17506](https://github.com/apache/hadoop/pull/6806) encountered this
failed UT and the
ZanderXu commented on PR #6806:
URL: https://github.com/apache/hadoop/pull/6806#issuecomment-2105603473
The failed UT `hadoop.hdfs.tools.TestDFSAdmin` is not caused by this PR, I
will create a ticket to fix it.
--
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/HADOOP-18851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845542#comment-17845542
]
ASF GitHub Bot commented on HADOOP-18851:
-
hadoop-yetus commented on PR #6803:
URL:
hadoop-yetus commented on PR #6803:
URL: https://github.com/apache/hadoop/pull/6803#issuecomment-2105598897
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
_ Prechecks
YaAYadeer commented on PR #6797:
URL: https://github.com/apache/hadoop/pull/6797#issuecomment-2105598177
The test class TestOfflineImageViewer already exists.
TestOfflineImageViewer.testPBImageXmlWriter() method will call dumpXattrs
when input parameter of dumpXattrs has xattrs.
--
hadoop-yetus commented on PR #6811:
URL: https://github.com/apache/hadoop/pull/6811#issuecomment-2105595427
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
_ Prechecks
25 matches
Mail list logo
