[GitHub] [hadoop] Hexiaoqiao commented on pull request #5743: HDFS-17049. EC: Fix duplicate block group IDs generated by SequentialBlockGroupIdGenerator.

Hexiaoqiao commented on PR #5743: URL: https://github.com/apache/hadoop/pull/5743#issuecomment-1598704939 Got it. Close the PR since it does not need to fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] Hexiaoqiao commented on pull request #5743: HDFS-17049. EC: Fix duplicate block group IDs generated by SequentialBlockGroupIdGenerator.

Hexiaoqiao commented on PR #5743: URL: https://github.com/apache/hadoop/pull/5743#issuecomment-1595672568 Back to this PR. Considering that blockId/blockGroupId generator is protected by global lock, I think we do not need more `synchronized` protection which has some time cost. However we

[GitHub] [hadoop] Hexiaoqiao commented on pull request #5743: HDFS-17049. EC: Fix duplicate block group IDs generated by SequentialBlockGroupIdGenerator.

Hexiaoqiao commented on PR #5743: URL: https://github.com/apache/hadoop/pull/5743#issuecomment-1592286013 > @zhtttylz Thanks for your review. I met this problem because in our production code the directory locks have finer granularity, which means different files may obtain different