[GitHub] [hadoop] bshashikant commented on pull request #2881: HDFS-15961. standby namenode failed to start ordered snapshot deletion is enabled while having snapshottable directories

bshashikant commented on pull request #2881: URL: https://github.com/apache/hadoop/pull/2881#issuecomment-827291426 The failures are nit related to the patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] bshashikant commented on pull request #2881: HDFS-15961. standby namenode failed to start ordered snapshot deletion is enabled while having snapshottable directories

bshashikant commented on pull request #2881: URL: https://github.com/apache/hadoop/pull/2881#issuecomment-827291331 Thanks @ayushtkn and @smengcl for the reviews. Committing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] bshashikant commented on pull request #2881: HDFS-15961. standby namenode failed to start ordered snapshot deletion is enabled while having snapshottable directories

bshashikant commented on pull request #2881: URL: https://github.com/apache/hadoop/pull/2881#issuecomment-824649349 @ayushtkn /@smengcl any further thoughts/reviews? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] bshashikant commented on pull request #2881: HDFS-15961. standby namenode failed to start ordered snapshot deletion is enabled while having snapshottable directories

bshashikant commented on pull request #2881: URL: https://github.com/apache/hadoop/pull/2881#issuecomment-819454476 > > I think We should hold this off, I think the code has issues, as I said. Earlier I thought, there is some catch but I don’t think. It is misbehaving only. Ideally such

[GitHub] [hadoop] bshashikant commented on pull request #2881: HDFS-15961. standby namenode failed to start ordered snapshot deletion is enabled while having snapshottable directories

bshashikant commented on pull request #2881: URL: https://github.com/apache/hadoop/pull/2881#issuecomment-819258964 > I think We should hold this off, I think the code has issues, as I said. Earlier I thought, there is some catch but I don’t think. It is misbehaving only. Ideally such

[GitHub] [hadoop] bshashikant commented on pull request #2881: HDFS-15961. standby namenode failed to start ordered snapshot deletion is enabled while having snapshottable directories

bshashikant commented on pull request #2881: URL: https://github.com/apache/hadoop/pull/2881#issuecomment-819237562 @smengcl , can you please have a look again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] bshashikant commented on pull request #2881: HDFS-15961. standby namenode failed to start ordered snapshot deletion is enabled while having snapshottable directories

bshashikant commented on pull request #2881: URL: https://github.com/apache/hadoop/pull/2881#issuecomment-817080125 > Thanx @bshashikant for the fix, Can you extend a test covering the fix as well Added the test case. -- This is an automated message from the Apache Git Service.