bshashikant commented on pull request #3340:
URL: https://github.com/apache/hadoop/pull/3340#issuecomment-917840218
Thanks @cnauroth and @szetszwo for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
bshashikant commented on pull request #3340:
URL: https://github.com/apache/hadoop/pull/3340#issuecomment-917839405
Thanks @szetszwo . I have retriggered the CI and the unit test failures in
the report are not related.
--
This is an automated message from the Apache Git Service.
To
bshashikant commented on pull request #3340:
URL: https://github.com/apache/hadoop/pull/3340#issuecomment-916626429
> > @bshashikant , thanks! In that case, let's please just add the comments
I requested to `INodeDirectory` and `INodeDirectoryAttributes`. Then I'll
approve and merge.
>
bshashikant commented on pull request #3340:
URL: https://github.com/apache/hadoop/pull/3340#issuecomment-916626334
> @bshashikant , thanks! In that case, let's please just add the comments I
requested to `INodeDirectory` and `INodeDirectoryAttributes`. Then I'll approve
and merge.
bshashikant commented on pull request #3340:
URL: https://github.com/apache/hadoop/pull/3340#issuecomment-916599655
Thanks @cnauroth . The problem here is very specific to snapshotRoot.
`@Test
public void testXattrOnFileWithSnapshotAndNNRestart() throws Exception {
bshashikant commented on pull request #3340:
URL: https://github.com/apache/hadoop/pull/3340#issuecomment-915780582
> @bshashikant , thank you for the patch.
>
> I see that the patch works by converting logic from reference-equals to
value-equals. In `AclStorage`, we maintain a
bshashikant commented on pull request #3340:
URL: https://github.com/apache/hadoop/pull/3340#issuecomment-914952043
The failures don't seem related. @szetszwo , @smengcl , can you please have
a look?
--
This is an automated message from the Apache Git Service.
To respond to the message,
