[GitHub] [hadoop] dbtsai commented on pull request #2297: HADOOP-17125. Using snappy-java in SnappyCodec

2020-10-06 Thread GitBox
dbtsai commented on pull request #2297: URL: https://github.com/apache/hadoop/pull/2297#issuecomment-704399048 Thanks all for helping and pushing this through! This will simplify how people deploy snappy native lib greatly.

[GitHub] [hadoop] dbtsai commented on pull request #2297: HADOOP-17125. Using snappy-java in SnappyCodec

2020-09-22 Thread GitBox
dbtsai commented on pull request #2297: URL: https://github.com/apache/hadoop/pull/2297#issuecomment-697008848 cc @iwasakims @aajisaka who involved with codec in Hadoop. This is an automated message from the Apache Git

[GitHub] [hadoop] dbtsai commented on pull request #2297: HADOOP-17125. Using snappy-java in SnappyCodec

2020-09-22 Thread GitBox
dbtsai commented on pull request #2297: URL: https://github.com/apache/hadoop/pull/2297#issuecomment-697008848 cc @iwasakims @aajisaka who involved with codec in Hadoop. This is an automated message from the Apache Git

[GitHub] [hadoop] dbtsai commented on pull request #2297: HADOOP-17125. Using snappy-java in SnappyCodec

2020-09-21 Thread GitBox
dbtsai commented on pull request #2297: URL: https://github.com/apache/hadoop/pull/2297#issuecomment-696356461 @steveloughran we addressed your comments. Please take a look again when you have time. Thanks! This is an

[GitHub] [hadoop] dbtsai commented on pull request #2297: HADOOP-17125. Using snappy-java in SnappyCodec

2020-09-21 Thread GitBox
dbtsai commented on pull request #2297: URL: https://github.com/apache/hadoop/pull/2297#issuecomment-696356461 @steveloughran we addressed your comments. Please take a look again when you have time. Thanks! This is an

[GitHub] [hadoop] dbtsai commented on pull request #2297: HADOOP-17125. Using snappy-java in SnappyCodec

2020-09-16 Thread GitBox
dbtsai commented on pull request #2297: URL: https://github.com/apache/hadoop/pull/2297#issuecomment-693683581 cc @jlowe and @liuml07 who recently worked on compression codecs for more feedback. This is an automated message

[GitHub] [hadoop] dbtsai commented on pull request #2297: HADOOP-17125. Using snappy-java in SnappyCodec

2020-09-15 Thread GitBox
dbtsai commented on pull request #2297: URL: https://github.com/apache/hadoop/pull/2297#issuecomment-693003698 cc @steveloughran and @jojochuang for review. This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] dbtsai commented on pull request #2297: HADOOP-17125. Using snappy-java in SnappyCodec

2020-09-12 Thread GitBox
dbtsai commented on pull request #2297: URL: https://github.com/apache/hadoop/pull/2297#issuecomment-690956278 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] dbtsai commented on pull request #2297: HADOOP-17125. Using snappy-java in SnappyCodec

2020-09-12 Thread GitBox
dbtsai commented on pull request #2297: URL: https://github.com/apache/hadoop/pull/2297#issuecomment-690956278 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] dbtsai commented on pull request #2297: HADOOP-17125. Using snappy-java in SnappyCodec

2020-09-12 Thread GitBox
dbtsai commented on pull request #2297: URL: https://github.com/apache/hadoop/pull/2297#issuecomment-690956278 The only test failure in ``` TestSnappyCompressorDecompressor.testSnappyDirectBlockCompression ``` , I guess it's because in `SnappyDirectBlockCompression`, the

[GitHub] [hadoop] dbtsai commented on pull request #2297: HADOOP-17125. Using snappy-java in SnappyCodec

2020-09-11 Thread GitBox
dbtsai commented on pull request #2297: URL: https://github.com/apache/hadoop/pull/2297#issuecomment-690956278 The only test failure in ``` TestSnappyCompressorDecompressor.testSnappyDirectBlockCompression ``` , I guess it's because in `SnappyDirectBlockCompression`, the

[GitHub] [hadoop] dbtsai commented on pull request #2297: HADOOP-17125. Using snappy-java in SnappyCodec

2020-09-10 Thread GitBox
dbtsai commented on pull request #2297: URL: https://github.com/apache/hadoop/pull/2297#issuecomment-690781897 Thanks @viirya for taking over my https://github.com/apache/hadoop/pull/2201 , and continue working on it. This