[GitHub] [hadoop] goiri commented on a diff in pull request #4228: HDFS-16468. Define ssize_t for Windows

goiri commented on code in PR #4228: URL: https://github.com/apache/hadoop/pull/4228#discussion_r859202738 ## hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/x-platform/types.h: ## @@ -0,0 +1,39 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [hadoop] goiri commented on a diff in pull request #4228: HDFS-16468. Define ssize_t for Windows

goiri commented on code in PR #4228: URL: https://github.com/apache/hadoop/pull/4228#discussion_r859200993 ## hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/examples/cc/cat/cat.cc: ## @@ -62,7 +62,6 @@ int main(int argc, char *argv[]) { //wrapping

[GitHub] [hadoop] goiri commented on a diff in pull request #4228: HDFS-16468. Define ssize_t for Windows

goiri commented on code in PR #4228: URL: https://github.com/apache/hadoop/pull/4228#discussion_r858136011 ## hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/jni_helper.c: ## @@ -487,10 +488,10 @@ static ssize_t wildcard_expandPath(const char* path, char*

[GitHub] [hadoop] goiri commented on a diff in pull request #4228: HDFS-16468. Define ssize_t for Windows

goiri commented on code in PR #4228: URL: https://github.com/apache/hadoop/pull/4228#discussion_r857865439 ## hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/examples/cc/cat/cat.cc: ## @@ -62,7 +62,6 @@ int main(int argc, char *argv[]) { //wrapping