hadoop-yetus commented on issue #1946: HADOOP-16961. ABFS: Adding metrics to AbfsInputStream URL: https://github.com/apache/hadoop/pull/1946#issuecomment-611074398 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 24m 46s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 20m 36s | trunk passed | | +1 :green_heart: | compile | 0m 29s | trunk passed | | +1 :green_heart: | checkstyle | 0m 22s | trunk passed | | +1 :green_heart: | mvnsite | 0m 31s | trunk passed | | +1 :green_heart: | shadedclient | 15m 30s | branch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 0m 24s | trunk passed | | +0 :ok: | spotbugs | 0m 52s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 0m 49s | trunk passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 29s | the patch passed | | +1 :green_heart: | compile | 0m 23s | the patch passed | | +1 :green_heart: | javac | 0m 23s | the patch passed | | -0 :warning: | checkstyle | 0m 17s | hadoop-tools/hadoop-azure: The patch generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0) | | +1 :green_heart: | mvnsite | 0m 27s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedclient | 17m 17s | patch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 0m 23s | the patch passed | | -1 :x: | findbugs | 1m 9s | hadoop-tools/hadoop-azure generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 25s | hadoop-azure in the patch passed. | | +1 :green_heart: | asflicense | 0m 33s | The patch does not generate ASF License warnings. | | | | 87m 30s | | | Reason | Tests | |-------:|:------| | FindBugs | module:hadoop-tools/hadoop-azure | | | Increment of volatile field org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.readOperations in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.readOperationStarted(long, long) At AbfsInputStreamStatisticsImpl.java:in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.readOperationStarted(long, long) At AbfsInputStreamStatisticsImpl.java:[line 113] | | | Increment of volatile field org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.remoteReadOperations in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.remoteReadOperation() At AbfsInputStreamStatisticsImpl.java:in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.remoteReadOperation() At AbfsInputStreamStatisticsImpl.java:[line 118] | | | Increment of volatile field org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.backwardSeekOperations in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekBackwards(long) At AbfsInputStreamStatisticsImpl.java:in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekBackwards(long) At AbfsInputStreamStatisticsImpl.java:[line 47] | | | Increment of volatile field org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekOperations in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekBackwards(long) At AbfsInputStreamStatisticsImpl.java:in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekBackwards(long) At AbfsInputStreamStatisticsImpl.java:[line 46] | | | Increment of volatile field org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.forwardSeekOperations in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekForwards(long) At AbfsInputStreamStatisticsImpl.java:in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekForwards(long) At AbfsInputStreamStatisticsImpl.java:[line 60] | | | Increment of volatile field org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekOperations in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekForwards(long) At AbfsInputStreamStatisticsImpl.java:in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekForwards(long) At AbfsInputStreamStatisticsImpl.java:[line 59] | | | Increment of volatile field org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekInBuffer in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekInBuffer() At AbfsInputStreamStatisticsImpl.java:in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekInBuffer() At AbfsInputStreamStatisticsImpl.java:[line 103] | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1946/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1946 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 7dd8211e3a28 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 1189af4 | | Default Java | 1.8.0_242 | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1946/1/artifact/out/diff-checkstyle-hadoop-tools_hadoop-azure.txt | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1946/1/artifact/out/new-findbugs-hadoop-tools_hadoop-azure.html | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1946/1/testReport/ | | Max. process+thread count | 412 (vs. ulimit of 5500) | | modules | C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1946/1/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
