[GitHub] [hadoop] hfutatzhanghb commented on pull request #5708: HDFS-17035. FsVolumeImpl#getActualNonDfsUsed may return negative value.

2023-06-07 Thread via GitHub
hfutatzhanghb commented on PR #5708: URL: https://github.com/apache/hadoop/pull/5708#issuecomment-1580380126 > Sir, thanks a lot for reviewing. Agree with you here, have modified code and run some UT in local. -- This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5708: HDFS-17035. FsVolumeImpl#getActualNonDfsUsed may return negative value.

2023-06-06 Thread via GitHub
hfutatzhanghb commented on PR #5708: URL: https://github.com/apache/hadoop/pull/5708#issuecomment-1579841895 > LGTM. +1 from my side. Let's wait if other folks to feedback util two workdays. Sir, thanks a lot for your reviewing. -- This is an automated message from the Apache Git

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5708: HDFS-17035. FsVolumeImpl#getActualNonDfsUsed may return negative value.

2023-06-06 Thread via GitHub
hfutatzhanghb commented on PR #5708: URL: https://github.com/apache/hadoop/pull/5708#issuecomment-1579767345 @ayushtkn @Hexiaoqiao @zhangshuyan0 . Hi, sir. could you please take a look at this minor issue when you are not busy ? Thanks a lot. -- This is an automated message from the

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5708: HDFS-17035. FsVolumeImpl#getActualNonDfsUsed may return negative value.

2023-06-02 Thread via GitHub
hfutatzhanghb commented on PR #5708: URL: https://github.com/apache/hadoop/pull/5708#issuecomment-1573665781 The failed unit test was passed in my local. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5708: HDFS-17035. FsVolumeImpl#getActualNonDfsUsed may return negative value.

2023-06-01 Thread via GitHub
hfutatzhanghb commented on PR #5708: URL: https://github.com/apache/hadoop/pull/5708#issuecomment-1573195739 ![image](https://github.com/apache/hadoop/assets/25115709/ff3291ce-e2e6-4567-856a-9cd95961fbf8) -- This is an automated message from the Apache Git Service. To respond to the