[GitHub] [hadoop] leixm commented on pull request #4797: YARN-11277. Trigger log-dir deletion by size for NonAggregatingLogHandler

2023-06-04 Thread via GitHub
leixm commented on PR #4797: URL: https://github.com/apache/hadoop/pull/4797#issuecomment-1575975247 @slfan1989 @ashutoshcipher @aajisaka Thank you for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [hadoop] leixm commented on pull request #4797: YARN-11277. Trigger log-dir deletion by size for NonAggregatingLogHandler

2023-05-29 Thread via GitHub
leixm commented on PR #4797: URL: https://github.com/apache/hadoop/pull/4797#issuecomment-1566712140 @slfan1989 @aajisaka All done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] leixm commented on pull request #4797: YARN-11277. Trigger log-dir deletion by size for NonAggregatingLogHandler

2023-05-22 Thread via GitHub
leixm commented on PR #4797: URL: https://github.com/apache/hadoop/pull/4797#issuecomment-1557124921 cc @aajisaka @slfan1989 PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [hadoop] leixm commented on pull request #4797: YARN-11277. Trigger log-dir deletion by size for NonAggregatingLogHandler

2022-11-16 Thread GitBox
leixm commented on PR #4797: URL: https://github.com/apache/hadoop/pull/4797#issuecomment-1316861930 @aajisaka Can you help review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [hadoop] leixm commented on pull request #4797: YARN-11277. Trigger log-dir deletion by size for NonAggregatingLogHandler

2022-08-25 Thread GitBox
leixm commented on PR #4797: URL: https://github.com/apache/hadoop/pull/4797#issuecomment-1227998696 @goiri @ayushtkn can you help review this pr plz? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop] leixm commented on pull request #4797: YARN-11277. Trigger log-dir deletion by size for NonAggregatingLogHandler

2022-08-25 Thread GitBox
leixm commented on PR #4797: URL: https://github.com/apache/hadoop/pull/4797#issuecomment-1227996542 All fixed, thanks for your review and suggestion @slfan1989 @ashutoshcipher -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hadoop] leixm commented on pull request #4797: YARN-11277. trigger log-dir deletion by size for NonAggregatingLogHandler

2022-08-24 Thread GitBox
leixm commented on PR #4797: URL: https://github.com/apache/hadoop/pull/4797#issuecomment-1225598272 If we set yarn.nodemanager.log.retain-seconds to a small value, this will cause normal logs to be deleted too quickly and still not solve the problem - this is due to some huge log files, Af

[GitHub] [hadoop] leixm commented on pull request #4797: YARN-11277. trigger log-dir deletion by size for NonAggregatingLogHandler

2022-08-24 Thread GitBox
leixm commented on PR #4797: URL: https://github.com/apache/hadoop/pull/4797#issuecomment-1225418277 @slfan1989 can you review this pr plz? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp